Re: Boder of Frame inset not visible in dark mode
On 2023-09-24 22:24, Dan wrote: Hello, PROBLEM There is a frame whose outline is not visible in dark mode because it is black (Insert > Frame > Simple Frame). The box inset name is "Boxed" (https://www.lyx.org/trac/browser/lyxgit/lib/layouts/stdinsets.inc#L504). See the attached image for a showcase of all the frames showing the problem. EXPECTED BEHAVIOUR === Simple Frame Box should have the same outline colour as the other frames. A bug here that wpuld solve the problem is that the frame setting misses the proper "Default" value for its frame color. When inserted, no special color is applied to the frame but the frame color is used. You can see this by changing the Main Text color (in Document Settings > Colors). If the default is changed to, say, red, the box gets that color in the output but still has "black" as frame color in the settings. Worse, once one changes the color in the frame settings to, say, blue, it is impossible to get the default behavior back since when switching back to "black", it is explicitly applied. Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: ctest ca/Intro_docbook5 now failing
On Mon, Sep 25, 2023 at 12:57:40AM -0400, Scott Kostyshak wrote: > On Mon, Sep 25, 2023 at 05:27:47AM +0200, Thibaut Cuvelier wrote: > > On Mon, 18 Sept 2023 at 02:43, Thibaut Cuvelier wrote: > > > > > On Thu, 14 Sept 2023 at 02:35, Scott Kostyshak wrote: > > > > > >> On Wed, Sep 06, 2023 at 11:52:49PM -0400, Scott Kostyshak wrote: > > >> > Recently (I think due to the ca/Intro changes) the following test > > >> started to fail: > > >> > > > >> > export/doc/ca/Intro_docbook5 > > >> > > > >> > Thibaut, can you take a look? I'm guessing the recent changes to that > > >> file just triggered a known issue with DocBook export. Can you confirm so > > >> that we can invert that test? > > >> > > > >> > > >> I just inverted it for now (at eb920502). Take a look whenever you have > > >> time. > > >> > > > > > > I had a look at that failure. It's a specific feature of that document, > > > with an emphasis ending at the end of a footnote (with no character > > > afterwards). Is this expected that someone can enter that? I would naïvely > > > think that LyX would remove that formatting (just like you cannot have two > > > spaces or an empty paragraph). LyXHTML ends the emphasis at the end of the > > > footnote, unlike DocBook. > > > > > > I have the idea for a fix; I'm waiting on your input on whether this is a > > > DocBook bug or unexpected LyX behaviour. > > > > > > > I made up my mind and decided to replicate the same behaviour as LyXHTML > > output: actually, there was some text, indicating a true bug in the > > implementation. The attached patch fixes it locally, making it so that the > > test can be uninverted. (As previously, I cannot push the commit onto the > > Git repository.) > > Thanks for working on it. I'll run the tests overnight with your patch > applied. > > Scott Looks good! It's in at ff9dfa96. Thanks, Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Boder of Frame inset not visible in dark mode
On Sun, Sep 24, 2023 at 10:24:30PM +0200, Dan wrote: > Hello, > > PROBLEM > > There is a frame whose outline is not visible in dark mode because it is > black (Insert > Frame > Simple Frame). > The box inset name is "Boxed" > (https://www.lyx.org/trac/browser/lyxgit/lib/layouts/stdinsets.inc#L504). > > See the attached image for a showcase of all the frames showing the problem. > > EXPECTED BEHAVIOUR > === > Simple Frame Box should have the same outline colour as the other frames. I see the problem, though I do not see what's the proper solution here. We use the color which is actually selected as a frame decoration (see dialog of the box inset->color. That is black by default and can be selected to other colors in the dialog which we paint according to the color chosen. Perhaps we could check for black background and invert in the case of black color but it looks somewhat hackish solution. You can play with InsetBox.cpp, line ~170 if you like. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
