Re: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread David Binderman
are pointless. Regards David Binderman

Re: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread David Binderman
nalyser coverity looks more deeply at the code, but didn't see this one. I used another static analyser, cppcheck, to find this bug: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression on both sides of '&&'. I recommend cppcheck for all C & C++ development work. Regards David Binderman

lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread David Binderman
Hello there, Source code is bool empty() const { return wid == 0 && asc == 0 && wid == 0; } Maybe better code bool empty() const { return wid == 0 && asc == 0 && des == 0; } Regards David Binderman