Re: [LyX/master] Update fr.po and a couple of shortcuts defined with non-existing letters

2022-06-14 Thread Jürgen Spitzmüller
Am Dienstag, dem 14.06.2022 um 15:48 +0200 schrieb Jean-Pierre
Chrétien:
> I have a question : with Debian stable, when I open the InsetSpace
> context menu, the selection is controlled by check-boxes. In that
> case, shortcuts are not useful.

Why? They are still the most convenient way to check an option with the
keyboard.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Amend [7efdbeaddf226/lyxgit]

2022-06-13 Thread Jürgen Spitzmüller
Am Montag, dem 13.06.2022 um 20:10 +0200 schrieb Daniel:
> I am curious, where does one get the 'Non-Floating Figures and
> Tables' 
> module? (It might be relevant to
> https://www.lyx.org/trac/ticket/11734.)

I seem to have written it myself. But it's not a good approach. It
doesn't use Caption InsetLayout, but InsetFlex (see attachment). A
better model are the special captions in the KOMA classes.

-- 
Jürgen
#\DeclareLyXModule{Non-floating Figures and Tables}
#DescriptionBegin
#Insert captions to figures and tables that do not float.
#DescriptionEnd

# Author: Jürgen Spitzmüller 

Format 66


InsetLayout Flex:NonFloatingFigure
LyxType  custom
LabelString  non-floating
LaTeXTypecommand
LatexNamefigcaption
NeedProtect  1
MultiPar false
Argument 1
LabelString   "Short Title|S"
Tooltip   "The caption as it appears in the list of 
figures/tables"
InsertCotext  1
EndArgument
Preamble
\usepackage{nonfloat}
EndPreamble
End

InsetLayout Flex:NonFloatingTable
CopyStyleFlex:NonFloatingFigure
LabelString  non-floating
LatexNametabcaption
End



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Fix subfloat inset label (#11757)

2022-05-28 Thread Jürgen Spitzmüller
Am Samstag, dem 28.05.2022 um 14:27 -0400 schrieb Scott Kostyshak:
> I get the following:
> 
> /home/scott/lyxbuilds/master-master/repo/src/insets/InsetFloat.cpp:
> In member function ‘virtual void lyx::InsetFloat::updateBuffer(const
> lyx::ParIterator&, lyx::UpdateType, bool)’:
> /home/scott/lyxbuilds/master-
> master/repo/src/insets/InsetFloat.cpp:882:84: error: unused parameter
> ‘deleted’ [-Werror=unused-parameter]
>   882 | void InsetFloat::updateBuffer(ParIterator const & it,
> UpdateType utype, bool const deleted)
>  
> |
>  ~~~^~~

Fixed.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Incorrect "Listpreamble" export to old version

2022-05-26 Thread Jürgen Spitzmüller
Am Mittwoch, dem 25.05.2022 um 20:35 +0200 schrieb Daniel:
> The new "Listpreamble" inset for numbered lists does not export 
> correctly to older versions of LyX. In LyX 2.4.0dev, the
> listpreamble's 
> content is inserted before the first item. Instead, when exporting to
> 2.3.x, the content of the inset is just added at it's place in
> brackets 
> "{}". This leads to a different and incorrect output in 2.3.x.

It's not possible otherwise, unless we'd transfer the whole list to
ERT. So yes, it's intentional.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] User Guide: add quotes to a PackageOptions command

2022-05-24 Thread Jürgen Spitzmüller
Am Mo., 23. Mai 2022 um 21:23 Uhr schrieb Scott Kostyshak :

> I'm really fine either way. Should I revert (by the way I also don't
> mind if others revert my commits)?
>

I'd tend to propose that (even though I am also fine with either way).

Thanks,
Jürgen


>
> Scott
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find and quote styles

2022-05-23 Thread Jürgen Spitzmüller
Am Montag, dem 23.05.2022 um 14:21 +0200 schrieb Kornel Benko:
> Thanks Jürgen. That is exactly what I was after. Please commit.

Done.

> > > but because of not able to set the quote-style in
> > > replace_work_area,
> > > findadv is not able to correct the quotes.  
> > 
> > The most elegant way to change the quotes there, currently, is
> > probably
> > to use the context menu of a quote inset.
> 
> Works too, but your patch is better :)

Except that this requires reopening the F pane, which is awkward if
you want one style in find and another one in replace.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find and quote styles

2022-05-23 Thread Jürgen Spitzmüller
Am Montag, dem 23.05.2022 um 10:35 +0200 schrieb Kornel Benko:
> 
> Setting quote-style does not work in the replace_work_area.
> The setting
>     Dokument->Settings->Language->Quote-style
> has no effect.

The embedded buffers in F are "internal", so changes in the document
settings have no effect on them. This also applies to main language,
for instance.

When opening the F pane, some document params (such as language) are
copied, though not quote style. The attached patch changes that.

> but because of not able to set the quote-style in replace_work_area,
> findadv is not able to correct the quotes.

The most elegant way to change the quotes there, currently, is probably
to use the context menu of a quote inset.

> 
> Kornel

-- 
Jürgen
diff --git a/src/BufferParams.cpp b/src/BufferParams.cpp
index 95aa9136d2..e62d0100c8 100644
--- a/src/BufferParams.cpp
+++ b/src/BufferParams.cpp
@@ -3805,6 +3805,7 @@ void BufferParams::copyForAdvFR(const BufferParams & bp)
 {
 	string const & lang = bp.language->lang();
 	setLanguage(lang);
+	quotes_style = bp.quotes_style;
 	layout_modules_ = bp.layout_modules_;
 	string const & doc_class = bp.documentClass().name();
 	setBaseClass(doc_class);


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] User Guide: add quotes to a PackageOptions command

2022-05-22 Thread Jürgen Spitzmüller
Am Sonntag, dem 22.05.2022 um 15:41 -0400 schrieb Scott Kostyshak:
> On Sun, May 22, 2022 at 06:17:32PM +0200, Daniel wrote:
> > On 2022-05-19 10:32, Jürgen Spitzmüller wrote:
> > > Am Do., 19. Mai 2022 um 08:45 Uhr schrieb Daniel  > > <mailto:xraco...@gmx.de>>:
> > > 
> > >     Did you mean "replacing lexrc.next with lex.eatLine"?
> > > 
> > > 
> > > yes. I went ahead and fixed it.
> > 
> > So, should the change in the docs be reverted then or what is the
> > more
> > natural way?
> 
> I'm fine either way. I think without quotes is a bit more natural.
> However, I think I would lean towards keeping the quotes just because
> it's backwards compatible, and if I remember correctly, when we
> export
> to older formats, we do not have backwards conversion for layouts. If
> that's correct, then I would recommend users to use the quoted
> version.

On the other hand the quotes are inconsistent, and they have not been
documented in the earlier versions.

> 
> Scott

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] User Guide: add quotes to a PackageOptions command

2022-05-19 Thread Jürgen Spitzmüller
Am Do., 19. Mai 2022 um 08:45 Uhr schrieb Daniel :

> Did you mean "replacing lexrc.next with lex.eatLine"?
>

yes. I went ahead and fixed it.


> Anyway, with current master, when I use quotes around PackageOptions I
> get a "Layout is invalid!" error. Also, it seems to work just fine
> without quotes and with or without comma. What am I missing?
>

Did you only enclose the options to quotes or the whole statement? Only the
former works.

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] User Guide: add quotes to a PackageOptions command

2022-05-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 19.05.2022 um 07:30 +0200 schrieb Jürgen
Spitzmüller:
> Am Donnerstag, dem 19.05.2022 um 07:13 +0200 schrieb Daniel:
> > I see. It seems a bit strange that one needs quotes with comma but
> > not 
> > without. And this is not how it is done elsewhere, e.g. for 
> > "AlignPossible", etc. But I guess there is a specific reason for
> > the 
> > PackageOptions being treated differently?
> 
> I don't know. I haven't looked at the code. It certainly is possible
> to change that.

(supposedly only a matter of replacing a lex.eat with lex.eatLine)

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] User Guide: add quotes to a PackageOptions command

2022-05-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 19.05.2022 um 07:13 +0200 schrieb Daniel:
> I see. It seems a bit strange that one needs quotes with comma but
> not 
> without. And this is not how it is done elsewhere, e.g. for 
> "AlignPossible", etc. But I guess there is a specific reason for the 
> PackageOptions being treated differently?

I don't know. I haven't looked at the code. It certainly is possible to
change that.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] User Guide: add quotes to a PackageOptions command

2022-05-18 Thread Jürgen Spitzmüller
Am Donnerstag, dem 19.05.2022 um 06:11 +0200 schrieb Daniel:
> Instead, I see
> 
> PackageOptions todonotes obeyFinal
> 
> in "todonotes.module".

That's only one option.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: PackageOptions with two options?

2022-05-18 Thread Jürgen Spitzmüller
Am Dienstag, dem 17.05.2022 um 22:34 -0400 schrieb Scott Kostyshak:
> In the User Guide we mention the following to get two options:
> 
>   PackageOptions hyperref option1,option2

Try

PackageOptions hyperref "option1,option2"

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [PATCH] Allow removing words from the personal dictionary, that weren't previously added

2022-05-15 Thread Jürgen Spitzmüller
Am Sonntag, dem 15.05.2022 um 15:58 +0200 schrieb Jean-Marc Lasgouttes:
> Le 26/04/2022 à 09:27, Isaac Oscar Gariano a écrit :
> > I've made the "Remove from personal dictionary" function/context
> > menu 
> > item work for words that haven't been previously added, but instead
> > are 
> > in the system-wide dictionary.
> 
> Juergen,
> 
> Did you have time to look at this patch?

Unfortunately not yet. It is marked in my inbox, but I didn't find the
time to look at it, and it will probably take me some more time to do
so.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Failure to compile with gcc-12 (2.3.x)

2022-05-14 Thread Jürgen Spitzmüller
Am Donnerstag, dem 03.02.2022 um 17:06 + schrieb José Abílio Matos:
> The changes were minimal and already referred here.
> 
> It was enough to patch two files. The equivalent patch is already
> applied to the devel branch.

Just to confirm: OpenSuse Tumbleweed pushed gcc 12 on me today. I got
the same error while compiling stable, this patch cures it.

I think you should commit.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: FindAdv: search for white space

2022-05-11 Thread Jürgen Spitzmüller
Am Mittwoch, dem 11.05.2022 um 14:18 +0200 schrieb Kornel Benko:
> How to search for space like
> hfill, medskip, thinspace, visible space, quad, ...
> and many more with regex?

I'd expect \s covers them (except for visible space).

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: FindAdv: search for white space

2022-05-11 Thread Jürgen Spitzmüller
Am Dienstag, dem 10.05.2022 um 16:50 +0200 schrieb Kornel Benko:
> Does it make sense to add a checkbox to advanced find GUI like
> 'Space-type'
> which would treat all white spaces equal?
> (Anything in src/insets/InsetSpace.cpp)

Smells a bit like feature creep to me. Isn't this something that can be
done more elegantly via regexp?

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Add GUI for search-ignore

2022-05-10 Thread Jürgen Spitzmüller
Am Dienstag, dem 10.05.2022 um 11:53 +0200 schrieb Kornel Benko:
> Could we please add shortcuts to
>   'Select all'
> and maybe also to
>   'Deselect all'
> ?

Done. I needed to change some other shortcuts in the pane to get free
accelerators.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: features/indexmacros

2022-05-05 Thread Jürgen Spitzmüller
Am Donnerstag, dem 05.05.2022 um 04:27 +0200 schrieb Thibaut Cuvelier:
> I've pushed my refactoring of the XHTML output. According to my
> tests, it is functionally equivalent to the previous code, but with
> cleaner XHTML output (new lines, use of dashes for
> internationalisation). 
> Also, I believe the code is much easier to understand and modify in
> the long term (it also handles more than three levels of index, even
> if I doubt it will ever be useful). Algorithmically, it has a very
> similar time complexity but has arrays to store the index in a format
> closer to the XHTML output. Except for very large indices, this
> should not have a significant impact on users.

Excellent.

> Next: port the DocBook code to reuse as much as possible of the new
> XHTML implementation; add features to the XHTML export (multiple
> indices and ranges should be more or less easy to implement).
> 
> Feedback welcome on the code :)! 

It's not really area I am competent, but it looks good.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Back

2022-05-04 Thread Jürgen Spitzmüller
Am Mittwoch, dem 04.05.2022 um 11:52 -0400 schrieb Richard Kimberly
Heck:
> > There's one (big) question for 2.4: should we include Jürgen's
> > latest changes for indices? I'm still working on the XHTML part,
> > with a quite large refactoring at the same time to make the code
> > (much) easier to understand. 
> I guess others should chime in on this. Can someone describe for me
> what these changes have involved?

This adds specific subinsets for indexes (for "see", "seealso",
"sortkey" etc.) and native support for index ranges, pagination
formatting etc. (things you currently write after "|" in index insets).
It thus solves some long-standing quirks when having to use raw
makeindex syntax in index insets.

Everything is pretty straightforward, and I only need to write the
lyx2lyx code (rather trivial) and documentation. But it's a file format
change, and we might not want that at the current stage of development.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Back

2022-05-03 Thread Jürgen Spitzmüller
Am Dienstag, dem 03.05.2022 um 11:19 -0400 schrieb Richard Kimberly
Heck:
> Hi, all,
> 
> Sorry for disappearing there for a while. I had some difficult
> personal 
> circumstances and an incredibly busy semester and just had to
> withdraw 
> from everything else until things settled down. Which they now have.
> 
> Where are things with respect to LyX 2.4.0? I'm happy to resume my
> role 
> as release manager for that project, if that's still required.
> 
> Riki

Welcome back, Riki! Good to see you are well. Many of us (incl. me)
have been quite a bit passive recently.


-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Qt6 crash

2022-05-01 Thread Jürgen Spitzmüller
Am Freitag, dem 05.11.2021 um 09:22 +0100 schrieb Jürgen Spitzmüller:
> Am Freitag, dem 05.11.2021 um 08:10 +0100 schrieb Jürgen Spitzmüller:
> > Am Freitag, dem 05.11.2021 um 00:27 +0100 schrieb Jean-Marc
> > Lasgouttes:
> > > Is there some message from stdlib-debug before the backtrace? 
> > 
> > No.
> > 
> > > Or is it a crash related to object layout incompatibility? One
> > > possibility is a missing #include "config.h"
> > 
> > I have no clue.
> 
> FWIW it crashes at GuiView.cpp:901
> 
> Buffer::ExportStatus const status = watcher->result();

BTW I still have the same crash consistently with Qt6 and stdlib-debug.
I also get a crash during autosave in autoSaveThreadFinished().

I suspect or use of QFutureWatcher is the problem, but I know too less
of that to investigate.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-30 Thread Jürgen Spitzmüller
Am Samstag, dem 30.04.2022 um 11:27 +0200 schrieb Kornel Benko:
> The naming is not very fortunate yet, so please proceed.

Done. I leave the documentation work to you.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-30 Thread Jürgen Spitzmüller
Am Samstag, dem 30.04.2022 um 10:42 +0200 schrieb Kornel Benko:
> Apparently the search needs some more description.
> Make a testcase:
> Document lang = German
> Insert 'a'
> select some 'a' and change its lang to English
> Open findadv dialog
> insert 'a'
> find ...
>   You will see, that the English 'a' is not found
> Open Settings in findadv
> check 'Language'
> find again
>   Each 'a' is found
> 
> The difference between
> 1 unchecked 'Ignore formatting'
>   and
> 2 checked 'Ignore formatting' _and_ checked all
> 
> should be only the search speed. Unchecked 'Ignore formatting' is way
> faster.

I see, this relates to the formatting in the search window, not the
formatting in the document. How odd. I would have expected:

write in the document

test test test

search for "test" will only find the first and third occurrence unless
ignore formatting > Font shape is checked.

I have to think about how to name and describe the current behavior in
a away that users actually understand what it does.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-30 Thread Jürgen Spitzmüller
Am Freitag, dem 29.04.2022 um 19:31 +0200 schrieb Kornel Benko:
> Only a small change seems to to be enough (FindAndReplace.cpp:470)
> 
>     FindAndReplaceOptions opt(find_buf_name, casesensitive,
> matchword,
> -  !backwards, expandmacros,
> ignoreformat,
> +  !backwards, expandmacros,
> !ignoreformat,
>   repl_buf_name, keep_case, scope,
> restr);

Did that, still does not work for me.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-30 Thread Jürgen Spitzmüller
Am Freitag, dem 29.04.2022 um 20:06 +0200 schrieb Kornel Benko:
> Maybe we should also rename 'Ignore formatting' to 'Handle formatted
> search'.

Apart from that, does it do what you expect?

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-29 Thread Jürgen Spitzmüller
Am Freitag, dem 29.04.2022 um 17:02 +0200 schrieb Kornel Benko:
> The meaning of 'Ignore formatting' is reversed.
> 
> If 'Ignore formatting' is _not_ checked, then all subsequent
> selections should be enabled.
> 
> That is, only in formatted search we can select what is to be ignored
> or not.

Sorry, I cannot follow. But maybe you can take and adapt the patch to
what you think should be.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-29 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 09:35 +0200 schrieb Jürgen Spitzmüller:
> I have a GUI ready, but it doesn't work. I am not sure I understand
> how
> this is supposed to be used. If I have a text file with "test
> \textbf{test} test" and search for "test", the bold string is found
> no
> matter what I do (e.g., also if I do "search-ignore series false"
> before searching and no matter whether "Ignore format" is checked in
> the dialog or not).
> 
> What am I doing wrong?

FYI attached is the patch. It still does not work at all. I am stuck.

-- 
Jürgen
diff --git a/src/frontends/qt/FindAndReplace.cpp b/src/frontends/qt/FindAndReplace.cpp
index ab61e1ab73..074cf78ee9 100644
--- a/src/frontends/qt/FindAndReplace.cpp
+++ b/src/frontends/qt/FindAndReplace.cpp
@@ -469,10 +469,48 @@ bool FindAndReplaceWidget::findAndReplace(
 	FindAndReplaceOptions opt(find_buf_name, casesensitive, matchword,
   !backwards, expandmacros, ignoreformat,
   repl_buf_name, keep_case, scope, restr);
+	
+	if (ignoreformat) {
+		// Formats to ignore
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("language",
+	  ignoreLanguageCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("color",
+	  ignoreColorCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("family",
+	  ignoreFFamilyCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("series",
+	  ignoreFSeriesCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("shape",
+	  ignoreFShapeCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("markup",
+	  ignoreMarkupCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("underline",
+	  ignoreUnderlineCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("strike",
+	  ignoreStrikeCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("deleted",
+	  ignoreDeletedCB->isChecked(;
+		lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("sectioning",
+	  ignoreSectioningCB->isChecked(;
+	}
+	lyx::dispatch(FuncRequest(LFUN_SEARCH_IGNORE, checkState("non-output-content",
+  ignoreNonOutputCB->isChecked(;
+	
 	return findAndReplaceScope(opt, replace_all);
 }
 
 
+docstring const FindAndReplaceWidget::checkState(string const s, bool const b)
+{
+	docstring res = from_ascii(s) + from_ascii(" ");
+	if (b)
+		res += from_ascii("true");
+	else
+		res += from_ascii("false");
+	return res;
+}
+
+
 bool FindAndReplaceWidget::findAndReplace(bool backwards, bool replace, bool replace_all)
 {
 	if (! view_.currentMainWorkArea()) {
@@ -492,7 +530,7 @@ bool FindAndReplaceWidget::findAndReplace(bool backwards, bool replace, bool rep
 		wordsCB->isChecked(),
 		backwards,
 		expandMacrosCB->isChecked(),
-		ignoreFormatCB->isChecked(),
+		ignoreFormatGB->isChecked(),
 		replace,
 		keepCaseCB->isChecked(),
 		replace_all);
@@ -532,6 +570,33 @@ void FindAndReplaceWidget::on_searchbackCB_clicked()
 }
 
 
+void FindAndReplaceWidget::setFormatIgnores(bool const b)
+{
+	ignoreLanguageCB->setChecked(b);
+	ignoreColorCB->setChecked(b);
+	ignoreFFamilyCB->setChecked(b);
+	ignoreFSeriesCB->setChecked(b);
+	ignoreFShapeCB->setChecked(b);
+	ignoreMarkupCB->setChecked(b);
+	ignoreUnderlineCB->setChecked(b);
+	ignoreStrikeCB->setChecked(b);
+	ignoreDeletedCB->setChecked(b);
+	ignoreSectioningCB->setChecked(b);
+}
+
+
+void FindAndReplaceWidget::on_selectAllPB_clicked()
+{
+	setFormatIgnores(true);
+}
+
+
+void FindAndReplaceWidget::on_deselectAllPB_clicked()
+{
+	setFormatIgnores(false);
+}
+
+
 // Copy selected elements from bv's BufferParams to the dest_bv's
 static void copy_params(BufferView const & bv, BufferView & dest_bv) {
 	Buffer const & doc_buf = bv.buffer();
@@ -584,8 +649,9 @@ void FindAndReplace::updateView()
 
 
 FindAndReplace::FindAndReplace(GuiView & parent,
-		Qt::DockWidgetArea area, Qt::WindowFlags flags)
-	: DockView(parent, "findreplaceadv", qt_("Advanced Find and Replace"),
+			   Qt::DockWidgetArea area,
+			   Qt::WindowFlags flags)
+: DockView(parent, "findreplaceadv", qt_("Advanced Find and Replace"),
 		   area, flags)
 {
 	widget_ = new FindAndReplaceWidget(parent);
diff --git a/src/frontends/qt/FindAndReplace.h b/src/frontends/qt/FindAndReplace.h
index 0ffc39d458..7ea70a97ed 100644
--- a/src/frontends/qt/FindAndReplace.h
+++ b/src/frontends/qt/FindAndReplace.h
@@ -16,6 +16,7 @@
 // This is needed so that ui_FindAndReplaceUi.h can find qt_()
 #include "qt_helpers.h"
 #include "ui_FindAndRepla

Re: features/indexmacros

2022-04-24 Thread Jürgen Spitzmüller
Am Montag, dem 25.04.2022 um 02:43 +0200 schrieb Thibaut Cuvelier:
> I have pushed a slightly revised patch to your branch with the
> DocBook implementation. I'm now having a look at the XHTML one, in
> particular to share some code between the two.

Great!

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Properly ignore debug levels in the GUI

2022-04-24 Thread Jürgen Spitzmüller
Am Sonntag, dem 24.04.2022 um 15:40 +0200 schrieb Kornel Benko:
> Not sure if this is the cause, but now I see 2 identical entries for
>   outfile - Output source file generation/processing
> in the list of debug levels (GUI)

fixed at 64ec812da576af.

> (expected 'latex' not found, while it shows OK from command line with
> '-dbg')

"latex" is kept as an alias to "outfile" (as of 997f0621c53) for
convenience (like "any" and "all"), but should not be shown in the GUI.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Problem selecting debug level through the GUI

2022-04-24 Thread Jürgen Spitzmüller
Am Sonntag, dem 24.04.2022 um 13:32 +0200 schrieb Kornel Benko:
> Never mind, found a solution and committed at 3b7a79f1.

Well I just was about to commit one :-(

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: features/indexmacros

2022-04-22 Thread Jürgen Spitzmüller
Am Freitag, dem 22.04.2022 um 09:01 +0200 schrieb Jürgen Spitzmüller:
> > Also, I'm assuming that the user either uses the new insets or the
> > old, pure LaTeX way of doing index, not a mix of both. Does this
> > make
> > sense?
> 
> With LaTeX, both methods can be used in parallel, which might be
> useful
> especially for transition of existing documents. 

I realize that I probably misunderstood. Yes, as per inset, you can
only use one approach. You can only mix different insets in one
document.

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: features/indexmacros

2022-04-22 Thread Jürgen Spitzmüller
Am Freitag, dem 22.04.2022 um 03:49 +0200 schrieb Thibaut Cuvelier:
> Code-wise, the design looks really clean! 

Thanks.

> Also, I'm assuming that the user either uses the new insets or the
> old, pure LaTeX way of doing index, not a mix of both. Does this make
> sense?

With LaTeX, both methods can be used in parallel, which might be useful
especially for transition of existing documents. 

-- 
Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Update sk.po

2022-04-19 Thread Jürgen Spitzmüller
Am Dienstag, dem 19.04.2022 um 13:16 +0200 schrieb Kornel Benko:
> +msgid "Find and replace mechanism, short version"

I'd say the antonym of "verbose" is "terse".

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: features/indexmacros

2022-04-19 Thread Jürgen Spitzmüller
Am Dienstag, dem 19.04.2022 um 13:21 +0200 schrieb Jürgen Spitzmüller:
> This adds native macros for subindexes (!level), |see and |seealso

and sort keys (sort@key), for that matter.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


features/indexmacros

2022-04-19 Thread Jürgen Spitzmüller
FYI:

I have now pushed my current work on index macros to the new
features/features/indexmacros branch.

This does:

Introduce InsetIndexMacros

This adds native macros for subindexes (!level), |see and |seealso
as well as native support for ranges |( |) and pagination format
-- e.g., |textbf -- via the index dialog

Resolves #12478, #7232 and #5014

The feature is complete (incl. tex2lyx) except for

* file format change and lyx2lyx
* docbook/xhtml
* documentation


So it is basically ready. However, I will postpone this to 2.5.x unless
you urge me to do otherwise or 2.4.x is retarded even longer (BTW I'd
opt for branching 2.4.x now just to at least pretend we are heading
towards something).

Testing welcome (Thibaut already promised to address docbook).

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Using inherited/current color in box

2022-04-09 Thread Jürgen Spitzmüller
Am Freitag, dem 08.04.2022 um 10:30 -0400 schrieb Scott Kostyshak:
> For lyx2lyx backwards conversion, I suppose there are 2 options:
> 
> 1. Try to figure out the default color from the .lyx file and set the
>    color explicitly.

Not an option IMHO. Since this color is dynamic, it could be changed
afterwards.

> 2. ERT.

Yes.

> 
> By the way (relevant here but also curious), if we do (2), is there
> any way to ask LyX for the appropriate LaTeX code to put in ERT? I
> suppose not since lyx2lyx is a separate program?

No, but lyx2lyx has routines to put code in an ert inset.

AFAIK, though, no further file format changes should go into 2.4. At
least I am holding back all my stuff meanwhile.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Find quotes with quick search

2022-04-07 Thread Jürgen Spitzmüller
Am Donnerstag, dem 07.04.2022 um 11:25 +0200 schrieb Kornel Benko:
> The attached works nice for me.
> Is that OK to you Jürgen?

Fine with me.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Using inherited/current color in box

2022-04-07 Thread Jürgen Spitzmüller
Am Donnerstag, dem 07.04.2022 um 22:31 -0400 schrieb Scott Kostyshak:
> Indeed using tcolorbox might suit my needs better. I might look into
> using that. In any case, I worked on a patch for fcolorbox.

You are aware that this is a file format change?

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-02 Thread Jürgen Spitzmüller
Am Samstag, dem 02.04.2022 um 11:57 +0200 schrieb Jürgen Spitzmüller:
> I'll have a look.

Better?

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-02 Thread Jürgen Spitzmüller
Am Samstag, dem 02.04.2022 um 11:48 +0200 schrieb Kornel Benko:
> No, normally we get in latex
> 
> \begin{comment}
> aexbc
> \end{comment}
> 
> now this is only the case if searching in non output (means no output
> in pdf IMO)

So you are talking about InsetNoteParams::Comment, not
InsetNoteParams::Note

I'll have a look.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-02 Thread Jürgen Spitzmüller
Am Samstag, dem 02.04.2022 um 11:24 +0200 schrieb Kornel Benko:
> InsetNoteParams::Note is now not part of latex output when not
> searched.

Isn't that how it should be?

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-02 Thread Jürgen Spitzmüller
Am Samstag, dem 02.04.2022 um 11:15 +0200 schrieb Kornel Benko:
> Perfect! Please commit.

Done.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-02 Thread Jürgen Spitzmüller
Am Samstag, dem 02.04.2022 um 09:38 +0200 schrieb Kornel Benko:
> But they do not appear in latex output, thus are never accessible by
> searchadv.

Like so (untested)?

In any case, I think the testing should be done in InsetNote::latex(),
not InsetText::latex().

Jürgen
diff --git a/src/insets/InsetNote.cpp b/src/insets/InsetNote.cpp
index adacef3bae..05253de855 100644
--- a/src/insets/InsetNote.cpp
+++ b/src/insets/InsetNote.cpp
@@ -206,9 +206,19 @@ bool InsetNote::isMacroScope() const
 
 void InsetNote::latex(otexstream & os, OutputParams const & runparams_in) const
 {
-	if (params_.type == InsetNoteParams::Note)
+	if (params_.type != InsetNoteParams::Greyedout
+	&& (runparams_in.for_searchAdv & OutputParams::SearchNonOutput) == 0)
 		return;
 
+	if (params_.type == InsetNoteParams::Note) {
+		if ((runparams_in.for_searchAdv & OutputParams::SearchNonOutput) != 0) {
+			OutputParams runparams(runparams_in);
+			InsetCollapsible::latex(os, runparams);
+			runparams_in.encoding = runparams.encoding;
+		}
+		return;
+	}
+
 	OutputParams runparams(runparams_in);
 	if (params_.type == InsetNoteParams::Comment) {
 		runparams.inComment = true;
diff --git a/src/insets/InsetText.cpp b/src/insets/InsetText.cpp
index af1847cbaf..c67e934add 100644
--- a/src/insets/InsetText.cpp
+++ b/src/insets/InsetText.cpp
@@ -485,12 +485,6 @@ void InsetText::latex(otexstream & os, OutputParams const & runparams) const
 	// environment. Standard collapsible insets should not
 	// redefine this, non-standard ones may call this.
 	InsetLayout const & il = getLayout();
-	if (runparams.for_searchAdv != OutputParams::NoSearch &&
-	(runparams.for_searchAdv & OutputParams::SearchNonOutput) == 0 &&
-	!il.latexname().empty() &&
-	il.latextype() == InsetLaTeXType::ENVIRONMENT &&
-	il.latexname() == "comment")
-		return;
 
 	if (il.forceOwnlines())
 		os << breakln;



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 20:17 +0200 schrieb Kornel Benko:
> > I think there is no need to restrict it to comment. Otherwise no
> > objection.
> 
> Do you have some ideas what else could be included?

LyX Notes.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 18:08 +0200 schrieb Kornel Benko:
> Apropos, do you have objections in regard of the patch in
> InsetText.cpp?

I think there is no need to restrict it to comment. Otherwise no
objection.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 15:59 +0200 schrieb Kornel Benko:
> What is missing is the search in comments only.

Do we really need this?

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 11:33 +0200 schrieb Kornel Benko:
> This will take a while :(

No problem.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 11:07 +0200 schrieb Kornel Benko:
> Attached example.

But this gives the same result if "search-ignore non-output-content"
is set to false or true. In both cases, the inset is found.

But anyway, my concern would rather be: how do I find a string _inside_
this inset?

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 11:03 +0200 schrieb Kornel Benko:
> You cannot if it is a lyx-comment. If the note is latex, then you can
> type the string in the search window in a note.

Does not work. 

Anyway, I think I have completely misunderstood the purpose of "search-
ignore non-output-content false". I thought it would enable searching
in things such as notes, comments, inactive branches. If it enables
_typing_ search strings in such insets, I fail to see why that should
be useful.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 10:10 +0200 schrieb Kornel Benko:
> ATM, it works like this:
> Any feature deselected with the lfun is ignored no matter what is in
> the search window.

I still do not understand. How can I make AdvSearch search in a note?
"search-ignore non-output-content false" does not do that for me.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 01.04.2022 um 09:49 +0200 schrieb Kornel Benko:
> Nothing wrong. Search for bold string instead.
> Any feature not used in the search-window will be ignored at the
> moment.

Is this really the lfun being in effect here or rather the old "ignore
setting"?

I am still not sure how this lfun works. How do I effectively use
"search-ignore non-output-content false"?

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-04-01 Thread Jürgen Spitzmüller
Am Freitag, dem 11.03.2022 um 14:38 +0100 schrieb Kornel Benko:
> Of course, thanks. If you have ideas, what I can do, I would like to
> collaborate.

I have a GUI ready, but it doesn't work. I am not sure I understand how
this is supposed to be used. If I have a text file with "test
\textbf{test} test" and search for "test", the bold string is found no
matter what I do (e.g., also if I do "search-ignore series false"
before searching and no matter whether "Ignore format" is checked in
the dialog or not).

What am I doing wrong?

Jürgen




signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: bg.po update

2022-04-01 Thread Jürgen Spitzmüller
Am Donnerstag, dem 31.03.2022 um 19:35 +0300 schrieb Veselin:
> Attached is an updated file from lyx 2.4.0dev for the bulgarian
> translation.
> 
> I send you an update as the translation was under 50%.

Thanks. Committed.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Missing tabular-feature_set-all-lines.svgz

2022-03-18 Thread Jürgen Spitzmüller
Am Freitag, dem 18.03.2022 um 09:18 +0100 schrieb Lorenzo Bertini:
> Hello,
> 
> since a week ago I can't build LyX anymore, as it complains that the 
> file "tabular-feature_set-all-lines.svgz" is necessary for "all-am",
> but 
> there are no rules to make it, as it is an image. I checked and it's
> not 
> present in origin repo. What can I do to start building again?

The necessary changes in makefile.am have been done AFAICS.

Did you try make distclean & ./autogen.sh

HTH,
Jürgen

> 
> Thanks in advance,
> 
> Lorenzo



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-03-11 Thread Jürgen Spitzmüller
Am Sonntag, dem 06.03.2022 um 19:01 +0100 schrieb Kornel Benko:
> Each of the (color .. strike) describe which char property has to be
> ignored while
> searching a pattern. Each property can be set independently.
> (deleted) describes if the searched region includes deleted (in
> documents with change-tracking enabled)
> (non-output-content) describes if the searched region includes
> contents of deactivated
> branches.
> 
> The values are "true" and "false", that is a simple checkbox should
> be OK.
> 
> Also with each new dialog start, the old values should be preserved.
> At lyx start all values may be "false". I'd prefer, if one could save
> the values as
> default (like we do for new document)
> 
> The call to the lyx-function is to be done separately for each
> changed checkbox.
> 
> Thanks in advance

FYI I am working on a GUI, but it'll take me some time.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Beamer example file: use relative offsets?

2022-03-06 Thread Jürgen Spitzmüller
Am So., 6. März 2022 um 20:19 Uhr schrieb Scott Kostyshak :

> For example, see the attached screenshot, where I highlight the "6". The
> "6" means to trigger the action (in this case highlight in red) on the
> 6th slide. If we replace the 6 with "+-" or ".(1)", we get identical PDF
> output. The advantage of using relative off-sets in this case, is that
> if we add another item to the list, or we add another manual pause, the
> relative offset does not need to be changed, but the absolute reference
> would need to be changed (e.g., if we add an item before we would need
> to change the 6 to a 7).
>

I think users should learn both, contextual and fixed offsets. As to the
mentioned example, I am undecided.

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-03-06 Thread Jürgen Spitzmüller
Am Sonntag, dem 06.03.2022 um 11:00 +0100 schrieb Kornel Benko:
> I'd like to, and not only for this, but would need help. GUI
> programming/creating is not
> my strength.
> 
> All the possibilities, effective if 'ignore format' == false
>   color, language, sectioning, font, series, shape, family,
> markup, underline,
>   strike
> and the other two effective allways
>   deleted, non-output-content
> deserve a GUI.

If you can describe exactly what the GUI should set, I can help.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Display manually set itemize symbols

2022-03-06 Thread Jürgen Spitzmüller
Am Sonntag, dem 06.03.2022 um 09:49 +0100 schrieb Jürgen Spitzmüller:
> I reverted the change.

Addressed differently at 1c2628b5de3837. Please try again.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-03-06 Thread Jürgen Spitzmüller
Am Sonntag, dem 06.03.2022 um 09:35 +0100 schrieb Kornel Benko:
> Implemented your suggestion.

Can't test it now but from the patch it looks good. I guess you will
also add GUI support (a checkbox to set this)?

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Display manually set itemize symbols

2022-03-06 Thread Jürgen Spitzmüller
Am Samstag, dem 05.03.2022 um 13:40 -0500 schrieb Scott Kostyshak:
> I just tried but I get the following:
> 
> LyX has caught an exception, it will now attempt to save all unsaved
> documents and exit.
> 
> Exception: std::bad_alloc

I reverted the change. No time currently to investigate further.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-03-05 Thread Jürgen Spitzmüller
Am Samstag, dem 05.03.2022 um 18:36 +0100 schrieb Kornel Benko:
> Or even
>   search-include non-output-content true
> ?
> 
> Would be a new command.

yes, even better (although it is not clear from the command that it
only applies advanced search).

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-03-05 Thread Jürgen Spitzmüller
Am Samstag, dem 05.03.2022 um 16:42 +0100 schrieb Kornel Benko:
> I have no idea, how to get notes output in latex mode

Adapt the conditions in InsetNote::latex() accordingly.

> > and I
> > don't see where to opt-out (as I'd have expected).
> 
> this could be done with the function 'search-ignore deactivated true'
> (not yet implemented
> though)
> Not happy about the naming ...

search-ignore non-output-content false?

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-03-05 Thread Jürgen Spitzmüller
Am Samstag, dem 05.03.2022 um 16:10 +0100 schrieb Kornel Benko:
> Does the attached work as expected?

It finds in deactivated branches (good!) but not in notes (bad!) and I
don't see where to opt-out (as I'd have expected).

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Display manually set itemize symbols

2022-03-05 Thread Jürgen Spitzmüller
Am Freitag, dem 04.03.2022 um 11:01 -0500 schrieb Scott Kostyshak:
> Question mark sounds good. Could get a bit fancier and do "?1" and
> "?2" to differentiate between further levels of nesting. Or instead
> of "?1", perhaps "?4" or whatever the nesting depth is.

Done (the latter) at 44d1756783262a.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Remove unused function

2022-03-05 Thread Jürgen Spitzmüller
Am Samstag, dem 05.03.2022 um 09:07 +0100 schrieb Kornel Benko:
> As you are at it, we also have identical functions with different
> names.
> See
>   docstring const & Bullet::getText() const
> and
>   docstring const & Bullet::getUnicode() const
> 
> Any reason to not unify them?

The functions are not identical. One returns text for source (text),
the other for workarea (unicode, now renamed label).

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Display manually set itemize symbols

2022-03-04 Thread Jürgen Spitzmüller
Am Freitag, dem 04.03.2022 um 11:01 -0500 schrieb Scott Kostyshak:
> > Long-term, we should limit the nesting level to what is supported
> > (but
> > consider that deeper nestings are possible e.g. with customized
> > enumitem lists).
> 
> Would this mean a new layout tag?

Yes, something like AllowedSelfNestingLevel (defaulting to 3).

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Display manually set itemize symbols

2022-03-04 Thread Jürgen Spitzmüller
Am Freitag, dem 04.03.2022 um 10:12 +0100 schrieb Kornel Benko:
> No problems with the release compiled version, but the debug version
> core-dumped.
> 
> Under gdb I see the same as Scott.
> Do we need LASSERT at BufferParams.cpp:657 anyway?

As long as nesting > 4 is possible, we definitely shouldn't assert, but
fall back to another glyph, maybe not the one from level i (as we do
now in release mode), but one that indicates the threshold has been
exceeded (maybe simply a question mark).

Long-term, we should limit the nesting level to what is supported (but
consider that deeper nestings are possible e.g. with customized
enumitem lists).

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Entering symbol U+2729

2022-03-04 Thread Jürgen Spitzmüller
Am Freitag, dem 04.03.2022 um 09:52 +0100 schrieb Kornel Benko:
> According to the code-preview, it is not.
> I always see
> 
> {\Huge\FiveStarOpen{}
> \FiveStarOpen{}}{\Huge\par}
> 
> when exported to any tex-variant.

Not here. The following is LuaTeX, with master:

%% LyX 2.4.0dev created this file.  For more info, see
https://www.lyx.org/.
%% Do not edit unless you really know what you are doing.
\documentclass[american]{article}
\usepackage{fontspec}
\setmainfont[Ligatures=TeX]{FreeSerif}
\usepackage{polyglossia}
\setdefaultlanguage[variant=american]{english}
\begin{document}
✩
\end{document}


Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Entering symbol U+2729

2022-03-04 Thread Jürgen Spitzmüller
Am Donnerstag, dem 03.03.2022 um 21:08 +0100 schrieb Kornel Benko:
> I don't have a command handy. The pifont \ding{"49} looks not as
> expected. (See pifont.ucf for U+2729)

pifont's \ding{73} is what I think you expect, but note that the form
is subject to interpretation anyway. Compare the output of Arial
Unicode and OpenSerif, for instance,
or
https://www.compart.com/de/unicode/U+2729
vs.
https://www.fileformat.info/info/unicode/char/2729/index.htm

\FiveStarOpen comes from a package that attempts to provide dingbats,
so it actually _is_ a representation (interpretation) of that glyph
rather than of WHITE STAR from the MISCELLANEOUS SYMBOLS block.

pifont might look more familiar, as this uses the Zapf Dingbat font
(rather than the bbding font) which is the most prominent dingbats font
and also used in the official unicode chart:
https://unicode.org/charts/PDF/U2700.pdf

However, the form of the glyph is -- as in the case of any other glyph
-- not set in stone. It is subject to font design, and what we
currently have is the bbding design (of Karel Horak).

In any case, if you change 0x2729, you'd also need to change all other
symbols in the DINGBATS block which also come from bbding currently, in
order to get coherent characters. And this will change people's exiting
documents.

So I vote for leaving things as they are unless there is really a good
reason for a change, or doing a file format change and maintain bbding
in existing documents via ERT.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Entering symbol U+2729

2022-03-03 Thread Jürgen Spitzmüller
Am Donnerstag, dem 03.03.2022 um 21:08 +0100 schrieb Kornel Benko:
> But at lest, we could use the unicode char directly for at lease
> lualatex and xeletex. 

That's what we do anyway.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Entering symbol U+2729

2022-03-03 Thread Jürgen Spitzmüller
Am Donnerstag, dem 03.03.2022 um 12:57 +0100 schrieb Kornel Benko:
> 'unicode-insert 0x2729' works as expected, displays 'STRESS OUTLINED
> WHITE STAR'✩
> but the latex-code shows \FiveStarOpen{} which is unicode U+2606,
> 'WHITE STAR' in dingbats
> ☆

Which LaTeX command do you propose instead? Or do you propose to remove
support for this glyph?

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Adapt resulting lyx-file to amend 39c0b322 (changed tex2lyx output)

2022-03-02 Thread Jürgen Spitzmüller
Am Mi., 2. März 2022 um 12:43 Uhr schrieb Kornel Benko :

> This lyx-file is what we expect as a result from tex2lyx. And since
> tex2lyx now adds
> \usepackage{textcomp}
> and the result is OK, we can use this file for later comparisons.
>
> So, you fixed the cause already.
> It is the same procedure as we are using for file-format changes.
>

No, I think here textcomp should not be added to the user preamble. It is
an automatically loaded package.

I fixed the cause at b5b3f56abb036edf, which ensues the previous fix.

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Adapt resulting lyx-file to amend 39c0b322 (changed tex2lyx output)

2022-03-02 Thread Jürgen Spitzmüller
Am Mi., 2. März 2022 um 08:51 Uhr schrieb Kornel Benko :

> commit 5e8969b597ae973a12cfb543ed055e4eb8cd16ec
> Author: Kornel Benko 
> Date:   Wed Mar 2 08:48:35 2022 +0100
>
> Adapt resulting lyx-file to amend 39c0b322 (changed tex2lyx output)
>

I'd rather fix the cause than the symptom.

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-03-01 Thread Jürgen Spitzmüller
Am Mittwoch, dem 02.03.2022 um 08:04 +0100 schrieb Jürgen Spitzmüller:
> The real culprit is 4cab1a77d20d3db8.
> 
> You now exit fromLaTeXCommand() in the "easy" cases, without properly
> setting needsTermination. If this boolean is correctly set (see the
> logic in the method below), the problem is probably solved.

Should be fixed at 39c0b322f7b14.

A remaining problem is that test-inset-basic now loads textcomp, which
it didn't before.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-03-01 Thread Jürgen Spitzmüller
Am Mittwoch, dem 02.03.2022 um 02:08 +0100 schrieb Thibaut Cuvelier:
> I'm still unable to reproduce locally. My Git directory is quite
> clean:

The real culprit is 4cab1a77d20d3db8.

You now exit fromLaTeXCommand() in the "easy" cases, without properly
setting needsTermination. If this boolean is correctly set (see the
logic in the method below), the problem is probably solved.

HTH,
Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-03-01 Thread Jürgen Spitzmüller
Am Di., 1. März 2022 um 17:53 Uhr schrieb Jürgen Spitzmüller :

> Am Di., 1. März 2022 um 03:48 Uhr schrieb Thibaut Cuvelier <
> tcuvel...@lyx.org>:
>
>> I tested only for test.ltx, but I can reproduce the error at commit
>> df59649a (before any of my Unicode changes).
>>
>
> Interestingly, I can't. With "make updatetests" in src/tex2lyx (which runs
> the tex2lyx tests), I do not see changes at df59649a, and a new bisect
> again points at 3f9e21b826926f.
>

Nope, sorry: fec498d6617d (missed some bisect step)

I have locally fixed the compile problem due to unsupported .contains() to
test also those commits.

Jürgen


>
> Jürgen
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-03-01 Thread Jürgen Spitzmüller
Am Di., 1. März 2022 um 03:48 Uhr schrieb Thibaut Cuvelier <
tcuvel...@lyx.org>:

> I tested only for test.ltx, but I can reproduce the error at commit
> df59649a (before any of my Unicode changes).
>

Interestingly, I can't. With "make updatetests" in src/tex2lyx (which runs
the tex2lyx tests), I do not see changes at df59649a, and a new bisect
again points at 3f9e21b826926f.

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Clarify debug message

2022-03-01 Thread Jürgen Spitzmüller
Am Di., 1. März 2022 um 13:51 Uhr schrieb Jürgen Spitzmüller :

> Am Di., 1. März 2022 um 04:19 Uhr schrieb Thibaut Cuvelier <
> tcuvel...@lyx.org>:
>
>> On Tue, 1 Mar 2022 at 03:58, Thibaut Cuvelier  wrote:
>>
>>> On Mon, 28 Feb 2022 at 08:04, Jürgen Spitzmüller  wrote:
>>>
>>>> Am Sonntag, dem 27.02.2022 um 20:48 +0100 schrieb Thibaut Cuvelier:
>>>> > I'm doing this in the attached patches (also for HTML, XML being the
>>>> > common part between the two). I would like some feedback more
>>>> > specifically for the typing of the enum: as I could find, it's never
>>>> > sure that enums are coded with enough bits to add a code (there are
>>>> > already enough codes to fill 32 bits). I thus forced the types to be
>>>> > unsigned long long, to have 64 available bits
>>>> > (https://en.cppreference.com/w/cpp/language/types).
>>>> >
>>>> > I also tried to change as many occurrences I could find, but there
>>>> > were not many (or my searching skills are not on par).
>>>>
>>>> Thinking more about it, another option would be to rename LATEX to
>>>> something more generic (e.g. OUTFILE), maybe keeping "latex" as an
>>>> alias on the command line. After all, only one of these is used at a
>>>> given time, and depending on the output chain, it might not even be
>>>> clear which one. Also, we do not have a PLAINTEXT mode.
>>>>
>>>
>>> What do you think about this new iteration?
>>>
>>
>> I forgot to include the changes to debug.cpp in the previous patch, here
>> is a new complete patch.
>>
>
> Looks good. I would probably rephrase the help text as "Output source file
> generation/processing"
>

... and add an alias "latex" for backwards compatibility, like we have for
"any" and "all".

Jürgen


>
> Thanks,
> Jürgen
>
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Clarify debug message

2022-03-01 Thread Jürgen Spitzmüller
Am Di., 1. März 2022 um 04:19 Uhr schrieb Thibaut Cuvelier <
tcuvel...@lyx.org>:

> On Tue, 1 Mar 2022 at 03:58, Thibaut Cuvelier  wrote:
>
>> On Mon, 28 Feb 2022 at 08:04, Jürgen Spitzmüller  wrote:
>>
>>> Am Sonntag, dem 27.02.2022 um 20:48 +0100 schrieb Thibaut Cuvelier:
>>> > I'm doing this in the attached patches (also for HTML, XML being the
>>> > common part between the two). I would like some feedback more
>>> > specifically for the typing of the enum: as I could find, it's never
>>> > sure that enums are coded with enough bits to add a code (there are
>>> > already enough codes to fill 32 bits). I thus forced the types to be
>>> > unsigned long long, to have 64 available bits
>>> > (https://en.cppreference.com/w/cpp/language/types).
>>> >
>>> > I also tried to change as many occurrences I could find, but there
>>> > were not many (or my searching skills are not on par).
>>>
>>> Thinking more about it, another option would be to rename LATEX to
>>> something more generic (e.g. OUTFILE), maybe keeping "latex" as an
>>> alias on the command line. After all, only one of these is used at a
>>> given time, and depending on the output chain, it might not even be
>>> clear which one. Also, we do not have a PLAINTEXT mode.
>>>
>>
>> What do you think about this new iteration?
>>
>
> I forgot to include the changes to debug.cpp in the previous patch, here
> is a new complete patch.
>

Looks good. I would probably rephrase the help text as "Output source file
generation/processing"

Thanks,
Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Clarify debug message

2022-02-27 Thread Jürgen Spitzmüller
Am Sonntag, dem 27.02.2022 um 20:48 +0100 schrieb Thibaut Cuvelier:
> I'm doing this in the attached patches (also for HTML, XML being the
> common part between the two). I would like some feedback more
> specifically for the typing of the enum: as I could find, it's never
> sure that enums are coded with enough bits to add a code (there are
> already enough codes to fill 32 bits). I thus forced the types to be
> unsigned long long, to have 64 available bits
> (https://en.cppreference.com/w/cpp/language/types).
> 
> I also tried to change as many occurrences I could find, but there
> were not many (or my searching skills are not on par).

Thinking more about it, another option would be to rename LATEX to
something more generic (e.g. OUTFILE), maybe keeping "latex" as an
alias on the command line. After all, only one of these is used at a
given time, and depending on the output chain, it might not even be
clear which one. Also, we do not have a PLAINTEXT mode.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-02-27 Thread Jürgen Spitzmüller
Am Sonntag, dem 27.02.2022 um 15:05 +0100 schrieb Jürgen Spitzmüller:
> The more serious issue is perhaps that the produced file seems to
> differ. But I am not sure how to read those tests.

These problems begin with

[fec498d6617d9] unicodesymbols: add several synonyms.

Attached is a diff from tex2lyx tests that shows the changes. These
seem to be (1.) additional space between characters and (2.) sometimes
inserted {} in ERT.

Thibaut, does this ring a bell?

Jürgen

diff --git a/src/tex2lyx/test/beamer.lyx.lyx b/src/tex2lyx/test/beamer.lyx.lyx
index 5b00841c5e..fed95a34f8 100644
--- a/src/tex2lyx/test/beamer.lyx.lyx
+++ b/src/tex2lyx/test/beamer.lyx.lyx
@@ -593,7 +593,7 @@ short
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Short Title\SpecialChar breakableslash
+Insert → Short Title\SpecialChar breakableslash
 Date\SpecialChar breakableslash
 \SpecialChar ldots
 
@@ -725,7 +725,7 @@ AgainFrame
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Overlay Specifications
+Insert → Overlay Specifications
 \end_layout
 
 \end_inset
@@ -815,7 +815,7 @@ Frame
 status collapsed
 
 \begin_layout Plain Layout
-Edit →Increase List Depth
+Edit → Increase List Depth
 \end_layout
 
 \end_inset
@@ -898,7 +898,7 @@ There is a simple and much more convenient way to start a new frame: Issue
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Separated Frame Below
+Insert → Separated Frame Below
 \end_layout
 
 \end_inset
@@ -926,7 +926,7 @@ Alt+A Shift+Return
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Separated Frame Above
+Insert → Separated Frame Above
 \end_layout
 
 \end_inset
@@ -1085,7 +1085,7 @@ Did you know that you can easily move and re-arrange whole frames via the outlin
 status collapsed
 
 \begin_layout Plain Layout
-View →Outline Pane
+View → Outline Pane
 \end_layout
 
 \end_inset
@@ -1362,7 +1362,7 @@ In LyX, these settings are generally accessible via
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Overlay Specifications
+Insert → Overlay Specifications
 \end_layout
 
 \end_inset
@@ -1372,7 +1372,7 @@ Insert →Overlay Specifications
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Action Specifications
+Insert → Action Specifications
 \end_layout
 
 \end_inset
@@ -1595,7 +1595,7 @@ Quote
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Overlay Specifications
+Insert → Overlay Specifications
 \end_layout
 
 \end_inset
@@ -2280,7 +2280,7 @@ Via
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Pause Number
+Insert → Pause Number
 \end_layout
 
 \end_inset
@@ -2540,7 +2540,7 @@ Beamer
 status collapsed
 
 \begin_layout Plain Layout
-Edit →Text Style
+Edit → Text Style
 \end_layout
 
 \end_inset
@@ -2804,7 +2804,7 @@ inline
 status collapsed
 
 \begin_layout Plain Layout
-Edit →Text Style
+Edit → Text Style
 \end_layout
 
 \end_inset
@@ -3246,7 +3246,7 @@ Use
 status collapsed
 
 \begin_layout Plain Layout
-Edit →Start New Environment
+Edit → Start New Environment
 \end_layout
 
 \end_inset
@@ -3323,7 +3323,7 @@ Via
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Additional Theorem Text
+Insert → Additional Theorem Text
 \end_layout
 
 \end_inset
@@ -3792,7 +3792,27 @@ So what?
 \end_layout
 
 \begin_layout Frame
-This is actually pretty useful! You can set up a single document and produce both a presentation and – using the article mode – a handout. 
+This is actually pretty useful! You can set up a single document and produce both a presentation and –
+\begin_inset ERT
+status collapsed
+
+\begin_layout Plain Layout
+{}
+\end_layout
+
+\end_inset
+
+ using the article mode –
+\begin_inset ERT
+status collapsed
+
+\begin_layout Plain Layout
+{}
+\end_layout
+
+\end_inset
+
+ a handout. 
 \end_layout
 
 \begin_deeper
@@ -3896,7 +3916,7 @@ status collapsed
 
 \begin_layout Plain Layout
 \noindent
-Edit →Text Style →Only
+Edit → Text Style → Only
 \end_layout
 
 \end_inset
@@ -3916,7 +3936,7 @@ Or put all sorts of complex contents via
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Custom Insets →ArticleMode
+Insert → Custom Insets → ArticleMode
 \end_layout
 
 \end_inset
@@ -3936,7 +3956,7 @@ Or put all sorts of complex contents via
 status collapsed
 
 \begin_layout Plain Layout
-Insert →Custom Insets →PresentationMode
+Insert → Custom Insets → PresentationMode
 \end_layout
 
 \end_inset
@@ -4085,7 +4105,7 @@ Then add the presentation to this document as a child (via
 status collapsed
 
 \begin_layout Plain Layout
-Insert →File →Child Document\SpecialChar ldots
+Insert → File → Child Document\SpecialChar ldots
 
 \end_layout
 
@@ -4161,7 +4181,7 @@ Berkeley
 status collapsed
 
 \begin_layout Plain Layout
-Document →Settings →LaTeX
+Document → Settings → LaTeX
 \begin_inset space ~
 
 \end_inset
diff --git a/src/tex2lyx/test/box-color-size-space-align.lyx.lyx b/src/tex2lyx/test/box-color-size-space-align.lyx.lyx
index 28ea2b539c..b88c57c199 100644
--- a/src/tex2lyx/test/box-color-size-space-align.lyx.lyx
+++ b/src/t

Re: [LyX/master] Clarify debug message

2022-02-27 Thread Jürgen Spitzmüller
Thibaut, you might want to introduce a Debug::DOCBOOK mode rather than
sending these messages over all channels (also, in other cases, the
docbook chain uses Debug::LATEX which strikes me odd).

Jürgen


Am Sonntag, dem 27.02.2022 um 14:39 +0100 schrieb Juergen Spitzmueller:
> commit 9cd479a044e76601d3ad625181918c26c4e551b0
> Author: Juergen Spitzmueller 
> Date:   Sun Feb 27 15:12:33 2022 +0100
> 
>     Clarify debug message
> ---
>  src/Floating.cpp |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/Floating.cpp b/src/Floating.cpp
> index 6a14708..8554503 100644
> --- a/src/Floating.cpp
> +++ b/src/Floating.cpp
> @@ -69,7 +69,7 @@ Floating::Floating(string const & type, string
> const & placement,
> docbook_float_type_ = "video";
> } else {
> // If nothing matches, return something that
> will not be valid.
> -   LYXERR0("Unrecognised float type: " +
> floattype_);
> +   LYXERR0("Float type '" + floattype_ + "'
> unknown to DocBook!");
> docbook_float_type_ = "unknown";
> }
> }
> @@ -159,7 +159,7 @@ string Floating::docbookTag(bool hasTitle) const
> return hasTitle ? "table" : "informaltable";
> } else {
> // If nothing matches, return something that will not
> be valid.
> -   LYXERR0("Unrecognised float type: " + floattype());
> +   LYXERR0("Float type '" + floattype() + "' unknown to
> DocBook!");
> return "float";
> }
>  }



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-02-27 Thread Jürgen Spitzmüller
Am Sonntag, dem 27.02.2022 um 12:38 +0100 schrieb Kornel Benko:
> b'Overwriting existing
> file /BUILD/BUILDMint18/BuildLyxGitQt5.9.5local-
> gcc8.4.0/src/tex2lyx/test/test.lyx\nFloating.cpp
> (72): Unrecognised float type: endnote\nFloating.cpp (72):
> Unrecognised float type:
> endnote\nFloating.cpp (72): Unrecognised float type:
> endnote\nFloating.cpp (72):
> Unrecognised float type: endnote\n'
> 
> Don't know if you are satisfied with it.

The message is probably harmless and due to 8b6e3d374996.

It occurs when a float type that is not hardcoded in
Floating::Floating() is detected (e.g., in private modules or layout
files), and the float cannot be associated with a respective docbook
equivalent.

The more serious issue is perhaps that the produced file seems to
differ. But I am not sure how to read those tests.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-02-27 Thread Jürgen Spitzmüller
Am Sonntag, dem 27.02.2022 um 10:25 +0100 schrieb Kornel Benko:
> Here it is (72% tests passed, 10 tests failed out of 36)
> 
> The following tests FAILED:
>10 - tex2lyx/roundtrip/test.ltx (Failed)
>11 - tex2lyx/cmplyx/test.ltx (Failed)
>14 - tex2lyx/roundtrip/beamer.tex (Failed)
>15 - tex2lyx/cmplyx/beamer.tex (Failed)
>16 - tex2lyx/roundtrip/box-color-size-space-align.tex
> (Failed)
>17 - tex2lyx/cmplyx/box-color-size-space-align.tex (Failed)
>26 - tex2lyx/roundtrip/test-insets-basic.tex (Failed)
>27 - tex2lyx/cmplyx/test-insets-basic.tex (Failed)
>28 - tex2lyx/roundtrip/test-insets.tex (Failed)
>29 - tex2lyx/cmplyx/test-insets.tex (Failed)
> Errors while running CTest

I was hoping to get some diffs or elaborations on what exactly fails.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Same commands for different unicodes?

2022-02-27 Thread Jürgen Spitzmüller
Am Sonntag, dem 27.02.2022 um 10:12 +0100 schrieb Kornel Benko:
> That is easy to say.
> OTOH, if F gets the unicode directly, there is no problem. The
> whole issue is to
> convert command names to unicode. F works on unicode only.

I don't understand. If you have respective context information, than
you can decide on the contextual meaning of \textepsilon easily. You
just need to know whether you are in a Greek context or not. If LyX
does not yet provide this information, it can be added easily via
OutputParams.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: tex2lyx tests failing on current master

2022-02-27 Thread Jürgen Spitzmüller
Am Samstag, dem 26.02.2022 um 23:23 -0500 schrieb Scott Kostyshak:
> There are some tex2lyx tests failing on current master.

Can you be a bit more precise?

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Same commands for different unicodes?

2022-02-27 Thread Jürgen Spitzmüller
Am Sonntag, dem 27.02.2022 um 05:05 +0100 schrieb Thibaut Cuvelier:
> I had a new look at this issue. What do you think about adding a new
> flag? It would work exactly like "deprecated", but without the
> implications of having symbols deprecated. I would call this new flag
> "improper", to indicate that the mapping is typical for LaTeX, but
> it's improper use of the Unicode symbol: its use should not really be
> advised in general to use this LaTeX command for that Unicode
> character. 
> That would be the case for 0x204e: this asterisk is supposed to be
> low, but LaTeX always uses a centred asterisk.
> 
> Of course, I could just add a "deprecated" flag to all these symbols
> to trigger the expected behaviour, but it doesn't feel right.
> 
> For now, I have implemented the basic change with a "deprecated"
> flag, with a comment each time to indicate why these mappings are
> indicated as deprecated. This is enough to eliminate all the cases
> you mentioned in your file sent on Feb 20. I'm splitting it into two
> patches, with the second one having potentially more impact than the
> first one (due to my lesser understanding).

I see no reason to state that IPA is less "wanted by users" that Greek.
I also see no reason to flag 0x025b (or tipa's \textepsilon)
"deprecated" or "improper" as it is in no way deprecated and a
perfectly proper command and glyph. Also, it is not as easy as to
assume an ipacommand analogouous to text and math, as \textepsilon
(IPA) works outside the \textipa context as soon as tipa is loaded,
where as \textepsilon (Greek) works inside \textgreek or Greek language
context.

IMHO Advance F needs to get to grips with the fact that there is no
1:1-mapping of command names and semantics in LaTeX and it needs to
consider the context in which a character is being used. Unicodesymbols
already provides the necessary information, no need to flag characters
deviant in addition to that. The latter would lead to the same amount
of false interpretation if the context is not being considered.

Jürgen 



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Purpose of outline's "Table of Contents"?

2022-02-22 Thread Jürgen Spitzmüller
Am Di., 22. Feb. 2022 um 13:00 Uhr schrieb Daniel :

> I am wondering what the purpose of the "Table of Contents" in the
> Outliner is. Is it supposed to show those elements that actually appear
> in the "Table of Contents"? Or all "Sectioning"/"Headings" independently
> of whether they actually appear in the TOC.
>
> Currently, it seems to rather do the latter than the former because it
> also lists "starred" sectioning entries that don't go into the TOC.
>

Yes. Also Frames in beamer and other structural elements. One purpose is to
easily move around parts of the document.


> Maybe a renaming would be worthwhile in order to not confuse the two?
>

I figure the most common term is actually "outline". Or "document
structure".

Jürgen


>
> Daniel
>
>
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Recent commit causes uncodable character

2022-02-22 Thread Jürgen Spitzmüller
Am Di., 22. Feb. 2022 um 10:48 Uhr schrieb Jürgen Spitzmüller :

> Am Di., 22. Feb. 2022 um 04:55 Uhr schrieb Scott Kostyshak <
> skost...@lyx.org>:
>
>> The attached example file used to compile to PDF a couple of days ago.
>>
>
> Bisect says:
> [0dc7f34e00e06e8b378236e32f86023313067b7c] unicodesymbols: parse
> supplementary lines to encode alternative ways to encode symbols in raw
> LaTeX.
>

It's probably rather 3f9e21b82692, for that matter.

Jürgen


>
> Jürgen
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Recent commit causes uncodable character

2022-02-22 Thread Jürgen Spitzmüller
Am Di., 22. Feb. 2022 um 04:55 Uhr schrieb Scott Kostyshak :

> The attached example file used to compile to PDF a couple of days ago.
>

Bisect says:
[0dc7f34e00e06e8b378236e32f86023313067b7c] unicodesymbols: parse
supplementary lines to encode alternative ways to encode symbols in raw
LaTeX.

Jürgen
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Recent commit causes uncodable character

2022-02-22 Thread Jürgen Spitzmüller
Am Di., 22. Feb. 2022 um 10:40 Uhr schrieb Kornel Benko :

> Am Mon, 21 Feb 2022 22:54:55 -0500
> schrieb Scott Kostyshak :
>
> > The attached example file used to compile to PDF a couple of days ago.
> >
> > Scott
>
> Using utf-8 encoding (by setting non-text-fonts) cures it.
> Works also if using
> Document->Settings...->Language->Encoding->Unicode(utf8)
>

Sure, then it's no more a character that need to be recoded.

Jürgen


>
> Kornel
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] Fix language direction switch issue

2022-02-21 Thread Jürgen Spitzmüller
Am Montag, dem 21.02.2022 um 09:16 +0100 schrieb Juergen Spitzmueller:
> commit 0d7d8c37e3962dab0e76dd5b21bfee308e522df2
> Author: Juergen Spitzmueller 
> Date:   Mon Feb 21 09:49:32 2022 +0100
> 
>     Fix language direction switch issue
>     
>     reported at https://marc.info/?l=lyx-users=164538003727435=2

Riki, this should also go to stable.

Jürgen

> ---
>  src/output_latex.cpp |    8 ++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/src/output_latex.cpp b/src/output_latex.cpp
> index f6c7375..03ac2b4 100644
> --- a/src/output_latex.cpp
> +++ b/src/output_latex.cpp
> @@ -933,10 +933,12 @@ void TeXOnePar(Buffer const & buf,
> break;
> }
> }
> +   bool const have_prior_nptpar =
> +   prior_nontitle_par && !prior_nontitle_par-
> >isPassThru();
> Language const * const prev_language =
> runparams_in.for_searchAdv != OutputParams::NoSearch
> ? languages.getLanguage("ignore")
> -   : (prior_nontitle_par && !prior_nontitle_par-
> >isPassThru())
> +   : (have_prior_nptpar)
> ? (use_prev_env_language 
> ? state->prev_env_language_
> : prior_nontitle_par-
> >getParLanguage(bparams))
> @@ -982,7 +984,9 @@ void TeXOnePar(Buffer const & buf,
> use_polyglossia
> && runparams.local_font != nullptr
> && outer_language->rightToLeft()
> -   && !par_language->rightToLeft();
> +   && !par_language->rightToLeft()
> +   && !(have_prior_nptpar
> +    && (prev_language->rightToLeft() !=
> par_language->rightToLeft()));
> bool const localswitch =
> (runparams_in.for_searchAdv !=
> OutputParams::NoSearch
> || text.inset().forceLocalFontSwitch()



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] child documents: allow inheritance of bibliography file list (#4427)

2022-02-20 Thread Jürgen Spitzmüller
Am Sonntag, dem 20.02.2022 um 09:48 -0500 schrieb Scott Kostyshak:
> I was going to say that it seems more simple to just select the
> BibTeX inset in the master document, copy, then paste in the child.

Sure that's an alternative. I implemented this since it was requested.

> But I just tried it and indeed Insert > List/Content/References > ...
> and pushing the button is a bit faster (mainly since I had to scroll
> to the bottom in the master document).

Plus it is easier to update if you changed the master and already have
an inset in the child.

Jürgen.



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] child documents: allow inheritance of bibliography file list (#4427)

2022-02-20 Thread Jürgen Spitzmüller
Am Sonntag, dem 20.02.2022 um 09:42 +0100 schrieb Jürgen Spitzmüller:
> > If so, I wonder if "copy" might be more clear?
> 
> I'm not sure. "Sync" would be another option.

Also note that it's a push button, which (IMO) clearly indicates that
this is an in-situ process (as opposed to a checkbox which would
indicate constant inheritance).

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: [LyX/master] child documents: allow inheritance of bibliography file list (#4427)

2022-02-20 Thread Jürgen Spitzmüller
Am Samstag, dem 19.02.2022 um 14:13 -0500 schrieb Scott Kostyshak:
> Cool, thanks for working on this. I'm confused about how this works.
> Is it a deep copy of the master's BibTeX or a pointer? e.g., if I
> click on "inherit", and then in the master document I change the
> bibliography, do I need to change the child again? 

Yes. It's similar to what we already offer for branches.

> If so, I wonder if "copy" might be more clear?

I'm not sure. "Sync" would be another option.

> Also, after clicking on inherit does the child's BibTeX inset output
> LaTeX when compiling the master?

It's a normal BibTeX inset. So it outputs LaTeX if it's not in a note
or somesuch.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: unicodesymbols: have several commands for a single symbol?

2022-02-20 Thread Jürgen Spitzmüller
Am Sonntag, dem 20.02.2022 um 01:15 +0100 schrieb Thibaut Cuvelier:
> Empty entries were already allowed. 

I know.

> There is no notion of inheritance, though, I'm only adding a way to
> have an alternative way of detecting a symbol. 

I see. I misunderstood, then.

Jürgen


signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: unicodesymbols: have several commands for a single symbol?

2022-02-18 Thread Jürgen Spitzmüller
Am Samstag, dem 19.02.2022 um 02:43 +0100 schrieb Thibaut Cuvelier:
> Does it look alright to you? If so, I will push these patches.

So if an entry has "", this will be set empty, and if it has nothing,
it will inherit the former, right? And until now, only "" was allowed,
no missing table entries? I am just asking if I got it right. If so, it
looks good to me.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: Advanced find does not search in deactivated branches

2022-02-18 Thread Jürgen Spitzmüller
Am Freitag, dem 18.02.2022 um 10:31 +0100 schrieb Kornel Benko:
> Given the string 'ABCD' while 'B' is in deactivated branch.
> Now considering the case searching for the word 'ACD'.
> Should it be found?

Don't know.

But if a deactivated branch (or note) contains one or several
paragraphs, strings there should be found. This seems to be the more
common use case (or at least how I use branches more commonly).

Thus I'd make that optional.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


Re: unicodesymbols: have several commands for a single symbol?

2022-02-13 Thread Jürgen Spitzmüller
Am Montag, dem 14.02.2022 um 03:24 +0100 schrieb Thibaut Cuvelier:
> Thanks, I just did that (with a small test file): a460097823. 
> 
> However, this test showed a limitation in the current unicodesymbols:
> there can be only one LaTeX command per symbol. This is a limitation
> in only a few cases, like  LyX Document
> \textexclamdown and !`: both of them are mapped to ¡ (i.e. ),
> but the file only allows for one mapping.

Yes, this stems from the history of this file, which has been created
first only for the unicode to latex route.

> If we decide to solve this problem, we could have several solutions
> (all modifying Encodings::read), I could think of two:
> - either use a separator symbol in the latexcommand part of each
> unicodesymbols line, but it would be hard to find a single character
> that is never used for latexcommands

yes.

> - or have multiple lines for a single character, with duplicate
> information for the second one or a simpler line format for these
> entries. For instance, for the inverted exclamation mark: 
> 
> 0x00a1 "\\textexclamdown"         "" "force=cp862;cp1255;euc-jp;euc-
> jp-platex;euc-kr;utf8-platex" # INVERTED EXCLAMATION MARK
> 0x00a1 "!`" # Implicitly, all the other parameters still apply

I'd also prefer this. For LaTeX output, the first occurrence should be
preferred.

> What do you think of this? Should this be done? 

I think it's definitely useful.

Jürgen



signature.asc
Description: This is a digitally signed message part
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel


  1   2   3   4   5   6   7   8   9   10   >