Re: Coverity musings

2024-09-19 Thread Jean-Marc Lasgouttes
Le 19/09/2024 à 15:40, Jürgen Spitzmüller a écrit : Am Donnerstag, dem 19.09.2024 um 15:14 +0200 schrieb Jean-Marc Lasgouttes: But why go from a vector<> to a map<>? Frankly: I can't remember. What I have in mind as a simpler alternative is this (like the last patch, wi

Re: Coverity musings

2024-09-19 Thread Jean-Marc Lasgouttes
Le 15/09/2024 à 18:14, Jürgen Spitzmüller a écrit : Am Samstag, dem 14.09.2024 um 20:07 +0200 schrieb Jean-Marc Lasgouttes: Back in history, the structure was not a map but a vecor. It is used to track things like "is there a line below this cell?". I am not sure why  Juergen chang

Re: Coverity musings

2024-09-14 Thread Jean-Marc Lasgouttes
Le 14/09/2024 à 15:40, Pavel Sanda a écrit : Can you explain what that construct works? If I understand correctly we are changing the underlying structure and that does not feel right for "search" procedure. Apart from that if we search extensively the memory will grow as well? First, for the f

Re: Coverity musings

2024-09-14 Thread Jean-Marc Lasgouttes
Le 14/09/2024 à 00:43, Richard Kimberly Heck a écrit : Do you have access to coverity? I think I did, but I do not remember how to access it. The password, etc, is probably saved in Firefox, if you just send me the URL. Have a look here. https://scan.coverity.com/projects/4164 You do have a

Re: [LyX/master] use std::move() instead of copying when value is no longer used

2024-09-14 Thread Jean-Marc Lasgouttes
Thanks. I would have done it otherwise. A good time to recall that "premature optimization is the root of all evil." JMarc Le 14 septembre 2024 11:01:03 GMT+02:00, "Jürgen Spitzmüller" a écrit : >Am Dienstag, dem 10.09.2024 um 15:21 +0200 schrieb Jean-Marc >Lasgou

Re: Coverity musings

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 20:44, Richard Kimberly Heck a écrit : * Places where I understand the issue, but fixing requires some work and is a bit scary. Example in the patch below: Jürgen, could you please have a look and tell me why we should not do that? It is too simple, I fear I am missing something

Coverity musings

2024-09-13 Thread Jean-Marc Lasgouttes
am not sure of a proper fix. * Places where I do not even understand what the issue is :( Have a nice weekend. JMarcFrom 213d8088bcbcae78ad735bb46bc8b1fb93e75bca Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Fri, 13 Sep 2024 17:10:58 +0200 Subject: [PATCH] Streamline use of map Typ

Re: [LyX/master] Do not use rand() to set a BranchList id

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 11:37, Pavel Sanda a écrit : On Fri, Sep 13, 2024 at 11:14:13AM +0200, Jean-Marc Lasgouttes wrote: Le 13/09/2024 ?? 11:11, Jean-Marc Lasgouttes a écrit : commit 9f40eaee15d53ce418a728d3ff3716541d35775f Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:07:05 2024 +0200

Re: [LyX/master] Do not use rand() to set a BranchList id

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 11:11, Jean-Marc Lasgouttes a écrit : commit 9f40eaee15d53ce418a728d3ff3716541d35775f Author: Jean-Marc Lasgouttes Date: Fri Sep 13 11:07:05 2024 +0200 Do not use rand() to set a BranchList id Use a simple counting instead, beecause Coverity complains that

Re: Registration

2024-09-13 Thread Jean-Marc Lasgouttes
Le 13/09/2024 à 10:50, Pavel Sanda a écrit : On Fri, Sep 13, 2024 at 10:44:55AM +0200, Pavel Sanda wrote: On Thu, Sep 12, 2024 at 11:32:55AM +0200, Daniel wrote: Are there any alternatives in the pipe? Not really, but I can improve the description to be more straightforward. Just did that.

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-11 Thread Jean-Marc Lasgouttes
Le 9 septembre 2024 19:01:09 GMT+02:00, "José Matos" a écrit : >On Mon, 2024-09-09 at 17:54 +0200, Jean-Marc Lasgouttes wrote: >> string const arg = (type.empty()) ? move(label) : move(label) + " " >> + type; > >I can understand the first move. Tha

Re: [LyX/master] use std::move() instead of copying when value is no longer used

2024-09-11 Thread Jean-Marc Lasgouttes
Le 07/09/2024 à 13:42, Jürgen Spitzmüller a écrit : Am Samstag, dem 07.09.2024 um 13:22 +0200 schrieb Jean-Marc Lasgouttes: I have been resisting to making these changes because someone may change the code and use the variable afterwards. But I may be wrong after all. I am not sure at all. I

Re: [LyX/master] use std::move() instead of copying when value is no longer used

2024-09-10 Thread Jean-Marc Lasgouttes
Le 10/09/2024 à 15:01, Pavel Sanda a écrit : I find that std::move construct make the readbility worse for me. Not seeing it on the left side of the assignment makes it easy to overlook that the variable might be actually empty after move and use it in the subsequent code later. Unless we are op

Re: [LyX/master] Initialize client's name in main()

2024-09-10 Thread Jean-Marc Lasgouttes
Le 10/09/2024 à 00:04, Richard Kimberly Heck a écrit : On 9/9/24 11:58 AM, Jean-Marc Lasgouttes wrote: Le 09/09/2024 à 15:33, Jean-Marc Lasgouttes a écrit : commit 3d323412ad5b4d47774de43f985202f20cabd156 Author: Jean-Marc Lasgouttes Date:   Mon Sep 9 15:29:39 2024 +0200 Initialize

Re: [LyX/master] Do not forget to reset stream after std::hex

2024-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2024 à 17:51, Jean-Marc Lasgouttes a écrit : commit f4c02d670b60a56bc6fb4a49e201c7134af1011b Author: Jean-Marc Lasgouttes Date: Mon Sep 9 17:49:20 2024 +0200 Do not forget to reset stream after std::hex Riki, this is in stable to. OK to backport? JMarc Spotted by

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2024 à 17:35, Scott Kostyshak a écrit : I see, good to know! Thanks to you and JMarc for taking on that seemingly never-ending task. The good thing is that we caught a few real bugs. It is not always coverity being annoying. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org h

Re: [LyX/master] Do not handle special case where buffer == NULL

2024-09-09 Thread Jean-Marc Lasgouttes
Le 09/09/2024 à 16:47, Jürgen Spitzmüller a écrit : Am Montag, dem 09.09.2024 um 16:31 +0200 schrieb Scott Kostyshak: Just out of curiosity (no I don't want to receive the scan results ;)), are most of these from Coverity adding new features that detect new things? Or were they there before, and

Re: label whitespaces no more

2024-09-08 Thread Jean-Marc Lasgouttes
Le 08/09/2024 à 19:09, Jürgen Spitzmüller a écrit : Am Sonntag, dem 08.09.2024 um 12:18 -0400 schrieb Richard Kimberly Heck: That was my thought, as well. Simple and effective. Good, I committed to master. Note that if you cherry-pick, you both need both bfd855747ab (the indentation fix) and 0

Re: [LyX/master] use std::move() instead of copying when value is no longer used

2024-09-07 Thread Jean-Marc Lasgouttes
Le 07/09/2024 à 12:52, Juergen Spitzmueller a écrit : commit e685d31f5aadadd9c84c80a604818d49f5853dbf Author: Juergen Spitzmueller Date: Sat Sep 7 12:50:27 2024 +0200 use std::move() instead of copying when value is no longer used This is mainly to shut down coverity which now

Re: [LyX/master] Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor()

2024-09-06 Thread Jean-Marc Lasgouttes
Le 06/09/2024 à 14:56, Jean-Marc Lasgouttes a écrit : commit 6c20e5db7db662239e8c2bd47fe28d18b27bd729 Author: Jean-Marc Lasgouttes Date: Thu Sep 5 22:05:38 2024 +0200 Add ScrollType BOTTOM and TOGGLE for BufferView::scrollToCursor() BOTTOM shows the paragraph containing the

Re: program listing crash

2024-08-31 Thread Jean-Marc Lasgouttes
Le 30/08/2024 à 19:48, Richard Kimberly Heck a écrit : Riki, this is obviously needed in stable too. In this setting, there is a separate issue that selection drawing fails. All in all, I propose to push the two patches below. OK. It is in, thanks. JMarc -- lyx-devel mailing list lyx-devel@

Re: [LyX/master] Do not run updateMacros if the buffer has not changed

2024-08-30 Thread Jean-Marc Lasgouttes
Le 30/08/2024 à 17:40, Scott Kostyshak a écrit : Great, thanks! Although from what I understand it has zero effect ;). Indeed. Even if we were to use all possible integers too soon, nothing bad would happen :) JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mai

Re: program listing crash

2024-08-30 Thread Jean-Marc Lasgouttes
46e697288d Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Fri, 30 Aug 2024 16:56:16 +0200 Subject: [PATCH 1/2] Fix update of cursor in tab-delete when there is a selection The position of the cursor should not be decreased if it is already at the start of the paragraph. This can lead

Re: [LyX/master] Do not run updateMacros if the buffer has not changed

2024-08-30 Thread Jean-Marc Lasgouttes
Le 30/08/2024 à 14:27, Scott Kostyshak a écrit : I have a question only out of curiosity (it doesn't have any practical consequence): Also, is id_ ever updated by just 1 in updateId()? When I put debug code to print id_, when I type I see: id_: 0 id_: 2 id_: 4 You are right, of course. I kn

Re: [for enrico] Question: do we still need that?

2024-08-29 Thread Jean-Marc Lasgouttes
Le 29/08/2024 à 13:51, Enrico Forestieri a écrit : What I did not do is remove the hand-made parsing of geometry that is used for window-new lfun only on Windows (why?). Can this go away? That code was necessary for Qt4, where -qwindowgeometry was not available. It was necessary on Windows bec

Re: [for enrico] Question: do we still need that?

2024-08-29 Thread Jean-Marc Lasgouttes
HAVE_XCB_XCB_H HAVE_LIXCB if they are available.From f2efed661bde9e03baf8269ee1f302c7489a162e Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Thu, 29 Aug 2024 11:10:31 +0200 Subject: [PATCH 1/2] Streamline -geometry argument support --- src/LyX.cpp | 23

Re: [for enrico] Question: do we still need that?

2024-08-28 Thread Jean-Marc Lasgouttes
Le 28/08/2024 à 15:54, Jean-Marc Lasgouttes a écrit : In createAppplication, we have: #if !defined(QPA_XCB) // prune -geometry argument(s) by shifting // the following ones 2 places down. for (int i = 0 ; i < argc ; ++i) {     if (strcmp(argv[i], "-geometr

[for enrico] Question: do we still need that?

2024-08-28 Thread Jean-Marc Lasgouttes
In createAppplication, we have: #if !defined(QPA_XCB) // prune -geometry argument(s) by shifting // the following ones 2 places down. for (int i = 0 ; i < argc ; ++i) { if (strcmp(argv[i], "-geometry") == 0) { int const remove = (i+1

Re: Regression in 2.4 - external rewrite causes buffer to be marked as modified

2024-08-19 Thread Jean-Marc Lasgouttes
Hi, I do not remember such a deliberate changel, but I may have missed it (or we'll find out that I did it on purpose and forgot about it 😁). JMarc Le 19 août 2024 11:04:16 GMT+02:00, Pavel Sanda a écrit : >Hi, > >can't remember whether this was intention but I find the new behaviour very >u

Re: [LyX/master] Implement Paragraph::getLabel()

2024-07-29 Thread Jean-Marc Lasgouttes
Le 29 juillet 2024 09:02:49 GMT+02:00, "Jürgen Spitzmüller" a écrit : >Am Montag, dem 29.07.2024 um 08:29 +0200 schrieb Jürgen Spitzmüller: >> Am Sonntag, dem 28.07.2024 um 19:39 +0200 schrieb Jean-Marc >> Lasgouttes: >> > Usually, when we use getLabel,

Re: [LyX/master] Implement Paragraph::getLabel()

2024-07-28 Thread Jean-Marc Lasgouttes
Le 28 juillet 2024 16:00:56 GMT+02:00, Juergen Spitzmueller a écrit : >commit a303600b544d9f4c82f2dee77616f821d0051854 >Author: Juergen Spitzmueller >Date: Sun Jul 28 15:52:19 2024 +0200 > >Implement Paragraph::getLabel() > >This function returns the first label (as string) if th

Re: [RFC] Make scrolling-by-selection smoother

2024-07-26 Thread Jean-Marc Lasgouttes
But is it faster when the mouse is below the window, then? JMarc Le 25 juillet 2024 21:14:36 GMT+02:00, Scott Kostyshak a écrit : >On Thu, Jul 25, 2024 at 08:48:49PM GMT, Jean-Marc Lasgouttes wrote: >> You are in full screen, right ? > >No, but by default I don't have

Re: [RFC] Make scrolling-by-selection smoother

2024-07-25 Thread Jean-Marc Lasgouttes
You are in full screen, right ? JMarc Le 25 juillet 2024 20:00:15 GMT+02:00, Scott Kostyshak a écrit : >On Thu, Jul 25, 2024 at 06:45:58PM GMT, Jean-Marc Lasgouttes wrote: >> >> > To me it seems that scrolling down (if I hold and drag the mouse) is >> > much slowe

Re: [RFC] Make scrolling-by-selection smoother

2024-07-25 Thread Jean-Marc Lasgouttes
Le 25/07/2024 à 18:42, Scott Kostyshak a écrit : On Mon, Jul 22, 2024 at 10:00:46PM GMT, Jean-Marc Lasgouttes wrote: Le 22/07/2024 à 21:49, Pavel Sanda a écrit : On Sat, Jul 20, 2024 at 09:22:02PM +0200, Jean-Marc Lasgouttes wrote: So, especially if you have a slow-ish computer, please test

Re: [LyX/master] mode convertLaTeXCommands from BiblioInfo to Encodings

2024-07-25 Thread Jean-Marc Lasgouttes
Le 25/07/2024 à 15:20, Jürgen Spitzmüller a écrit : Am Donnerstag, dem 25.07.2024 um 11:30 +0200 schrieb Jean-Marc Lasgouttes: Did I already say today that I hate updateMacros and have no idea of what it does ? Just wanted to mention that this seems to cure it: Smart man. Of course, it

Re: [LyX/master] mode convertLaTeXCommands from BiblioInfo to Encodings

2024-07-25 Thread Jean-Marc Lasgouttes
isect. JMarc Bisect points me to: commit 999fb37ebb1aecfda9889fa6a2b2fbb15133f2aa Author: Jean-Marc Lasgouttes Date: Sat Jul 20 22:31:34 2024 +0200 Do not run updateMacros if the buffer has not changed Each buffer now has an id which is increased when it is marked dirty

Re: [LyX/master] Do not run updateMacros if the buffer has not changed

2024-07-24 Thread Jean-Marc Lasgouttes
Le 25/07/2024 à 00:43, Richard Kimberly Heck a écrit : On 7/24/24 12:36 PM, Jean-Marc Lasgouttes wrote: Le 24/07/2024 à 18:31, Jean-Marc Lasgouttes a écrit : commit 999fb37ebb1aecfda9889fa6a2b2fbb15133f2aa Author: Jean-Marc Lasgouttes Date:   Sat Jul 20 22:31:34 2024 +0200 Do not run

Re: [PATCH] WIP: rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 22:48, Pavel Sanda a écrit : I have difficulty to see any visible difference when it comes to the cursor speed in UG after your last patch (detecting changes in buffer before calling updatemacros), i.e. the difference seems to be within rounding error. The updateMacros probably i

Re: [PATCH] WIP: rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 01:57, Pavel Sanda a écrit : On top of that this speed up was good enough that I do not see visually noticeable hiccups while moving with the cursor in User Guide anymore - but that's also due to the fact that cursor moving is still somewhat slow on fast repeat rates compared to o

Re: [PATCH] WIP: rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 19:28, Scott Kostyshak a écrit : /home/scott/lyxbuilds/master-master/repo/src/insets/InsetTabular.h:1120:7: error: 'updateStatistics' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] void updateStatistics(Statistics & st

Re: [LyX/master] Do not run updateMacros if the buffer has not changed

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 18:31, Jean-Marc Lasgouttes a écrit : commit 999fb37ebb1aecfda9889fa6a2b2fbb15133f2aa Author: Jean-Marc Lasgouttes Date: Sat Jul 20 22:31:34 2024 +0200 Do not run updateMacros if the buffer has not changed Each buffer now has an id which is increased when it

Re: [LyX/master] Fixup 216a6fb348: close when quitting text mode

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 17:46, Richard Kimberly Heck a écrit : Riki, this is candidate for branch. Any and all fixes for this are fine. Thanks, everything is in now. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Fixup 216a6fb3: fix broken xml syntax

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 17:45, Richard Kimberly Heck a écrit : On 7/23/24 5:49 PM, Jean-Marc Lasgouttes wrote: Le 23/07/2024 à 19:52, Jean-Marc Lasgouttes a écrit : commit a268fe096a58a7818554a7da4da85896bb289c81 Author: Jean-Marc Lasgouttes Date:   Tue Jul 23 15:04:49 2024 +0200 Fixup 216a6fb3

Re: [PATCH] WIP: rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 09:43, Jean-Marc Lasgouttes a écrit : All in all this patch is nice piece of work! :) Thanks. It needs some cleanup, so I will push it later. I found the time, the code is now in. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo

Re: [PATCH] WIP: rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 12:30, Jean-Marc Lasgouttes a écrit : Le 24/07/2024 à 09:55, Pavel Sanda a écrit : On Wed, Jul 24, 2024 at 09:43:43AM +0200, Jean-Marc Lasgouttes wrote: Good, that was the point. The code I proposed to avoid running updateMacros on an unchanged document can be used here too

Re: LyX user file in linux

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 15:36, Jürgen Spitzmüller a écrit : Am Mittwoch, dem 24.07.2024 um 10:40 +0100 schrieb José Matos: What do you think? Any idea about this? Since I do access it often, I am personally not too fond of having it hidden deeper down the hierarchy. I also think some external program

Re: [PATCH] WIP: rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24/07/2024 à 09:55, Pavel Sanda a écrit : On Wed, Jul 24, 2024 at 09:43:43AM +0200, Jean-Marc Lasgouttes wrote: Good, that was the point. The code I proposed to avoid running updateMacros on an unchanged document can be used here too. Are updateMacros called for each caret movement in the

Re: [PATCH] WIP: rewrite statistics code

2024-07-24 Thread Jean-Marc Lasgouttes
Le 24 juillet 2024 01:57:01 GMT+02:00, Pavel Sanda a écrit : >I tested and do not see any counting difference in my selected document and >confirm that profiling gives about 3x better time with your patch. Thanks for testing. To be frank, I have been disappointed at first to have "only" a 3x s

Re: [LyX/master] Do not export the content of InsetMathBoxed as text in MathML

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 23:48, Jean-Marc Lasgouttes a écrit : commit 1186d90edf9a6702573f296d5642c5e61ceaaedf Author: Jean-Marc Lasgouttes Date: Tue Jul 23 23:44:58 2024 +0200 Do not export the content of InsetMathBoxed as text in MathML \boxed{} is the only box in LaTeX that

Re: [LyX/master] Fixup 216a6fb348: close when quitting text mode

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 22:11, Jean-Marc Lasgouttes a écrit : commit 1385f0fddd0229770496b1e50b76782892032d18 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 22:02:50 2024 +0200 Fixup 216a6fb348: close when quitting text mode This fixes malformed documents on UserGuide export

Re: [LyX/master] Fixup 216a6fb3: fix broken xml syntax

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 19:52, Jean-Marc Lasgouttes a écrit : commit a268fe096a58a7818554a7da4da85896bb289c81 Author: Jean-Marc Lasgouttes Date: Tue Jul 23 15:04:49 2024 +0200 Fixup 216a6fb3: fix broken xml syntax This commit addresses two issues: 1/ the embarassing one

Re: Many xhtml/docbook tests now failing on master

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 22:22, Scott Kostyshak a écrit : On Tue, Jul 23, 2024 at 04:14:28PM GMT, Scott Kostyshak wrote: On Tue, Jul 23, 2024 at 10:12:32PM GMT, Jean-Marc Lasgouttes wrote: Le 23/07/2024 à 21:11, Scott Kostyshak a écrit : I believe this one is very recent: export/doc

Re: Many xhtml/docbook tests now failing on master

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 21:11, Scott Kostyshak a écrit : I believe this one is very recent: export/doc/UserGuide_xhtml This corresponds to the English user guide. This one was easy. Do you have another one for me? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailma

Re: Many xhtml/docbook tests now failing on master

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 21:11, Kornel Benko a écrit : Am Tue, 23 Jul 2024 20:47:03 +0200 schrieb Jean-Marc Lasgouttes : Le 23/07/2024 à 20:23, Kornel Benko a écrit : From the 132 previously failed tests now are only 54 test failing. Some of the first are: 59% tests passed, 54 tests failed out of

Re: Many xhtml/docbook tests now failing on master

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 20:53, Scott Kostyshak a écrit : I have 60 xhtml tests failing on current master now. Some are timing out so that might be a good place to start. For example, the following export times out for me after 10 minutes: cd lib/examples/Curricula_Vitae && lyx -e xhtml Modern_CV.lyx T

Re: Many xhtml/docbook tests now failing on master

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 20:23, Kornel Benko a écrit : From the 132 previously failed tests now are only 54 test failing. Some of the first are: 59% tests passed, 54 tests failed out of 132 The following tests FAILED: 300 - export/export/docbook/basic_xhtml (Failed) 306 - export/export/do

Re: Many xhtml/docbook tests now failing on master

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 19:24, Kornel Benko a écrit : Even with newest commits I get 71% tests passed, 132 tests failed out of 449 from # ctest -R .xhtml Kornel Hopefully most of the issues are gone now. The biggest and stupidest problem was that a backup variable was a bool instead o

Re: Many xhtml/docbook tests now failing on master

2024-07-23 Thread Jean-Marc Lasgouttes
Le 23/07/2024 à 19:24, Kornel Benko a écrit : Am Mon, 22 Jul 2024 16:47:14 -0400 schrieb Scott Kostyshak : I don't have time to look into them but a whole bunch of xhtml and docbook tests started failing recently on master. Kornel can you reproduce? Scott Even with newest commits I get 71% t

Re: Many xhtml/docbook tests now failing on master

2024-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2024 à 23:58, Scott Kostyshak a écrit : On Mon, Jul 22, 2024 at 11:27:46PM GMT, Jean-Marc Lasgouttes wrote: Le 22/07/2024 à 22:47, Scott Kostyshak a écrit : I don't have time to look into them but a whole bunch of xhtml and docbook tests started failing recently on master. Korne

Re: [LyX/2.4.x] Cleanup MathMLStream

2024-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2024 à 22:40, Enrico Forestieri a écrit : diff --git a/src/mathed/InsetMathChar.cpp b/src/mathed/InsetMathChar.cpp index 199982a5f7..82d0b63f1e 100644 --- a/src/mathed/InsetMathChar.cpp +++ b/src/mathed/InsetMathChar.cpp @@ -248,7 +248,7 @@ void InsetMathChar::mathmlize(MathMLStream & ms

Re: [LyX/2.4.x] Cleanup MathMLStream

2024-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2024 à 22:40, Enrico Forestieri a écrit : I don't understand the need for the two changes above. Note that on systems where sizeof(wchar_t) == 2, lyx::char_type is defined as a 32- bit value. So, with the above changes, char_ will be output as a number rather than a character. What a

Re: Many xhtml/docbook tests now failing on master

2024-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2024 à 22:47, Scott Kostyshak a écrit : I don't have time to look into them but a whole bunch of xhtml and docbook tests started failing recently on master. Kornel can you reproduce? I would be grateful to have individual examples. I guess the point made by Enrico is one of those issu

Re: [RFC] Make scrolling-by-selection smoother

2024-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2024 à 21:49, Pavel Sanda a écrit : On Sat, Jul 20, 2024 at 09:22:02PM +0200, Jean-Marc Lasgouttes wrote: So, especially if you have a slow-ish computer, please test. I tested on two archaic laptops and do not see any visible difference in speed. But the version with your patch is

Re: [PATCH] use yellow background for math comments

2024-07-21 Thread Jean-Marc Lasgouttes
Le 21/07/2024 à 09:49, José Matos a écrit : Actually it was more (for me a least) import that you applied one of the changes. Personally I prefer your first option but even the second option would be better than not to do nothing. I suppose that we can improve our communication skills and avoid

[PATCH] WIP: rewrite statistics code

2024-07-21 Thread Jean-Marc Lasgouttes
rom: Jean-Marc Lasgouttes Date: Sun, 21 Jul 2024 22:09:28 +0200 Subject: [PATCH] WIP: rewrite statistics code The statistics code is known to be very slow, because it relies on DocIterator to go through the buffer. This commit introduces a new Statitistics class that encapsulates the main code, al

Get rid of INSTALL.MacOSX?

2024-07-20 Thread Jean-Marc Lasgouttes
The last remaining bit of TODO.killqt4 is INSTALL.MacOSX. I thought we wanted to update it, but I fail to see what should be kept in this file as it is. Stephan, do we have a reason to keep it? Later, you could create a new INSTALL.macOS with up-to-date information if you feel that the file i

Re: [LyX/master] Fixup 2bdd691130: remove two more Update::SinglePar instances

2024-07-20 Thread Jean-Marc Lasgouttes
Le 20/07/2024 à 21:22, Richard Kimberly Heck a écrit : On 7/20/24 11:16 AM, Jean-Marc Lasgouttes wrote: Le 20/07/2024 à 17:13, Jean-Marc Lasgouttes a écrit : commit 485f5afc21ba553fd16465231de7570b0c631298 Author: Jean-Marc Lasgouttes Date:   Sat Jul 20 17:12:09 2024 +0200 Fixup

Re: [PATCH] use yellow background for math comments

2024-07-20 Thread Jean-Marc Lasgouttes
Le 19/06/2024 à 16:23, Jean-Marc Lasgouttes a écrit : I can't find the place where math comments appearance was discussed recently, so here is is. This trivial patch uses a yellow (Note) background to mark comments. While the result is not the same as Notes (the output actually goes to

Re: [RFC] Make scrolling-by-selection smoother

2024-07-20 Thread Jean-Marc Lasgouttes
Le 20/07/2024 à 21:23, Richard Kimberly Heck a écrit : On 7/20/24 3:22 PM, Jean-Marc Lasgouttes wrote: PS: the profiler tells me that more than 10% of this time is lost updating macros over and over. I'll take a look at that. That is at the root of a lot of the performance issues we

[RFC] Make scrolling-by-selection smoother

2024-07-20 Thread Jean-Marc Lasgouttes
I am not sure how. So, especially if you have a slow-ish computer, please test. JMarc PS: the profiler tells me that more than 10% of this time is lost updating macros over and over. I'll take a look at that.From 9da312f269b2ab3060d1b4231a82dc36787fd45a Mon Sep 17 00:00:00 2001 From: Jean

Re: [LyX/master] Fixup 2bdd691130: remove two more Update::SinglePar instances

2024-07-20 Thread Jean-Marc Lasgouttes
Le 20/07/2024 à 17:13, Jean-Marc Lasgouttes a écrit : commit 485f5afc21ba553fd16465231de7570b0c631298 Author: Jean-Marc Lasgouttes Date: Sat Jul 20 17:12:09 2024 +0200 Fixup 2bdd691130: remove two more Update::SinglePar instances They do not do what the author(s) of these

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-18 Thread Jean-Marc Lasgouttes
Le 16/07/2024 à 17:26, Richard Kimberly Heck a écrit : On 7/16/24 9:48 AM, Jean-Marc Lasgouttes wrote: Le 15/07/2024 à 18:14, Scott Kostyshak a écrit : I cannot reproduce, but the following patch makes sense. Does it work? Yes it fixes the behavior both with and without change tracking

Re: LyX 2.4.1 Released

2024-07-18 Thread Jean-Marc Lasgouttes
Le 18/07/2024 à 04:45, Richard Kimberly Heck a écrit : This line is present in master as well, but is actually coming from completely different changeset (1d1f95d2ed0b, JMarc, Reduce metrics updates from 4 to 1 when loading file) which is not part of 2.4. So it seems that it got accidentally i

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-16 Thread Jean-Marc Lasgouttes
it was kind of stable now. Riki, this is obviously candidate for branch. JMarc commit 82f387dabc2b18de6a9917192f4304e92bff8bc1 Author: Jean-Marc Lasgouttes Date: Tue Jul 16 15:43:11 2024 +0200 Fix faulty undo recording The recordUndo() call is very wrong, since we may be inserting

Re: Compilation warning

2024-07-15 Thread Jean-Marc Lasgouttes
Le 12/07/2024 à 21:25, Richard Kimberly Heck a écrit : On 7/12/24 11:13 AM, Jean-Marc Lasgouttes wrote: Le 12/07/2024 à 17:02, Jürgen Spitzmüller a écrit : Am Freitag, dem 12.07.2024 um 16:18 +0200 schrieb Jean-Marc Lasgouttes: It is the fault of autoconf 2.72, actually. Try the patch below

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-15 Thread Jean-Marc Lasgouttes
Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : To reproduce: 1. Fresh build on current master. 2. Open User Guide. 3. Make sure that editing is enabled, and turn off change tracking. 4. Scroll to the end. 5. Select multiple bib items. 6. Click on the yellow note. 7. Do Undo with ctrl + z. I g

Re: Compilation warning

2024-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2024 à 17:02, Jürgen Spitzmüller a écrit : Am Freitag, dem 12.07.2024 um 16:18 +0200 schrieb Jean-Marc Lasgouttes: It is the fault of autoconf 2.72, actually. Try the patch below. Thanks, this works! Very good. It is in master now. Riki, this is candidate for branch. A workaround

Re: Compilation warning

2024-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2024 à 15:56, Jean-Marc Lasgouttes a écrit : Le 12/07/2024 à 15:47, Jürgen Spitzmüller a écrit : Am Freitag, dem 12.07.2024 um 15:28 +0200 schrieb Jean-Marc Lasgouttes: Do you see a mention of grep and egrep in the configure output? yes: checking for grep that handles long lines

Re: Compilation warning

2024-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2024 à 15:47, Jürgen Spitzmüller a écrit : Am Freitag, dem 12.07.2024 um 15:28 +0200 schrieb Jean-Marc Lasgouttes: Do you see a mention of grep and egrep in the configure output? yes: checking for grep that handles long lines and -e... /usr/bin/grep I get nothing like the above

Re: Compilation warning

2024-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2024 à 14:16, Jürgen Spitzmüller a écrit : Am Freitag, dem 12.07.2024 um 11:31 +0200 schrieb Pavel Sanda: Can you share the exact autogen/configure sequence and params so I can try to reproduce your workflow? ./autogen.sh ./configure --enable-build-type=rel The issue shows up in the

Re: LyX 2.4.0 and 2.4.1

2024-07-12 Thread Jean-Marc Lasgouttes
Le 12/07/2024 à 03:54, John O'Gorman a écrit : Hi I have recently installed 2.4.0 and then upgraded to 2.4.1 on 2 machines: an imac and an OpenSuSE tumbleweed. The Mac and Linux implementations differ. On the Mac the top left icon gives the About LyX output. On the Linux you instead go to t

Re: Request to backport some screen-update code

2024-07-10 Thread Jean-Marc Lasgouttes
Le 10/07/2024 à 17:17, Richard Kimberly Heck a écrit : Riki, would that be OK? Yes. Should get plenty of testing before release. Thanks, I did that. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] Fix display of page references when language is not specified

2024-07-10 Thread Jean-Marc Lasgouttes
Le 05/07/2024 à 18:12, Richard Kimberly Heck a écrit : On 7/5/24 10:25 AM, Jean-Marc Lasgouttes wrote: Le 05/07/2024 à 16:18, Jean-Marc Lasgouttes a écrit : commit 6f6d9b631d110fb71fcd99351b4f40d58451700a Author: Jean-Marc Lasgouttes Date:   Fri Jul 5 16:10:17 2024 +0200 Fix display of

Request to backport some screen-update code

2024-07-10 Thread Jean-Marc Lasgouttes
are now just below the anchor paragraph. pit_type pit2 = anchor_pit + 1; + pit_type const npit = pit_type(text_->paragraphs().size()); for (; pit2 < npit && y2 < bv_height; ++pit2) { if (!contains(pit2)) redoParagraph(pit2); -- 2.34.1 From 6f61b0b4318e435838a29ecdd6775d8ffbb9400a Mon Sep 17

Re: Exception ignored in: _io.TextIOWrapper

2024-07-05 Thread Jean-Marc Lasgouttes
Le 05/07/2024 à 18:46, Scott Kostyshak a écrit : On Fri, Jul 05, 2024 at 05:33:39PM GMT, José Matos wrote: On Fri, 2024-07-05 at 16:27 +0200, Jean-Marc Lasgouttes wrote: Can InsetInfo run an occasional pref2pref? Possible but unlikely. As far as I remember all layout files are updated and

Re: Exception ignored in: _io.TextIOWrapper

2024-07-05 Thread Jean-Marc Lasgouttes
Le 05/07/2024 à 15:59, José Matos a écrit : On Fri, 2024-07-05 at 14:33 +0200, Jean-Marc Lasgouttes wrote: While scrolling text in stable (preview if off), I get messages like: Exception ignored in: <_io.TextIOWrapper name='' mode='w' encoding='utf-8'> José

Re: [LyX/master] Fix display of page references when language is not specified

2024-07-05 Thread Jean-Marc Lasgouttes
Le 05/07/2024 à 16:18, Jean-Marc Lasgouttes a écrit : commit 6f6d9b631d110fb71fcd99351b4f40d58451700a Author: Jean-Marc Lasgouttes Date: Fri Jul 5 16:10:17 2024 +0200 Fix display of page references when language is not specified Riki, this is candidate for branch. A pretty minor issue

Exception ignored in: _io.TextIOWrapper

2024-07-05 Thread Jean-Marc Lasgouttes
While scrolling text in stable (preview if off), I get messages like: Exception ignored in: <_io.TextIOWrapper name='' mode='w' encoding='utf-8'> José, this looks like python stuff, over to you :) JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx

Re: 2.4.1

2024-07-05 Thread Jean-Marc Lasgouttes
Le 05/07/2024 à 14:10, Jürgen Spitzmüller a écrit : Am Donnerstag, dem 04.07.2024 um 17:12 +0200 schrieb Jean-Marc Lasgouttes: From what I understand, it exhausts the memory of the computer by allocating memory somewhere in the regex machinery (see the backtrace in the report). So the problem

Re: 2.4.1

2024-07-04 Thread Jean-Marc Lasgouttes
Le 04/07/2024 à 16:42, Jürgen Spitzmüller a écrit : I think the problem is that we call getAuthors() for one and the same reference way too often by calling BibTeXInfo::getAuthorList() from diverse places (which is at least in parts also my fault, see BibTeXInfo::getValueForKey()). Every time we

Re: Out of sync information between Help->About LyX->{Version, Build Info}

2024-07-04 Thread Jean-Marc Lasgouttes
Le 04/07/2024 à 14:01, José Matos a écrit : On Thu, 2024-07-04 at 13:47 +0200, Pavel Sanda wrote: I would be concerned if running ./configure does not fix the Qt version. Does it fix it in your case? Pavel Yes, it works. Since you do an out source dir build I always need to extract the previ

Re: Out of sync information between Help->About LyX->{Version, Build Info}

2024-07-04 Thread Jean-Marc Lasgouttes
Le 04/07/2024 à 13:47, Pavel Sanda a écrit : On Thu, Jul 04, 2024 at 12:29:13PM +0100, José Matos wrote: There is some mechanism in action because all C++ files were recompiled when the Qt version changed. I would be concerned if running ./configure does not fix the Qt version. Does it fix it

Re: Out of sync information between Help->About LyX->{Version, Build Info}

2024-07-04 Thread Jean-Marc Lasgouttes
Le 04/07/2024 à 11:47, José Matos a écrit : The Qt version is an old one, most likely the one used last time that configure ran. Indeed. Not sure what to do about it. But the Qt version at configure time may matter, if we did tricks according to it. JMarc -- lyx-devel mailing list lyx-devel

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-03 Thread Jean-Marc Lasgouttes
Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : To reproduce: 1. Fresh build on current master. 2. Open User Guide. 3. Make sure that editing is enabled, and turn off change tracking. 4. Scroll to the end. 5. Select multiple bib items. 6. Click on the yellow note. 7. Do Undo with ctrl + z. I g

Re: 2.4.1

2024-07-03 Thread Jean-Marc Lasgouttes
Le 24/06/2024 à 22:26, Richard Kimberly Heck a écrit : On 6/24/24 1:20 PM, Jean-Marc Lasgouttes wrote: Le 09/06/2024 à 19:18, Richard Kimberly Heck a écrit : We do not seem to have had any panicked reports of crashes. Yea! So I propose to merge 2.4.1-devel into 2.4.x and plan to release 2.4.1

Re: Assertion when selecting large table in User Guide on master

2024-07-03 Thread Jean-Marc Lasgouttes
Le 03/07/2024 à 19:34, Scott Kostyshak a écrit : On Wed, Jul 03, 2024 at 05:48:23PM GMT, Jean-Marc Lasgouttes wrote: Le 03/07/2024 à 06:17, Scott Kostyshak a écrit : I still get an assertion while selecting the phone table. Hmm, I was two quick in my testing. I just pushed two patches which

Re: Assertion when selecting large table in User Guide on master

2024-07-03 Thread Jean-Marc Lasgouttes
Le 03/07/2024 à 06:17, Scott Kostyshak a écrit : I still get an assertion while selecting the phone table. Hmm, I was two quick in my testing. I just pushed two patches which: 1/ avoids setting Update::SinglePar in a place where this does not make sense 2/ make BufferView::singleParUpdate rob

Re: Assertion when selecting large table in User Guide on master

2024-07-02 Thread Jean-Marc Lasgouttes
Le 02/07/2024 à 05:27, Scott Kostyshak a écrit : I no longer get the assertion in that place. But if I work a bit harder and drag the selection up and down, eventually I get an assertion. Backtrace attached (this was while testing the patch). OK, I just pushed a different solution: instead of b

Re: Assertion when selecting large table in User Guide on master

2024-07-02 Thread Jean-Marc Lasgouttes
Le 02/07/2024 à 17:44, Scott Kostyshak a écrit : Oops, sorry about that. Backtrace now attached. The way I reproduce is just drag selection with my mouse up and down, up and down in the User Guide. It usually just takes a few seconds. I can reproduce too. The goodpart is that the assertion abo

Re: change in behavior of cursor movement in math array

2024-07-02 Thread Jean-Marc Lasgouttes
Le 02/07/2024 à 17:53, Udicoudco a écrit : On Tue, Jul 2, 2024 at 6:39 PM Jean-Marc Lasgouttes wrote: The place you are looking for is InsetMathGrid::firstIdx. It enters by the first/middle/last row depending on the vertical alignment of the inset. I guess the change happened at commit

  1   2   3   4   5   6   7   8   9   10   >