Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

El 18.04.2017 a las 22:57, Uwe Stöhr escribió: Since the default is now no longer "default" this fails. Ah, I see now that you already fixed this. regards Uwe

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

El 18.04.2017 a las 14:52, Jean-Marc Lasgouttes escribió: Do I? Yes, always get \paragraph_separation indent \paragraph_indentation default but it should simply be \paragraph_separation indent There is no need to pollute the LyX file with unnecessary info. We only output the things that

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

El 18.04.2017 a las 14:59, Jean-Marc Lasgouttes escribió: Does it really break, or do you think it does? In lyx_2_0.py we have: --- def revert_paragraph_indentation(document): " Revert custom paragraph indentation to preamble code " i = find_token(document.header,

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Am Dienstag, 18. April 2017 um 20:52:07, schrieb Jean-Marc Lasgouttes > Le 18/04/2017 à 18:57, Kornel Benko a écrit : > > Am Dienstag, 18. April 2017 um 18:22:00, schrieb Jean-Marc Lasgouttes > > > >> Le 18/04/2017 à 14:52, Jean-Marc Lasgouttes a écrit :

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 18/04/2017 à 18:57, Kornel Benko a écrit : Am Dienstag, 18. April 2017 um 18:22:00, schrieb Jean-Marc Lasgouttes Le 18/04/2017 à 14:52, Jean-Marc Lasgouttes a écrit : The default value has unit==NONE, which is the definition of an empty length. An empty length is not

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Am Dienstag, 18. April 2017 um 18:22:00, schrieb Jean-Marc Lasgouttes > Le 18/04/2017 à 14:52, Jean-Marc Lasgouttes a écrit : > > The default value has unit==NONE, which is the definition of an empty > > length. An empty length is not of size 0, it is undefined. This is what

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 18/04/2017 à 14:52, Jean-Marc Lasgouttes a écrit : The default value has unit==NONE, which is the definition of an empty length. An empty length is not of size 0, it is undefined. This is what is obtained when the entry field is left empty. What is wrong with that? The Length constructor

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 17/04/2017 à 19:57, Uwe Stöhr a écrit : El 17.04.2017 a las 19:53, Uwe Stöhr escribió: No, it introduces bugs. You also use now \paragraph_indentation "23bp" instead of the former \paragraph_indentation 23bp the quotes change the fileformat and break lyx2lyx routines. Does it really

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 17/04/2017 à 19:53, Uwe Stöhr a écrit : El 17.04.2017 a las 18:32, Jean-Marc Lasgouttes escribió: I do not have time right now, but I just committed a patch for parindent. Does it help? No, it introduces bugs. Noe you use "0pt" as default value but this is not correct. We don't know the

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

El 17.04.2017 a las 19:53, Uwe Stöhr escribió: No, it introduces bugs. You also use now \paragraph_indentation "23bp" instead of the former \paragraph_indentation 23bp the quotes change the fileformat and break lyx2lyx routines. regards Uwe

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

El 17.04.2017 a las 18:32, Jean-Marc Lasgouttes escribió: I do not have time right now, but I just committed a patch for parindent. Does it help? No, it introduces bugs. Noe you use "0pt" as default value but this is not correct. We don't know the default value of parindent. Moreover you

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 17/04/2017 à 18:07, Uwe Stöhr a écrit : OK, attached is a patch that would omit HSpace. I don't understand why it doesn't work: If the default value is used math_indentation is not "default" but empty. Maybe you see my mistake? In the patch I corrected also the UI enabling logic. If I

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

El 15.04.2017 a las 19:07, Jean-Marc Lasgouttes escribió: Nowadays (with default lengths), the class is basically useless. OK, attached is a patch that would omit HSpace. I don't understand why it doesn't work: If the default value is used math_indentation is not "default" but empty.

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 14/04/2017 à 01:09, Uwe Stöhr a écrit : I meant that you introduce one HSpace variable in BufferParams::Impl and a string variable in BufferParams. What is that? I have just used what is already in use to set the paragraph indentation. No. BufferParams.h: /// the indentation of

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 14/04/2017 à 01:09, Uwe Stöhr a écrit : I have also begun a patch to get rid of the HSpace class for this and paragraph indentation. More on this later. OK. However, I cannot comment on this since I don't know why the HSpace class was once chosen for paragraph indentation. You introduced

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

El 13.04.2017 a las 22:56, Jean-Marc Lasgouttes escribió: I meant that you introduce one HSpace variable in BufferParams::Impl and a string variable in BufferParams. What is that? I have just used what is already in use to set the paragraph indentation. I have also begun a patch to get rid

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

On 2017-04-13, Jean-Marc Lasgouttes wrote: > Thanks Uwe for giving a go to it. There are still a number of issues, > though. > I would really have preferred math_indent to math_indentation, ... I would actually have preferred "mathindent". However, looking in the lyx-file, I see that

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Le 13/04/2017 à 11:50, Jean-Marc Lasgouttes a écrit : Thanks Uwe for giving a go to it. There are still a number of issues, though. I would really have preferred math_indent to math_indentation, and you should get rid of the second version that is a string instead of a length. I meant that

Re: [LyX/master] BufferParams: rename formula_indent to math_indent etc. as requested

Thanks Uwe for giving a go to it. There are still a number of issues, though. I would really have preferred math_indent to math_indentation, and you should get rid of the second version that is a string instead of a length. I am away for a few days, I will be more specific in a few days.