Re: [LyX/master] Do some caching of window title and related UI

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 13:57, Jean-Marc Lasgouttes a écrit : Le 23/10/2016 à 13:55, Guillaume Munch a écrit : By the way, since we appreciate the value of static checks, it is possible to use the new syntax for signal/slot connections, which allows us to know during compilation that it is mistyped or

Re: [LyX/master] Do some caching of window title and related UI

2016-10-23 Thread Jean-Marc Lasgouttes
Le 23/10/2016 à 13:55, Guillaume Munch a écrit : By the way, since we appreciate the value of static checks, it is possible to use the new syntax for signal/slot connections, which allows us to know during compilation that it is mistyped or that the signal or the slot does not exist. When we are

Re: [LyX/master] Do some caching of window title and related UI

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 13:42, Guillaume Munch a écrit : Le 23/10/2016 à 13:27, Jean-Marc Lasgouttes a écrit : Le 22/10/2016 à 22:36, Guillaume Munch a écrit : I know that this is not really followed in LyX currently but I suggest to write "Q_EMIT titleChanged(this)" instead. This is meant to warn the

Re: [LyX/master] Do some caching of window title and related UI

2016-10-23 Thread Guillaume Munch
Le 23/10/2016 à 13:27, Jean-Marc Lasgouttes a écrit : Le 22/10/2016 à 22:36, Guillaume Munch a écrit : I know that this is not really followed in LyX currently but I suggest to write "Q_EMIT titleChanged(this)" instead. This is meant to warn the reader that something they do not expect can

Re: [LyX/master] Do some caching of window title and related UI

2016-10-23 Thread Jean-Marc Lasgouttes
Le 22/10/2016 à 22:36, Guillaume Munch a écrit : I know that this is not really followed in LyX currently but I suggest to write "Q_EMIT titleChanged(this)" instead. This is meant to warn the reader that something they do not expect can happen. (And similarly whenever a signal is emitted.) The

Re: [LyX/master] Do some caching of window title and related UI

2016-10-22 Thread Guillaume Munch
Le 19/10/2016 à 12:00, Jean-Marc Lasgouttes a écrit : @@ -1388,8 +1388,15 @@ QVariant GuiWorkArea::inputMethodQuery(Qt::InputMethodQuery query) const void GuiWorkArea::updateWindowTitle() { - d->lyx_view_->updateWindowTitle(this); - titleChanged(this); + Buffer const & buf

Re: [LyX/master] Do some caching of window title and related UI

2016-10-19 Thread Jean-Marc Lasgouttes
Le 19/10/2016 à 14:04, Jürgen Spitzmüller a écrit : I suppose the latter 4 lines are not supposed to be indented. GCC 6.2 issues a warning about this. Definitely, thanks. JMarc

Re: [LyX/master] Do some caching of window title and related UI

2016-10-19 Thread Jürgen Spitzmüller
2016-10-19 12:00 GMT+02:00 Jean-Marc Lasgouttes : > -string LyXVC::vcname() const > +docstring LyXVC::vcstatus() const > { > - return vcs->vcname(); > + if (!vcs) > + return docstring(); > + if (locking()) > + return bformat(_("%1$s