Re: [LyX/master] Do the actual drawing in the paint event
Le 20/07/2018 à 13:50, Scott Kostyshak a écrit : With high zoom levels, I noticed a separate issue. It is much more minor, but in case it is related I will describe it. The blue lines change length based on cursor movement. It is very subtle, but if you flip between the attached screenshots, you will see the blue lines changing length based on the cursor position. In case it is difficult to see, I attach difference.png. Zoom in and look at the red dots on the ends of a couple of the blue lines. I can reproduce this problem. As I see it, the blue line of text goes over the blue line of insets (this happens around insets). Therefore, when only insets are painted, the erase the extra pixels. JMarc
Re: [LyX/master] Do the actual drawing in the paint event
On Fri, Jul 20, 2018 at 01:56:59PM +, Kornel Benko wrote: > Am Freitag, 20. Juli 2018 15:26:47 CEST schrieb Jean-Marc Lasgouttes > : > > Le 20/07/2018 à 13:50, Scott Kostyshak a écrit : > > > On Thu, Jul 19, 2018 at 07:14:27PM +, Jean-Marc Lasgouttes wrote: > > >> Le 16/07/2018 à 13:34, Scott Kostyshak a écrit : > > >>> To reproduce, open the attached file (which is related to the Hebrew > > >>> splash.lyx), and place the cursor at the top of the file, then press the > > >>> down arrow repeatedly. At some point, the blue lines disappear in some > > >>> places and then reappear. > > >> > > >> Does the situation change if you zoom in? > > > > > > I can still reproduce the issue at high zoom levels. I take it by your > > > question that you cannot reproduce? Perhaps another instance of > > > different Qt versions? If so, perhaps you should not spend time on it. > > > > OK, I can reproduce actually. I committed a possible fix, please tel me > > if it is OK. > > > > JMarc > > FWIW, I cannot reproduce anymore. +1 looks good. I can still reproduce that the blue line can change width very very slightly. But I don't think this is worth spending time on. Thanks! Scott signature.asc Description: PGP signature
Re: [LyX/master] Do the actual drawing in the paint event
Am Freitag, 20. Juli 2018 15:26:47 CEST schrieb Jean-Marc Lasgouttes : > Le 20/07/2018 à 13:50, Scott Kostyshak a écrit : > > On Thu, Jul 19, 2018 at 07:14:27PM +, Jean-Marc Lasgouttes wrote: > >> Le 16/07/2018 à 13:34, Scott Kostyshak a écrit : > >>> To reproduce, open the attached file (which is related to the Hebrew > >>> splash.lyx), and place the cursor at the top of the file, then press the > >>> down arrow repeatedly. At some point, the blue lines disappear in some > >>> places and then reappear. > >> > >> Does the situation change if you zoom in? > > > > I can still reproduce the issue at high zoom levels. I take it by your > > question that you cannot reproduce? Perhaps another instance of > > different Qt versions? If so, perhaps you should not spend time on it. > > OK, I can reproduce actually. I committed a possible fix, please tel me > if it is OK. > > JMarc FWIW, I cannot reproduce anymore. Kornel signature.asc Description: This is a digitally signed message part.
Re: [LyX/master] Do the actual drawing in the paint event
Le 20/07/2018 à 13:50, Scott Kostyshak a écrit : On Thu, Jul 19, 2018 at 07:14:27PM +, Jean-Marc Lasgouttes wrote: Le 16/07/2018 à 13:34, Scott Kostyshak a écrit : To reproduce, open the attached file (which is related to the Hebrew splash.lyx), and place the cursor at the top of the file, then press the down arrow repeatedly. At some point, the blue lines disappear in some places and then reappear. Does the situation change if you zoom in? I can still reproduce the issue at high zoom levels. I take it by your question that you cannot reproduce? Perhaps another instance of different Qt versions? If so, perhaps you should not spend time on it. OK, I can reproduce actually. I committed a possible fix, please tel me if it is OK. JMarc
Re: [LyX/master] Do the actual drawing in the paint event
Le 16/07/2018 à 13:34, Scott Kostyshak a écrit : To reproduce, open the attached file (which is related to the Hebrew splash.lyx), and place the cursor at the top of the file, then press the down arrow repeatedly. At some point, the blue lines disappear in some places and then reappear. Does the situation change if you zoom in? I see similar things when the underlines positions are below the bottom of the row and are therefore erased by the next row. I see two solutions: * adjust the lines to be inside rows * adjust row height to contain the rows. JMarc
Re: [LyX/master] Do the actual drawing in the paint event
On Fri, Sep 08, 2017 at 03:20:29PM +, Jean-Marc Lasgouttes wrote: > commit 24c29908bd68ac36199bf413d9fed078f6f1f224 > Author: Jean-Marc Lasgouttes > Date: Fri Sep 8 16:55:11 2017 +0200 > > Do the actual drawing in the paint event > > Historically, because of two-stage drawing, LyX has been painting on a > Pixmap, and this pixmap is copied to screen at paint event time. > > Now that we have three-stage drawing, it is possible to delay the > painting to actual paint event and avoid the intermediate Pixmap. > > Known bug: the cursor is never erased. I found a regression that I think (based on a bisect) is either related to this commit or to e7fdce0b. Note that I did the bisect on the 2.3.x branch, which corresponds to commits 7b8b3e38 and ef1d5020. To reproduce, open the attached file (which is related to the Hebrew splash.lyx), and place the cursor at the top of the file, then press the down arrow repeatedly. At some point, the blue lines disappear in some places and then reappear. If you cannot reproduce, let me know and I will make a screencast. Scott mwe_underlining.22.lyx Description: application/lyx signature.asc Description: PGP signature
