Re: [LyX/master] MathAtom is a unique_ptr

2017-04-13 Thread Jean-Marc Lasgouttes
Le 12/04/2017 à 22:06, Guillaume MM a écrit : Thanks for doing that. A question, though: do you advise to always add the explicit default entries, even when we believe that the compiler will do it by itself? I would advise to declare all four (both copy operators and both move operators,

Re: [LyX/master] MathAtom is a unique_ptr

2017-04-12 Thread Guillaume MM
Le 08/04/2017 à 15:10, Jean-Marc Lasgouttes a écrit : Le 07/04/2017 à 23:55, Guillaume MM a écrit : commit b382b246b62b66100733449b2bf75a01fd1d263f Author: Guillaume MM Date: Sun Apr 2 21:04:06 2017 +0200 MathAtom is a unique_ptr Fix coverity suggestion of defining a

Re: [LyX/master] MathAtom is a unique_ptr

2017-04-08 Thread Jean-Marc Lasgouttes
Le 07/04/2017 à 23:55, Guillaume MM a écrit : commit b382b246b62b66100733449b2bf75a01fd1d263f Author: Guillaume MM Date: Sun Apr 2 21:04:06 2017 +0200 MathAtom is a unique_ptr Fix coverity suggestion of defining a move constructor - /// default constructor,