Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[Scott Kostyshak]

On Mon, Aug 07, 2017 at 02:26:25PM +0930, racoon wrote:

> Thanks. It seem that you are correct. Unfortunately, I did not find where
> the zoom is set but I tested it without the dispatch and it seems to work
> totally fine. Would you mind removing the dispatch line then?

Thanks for testing, Daniel. I removed the dispatch at acc1cc39. If in
future testing it turns out we need it, we could consider conditioning
on having a buffer available.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[racoon]

On 03.08.2017 07:32, Scott Kostyshak wrote:

On Tue, Jul 25, 2017 at 08:23:39AM +1000, racoon wrote:

On 25.07.2017 07:49, Scott Kostyshak wrote:

On Sat, Jul 22, 2017 at 07:41:32PM +1000, racoon wrote:

On 22.07.2017 08:38, Scott Kostyshak wrote:



No, sorry. Most importantly, I do not understand what the debug messages
mean. Unfortunately, I also do not have much time at my hands at the moment
either. I am happy to help though, if something in my code is unclear.


No problem, Daniel. Thanks for the reply. I'll take a look at it
hopefully within the next week.


Thanks Scott.


The issue comes from the call to dispatch, in the following part of your commit:

  bool GuiView::restoreLayout()
  {
 QSettings settings;
+   lyxrc.currentZoom = settings.value("zoom", lyxrc.zoom).toInt();
+   lyx::dispatch(FuncRequest(LFUN_BUFFER_ZOOM, 
convert(lyxrc.currentZoom)));
 settings.beginGroup("views");
 settings.beginGroup(QString::number(id_));
 QString const icon_key = "icon_size";

The reason the message is shown on startup for me is that there is no buffer
open. What is the purpose of having the dispatch there? Isn't the zoom
automatically set (via some other mechanism) when a buffer is opened?


Thanks. It seem that you are correct. Unfortunately, I did not find 
where the zoom is set but I tested it without the dispatch and it seems 
to work totally fine. Would you mind removing the dispatch line then?


Daniel

Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[Scott Kostyshak]

On Tue, Jul 25, 2017 at 08:23:39AM +1000, racoon wrote:
> On 25.07.2017 07:49, Scott Kostyshak wrote:
> > On Sat, Jul 22, 2017 at 07:41:32PM +1000, racoon wrote:
> > > On 22.07.2017 08:38, Scott Kostyshak wrote:
> > 
> > > No, sorry. Most importantly, I do not understand what the debug messages
> > > mean. Unfortunately, I also do not have much time at my hands at the 
> > > moment
> > > either. I am happy to help though, if something in my code is unclear.
> > 
> > No problem, Daniel. Thanks for the reply. I'll take a look at it
> > hopefully within the next week.
> 
> Thanks Scott.

The issue comes from the call to dispatch, in the following part of your commit:

 bool GuiView::restoreLayout()
 {
QSettings settings;
+   lyxrc.currentZoom = settings.value("zoom", lyxrc.zoom).toInt();
+   lyx::dispatch(FuncRequest(LFUN_BUFFER_ZOOM, 
convert(lyxrc.currentZoom)));
settings.beginGroup("views");
settings.beginGroup(QString::number(id_));
QString const icon_key = "icon_size";

The reason the message is shown on startup for me is that there is no buffer
open. What is the purpose of having the dispatch there? Isn't the zoom
automatically set (via some other mechanism) when a buffer is opened?

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[racoon]

On 25.07.2017 07:49, Scott Kostyshak wrote:

On Sat, Jul 22, 2017 at 07:41:32PM +1000, racoon wrote:

On 22.07.2017 08:38, Scott Kostyshak wrote:



No, sorry. Most importantly, I do not understand what the debug messages
mean. Unfortunately, I also do not have much time at my hands at the moment
either. I am happy to help though, if something in my code is unclear.


No problem, Daniel. Thanks for the reply. I'll take a look at it
hopefully within the next week.


Thanks Scott.

Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[Scott Kostyshak]

On Sat, Jul 22, 2017 at 07:41:32PM +1000, racoon wrote:
> On 22.07.2017 08:38, Scott Kostyshak wrote:

> No, sorry. Most importantly, I do not understand what the debug messages
> mean. Unfortunately, I also do not have much time at my hands at the moment
> either. I am happy to help though, if something in my code is unclear.

No problem, Daniel. Thanks for the reply. I'll take a look at it
hopefully within the next week.

Scott

> Daniel

Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[racoon]

On 22.07.2017 08:38, Scott Kostyshak wrote:

On Tue, Jul 18, 2017 at 04:43:44AM -0400, Scott Kostyshak wrote:

On Sun, May 07, 2017 at 02:18:41PM +0200, Guillaume MM wrote:

commit 4183a9f4dc9bc0893fc59cd7e31db9bc7e52eea9
Author: Daniel Ramöller 
Date:   Sat Oct 29 10:28:34 2016 +0200

 Preferences shows current zoom instead of preference's default zoom 
(#10455)
 
 - Adds a currentZoom variable which holds the current zoom level.
 
 - The zoom stored in preferences is used as default zoom level (default binding:

   M+0).
 
 - The currentZoom is saved and restored via QSettings.
 
 - Adds LFUN buffer-zoom for (re)setting zoom.


After this commit, I see the following:

$ lyx -dbg action

Debugging `action' (User commands)
frontends/qt4/GuiApplication.cpp (1576): cmd:  action: 269 [window-new]
arg: '' x: 0 y: 0
frontends/qt4/GuiApplication.cpp (1576): cmd:  action: 367 [buffer-zoom]
arg: '110' x: 0 y: 0
frontends/qt4/GuiApplication.cpp (1586): action buffer-zoom
[buffer-zoom] is disabled at this location
frontends/qt4/GuiApplication.cpp (1357): dispatch msg is Command not
allowed without any document open
frontends/qt4/GuiApplication.cpp (1357): dispatch msg is


before, I saw this:


$ lyx -dbg action

Debugging `action' (User commands)
frontends/qt4/GuiApplication.cpp (1570): cmd:  action: 269 [window-new]
arg: '' x: 0 y: 0
frontends/qt4/GuiApplication.cpp (1351): dispatch msg is


Racoon, I just wanted to make sure that you saw this email about the
above potential regression. Will you have time to look into it?


No, sorry. Most importantly, I do not understand what the debug messages 
mean. Unfortunately, I also do not have much time at my hands at the 
moment either. I am happy to help though, if something in my code is 
unclear.


Daniel

Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[Scott Kostyshak]

On Tue, Jul 18, 2017 at 04:43:44AM -0400, Scott Kostyshak wrote:
> On Sun, May 07, 2017 at 02:18:41PM +0200, Guillaume MM wrote:
> > commit 4183a9f4dc9bc0893fc59cd7e31db9bc7e52eea9
> > Author: Daniel Ramöller 
> > Date:   Sat Oct 29 10:28:34 2016 +0200
> > 
> > Preferences shows current zoom instead of preference's default zoom 
> > (#10455)
> > 
> > - Adds a currentZoom variable which holds the current zoom level.
> > 
> > - The zoom stored in preferences is used as default zoom level (default 
> > binding:
> >   M+0).
> > 
> > - The currentZoom is saved and restored via QSettings.
> > 
> > - Adds LFUN buffer-zoom for (re)setting zoom.
> 
> After this commit, I see the following:
> 
> $ lyx -dbg action
> 
> Debugging `action' (User commands)
> frontends/qt4/GuiApplication.cpp (1576): cmd:  action: 269 [window-new]
> arg: '' x: 0 y: 0
> frontends/qt4/GuiApplication.cpp (1576): cmd:  action: 367 [buffer-zoom]
> arg: '110' x: 0 y: 0
> frontends/qt4/GuiApplication.cpp (1586): action buffer-zoom
> [buffer-zoom] is disabled at this location
> frontends/qt4/GuiApplication.cpp (1357): dispatch msg is Command not
> allowed without any document open
> frontends/qt4/GuiApplication.cpp (1357): dispatch msg is 
> 
> 
> before, I saw this:
> 
> 
> $ lyx -dbg action
> 
> Debugging `action' (User commands)
> frontends/qt4/GuiApplication.cpp (1570): cmd:  action: 269 [window-new]
> arg: '' x: 0 y: 0
> frontends/qt4/GuiApplication.cpp (1351): dispatch msg is 

Racoon, I just wanted to make sure that you saw this email about the
above potential regression. Will you have time to look into it?

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Preferences shows current zoom instead of preference's default zoom (#10455)

[Scott Kostyshak]

On Sun, May 07, 2017 at 02:18:41PM +0200, Guillaume MM wrote:
> commit 4183a9f4dc9bc0893fc59cd7e31db9bc7e52eea9
> Author: Daniel Ramöller 
> Date:   Sat Oct 29 10:28:34 2016 +0200
> 
> Preferences shows current zoom instead of preference's default zoom 
> (#10455)
> 
> - Adds a currentZoom variable which holds the current zoom level.
> 
> - The zoom stored in preferences is used as default zoom level (default 
> binding:
>   M+0).
> 
> - The currentZoom is saved and restored via QSettings.
> 
> - Adds LFUN buffer-zoom for (re)setting zoom.

After this commit, I see the following:

$ lyx -dbg action

Debugging `action' (User commands)
frontends/qt4/GuiApplication.cpp (1576): cmd:  action: 269 [window-new]
arg: '' x: 0 y: 0
frontends/qt4/GuiApplication.cpp (1576): cmd:  action: 367 [buffer-zoom]
arg: '110' x: 0 y: 0
frontends/qt4/GuiApplication.cpp (1586): action buffer-zoom
[buffer-zoom] is disabled at this location
frontends/qt4/GuiApplication.cpp (1357): dispatch msg is Command not
allowed without any document open
frontends/qt4/GuiApplication.cpp (1357): dispatch msg is 


before, I saw this:


$ lyx -dbg action

Debugging `action' (User commands)
frontends/qt4/GuiApplication.cpp (1570): cmd:  action: 269 [window-new]
arg: '' x: 0 y: 0
frontends/qt4/GuiApplication.cpp (1351): dispatch msg is 

Scott


signature.asc
Description: PGP signature