Re: [LyX/master] Remove unused function
Am Sat, 05 Mar 2022 09:29:23 +0100 schrieb Jürgen Spitzmüller : > Am Samstag, dem 05.03.2022 um 09:07 +0100 schrieb Kornel Benko: > > As you are at it, we also have identical functions with different > > names. > > See > > docstring const & Bullet::getText() const > > and > > docstring const & Bullet::getUnicode() const > > > > Any reason to not unify them? > > The functions are not identical. One returns text for source (text), > the other for workarea (unicode, now renamed label). > > Jürgen > I had to look 5 times to see the difference. Becoming blind. Kornel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel pgpa7TNx6KAp3.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Remove unused function
Am Samstag, dem 05.03.2022 um 09:07 +0100 schrieb Kornel Benko: > As you are at it, we also have identical functions with different > names. > See > docstring const & Bullet::getText() const > and > docstring const & Bullet::getUnicode() const > > Any reason to not unify them? The functions are not identical. One returns text for source (text), the other for workarea (unicode, now renamed label). Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Remove unused function
Am Sat, 5 Mar 2022 08:17:53 +0100 (CET) schrieb Juergen Spitzmueller : > commit ad31043987bd55f0519448fd46dcf8ed96ce6475 > Author: Juergen Spitzmueller > Date: Sat Mar 5 08:51:32 2022 +0100 > > Remove unused function As you are at it, we also have identical functions with different names. See docstring const & Bullet::getText() const and docstring const & Bullet::getUnicode() const Any reason to not unify them? Kornel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel pgp12LPcPrmMk.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
