Re: [patch] Factor out magic zoom minimum to a const member

2016-10-09 Thread Scott Kostyshak
On Sun, Oct 09, 2016 at 11:35:26PM +0200, Guillaume Munch wrote: > I now get the following with gcc 4.6: > > ../../../../src/frontends/qt4/GuiView.h:467:33: sorry, unimplemented: > non-static data member initializers > > Your code is fine, this is just gcc 4.6 not supporting a C++11 feature. >

Re: [patch] Factor out magic zoom minimum to a const member

2016-10-09 Thread Guillaume Munch
Le 09/10/2016 à 23:26, Scott Kostyshak a écrit : On Sun, Oct 09, 2016 at 05:21:03PM -0400, Scott Kostyshak wrote: I just pushed a commit but I forgot to append the underscore. I'll fix that now. Committed at 168d3557 and amended at 5fd21db9. Scott I now get the following with gcc 4.6:

Re: [patch] Factor out magic zoom minimum to a const member

2016-10-09 Thread Scott Kostyshak
On Sun, Oct 09, 2016 at 05:21:03PM -0400, Scott Kostyshak wrote: > I just pushed a commit but I forgot to append the underscore. I'll fix > that now. Committed at 168d3557 and amended at 5fd21db9. Scott signature.asc Description: PGP signature

Re: [patch] Factor out magic zoom minimum to a const member

2016-10-09 Thread Scott Kostyshak
On Sun, Oct 09, 2016 at 07:24:25PM +0200, Enrico Forestieri wrote: > On Sat, Oct 08, 2016 at 10:09:54AM -0400, Scott Kostyshak wrote: > > > On Sat, Oct 08, 2016 at 11:02:17AM +0200, Enrico Forestieri wrote: > > > On Fri, Oct 07, 2016 at 11:41:25PM -0400, Scott Kostyshak wrote: > > > > > > > The

Re: [patch] Factor out magic zoom minimum to a const member

2016-10-09 Thread Enrico Forestieri
On Sat, Oct 08, 2016 at 10:09:54AM -0400, Scott Kostyshak wrote: > On Sat, Oct 08, 2016 at 11:02:17AM +0200, Enrico Forestieri wrote: > > On Fri, Oct 07, 2016 at 11:41:25PM -0400, Scott Kostyshak wrote: > > > > > The attached patch is simple but I have not made a change like this > > > before so

Re: [patch] Factor out magic zoom minimum to a const member

2016-10-08 Thread Scott Kostyshak
On Sat, Oct 08, 2016 at 11:02:17AM +0200, Enrico Forestieri wrote: > On Fri, Oct 07, 2016 at 11:41:25PM -0400, Scott Kostyshak wrote: > > > The attached patch is simple but I have not made a change like this > > before so I wanted to check on the list. > > In general, all capitals is used for

Re: [patch] Factor out magic zoom minimum to a const member

2016-10-08 Thread Enrico Forestieri
On Fri, Oct 07, 2016 at 11:41:25PM -0400, Scott Kostyshak wrote: > The attached patch is simple but I have not made a change like this > before so I wanted to check on the list. In general, all capitals is used for preprocessor macros and in LyX private mambers have a trailing underscore. So, I

[patch] Factor out magic zoom minimum to a const member

2016-10-07 Thread Scott Kostyshak
The attached patch is simple but I have not made a change like this before so I wanted to check on the list. Scott From 3afb01f8b005bbd28109dec80de3a9d368de9003 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak <skost...@lyx.org> Date: Fri, 7 Oct 2016 23:18:54 -0400 Subject: [PATCH] Factor out