Re: [patch] LilyPond-book module

2010-10-09 Thread Julien Rioux
On 23/09/2010 5:28 AM, Pavel Sanda wrote: Julien Rioux wrote: I asked on lilypond-user list and there is no safe mode for lilypond-book. I see three ways o action: - Request for a safe-mode for lilypond-book, have it fixed upstream, then support in LyX only newer versions which have a safe

Re: [patch] LilyPond-book module

2010-10-09 Thread Pavel Sanda
Julien Rioux wrote: FYI I sent a patch to the lilypond devs [1], this wasn't so hard to do. Hopefully it gets pushed in before their next release cycle, which would be version 2.14. [1] http://code.google.com/p/lilypond/issues/detail?id=1281 thanks, i filled bug so we dont forget on the

Re: [patch] LilyPond-book module

2010-10-09 Thread Julien Rioux
On 23/09/2010 5:28 AM, Pavel Sanda wrote: Julien Rioux wrote: I asked on lilypond-user list and there is no safe mode for lilypond-book. I see three ways o action: - Request for a safe-mode for lilypond-book, have it fixed upstream, then support in LyX only newer versions which have a safe

Re: [patch] LilyPond-book module

2010-10-09 Thread Pavel Sanda
Julien Rioux wrote: > FYI I sent a patch to the lilypond devs [1], this wasn't so hard to do. > Hopefully it gets pushed in before their next release cycle, which would be > version 2.14. > > [1] http://code.google.com/p/lilypond/issues/detail?id=1281 thanks, i filled bug so we dont forget on

Re: [patch] LilyPond-book module

2010-09-23 Thread Pavel Sanda
Julien Rioux wrote: I asked on lilypond-user list and there is no safe mode for lilypond-book. I see three ways o action: - Request for a safe-mode for lilypond-book, have it fixed upstream, then support in LyX only newer versions which have a safe mode. (I'll send the request to

Re: [patch] LilyPond-book module

2010-09-23 Thread Pavel Sanda
Julien Rioux wrote: > I asked on lilypond-user list and there is no safe mode for lilypond-book. > I see three ways o action: > > - Request for a safe-mode for lilypond-book, have it fixed upstream, then > support in LyX only newer versions which have a safe mode. (I'll send the > request to

Re: [patch] LilyPond-book module

2010-09-22 Thread Pavel Sanda
Julien Rioux wrote: Thanks, but hold on... lilypond-book can run evil scheme code included within the lilypond snippets! lilypond itself has a -dsafe command-line switch but lilypond-book doesn't have that, or I couldn't find it. We need to ensure lilypond-book can be run in safe mode

Re: [patch] LilyPond-book module

2010-09-22 Thread Julien Rioux
On 22/09/2010 5:12 AM, Pavel Sanda wrote: Julien Rioux wrote: Thanks, but hold on... lilypond-book can run evil scheme code included within the lilypond snippets! lilypond itself has a -dsafe command-line switch but lilypond-book doesn't have that, or I couldn't find it. We need to ensure

Re: [patch] LilyPond-book module

2010-09-22 Thread Pavel Sanda
Julien Rioux wrote: > Thanks, but hold on... lilypond-book can run evil scheme code included > within the lilypond snippets! > > lilypond itself has a -dsafe command-line switch but lilypond-book doesn't > have that, or I couldn't find it. We need to ensure lilypond-book can be > run in safe

Re: [patch] LilyPond-book module

2010-09-22 Thread Julien Rioux
On 22/09/2010 5:12 AM, Pavel Sanda wrote: Julien Rioux wrote: Thanks, but hold on... lilypond-book can run evil scheme code included within the lilypond snippets! lilypond itself has a -dsafe command-line switch but lilypond-book doesn't have that, or I couldn't find it. We need to ensure

Re: [patch] LilyPond-book module

2010-09-21 Thread Abdelrazak Younes
On 09/20/2010 11:56 PM, Pavel Sanda wrote: Julien Rioux wrote: The lytex converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex,

Re: [patch] LilyPond-book module

2010-09-21 Thread Pavel Sanda
Pavel Sanda wrote: Julien Rioux wrote: Same code base, new patch, without using svn cp. i went briefly through the patch and looks ok. i will wait whether there are other comments (mainly for the python part which i skipped;) but this can go in imho. its in. you probably want new

Re: [patch] LilyPond-book module

2010-09-21 Thread Julien Rioux
On 21/09/2010 12:41 PM, Pavel Sanda wrote: Pavel Sanda wrote: Julien Rioux wrote: Same code base, new patch, without using svn cp. i went briefly through the patch and looks ok. i will wait whether there are other comments (mainly for the python part which i skipped;) but this can go in

Re: [patch] LilyPond-book module

2010-09-21 Thread Abdelrazak Younes
On 09/20/2010 11:56 PM, Pavel Sanda wrote: Julien Rioux wrote: The "lytex" converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex,

Re: [patch] LilyPond-book module

2010-09-21 Thread Pavel Sanda
Pavel Sanda wrote: > Julien Rioux wrote: > > Same code base, new patch, without using "svn cp". > > i went briefly through the patch and looks ok. i will wait whether there are > other comments (mainly for the python part which i skipped;) but this can go > in > imho. its in. you probably want

Re: [patch] LilyPond-book module

2010-09-21 Thread Julien Rioux
On 21/09/2010 12:41 PM, Pavel Sanda wrote: Pavel Sanda wrote: Julien Rioux wrote: Same code base, new patch, without using "svn cp". i went briefly through the patch and looks ok. i will wait whether there are other comments (mainly for the python part which i skipped;) but this can go in

[patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
Dear devs, Please have a look at the attached, an updated patch to provide lilypond-book support: Inclusion of lilypond code directly in LyX. This is done with a module with OutputFormat keyword and (at the moment) a simple inset. The preview mechanism is extended to allow for musical

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: - if (!pconverter_){ - if (b.params().encoding().package() == Encoding::japanese) - pconverter_ = setConverter(lyxpreview-platex); - else - pconverter_ = setConverter(lyxpreview); - } + if

Re: [patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
On 20/09/2010 5:16 PM, Pavel Sanda wrote: Julien Rioux wrote: - if (!pconverter_){ - if (b.params().encoding().package() == Encoding::japanese) - pconverter_ = setConverter(lyxpreview-platex); - else - pconverter_ =

Re: [patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
On 20/09/2010 5:16 PM, Pavel Sanda wrote: --- lib/scripts/lyxpreview-lytex2bitmap.py (revision 35036) this file does not exists in lyx proper... there are many other links to lytex in your patch, so before diving in, please send updated version... pavel Same code base, new patch,

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: The lytex converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex, because i dont see any such script in the diff...?

Re: [patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
On 20/09/2010 5:56 PM, Pavel Sanda wrote: Julien Rioux wrote: The lytex converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex, because i

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: \begin{lilypond}...\end{lilypond} snippets. I started using that extension too, but we can choose something else. no, its ok. the current version makes sense to me. pavel

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: Same code base, new patch, without using svn cp. i went briefly through the patch and looks ok. i will wait whether there are other comments (mainly for the python part which i skipped;) but this can go in imho. pavel

[patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
Dear devs, Please have a look at the attached, an updated patch to provide lilypond-book support: Inclusion of lilypond code directly in LyX. This is done with a module with OutputFormat keyword and (at the moment) a simple inset. The preview mechanism is extended to allow for musical

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: > - if (!pconverter_){ > - if (b.params().encoding().package() == Encoding::japanese) > - pconverter_ = setConverter("lyxpreview-platex"); > - else > - pconverter_ = setConverter("lyxpreview"); > - } > +

Re: [patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
On 20/09/2010 5:16 PM, Pavel Sanda wrote: Julien Rioux wrote: - if (!pconverter_){ - if (b.params().encoding().package() == Encoding::japanese) - pconverter_ = setConverter("lyxpreview-platex"); - else - pconverter_ =

Re: [patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
On 20/09/2010 5:16 PM, Pavel Sanda wrote: --- lib/scripts/lyxpreview-lytex2bitmap.py (revision 35036) this file does not exists in lyx proper... there are many other links to lytex in your patch, so before diving in, please send updated version... pavel Same code base, new patch,

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: > The "lytex" converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex, because i dont see any such script in the diff...?

Re: [patch] LilyPond-book module

2010-09-20 Thread Julien Rioux
On 20/09/2010 5:56 PM, Pavel Sanda wrote: Julien Rioux wrote: The "lytex" converter adds an extra preprocessing step through i guess thats misunderstanding. there exists special lyx+latex release called lytex and i thought that you refer to THAT lytex ;) have you done svn add lytex, because i

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: > \begin{lilypond}...\end{lilypond} snippets. I started using that extension > too, but we can choose something else. no, its ok. the current version makes sense to me. pavel

Re: [patch] LilyPond-book module

2010-09-20 Thread Pavel Sanda
Julien Rioux wrote: > Same code base, new patch, without using "svn cp". i went briefly through the patch and looks ok. i will wait whether there are other comments (mainly for the python part which i skipped;) but this can go in imho. pavel