[patch] fix for trunk regression regarding view hidden

2012-02-22 Thread Scott Kostyshak
The attached patch fixes a regression introduced into trunk in r40585 description of regression: Non-hidden files are shown in the submenu view hidden and hidden files are not shown there. You can reproduce by opening a new file and seeing that it is listed under view hidden. Additionally,

Re: [patch] fix for trunk regression regarding view hidden

2012-02-22 Thread Pavel Sanda
Scott Kostyshak wrote: The attached patch fixes a regression introduced into trunk in r40585 I don't see the whole context of the code but it seems to me that to get pre-r40585 logic, '!' shall be put ahead of the whole clause, no? Should I send small fixes such as this to the list or make a

RE: [patch] fix for trunk regression regarding view hidden

2012-02-22 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Pavel Sanda [sa...@lyx.org] Sent: Wednesday, February 22, 2012 6:08 AM I don't see the whole context of the code but it seems to me that to get pre-r40585 logic, '!' shall be put ahead of the whole clause, no? Yes, you are

Re: [patch] fix for trunk regression regarding view hidden

2012-02-22 Thread Pavel Sanda
Scott Kostyshak wrote: Attached is the updated patch. Its in, thanks Pavel

[patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Scott Kostyshak
The attached patch fixes a regression introduced into trunk in r40585 description of regression: Non-hidden files are shown in the submenu view > hidden and hidden files are not shown there. You can reproduce by opening a new file and seeing that it is listed under view > hidden. Additionally,

Re: [patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Pavel Sanda
Scott Kostyshak wrote: > The attached patch fixes a regression introduced into trunk in r40585 I don't see the whole context of the code but it seems to me that to get pre-r40585 logic, '!' shall be put ahead of the whole && clause, no? > Should I send small fixes such as this to the list or

RE: [patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Pavel Sanda [sa...@lyx.org] Sent: Wednesday, February 22, 2012 6:08 AM > I don't see the whole context of the code but it seems to me that to > get pre-r40585 logic, '!' shall be put ahead of the whole && clause, no? Yes, you

Re: [patch] fix for trunk regression regarding view > hidden

2012-02-22 Thread Pavel Sanda
Scott Kostyshak wrote: > Attached is the updated patch. Its in, thanks Pavel