Re: [patch] insetlisting/caption

2007-05-15 Thread Jürgen Spitzmüller
Bo Peng wrote: I have submitted your patch with Include dialog changes. Please test. lyx2lyx changes will be added soon. Thanks. The one issue I already mentioned: in the navigte menu, the category Listings is not indocated correctly. Anyone an idea? Now, it is again qt experts' turn to fix

RE: [patch] insetlisting/caption

2007-05-15 Thread Leuven, E.
Jürgen Spitzmüller wrote: Now, it is again qt experts' turn to fix the include dialog. WHY the hell the editboxes are much larger than they are in designer? Edwin? committed a tweak

Re: [patch] insetlisting/caption

2007-05-15 Thread Jürgen Spitzmüller
Bo Peng wrote: > I have submitted your patch with Include dialog changes. Please test. > lyx2lyx changes will be added soon. Thanks. The one issue I already mentioned: in the navigte menu, the category "Listings" is not indocated correctly. Anyone an idea? > Now, it is again qt experts' turn to

RE: [patch] insetlisting/caption

2007-05-15 Thread Leuven, E.
Jürgen Spitzmüller wrote: >> Now, it is again qt experts' turn to fix the include dialog. WHY the >> hell the editboxes are much larger than they are in designer? > > Edwin? committed a tweak

[patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
One thing I don't like about the listings implementation is that you have to insert the caption via the dialog (which is not only unusual, but also doesn't let you use the crossrefs dialog etc.). The attached patch uses the caption and label insets instead. It needs testing. If we'd put this

Re: [patch] insetlisting/caption

2007-05-14 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: One thing I don't like about the listings implementation is that you have to insert the caption via the dialog (which is not only unusual, but also doesn't let you use the crossrefs dialog etc.). The attached patch uses the caption and label insets instead. It needs

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
This looks not only natural but the right thing to do. I vote YES :-) Thank you very much! I thought of this as well but did not gather enough time to think about it. I vote yes to put it in except that the trunk is broken now so I can not test your patch. Cheers, Bo g++ -o

Re: [patch] insetlisting/caption

2007-05-14 Thread Abdelrazak Younes
Bo Peng wrote: I vote yes to put it in except that the trunk is broken now so I can not test your patch. Should be fine now, sorry. Abdel.

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
Bo Peng wrote: Thank you very much! I thought of this as well but did not gather enough time to think about it. I vote yes to put it in except that the trunk is broken now so I can not test your patch. Please do if trunk works again, and report back. Known issues: - The listings are put to

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
I vote yes to put it in except that the trunk is broken now so I can not test your patch. A few questions: 1. You mentioned file format change but no lyx2lyx stuff in your patch. 2. Should caption be removed from the listings dialog? Or should the caption inset automatically reflects the

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
Bo Peng wrote: A few questions: 1. You mentioned file format change but no lyx2lyx stuff in your patch. I haven't done anything yet. Perhaps we don't need it, since no LyX version with listings hasn't been released yet. That's why I like to have it included before the next beta. 2. Should

Re: [patch] insetlisting/caption

2007-05-14 Thread José Matos
On Monday 14 May 2007 15:02:07 Jürgen Spitzmüller wrote: If we'd put this in before the next beta, we wouldn't need to change the file format. These two issues are orthogonal, if there is a file format change we honour it even if it is inside the same development series. :-) Jürgen --

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
On 5/14/07, José Matos [EMAIL PROTECTED] wrote: On Monday 14 May 2007 15:02:07 Jürgen Spitzmüller wrote: If we'd put this in before the next beta, we wouldn't need to change the file format. Hi, Jose, When do you plan to release beta 3? I can modify Jurgen's patch later today 1. add

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
José Matos wrote: These two issues are orthogonal, if there is a file format change we honour it even if it is inside the same development series. :-) You're right (and Bo already convinced me in PM). Jürgen

Re: [patch] insetlisting/caption

2007-05-14 Thread José Matos
On Monday 14 May 2007 19:05:21 Bo Peng wrote: On 5/14/07, José Matos [EMAIL PROTECTED] wrote: On Monday 14 May 2007 15:02:07 Jürgen Spitzmüller wrote: If we'd put this in before the next beta, we wouldn't need to change the file format. Hi, Jose, When do you plan to release beta 3? I

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
Bo Peng wrote: I can modify Jurgen's patch later today Bo, please also include this patch (a bugfix and a semantic correction). Jürgen Index: src/frontends/qt4/QListings.cpp === --- src/frontends/qt4/QListings.cpp (Revision 18312)

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
Bo, please also include this patch (a bugfix and a semantic correction). Got it. Thanks. Bo

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
If we'd put this in before the next beta, we wouldn't need to change the file format. I have submitted your patch with Include dialog changes. Please test. lyx2lyx changes will be added soon. Now, it is again qt experts' turn to fix the include dialog. WHY the hell the editboxes are much

[patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
One thing I don't like about the listings implementation is that you have to insert the caption via the dialog (which is not only unusual, but also doesn't let you use the crossrefs dialog etc.). The attached patch uses the caption and label insets instead. It needs testing. If we'd put this

Re: [patch] insetlisting/caption

2007-05-14 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: One thing I don't like about the listings implementation is that you have to insert the caption via the dialog (which is not only unusual, but also doesn't let you use the crossrefs dialog etc.). The attached patch uses the caption and label insets instead. It needs

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
This looks not only natural but the right thing to do. I vote YES :-) Thank you very much! I thought of this as well but did not gather enough time to think about it. I vote yes to put it in except that the trunk is broken now so I can not test your patch. Cheers, Bo g++ -o

Re: [patch] insetlisting/caption

2007-05-14 Thread Abdelrazak Younes
Bo Peng wrote: I vote yes to put it in except that the trunk is broken now so I can not test your patch. Should be fine now, sorry. Abdel.

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
Bo Peng wrote: > Thank you very much! I thought of this as well but did not gather > enough time to think about it. > > I vote yes to put it in except that the trunk is broken now so I can > not test your patch. Please do if trunk works again, and report back. Known issues: - The listings are

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
I vote yes to put it in except that the trunk is broken now so I can not test your patch. A few questions: 1. You mentioned file format change but no lyx2lyx stuff in your patch. 2. Should caption be removed from the listings dialog? Or should the caption inset automatically reflects the

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
Bo Peng wrote: > A few questions: > > 1. You mentioned file format change but no lyx2lyx stuff in your patch. I haven't done anything yet. Perhaps we don't need it, since no LyX version with listings hasn't been released yet. That's why I like to have it included before the next beta. > 2.

Re: [patch] insetlisting/caption

2007-05-14 Thread José Matos
On Monday 14 May 2007 15:02:07 Jürgen Spitzmüller wrote: > If we'd put this in before the next beta, we wouldn't need to change the > file format. These two issues are orthogonal, if there is a file format change we honour it even if it is inside the same development series. :-) > Jürgen --

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
On 5/14/07, José Matos <[EMAIL PROTECTED]> wrote: On Monday 14 May 2007 15:02:07 Jürgen Spitzmüller wrote: > If we'd put this in before the next beta, we wouldn't need to change the > file format. Hi, Jose, When do you plan to release beta 3? I can modify Jurgen's patch later today 1. add

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
José Matos wrote: > These two issues are orthogonal, if there is a file format change we honour > it even if it is inside the same development series. :-) You're right (and Bo already convinced me in PM). Jürgen

Re: [patch] insetlisting/caption

2007-05-14 Thread José Matos
On Monday 14 May 2007 19:05:21 Bo Peng wrote: > On 5/14/07, José Matos <[EMAIL PROTECTED]> wrote: > > On Monday 14 May 2007 15:02:07 Jürgen Spitzmüller wrote: > > > If we'd put this in before the next beta, we wouldn't need to change > > > the file format. > > Hi, Jose, > > When do you plan to

Re: [patch] insetlisting/caption

2007-05-14 Thread Jürgen Spitzmüller
Bo Peng wrote: > I can modify Jurgen's patch later today Bo, please also include this patch (a bugfix and a semantic correction). Jürgen Index: src/frontends/qt4/QListings.cpp === --- src/frontends/qt4/QListings.cpp (Revision 18312)

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
Bo, please also include this patch (a bugfix and a semantic correction). Got it. Thanks. Bo

Re: [patch] insetlisting/caption

2007-05-14 Thread Bo Peng
If we'd put this in before the next beta, we wouldn't need to change the file format. I have submitted your patch with Include dialog changes. Please test. lyx2lyx changes will be added soon. Now, it is again qt experts' turn to fix the include dialog. WHY the hell the editboxes are much