Re: 10188: change voids to bools or use exceptions?

2016-09-02 Thread Scott Kostyshak
On Fri, Sep 02, 2016 at 06:28:45PM -0400, Scott Kostyshak wrote: > On Thu, Sep 01, 2016 at 04:15:39PM -0400, Scott Kostyshak wrote: > > On Thu, Sep 01, 2016 at 12:48:23AM -0400, Richard Heck wrote: > > > On 08/31/2016 05:28 PM, Scott Kostyshak wrote: > > > > On Wed, Aug 31, 2016 at 10:08:35PM

Re: 10188: change voids to bools or use exceptions?

2016-09-02 Thread Scott Kostyshak
On Thu, Sep 01, 2016 at 04:15:39PM -0400, Scott Kostyshak wrote: > On Thu, Sep 01, 2016 at 12:48:23AM -0400, Richard Heck wrote: > > On 08/31/2016 05:28 PM, Scott Kostyshak wrote: > > > On Wed, Aug 31, 2016 at 10:08:35PM +0100, Guillaume Munch wrote: > > > > > >> Sounds good to me > > >> (and if

Re: 10188: change voids to bools or use exceptions?

2016-09-01 Thread Scott Kostyshak
On Thu, Sep 01, 2016 at 12:48:23AM -0400, Richard Heck wrote: > On 08/31/2016 05:28 PM, Scott Kostyshak wrote: > > On Wed, Aug 31, 2016 at 10:08:35PM +0100, Guillaume Munch wrote: > > > >> Sounds good to me > >> (and if there are caveats I am not aware of regarding > >> exceptions in LyX, I would

Re: 10188: change voids to bools or use exceptions?

2016-08-31 Thread Richard Heck
On 08/31/2016 05:28 PM, Scott Kostyshak wrote: > On Wed, Aug 31, 2016 at 10:08:35PM +0100, Guillaume Munch wrote: > >> Sounds good to me >> (and if there are caveats I am not aware of regarding >> exceptions in LyX, I would be curious to know) > I have occassionally seen comments that suggest

Re: 10188: change voids to bools or use exceptions?

2016-08-31 Thread Scott Kostyshak
On Wed, Aug 31, 2016 at 10:08:35PM +0100, Guillaume Munch wrote: > Sounds good to me > (and if there are caveats I am not aware of regarding > exceptions in LyX, I would be curious to know) I have occassionally seen comments that suggest exceptions should be avoided, for example here [1]. >

Re: 10188: change voids to bools or use exceptions?

2016-08-31 Thread Guillaume Munch
Le 31/08/2016 à 17:55, Scott Kostyshak a écrit : On Wed, Aug 31, 2016 at 12:24:32PM -0400, Richard Heck wrote: On 08/31/2016 12:16 PM, Scott Kostyshak wrote: I'm trying to make a patch for #10188, which has to do with the fact that in some cases LyX GUI gives an error but lyx -e does not exit

Re: 10188: change voids to bools or use exceptions?

2016-08-31 Thread Scott Kostyshak
On Wed, Aug 31, 2016 at 12:24:32PM -0400, Richard Heck wrote: > On 08/31/2016 12:16 PM, Scott Kostyshak wrote: > > I'm trying to make a patch for #10188, which has to do with the fact > > that in some cases LyX GUI gives an error but lyx -e does not exit with > > non-zero exit code. At first it

Re: 10188: change voids to bools or use exceptions?

2016-08-31 Thread Richard Heck
On 08/31/2016 12:16 PM, Scott Kostyshak wrote: > I'm trying to make a patch for #10188, which has to do with the fact > that in some cases LyX GUI gives an error but lyx -e does not exit with > non-zero exit code. At first it seemed more reasonable to change the > latex() method to return a bool

10188: change voids to bools or use exceptions?

2016-08-31 Thread Scott Kostyshak
I'm trying to make a patch for #10188, which has to do with the fact that in some cases LyX GUI gives an error but lyx -e does not exit with non-zero exit code. At first it seemed more reasonable to change the latex() method to return a bool indicating if exporting to LaTeX had an error. I started