Re: Graphics path with :

2005-06-06 Thread Andre Poenitz
On Tue, May 31, 2005 at 11:12:26AM +0200, Jean-Marc Lasgouttes wrote:
  Angus == Angus Leeming [EMAIL PROTECTED] writes:
 
 Angus Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and
 Angus http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex,
 Angus I don't see why a ':' in a file name won't work, but you're the
 Angus one using this stuff...
 
 I guess ':' is a problem in a windows file name if it is not the drive
 separator.

'Problem' is the wrong word. They serve a purpose IIRC. Try writing and
reading to a.txt:1.

Andre'


Re: Graphics path with ":"

2005-06-06 Thread Andre Poenitz
On Tue, May 31, 2005 at 11:12:26AM +0200, Jean-Marc Lasgouttes wrote:
> > "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
> 
> Angus> Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and
> Angus> http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex,
> Angus> I don't see why a ':' in a file name won't work, but you're the
> Angus> one using this stuff...
> 
> I guess ':' is a problem in a windows file name if it is not the drive
> separator.

'Problem' is the wrong word. They serve a purpose IIRC. Try writing and
reading to a.txt:1.

Andre'


Re: Graphics path with :

2005-05-31 Thread Angus Leeming
Michael Schmitt wrote:

 Angus,
 
 I tried to insert a graphics which is located in directory
 C:\blabla\blabla. However, LyX 1.3.6cvs complains about the path
 containing invalid character :. Didn't this work before?

In src/frontends/controllers/helper_funcs.C, try removing the ':' from 

string const get_invalid_chars_latex()
{
string invalid_chars(#$%{}()[]:\^);
if (!lyxrc.tex_allows_spaces)
invalid_chars += ' ';
return invalid_chars;
}

Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and 
http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex, I 
don't see why a ':' in a file name won't work, but you're the one using 
this stuff...

Please report back if LaTeX is happy.

-- 
Angus



Re: Graphics path with :

2005-05-31 Thread Jean-Marc Lasgouttes
 Angus == Angus Leeming [EMAIL PROTECTED] writes:

Angus Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and
Angus http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex,
Angus I don't see why a ':' in a file name won't work, but you're the
Angus one using this stuff...

I guess ':' is a problem in a windows file name if it is not the drive
separator.

JMarc


Re: Graphics path with :

2005-05-31 Thread Angus Leeming
Jean-Marc Lasgouttes wrote:
 Angus Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and
 Angus http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex,
 Angus I don't see why a ':' in a file name won't work, but you're the
 Angus one using this stuff...
 
 I guess ':' is a problem in a windows file name if it is not the drive
 separator.

Not from a LaTeX point of view. The OS will complain that such a file name 
is illegal and that the file can't exist. I don't think that we need to do 
anything special to handle such situations.

One thing that I have noticed (not a bug, but an inconsistency) is that in 
the Preferences dialog, the Paths pane displays all paths in UNIX style. 
This looks a little odd because at the bottom of the list is the 
prepend_path variable which is displayed as C:\foo\bar;C:\bar\baz.

Do you think that we should pass the other paths through 
(in,ex}ternal_path() ?

-- 
Angus



Re: Graphics path with :

2005-05-31 Thread Jean-Marc Lasgouttes
 Angus == Angus Leeming [EMAIL PROTECTED] writes:

Angus One thing that I have noticed (not a bug, but an inconsistency)
Angus is that in the Preferences dialog, the Paths pane displays all
Angus paths in UNIX style. This looks a little odd because at the
Angus bottom of the list is the prepend_path variable which is
Angus displayed as C:\foo\bar;C:\bar\baz.

Angus Do you think that we should pass the other paths through
Angus (in,ex}ternal_path() ?

We should probably. But in which form should we store them?

JMarc


Re: Graphics path with :

2005-05-31 Thread Angus Leeming
Jean-Marc Lasgouttes wrote:
 Angus One thing that I have noticed (not a bug, but an inconsistency)
 Angus is that in the Preferences dialog, the Paths pane displays all
 Angus paths in UNIX style. This looks a little odd because at the
 Angus bottom of the list is the prepend_path variable which is
 Angus displayed as C:\foo\bar;C:\bar\baz.
 
 Angus Do you think that we should pass the other paths through
 Angus (in,ex}ternal_path() ?
 
 We should probably. But in which form should we store them?

lyxrc.defaults/preferences: external_path. Convert to internal_path in 
lyxrc::read() and to external_path in lyxrc::write().

-- 
Angus



Re: Graphics path with :

2005-05-31 Thread Michael Schmitt

Angus Leeming wrote:

In src/frontends/controllers/helper_funcs.C, try removing the ':' from 


Please report back if LaTeX is happy.
 


LaTeX is happy and I am happy, too :-)

What astonishes me is the fact that LyX 1.4 works without a patch. Maybe 
it converts paths before the character check...


Regards, Michael



Re: Graphics path with :

2005-05-31 Thread Angus Leeming

Michael Schmitt wrote:

Angus Leeming wrote:


In src/frontends/controllers/helper_funcs.C, try removing the ':' from
Please report back if LaTeX is happy.
 


LaTeX is happy and I am happy, too :-)


Then I'll commit the patch... Done.

What astonishes me is the fact that LyX 1.4 works without a patch. Maybe 
it converts paths before the character check...


Perhaps you aren't looking hard enough. The check is in the input widget in 
1.4.x. The first time you input an invalid file name you'll get a dialog 
popping up to tell you so, but thereafter it won't. Instead, the input 
widget's label should go red and the dialog OK,Apply buttons will be disabled.


Angus



Re: Graphics path with ":"

2005-05-31 Thread Angus Leeming
Michael Schmitt wrote:

> Angus,
> 
> I tried to insert a graphics which is located in directory
> C:\blabla\blabla. However, LyX 1.3.6cvs complains about the path
> containing invalid character ":". Didn't this work before?

In src/frontends/controllers/helper_funcs.C, try removing the ':' from 

string const get_invalid_chars_latex()
{
string invalid_chars("#$%{}()[]:\"^");
if (!lyxrc.tex_allows_spaces)
invalid_chars += ' ';
return invalid_chars;
}

Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and 
http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex, I 
don't see why a ':' in a file name won't work, but you're the one using 
this stuff...

Please report back if LaTeX is happy.

-- 
Angus



Re: Graphics path with ":"

2005-05-31 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:

Angus> Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and
Angus> http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex,
Angus> I don't see why a ':' in a file name won't work, but you're the
Angus> one using this stuff...

I guess ':' is a problem in a windows file name if it is not the drive
separator.

JMarc


Re: Graphics path with ":"

2005-05-31 Thread Angus Leeming
Jean-Marc Lasgouttes wrote:
> Angus> Reading http://wiki.lyx.org/LaTeX/FilesWithSpecialChars and
> Angus> http://wiki.lyx.org/uploads/LaTeX/FilesWithSpecialChars/filenames.tex,
> Angus> I don't see why a ':' in a file name won't work, but you're the
> Angus> one using this stuff...
> 
> I guess ':' is a problem in a windows file name if it is not the drive
> separator.

Not from a LaTeX point of view. The OS will complain that such a file name 
is illegal and that the file can't exist. I don't think that we need to do 
anything special to handle such situations.

One thing that I have noticed (not a bug, but an inconsistency) is that in 
the Preferences dialog, the Paths pane displays all paths in UNIX style. 
This looks a little odd because at the bottom of the list is the 
"prepend_path" variable which is displayed as "C:\foo\bar;C:\bar\baz".

Do you think that we should pass the other paths through 
(in,ex}ternal_path() ?

-- 
Angus



Re: Graphics path with ":"

2005-05-31 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:

Angus> One thing that I have noticed (not a bug, but an inconsistency)
Angus> is that in the Preferences dialog, the Paths pane displays all
Angus> paths in UNIX style. This looks a little odd because at the
Angus> bottom of the list is the "prepend_path" variable which is
Angus> displayed as "C:\foo\bar;C:\bar\baz".

Angus> Do you think that we should pass the other paths through
Angus> (in,ex}ternal_path() ?

We should probably. But in which form should we store them?

JMarc


Re: Graphics path with ":"

2005-05-31 Thread Angus Leeming
Jean-Marc Lasgouttes wrote:
> Angus> One thing that I have noticed (not a bug, but an inconsistency)
> Angus> is that in the Preferences dialog, the Paths pane displays all
> Angus> paths in UNIX style. This looks a little odd because at the
> Angus> bottom of the list is the "prepend_path" variable which is
> Angus> displayed as "C:\foo\bar;C:\bar\baz".
> 
> Angus> Do you think that we should pass the other paths through
> Angus> (in,ex}ternal_path() ?
> 
> We should probably. But in which form should we store them?

lyxrc.defaults/preferences: external_path. Convert to internal_path in 
lyxrc::read() and to external_path in lyxrc::write().

-- 
Angus



Re: Graphics path with ":"

2005-05-31 Thread Michael Schmitt

Angus Leeming wrote:

In src/frontends/controllers/helper_funcs.C, try removing the ':' from 


Please report back if LaTeX is happy.
 


LaTeX is happy and I am happy, too :-)

What astonishes me is the fact that LyX 1.4 works without a patch. Maybe 
it converts paths before the character check...


Regards, Michael



Re: Graphics path with ":"

2005-05-31 Thread Angus Leeming

Michael Schmitt wrote:

Angus Leeming wrote:


In src/frontends/controllers/helper_funcs.C, try removing the ':' from
Please report back if LaTeX is happy.
 


LaTeX is happy and I am happy, too :-)


Then I'll commit the patch... Done.

What astonishes me is the fact that LyX 1.4 works without a patch. Maybe 
it converts paths before the character check...


Perhaps you aren't looking hard enough. The check is in the input widget in 
1.4.x. The first time you input an invalid file name you'll get a dialog 
popping up to tell you so, but thereafter it won't. Instead, the input 
widget's label should go red and the dialog OK,Apply buttons will be disabled.


Angus



Graphics path with :

2005-05-30 Thread Michael Schmitt

Angus,

I tried to insert a graphics which is located in directory 
C:\blabla\blabla. However, LyX 1.3.6cvs complains about the path 
containing invalid character :. Didn't this work before?


Regards, Michael




Graphics path with ":"

2005-05-30 Thread Michael Schmitt

Angus,

I tried to insert a graphics which is located in directory 
C:\blabla\blabla. However, LyX 1.3.6cvs complains about the path 
containing invalid character ":". Didn't this work before?


Regards, Michael