Re: Fwd: LyXAction, LyXFunc

2010-02-09 Thread Jean-Marc Lasgouttes
? LyXAction is the dictionary of known LyX functions, with their names and properties (together with FuncCode.h for the enums). LyXFunc contains the basic mechanism to execute these functions. It should soon become a variable-less class, and part of its contents will be moved somewhere else. This is in flux

Re: Fwd: LyXAction, LyXFunc

2010-02-09 Thread Jean-Marc Lasgouttes
ed to distinguish these two? LyXAction is the dictionary of known LyX functions, with their names and properties (together with FuncCode.h for the enums). LyXFunc contains the basic mechanism to execute these functions. It should soon become a variable-less class, and part of its contents w

Fwd: LyXAction, LyXFunc

2010-02-08 Thread Manoj Rajagopalan
Hi all, Re-sending. I am trying to understand the LyX flow of control. Appreciate any help. Apologies for the duplicate. Thanks, Manoj -- Forwarded Message -- Subject: LyXAction, LyXFunc Date: Sunday 07 February 2010 From: Manoj Rajagopalan rma...@umich.edu To: LyX

Fwd: LyXAction, LyXFunc

2010-02-08 Thread Manoj Rajagopalan
Hi all, Re-sending. I am trying to understand the LyX flow of control. Appreciate any help. Apologies for the duplicate. Thanks, Manoj -- Forwarded Message -- Subject: LyXAction, LyXFunc Date: Sunday 07 February 2010 From: Manoj Rajagopalan <rma...@umich.edu> T

LyXAction, LyXFunc

2010-02-07 Thread Manoj Rajagopalan
Hi all, These classes seem to be related. Could someone help me understand what each does and how they are related? IIUC, both are meant to be singletons which help with translating user inputs and commands into FuncRequest instances that cause the update of the document or LyX application

LyXAction, LyXFunc

2010-02-07 Thread Manoj Rajagopalan
Hi all, These classes seem to be related. Could someone help me understand what each does and how they are related? IIUC, both are meant to be singletons which help with translating user inputs and commands into FuncRequest instances that cause the update of the document or LyX application

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
sanda wrote: Author: sanda Date: Tue Jan 20 15:51:18 2009 New Revision: 28257 URL: http://www.lyx.org/trac/changeset/28257 Log: Backport Pavel, can we please return to the practice of posting branch-patches to the list before committing? I really like to understand the changes to branch.

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Pavel Sanda
Jürgen Spitzmüller wrote: sanda wrote: Author: sanda Date: Tue Jan 20 15:51:18 2009 New Revision: 28257 URL: http://www.lyx.org/trac/changeset/28257 Log: Backport Pavel, can we please return to the practice of posting branch-patches to the list before committing? I really like

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
Pavel Sanda wrote: sorry, shoould i revert? No. But could you try to explain in one or two words what the change does? Jürgen

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Pavel Sanda
Jürgen Spitzmüller wrote: Pavel Sanda wrote: sorry, shoould i revert? No. But could you try to explain in one or two words what the change does? i discovered this glitch while backporting fix for 5389. 1. set new window for each opened file in preferences 2. new file (window 1) 3. open file

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
Pavel Sanda wrote: i discovered this glitch while backporting fix for 5389. 1. set new window for each opened file in preferences 2. new file (window 1) 3. open file registered under rcs (window 2) 4. checkout for edit, type something 5. check-in - question for saving the file - yes - dialog

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Pavel Sanda
Jürgen Spitzmüller wrote: I see. Do we need to check for lyx_view_ != 0 at this place, as we do otherwhere? no, it has been checked before. pavel

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
Pavel Sanda wrote: I see. Do we need to check for lyx_view_ != 0 at this place, as we do otherwhere? no, it has been checked before. OK. Thanks for the explanation. Jürgen

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
sanda wrote: > Author: sanda > Date: Tue Jan 20 15:51:18 2009 > New Revision: 28257 > > URL: http://www.lyx.org/trac/changeset/28257 > Log: > Backport Pavel, can we please return to the practice of posting branch-patches to the list before committing? I really like to understand the changes to

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > sanda wrote: > > Author: sanda > > Date: Tue Jan 20 15:51:18 2009 > > New Revision: 28257 > > > > URL: http://www.lyx.org/trac/changeset/28257 > > Log: > > Backport > > Pavel, can we please return to the practice of posting branch-patches to the > list before

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > sorry, shoould i revert? No. But could you try to explain in one or two words what the change does? Jürgen

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > Pavel Sanda wrote: > > sorry, shoould i revert? > > No. But could you try to explain in one or two words what the change does? i discovered this glitch while backporting fix for 5389. 1. set new window for each opened file in preferences 2. new file (window 1) 3. open

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i discovered this glitch while backporting fix for 5389. > 1. set new window for each opened file in preferences > 2. new file (window 1) > 3. open file registered under rcs (window 2) > 4. checkout for edit, type something > 5. check-in -> question for saving the file -> yes

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Pavel Sanda
Jürgen Spitzmüller wrote: > I see. Do we need to check for lyx_view_ != 0 at this place, as we do > otherwhere? no, it has been checked before. pavel

Re: [Cvslog] r28257 - in /lyx-devel/branches/BRANCH_1_6_X: src/LyXFunc...

2009-01-20 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > I see. Do we need to check for lyx_view_ != 0 at this place, as we do > > otherwhere? > > no, it has been checked before. OK. Thanks for the explanation. Jürgen

Re: [Patch/RFC] How to use LyXFunc and FuncRequest

2006-09-25 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak Right now there is only one LyXView for one LyXFunc. There Abdelrazak are two way forward for the multiple LyXView problem. Abdelrazak 1) Application maintains a map of LyXFunc indexed by the Abdelrazak LyXView ID as given

Re: [Patch/RFC] How to use LyXFunc and FuncRequest

2006-09-25 Thread Jean-Marc Lasgouttes
>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Right now there is only one LyXView for one LyXFunc. There Abdelrazak> are two way forward for the multiple LyXView problem. Abdelrazak> 1) Application maintains a map of LyXFu

[Patch/RFC] How to use LyXFunc and FuncRequest

2006-09-22 Thread Abdelrazak Younes
Hello, This patch replaces BufferView-LyXView-getLyXFunc() with theApp-lyxFunc(). I am not sure yet how to proceed with the LyXView/LyXFunc interaction and the dispatch machinery. Right now there is only one LyXView for one LyXFunc. There are two way forward for the multiple LyXView

[Patch/RFC] How to use LyXFunc and FuncRequest

2006-09-22 Thread Abdelrazak Younes
Hello, This patch replaces BufferView->LyXView->getLyXFunc() with theApp->lyxFunc(). I am not sure yet how to proceed with the LyXView/LyXFunc interaction and the dispatch machinery. Right now there is only one LyXView for one LyXFunc. There are two way forward for the multipl

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Asger Ottar Alstrup
Abdelrazak Younes wrote: Are you sure you cannot come [to denmmark]? I'd like to but it will be difficult. I think going to Denmark will by far be the best way to solve the issues. In the history of LyX, there has been a tradition of long and intense discussions about this and that. They

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Abdelrazak Younes
Asger Ottar Alstrup wrote: Abdelrazak Younes wrote: Are you sure you cannot come [to denmmark]? I'd like to but it will be difficult. I think going to Denmark will by far be the best way to solve the issues. In the history of LyX, there has been a tradition of long and intense discussions

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Jean-Marc Lasgouttes
Abdelrazak == Abdelrazak Younes [EMAIL PROTECTED] writes: Abdelrazak I am sure he his but that is not the problem. We should be Abdelrazak able to work out the frictions without meeting face to Abdelrazak face. It is not always possible. JMarc

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Helge Hafting
Abdelrazak Younes wrote: I am sure he his but that is not the problem. We should be able to work out the frictions without meeting face to face. The problem here is that humans interface better face to face. E-mail is ok for conveying ideas, but not emotions. Or an impression of how

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Andre Poenitz
On Mon, Sep 18, 2006 at 12:19:55PM +0200, Abdelrazak Younes wrote: Asger Ottar Alstrup wrote: Abdelrazak Younes wrote: Are you sure you cannot come [to denmmark]? I'd like to but it will be difficult. I think going to Denmark will by far be the best way to solve the issues. In the

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Andre Poenitz
On Sun, Sep 17, 2006 at 10:19:25PM +0200, Abdelrazak Younes wrote: A pity that you cannot come to denmark, we should get drunk (at least I) and then we could go outside and fight it out. You'd loose, I've been practising French boxing in my youth. Are you sure you cannot come? I'd like

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Asger Ottar Alstrup
Abdelrazak Younes wrote: Are you sure you cannot come [to denmmark]? I'd like to but it will be difficult. I think going to Denmark will by far be the best way to solve the issues. In the history of LyX, there has been a tradition of long and intense discussions about this and that. They

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Abdelrazak Younes
Asger Ottar Alstrup wrote: Abdelrazak Younes wrote: Are you sure you cannot come [to denmmark]? I'd like to but it will be difficult. I think going to Denmark will by far be the best way to solve the issues. In the history of LyX, there has been a tradition of long and intense discussions

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> I am sure he his but that is not the problem. We should be Abdelrazak> able to work out the frictions without meeting face to Abdelrazak> face. It is not always possible. JMarc

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Helge Hafting
Abdelrazak Younes wrote: I am sure he his but that is not the problem. We should be able to work out the frictions without meeting face to face. The problem here is that humans interface better face to face. E-mail is ok for conveying ideas, but not emotions. Or an impression of how

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Andre Poenitz
On Mon, Sep 18, 2006 at 12:19:55PM +0200, Abdelrazak Younes wrote: > Asger Ottar Alstrup wrote: > >Abdelrazak Younes wrote: > >>>Are you sure you cannot come [to denmmark]? > >> > >>I'd like to but it will be difficult. > > > >I think going to Denmark will by far be the best way to solve the

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-18 Thread Andre Poenitz
On Sun, Sep 17, 2006 at 10:19:25PM +0200, Abdelrazak Younes wrote: > >A pity that you cannot come to denmark, we should get drunk (at least > >I) and then we could go outside and fight it out. > > You'd loose, I've been practising French boxing in my youth. > > >Are you sure you > >cannot come?

[PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
(BufferView * bv) +bool LyXFunc::ensureBufferClean(BufferView * bv) { Buffer buf = *bv-buffer(); if (buf.isClean()) @@ -668,12 +666,14 @@ _(Cancel)); if (ret == 0) - bv-owner()-dispatch(FuncRequest(LFUN_BUFFER_WRITE

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | This avoids the bv-owner()-dispatch() redirection. | | Will commit soon. I am not confident in its correctness. -- Lgb

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes [EMAIL PROTECTED] writes: | This avoids the bv-owner()-dispatch() redirection. | | Will commit soon. I am not confident in its correctness. I am not confident in your empty argument. Abdel.

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | Lars Gullik Bjønnes wrote: | Abdelrazak Younes [EMAIL PROTECTED] writes: | | This avoids the bv-owner()-dispatch() redirection. | | | Will commit soon. | I am not confident in its correctness. | | I am not confident in your empty argument. We

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
in your empty argument. We have had multitudes of errors becuase of functions in the wrong instance fo the class have been called. There is only one LyXFunc for one LyXView, how in hell could that be a wrong instance if there is only one unique instance? The onus is on _you_ to show

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
am not confident in its correctness. | | | I am not confident in your empty argument. | We have had multitudes of errors becuase of functions in the wrong | instance fo the class have been called. | | There is only one LyXFunc for one LyXView, how in hell could that be a | wrong instance

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
. | | | | Will commit soon. | | I am not confident in its correctness. | | | I am not confident in your empty argument. | We have had multitudes of errors becuase of functions in the wrong | instance fo the class have been called. | | There is only one LyXFunc for one LyXView, how in hell could

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | Hell? It is not very bad lamguage if you ask me. You have been using | worse word against me. Check your archive. Then I am sorry, I'll try to clean up my language and henceforth only use the most civil language in my accusations. | | The onus is

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes [EMAIL PROTECTED] writes: | Hell? It is not very bad lamguage if you ask me. You have been using | worse word against me. Check your archive. Then I am sorry, I'll try to clean up my language and henceforth only use the most civil language in my

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | I have to change and you are right. Of course that's how it is. | | Are you ironic here or serious? I was pretty serious. A bit of both I guess. | A pity that you cannot come to denmark, we should get drunk (at least | I) and then we could go

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Edwin Leuven
Abdelrazak Younes wrote: You'd loose, I've been practising French boxing in my youth. like zidane?! lars, be careful!! ;-)

[PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
rClean(BufferView * bv) +bool LyXFunc::ensureBufferClean(BufferView * bv) { Buffer & buf = *bv->buffer(); if (buf.isClean()) @@ -668,12 +666,14 @@ _("")); if (ret == 0) - bv->owner()->dispatch(

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | This avoids the bv->owner()->dispatch() redirection. | | Will commit soon. I am not confident in its correctness. -- Lgb

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | This avoids the bv->owner()->dispatch() redirection. | | Will commit soon. I am not confident in its correctness. I am not confident in your empty argument. Abdel.

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: | > Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > | This avoids the bv->owner()->dispatch() redirection. | > | | Will commit soon. | > I am not confident in its correctness. | | I am not confident in your empty

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
in its correctness. | | I am not confident in your empty argument. We have had multitudes of errors becuase of functions in the wrong instance fo the class have been called. There is only one LyXFunc for one LyXView, how in hell could that be a wrong instance if there is only one unique instance?

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
bv->owner()->dispatch() redirection. | > | > | | Will commit soon. | > | > I am not confident in its correctness. | > | | I am not confident in your empty argument. | > We have had multitudes of errors becuase of functions in the wrong | > instance fo the class have been called. |

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
his avoids the bv->owner()->dispatch() redirection. | > | > | | Will commit soon. | > | > I am not confident in its correctness. | > | | I am not confident in your empty argument. | > We have had multitudes of errors becuase of functions in the wrong | > instance fo the class h

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | "Hell"? It is not very bad lamguage if you ask me. You have been using | worse word against me. Check your archive. Then I am sorry, I'll try to clean up my language and henceforth only use the most civil language in my accusations. | > | > The

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Abdelrazak Younes
Lars Gullik Bjønnes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: | "Hell"? It is not very bad lamguage if you ask me. You have been using | worse word against me. Check your archive. Then I am sorry, I'll try to clean up my language and henceforth only use the most civil language in my

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | > I have to change and you are right. Of course that's how it is. | | Are you ironic here or serious? I was pretty serious. A bit of both I guess. | > A pity that you cannot come to denmark, we should get drunk (at least | > I) and then we could

Re: [PATCH] make ensureBufferClean a private member of LyXFunc

2006-09-17 Thread Edwin Leuven
Abdelrazak Younes wrote: You'd loose, I've been practising French boxing in my youth. like zidane?! lars, be careful!! ;-)

Question about potential bug in LyXFunc

2006-09-10 Thread Abdelrazak Younes
While re-compiling LyX, I noticed the following warning: ..\..\..\src\lyxfunc.C(218) : warning C4244: 'initializing' : conversion from 'lyx::char_type' to 'char', possible loss of data in void LyXFunc::handleKeyFunc(kb_action action) { char c = encoded_last_key; The problem

Re: Question about potential bug in LyXFunc

2006-09-10 Thread Lars Gullik Bjønnes
Abdelrazak Younes [EMAIL PROTECTED] writes: | While re-compiling LyX, I noticed the following warning: | | ..\..\..\src\lyxfunc.C(218) : warning C4244: 'initializing' : | conversion from 'lyx::char_type' to 'char', possible loss of data | | in | | void LyXFunc::handleKeyFunc(kb_action action

Question about potential bug in LyXFunc

2006-09-10 Thread Abdelrazak Younes
While re-compiling LyX, I noticed the following warning: ..\..\..\src\lyxfunc.C(218) : warning C4244: 'initializing' : conversion from 'lyx::char_type' to 'char', possible loss of data in void LyXFunc::handleKeyFunc(kb_action action) { char c = encoded_last_key; The problem

Re: Question about potential bug in LyXFunc

2006-09-10 Thread Lars Gullik Bjønnes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: | While re-compiling LyX, I noticed the following warning: | | ..\..\..\src\lyxfunc.C(218) : warning C4244: 'initializing' : | conversion from 'lyx::char_type' to 'char', possible loss of data | | in | | void LyXFunc::handleKeyFunc(kb_

[patch] lyxfunc

2003-11-05 Thread Alfredo Braunstein
Nov 2003 09:50:10 - @@ -1404,14 +1404,9 @@ void LyXFunc::dispatch(FuncRequest const found. endl; } - if (view()-theLockingInset()) - view()-unlockInset(view()-theLockingInset

Re: [patch] lyxfunc

2003-11-05 Thread Alfredo Braunstein
Alfredo Braunstein wrote: I envisage we will use this a lot: par.text() ? par.text() : view()-text; and it seems a little dummy to me. Shouldn't we have par.text(bv) anyway, thinking about multiple views? Can I remove ParIterator::text() and substitute it with ParIterator::text(BufferView

Re: [patch] lyxfunc

2003-11-05 Thread Andre Poenitz
On Wed, Nov 05, 2003 at 11:06:19AM +0100, Alfredo Braunstein wrote: Alfredo Braunstein wrote: I envisage we will use this a lot: par.text() ? par.text() : view()-text; and it seems a little dummy to me. Shouldn't we have par.text(bv) anyway, thinking about multiple views? Can I

[patch] lyxfunc

2003-11-05 Thread Alfredo Braunstein
++ lyxfunc.C 5 Nov 2003 09:50:10 - @@ -1404,14 +1404,9 @@ void LyXFunc::dispatch(FuncRequest const << " found." << endl; } - if (view()->theLockingInset()) - view()

Re: [patch] lyxfunc

2003-11-05 Thread Alfredo Braunstein
Alfredo Braunstein wrote: I envisage we will use this a lot: > par.text() ? par.text() : view()->text; and it seems a little dummy to me. Shouldn't we have par.text(bv) anyway, thinking about multiple views? Can I remove ParIterator::text() and substitute it with ParIterator::text(BufferView

Re: [patch] lyxfunc

2003-11-05 Thread Andre Poenitz
On Wed, Nov 05, 2003 at 11:06:19AM +0100, Alfredo Braunstein wrote: > Alfredo Braunstein wrote: > > I envisage we will use this a lot: > > > par.text() ? par.text() : view()->text; > > and it seems a little dummy to me. > > Shouldn't we have par.text(bv) anyway, thinking about multiple views?

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
On Thu, Aug 07, 2003 at 02:04:18PM +0200, Lars Gullik Bjønnes wrote: Andre Poenitz [EMAIL PROTECTED] writes: | Duplicated and/or dead code. I do not agree with how you remove the else It's still in now. it is not longer obvious that the cases are exclusive... I have to read each block

[patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfunc.C,v retrieving revision 1.475 diff -u -p -r1.475 lyxfunc.C --- lyxfunc.C 4 Aug 2003 09:06:31 - 1.475 +++ lyxfunc.C 7 Aug 2003 09:42:01 - @@ -859,8 +859,7 @@ void LyXFunc::dispatch(FuncRequest const int

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread John Levon
On Thu, Aug 07, 2003 at 01:56:41PM +0200, Andre Poenitz wrote: But from a first glance it did not crash more often with this change than without... Ok I'll split it into two and let you play around with the LyXFunc.C part... I'd rather know what this code is supposed to do. regards

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
=== RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfunc.C,v retrieving revision 1.475 diff -u -p -r1.475 lyxfunc.C --- lyxfunc.C 4 Aug 2003 09:06:31 - 1.475 +++ lyxfunc.C 7 Aug 2003 09:42:01 - @@ -876,32 +875,26 @@ void LyXFunc

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread John Levon
On Thu, Aug 07, 2003 at 01:44:49PM +0200, Andre Poenitz wrote: Duplicated and/or dead code. Have you given this some *proper* testing with undo ? In particular in various positions of tables etc. ? john

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
On Thu, Aug 07, 2003 at 03:20:19PM +0200, Lars Gullik Bjønnes wrote: Andre Poenitz [EMAIL PROTECTED] writes: | On Thu, Aug 07, 2003 at 02:04:18PM +0200, Lars Gullik Bjønnes wrote: Andre Poenitz [EMAIL PROTECTED] writes: | Duplicated and/or dead code. I do not agree with how you

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
On Thu, Aug 07, 2003 at 02:04:18PM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Duplicated and/or dead code. > > I do not agree with how you remove the else It's still in now. > it is not longer obvious that the cases are exclusive... I have to > read

[patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
file: /usr/local/lyx/cvsroot/lyx-devel/src/lyxfunc.C,v retrieving revision 1.475 diff -u -p -r1.475 lyxfunc.C --- lyxfunc.C 4 Aug 2003 09:06:31 - 1.475 +++ lyxfunc.C 7 Aug 2003 09:42:01 - @@ -859,8 +859,7 @@ void LyXFunc::dispatch(FuncRequest const int

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread John Levon
On Thu, Aug 07, 2003 at 01:56:41PM +0200, Andre Poenitz wrote: > But from a first glance it did not crash more often with this change > than without... > > Ok I'll split it into two and let you play around with the LyXFunc.C > part... I'd rather know what this code is supposed to do.

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
32 +875,26 @@ void LyXFunc::dispatch(FuncRequest const goto exit_with_message; } - // Undo/Redo is a bit tricky for insets. - if (action == LFUN_UNDO) { -

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread John Levon
On Thu, Aug 07, 2003 at 01:44:49PM +0200, Andre Poenitz wrote: > Duplicated and/or dead code. Have you given this some *proper* testing with undo ? In particular in various positions of tables etc. ? john

Re: [patch] merge some LFUN handlers from InsetText, LyXText and LyXFunc

2003-08-14 Thread Andre Poenitz
On Thu, Aug 07, 2003 at 03:20:19PM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Thu, Aug 07, 2003 at 02:04:18PM +0200, Lars Gullik Bjønnes wrote: > >> Andre Poenitz <[EMAIL PROTECTED]> writes: > >> > >> | Duplicated and/or dead code. > >> > >> I do not

LyXFunc::getStatus ?

2003-03-07 Thread Angus Leeming
I am happily removing stuff like: case LFUN_REF_INSERT: code = Inset::REF_CODE; break; Should I replace it with something like: case LFUN_DIALOG_SHOW_NEW_INSET: if (ev.argument == citation) code =

Re: LyXFunc::getStatus ?

2003-03-07 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus I am happily removing stuff like: case LFUN_REF_INSERT: code = Angus Inset::REF_CODE; break; Angus Should I replace it with something like: case Angus LFUN_DIALOG_SHOW_NEW_INSET: if (ev.argument == citation) code Angus = Inset::CITE_CODE;

Re: LyXFunc::getStatus ?

2003-03-07 Thread Andre Poenitz
On Fri, Mar 07, 2003 at 03:32:06PM +, Angus Leeming wrote: I am happily removing stuff like: case LFUN_REF_INSERT: code = Inset::REF_CODE; break; Should I replace it with something like: case LFUN_DIALOG_SHOW_NEW_INSET:

Re: LyXFunc::getStatus ?

2003-03-07 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Angus What does the function do? The idea is to be able to say whether it is legal to use LFUN_DIALOG_SHOW_NEW_INSET at some place. Therefore we need the relevant Inset::Code in order to call insetAllowed(code). So we want to get the code of the new inset from

LyXFunc::getStatus ?

2003-03-07 Thread Angus Leeming
I am happily removing stuff like: case LFUN_REF_INSERT: code = Inset::REF_CODE; break; Should I replace it with something like: case LFUN_DIALOG_SHOW_NEW_INSET: if (ev.argument == "citation") code =

Re: LyXFunc::getStatus ?

2003-03-07 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I am happily removing stuff like: case LFUN_REF_INSERT: code = Angus> Inset::REF_CODE; break; Angus> Should I replace it with something like: case Angus> LFUN_DIALOG_SHOW_NEW_INSET: if (ev.argument == "citation") code Angus> =

Re: LyXFunc::getStatus ?

2003-03-07 Thread Andre Poenitz
On Fri, Mar 07, 2003 at 03:32:06PM +, Angus Leeming wrote: > I am happily removing stuff like: > > case LFUN_REF_INSERT: > code = Inset::REF_CODE; > break; > > Should I replace it with something like: > case LFUN_DIALOG_SHOW_NEW_INSET: >

Re: LyXFunc::getStatus ?

2003-03-07 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> What does the function do? > > The idea is to be able to say whether it is legal to use > LFUN_DIALOG_SHOW_NEW_INSET at some place. Therefore we need the > relevant Inset::Code in order to call insetAllowed(code). So we want > to get the code of the new inset

LyXFunc/LyXAction

2002-08-16 Thread Angus Leeming
/wanted? Is their an implementation? Angus -- Forwarded Message -- Subject: LyXFunc/LyXAction Date: 13 Oct 2000 15:48:08 +0200 From: [EMAIL PROTECTED] (Lars Gullik Bjønnes) To: [EMAIL PROTECTED] We should make a way to ensure that LyXFunc are called with the correct number

Re: stream_cast and Re: LyXFunc/LyXAction

2002-08-16 Thread Angus Leeming
(123); This could easily be used for the FuncSlot. Lgb --- and I also found Allan's follow up -- Forwarded Message -- Subject: Re: stream_cast and Re: LyXFunc/LyXAction Date: Thu, 19 Oct 2000 16:49:54 +1000 (GMT+1000

Re: LyXFunc/LyXAction

2002-08-16 Thread Andre Poenitz
On Fri, Aug 16, 2002 at 06:26:35PM +0100, Angus Leeming wrote: -- Forwarded Message -- Subject: LyXFunc/LyXAction Date: 13 Oct 2000 15:48:08 +0200 From: [EMAIL PROTECTED] (Lars Gullik Bjønnes) To: [EMAIL PROTECTED] We should make a way to ensure that LyXFunc are called

Re: stream_cast and Re: LyXFunc/LyXAction

2002-08-16 Thread Andre Poenitz
On Fri, Aug 16, 2002 at 06:31:24PM +0100, Angus Leeming wrote: This sounds like xtl to me. Would FuncRequest not benefit from this? Overkill IMNSHO. _Please_ let's see how far we come using the int,int,button,string approach. unscrambling of stringifications... We certainly do not do much

LyXFunc/LyXAction

2002-08-16 Thread Angus Leeming
/wanted? Is their an implementation? Angus -- Forwarded Message -- Subject: LyXFunc/LyXAction Date: 13 Oct 2000 15:48:08 +0200 From: [EMAIL PROTECTED] (Lars Gullik Bjønnes) To: [EMAIL PROTECTED] We should make a way to ensure that LyXFunc are called with the correct number

Re: stream_cast<> and Re: LyXFunc/LyXAction

2002-08-16 Thread Angus Leeming
string: string a = stream_cast<string, int>(123); This could easily be used for the FuncSlot. Lgb --- and I also found Allan's follow up -- Forwarded Message -- Subject: Re: stream_cast<> and Re: LyXF

Re: LyXFunc/LyXAction

2002-08-16 Thread Andre Poenitz
On Fri, Aug 16, 2002 at 06:26:35PM +0100, Angus Leeming wrote: > -- Forwarded Message -- > > Subject: LyXFunc/LyXAction > Date: 13 Oct 2000 15:48:08 +0200 > From: [EMAIL PROTECTED] (Lars Gullik Bjønnes) > To: [EMAIL PROTECTED] > > We should make a wa

Re: stream_cast<> and Re: LyXFunc/LyXAction

2002-08-16 Thread Andre Poenitz
On Fri, Aug 16, 2002 at 06:31:24PM +0100, Angus Leeming wrote: > This sounds like xtl to me. Would FuncRequest not benefit from this? Overkill IMNSHO. _Please_ let's see how far we come using the int,int,button,string approach. > unscrambling of stringifications... We certainly do not do

Re: new lyxfunc

2001-01-16 Thread Lars Gullik Bjønnes
position to the lyxfunc could be | as simple as a vectorstring for each container (I presume the integers | are the positions in the menu and therefore small). I foresee only one small problem, dynamically generated pseudo funcs. They need a name. | The problem with ii) as I read it is O(n

Re: new lyxfunc

2001-01-16 Thread Andre Poenitz
| Note that the container mapping from menu position to the lyxfunc could be | as simple as a vectorstring for each container (I presume the integers | are the positions in the menu and therefore small). I foresee only one small problem, dynamically generated pseudo funcs. They need a name

Re: new lyxfunc

2001-01-16 Thread Dekel Tsur
I didn't follow the discussion, but I want to note that currently, the code in LyXFunc::Dispatch is duplicated in InsetText::LocalDispatch, which is bad. Are there plans for fixing this ?

Re: new lyxfunc

2001-01-16 Thread John Levon
On Tue, 16 Jan 2001, Dekel Tsur wrote: I didn't follow the discussion, but I want to note that currently, the code in LyXFunc::Dispatch is duplicated in InsetText::LocalDispatch, which is bad. Are there plans for fixing this ? Can someone explain exactly why we need Local Dispatch

  1   2   3   4   >