Re: Preference to disable input completion?

2020-12-04 Thread Jean-Marc Lasgouttes 

Le 04/12/2020 à 14:17, Pavel Sanda a écrit :

On Thu, Dec 03, 2020 at 07:09:12PM +0100, Jean-Marc Lasgouttes wrote:

* What is popular ?

lapinot: cat user-prefs/*/* | sed 's/^\*//'|grep -o '^\\[^ ]* ' |sort |uniq
-c|sort -k 1n

...

   5 \fullscreen_scrollbar
   5 \paragraph_markers
   6 \load_session
   6 \screen_font_roman
   6 \spellcheck_continuously
   9 \preview
  10 \screen_zoom
  10 \single_instance
  12 \user_email
  13 \screen_font_sizes
  13 \user_name
  19 \converter
  33 \set_color
  54 \format

Things we could look at for change of default:
single_instance
preview
spellcheck_continuously
load_session
... and others


Are the listed prefs coming with same argument (i.e. all found \single_instance have 
"false"?)


I have not looks at the data more seriously than that. These prefs mean 
that people have changed the default (which may be platform-dependant).



And what is in your opinion count required for change? >50% of users changing 
the default setting?


I have no number in  mind. I am just saying that we should look at them 
and see whether changing the default may be useful. Often, our defaults 
have been kept by laziness.


In other cases like screen_font_size, no value has actually been 
changed; there is a rounding issue in our tests as far as I can see. I 
would be very glad to remove this pref actually.


For your enjoyment, here are more details below (as you see I removed 
some not relevant prefs.


JMarc


lapinot: cat user-prefs/*/* | sed 's/^\*\|\r$//'|grep '^\\[^ ]* ' | grep 
-v '\\user\|set_color\|[\_]path'|sort |uniq -c|sort -k 1n|tail -30

  1 \serverpipe "\\.\pipe\lyxpipe"
  1 \spellchecker hunspell
  1 \ui_file "/usr/share/lyx/ui/default"
  1 \use_converter_needauth_forbidden false
  2 \autosave 60
  2 \completion_inline_text true
  2 \default_length_unit 6
  2 \forward_search_pdf "SumatraPDF -reuse-instance \"$$o\" 
-forward-search \"$$t\" $$n"

  2 \gui_language british
  2 \icon_set "classic"
  2 \kbmap true
  2 \preview off
  2 \screen_font_typewriter "Courier"
  2 \screen_zoom 130
  2 \screen_zoom 170
  2 \screen_zoom 200
  2 \scroll_below_document true
  2 \spellcheck_notes false
  2 \use_system_colors false
  3 \preview no_math
  3 \spellchecker enchant
  4 \cursor_width 2
  4 \default_otf_view_format dvi3
  4 \preview on
  5 \fullscreen_scrollbar false
  5 \paragraph_markers true
  6 \load_session true
  6 \spellcheck_continuously true
 10 \single_instance false
 13 \screen_font_sizes 5 7 8 9 10 12 14.4 17.26 20.74 24.88

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-04 Thread Pavel Sanda 
On Thu, Dec 03, 2020 at 07:09:12PM +0100, Jean-Marc Lasgouttes wrote:
> * What is popular ?
> 
> lapinot: cat user-prefs/*/* | sed 's/^\*//'|grep -o '^\\[^ ]* ' |sort |uniq
> -c|sort -k 1n
...
>   5 \fullscreen_scrollbar
>   5 \paragraph_markers
>   6 \load_session
>   6 \screen_font_roman
>   6 \spellcheck_continuously
>   9 \preview
>  10 \screen_zoom
>  10 \single_instance
>  12 \user_email
>  13 \screen_font_sizes
>  13 \user_name
>  19 \converter
>  33 \set_color
>  54 \format
> 
> Things we could look at for change of default:
> single_instance
> preview
> spellcheck_continuously
> load_session
> ... and others

Are the listed prefs coming with same argument (i.e. all found \single_instance 
have "false"?)
And what is in your opinion count required for change? >50% of users changing 
the default setting?

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-03 Thread Jean-Marc Lasgouttes 

Le 01/12/2020 à 19:53, Scott Kostyshak a écrit :

On Tue, Dec 01, 2020 at 05:29:33PM +0100, Jean-Marc Lasgouttes wrote:


Scott, I am not sure you still have this set of preference files contributed
by users.


Yes, I have them and double-checked that in my email asking for them I
asked users to remove any information they did not want made public so
that I can share them. They are attached.

They are organized by OS to consider the possibility of making default
preferences OS-dependent (which we already do in some cases).


Here are the basic stats first

* How many prefs files ?

lapinot: find user-prefs|wc -l
21

* What is popular ?

lapinot: cat user-prefs/*/* | sed 's/^\*//'|grep -o '^\\[^ ]* ' |sort 
|uniq -c|sort -k 1n

  1 \accept_compound
  1 \autocorrection_math
  1 \bind_file
  1 \completion_minlength
  1 \completion_popup_after_complete
  1 \completion_popup_delay
  1 \completion_popup_text
  1 \display_graphics
  1 \export_overwrite
  1 \forward_search_dvi
  1 \fullscreen_statusbar
  1 \index_command
  1 \kbmap_primary
  1 \language_package_selection
  1 \macro_edit_style
  1 \make_backup
  1 \open_buffers_in_tabs
  1 \plaintext_linelen
  1 \preview_scale_factor
  1 \screen_dpi
  1 \ui_file
  1 \use_converter_needauth_forbidden
  2 \completion_inline_text
  2 \default_length_unit
  2 \hunspelldir_path
  2 \icon_set
  2 \kbmap
  2 \num_lastfiles
  2 \scroll_below_document
  2 \spellcheck_notes
  2 \thesaurusdir_path
  2 \use_system_colors
  3 \autosave
  3 \backupdir_path
  3 \document_path
  3 \example_path
  3 \forward_search_pdf
  3 \path_prefix
  3 \serverpipe
  4 \cursor_width
  4 \default_otf_view_format
  4 \gui_language
  4 \screen_font_sans
  4 \screen_font_typewriter
  4 \spellchecker
  4 \template_path
  5 \fullscreen_scrollbar
  5 \paragraph_markers
  6 \load_session
  6 \screen_font_roman
  6 \spellcheck_continuously
  9 \preview
 10 \screen_zoom
 10 \single_instance
 12 \user_email
 13 \screen_font_sizes
 13 \user_name
 19 \converter
 33 \set_color
 54 \format

Things we could look at for change of default:
single_instance
preview
spellcheck_continuously
load_session
... and others

JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Richard Kimberly Heck 

On 12/1/20 11:29 AM, Jean-Marc Lasgouttes wrote:

Le 01/12/2020 à 16:44, Richard Kimberly Heck a écrit :

No, the forces of FUD and reaction managed to stop progress (again).


I don't think we reached a conclusion here. The proposal was to enable
it by default, but to set it to off for users migrating from 2.3.x who
haven't enabled it (via prefs2prefs). Patch attached again.


It is a compromise, but better than nothing.


I'll start a new thread to find a resolution of that issue.

I also agree that we need to sort out the completion stuff. I only use 
it in math, myself, so I don't have strong opinions. But I'm happy to 
listen and to help implement whatever we decide (especially prefs2prefs 
pieces, if needed).


Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Scott Kostyshak 
On Tue, Dec 01, 2020 at 05:29:33PM +0100, Jean-Marc Lasgouttes wrote:
> 
> Scott, I am not sure you still have this set of preference files contributed
> by users.

Yes, I have them and double-checked that in my email asking for them I
asked users to remove any information they did not want made public so
that I can share them. They are attached.

They are organized by OS to consider the possibility of making default
preferences OS-dependent (which we already do in some cases).

Scott


user-prefs.tar.gz
Description: application/gzip


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Pavel Sanda 
On Tue, Dec 01, 2020 at 10:24:55AM -0700, Joel Kulesza wrote:
> Interesting.  I'd not heard that distinction before???thanks for sharing it.

I think I just made it ;) But you can see these two opposing approaches at
play when some conflicting UI issue pops up here on the list. P
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Joel Kulesza 
On Tue, Dec 1, 2020 at 10:10 AM Pavel Sanda  wrote:

> On Tue, Dec 01, 2020 at 07:47:40AM -0700, Joel Kulesza wrote:
> > > Yep, that was the major point why we left continuous spellcheck off
> years
> > > back.
> > >
> > > Now it seems that you missed the new thread about continuous spellcheck
> > > from one month back where left wing of devs come up with the reasoning
> that
> > > many users won't get idea about existing spellcheck in lyx unless it's
> on
> > > by default.
> > >
> >
> > I've never been called left wing, and I'm pretty sure I don't qualify as
> > 'dev,' but this goes beyond reasoning.
>
> To state myself clearly by left wing position I meant the opinion that the
> users
> need someone to guide them, while the right wing opinion tends toward more
> raw
> ui experience when you are on your own.
> When you lean too much to the left there is a danger that power users will
> be
> annoyed by the helper functions (I guess that's what Maria called bloat),
> when
> you lean too much to the right you will make you program hostile to the
> average
> user base.
>

Interesting.  I'd not heard that distinction before—thanks for sharing it.
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Pavel Sanda 
On Tue, Dec 01, 2020 at 07:47:40AM -0700, Joel Kulesza wrote:
> > Yep, that was the major point why we left continuous spellcheck off years
> > back.
> >
> > Now it seems that you missed the new thread about continuous spellcheck
> > from one month back where left wing of devs come up with the reasoning that
> > many users won't get idea about existing spellcheck in lyx unless it's on
> > by default.
> >
> 
> I've never been called left wing, and I'm pretty sure I don't qualify as
> 'dev,' but this goes beyond reasoning. 

To state myself clearly by left wing position I meant the opinion that the users
need someone to guide them, while the right wing opinion tends toward more raw
ui experience when you are on your own.
When you lean too much to the left there is a danger that power users will be
annoyed by the helper functions (I guess that's what Maria called bloat), when
you lean too much to the right you will make you program hostile to the average
user base.

IIRC in the case of continuous spellcheck the initial decade old discussion was
that it's hard-to-find function for some newcomers vs irritating bloat for some 
oldschoolers. The resolution was to keep it off by default but add toolbar icon
for easy discoverability.
The current push was that toolbar icon is not enough and resolution was that
conservative users will be served by pref2pref machinery to keep it off, while
newcomers will have it on. Meaning that you need be both conservative and 
oldcomer 
to have it off by default now :)

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Pavel Sanda 
On Tue, Dec 01, 2020 at 02:23:57PM +0100, Jean-Marc Lasgouttes wrote:
> Le 01/12/2020 ?? 12:27, Pavel Sanda a écrit :
> >Yep, that was the major point why we left continuous spellcheck off years
> >back.
> >
> >Now it seems that you missed the new thread about continuous spellcheck from
> >one month back where left wing of devs come up with the reasoning that many
> >users won't get idea about existing spellcheck in lyx unless it's on by
> >default.
> >
> >I do not remember whether the patch made it into 2.4 or its pending.
> 
> No, the forces of FUD and reaction managed to stop progress (again).

Looking at the old thread the main reason this is not yet in the master
seems to be oblivion rather than reactionary forces :)

> Seriously, continuous spelling is much easier to disable (just an icon in
> plain sight) than completion.

Agreed.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Jean-Marc Lasgouttes 

Le 01/12/2020 à 16:44, Richard Kimberly Heck a écrit :

No, the forces of FUD and reaction managed to stop progress (again).


I don't think we reached a conclusion here. The proposal was to enable
it by default, but to set it to off for users migrating from 2.3.x who
haven't enabled it (via prefs2prefs). Patch attached again.


It is a compromise, but better than nothing.

OTOH, we really should find a way to mitigate the completion mess. There 
is not reason it cannot be disabled. As far as preferences go, there is 
room for disabling many of them IMO:


/// minimum length of words to complete
unsigned int completion_minlength = 6;

///
bool completion_cursor_text = true;
///
double completion_inline_delay = 0.2;
///
bool completion_inline_math = true;
///
bool completion_inline_text = false;
///
int completion_inline_dots = -1;
///
double completion_popup_delay = 2.0;
///
bool completion_popup_math = true;
///
bool completion_popup_text = false;
///
bool completion_popup_after_complete = true;

Everything is configurable, except the important stuff!

Scott, I am not sure you still have this set of preference files 
contributed by users. It would be nice to know whether people use thoese 
settings. It seems that there are choices to be made. For example I do 
not know why it could be good to disable the |> cursor with 
completion_cursor_text=false.


JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Richard Kimberly Heck 
On 12/1/20 8:23 AM, Jean-Marc Lasgouttes wrote:
> Le 01/12/2020 à 12:27, Pavel Sanda a écrit :
>> Yep, that was the major point why we left continuous spellcheck off
>> years back.
>>
>> Now it seems that you missed the new thread about continuous
>> spellcheck from
>> one month back where left wing of devs come up with the reasoning
>> that many
>> users won't get idea about existing spellcheck in lyx unless it's on by
>> default.
>>
>> I do not remember whether the patch made it into 2.4 or its pending.
>
> No, the forces of FUD and reaction managed to stop progress (again).

I don't think we reached a conclusion here. The proposal was to enable
it by default, but to set it to off for users migrating from 2.3.x who
haven't enabled it (via prefs2prefs). Patch attached again.

Riki



>From 5891fa7c3e4b3139aeb3a7c9e256f71d9a9122bf Mon Sep 17 00:00:00 2001
From: Richard Kimberly Heck 
Date: Sun, 1 Nov 2020 18:05:17 -0500
Subject: [PATCH] Make default TRUE for continuous spellcheck.

Also, set preference to FALSE for existing users who do not have it
set to true (so behavior does not change for them).
---
 lib/configure.py |  2 +-
 lib/scripts/prefs2prefs.py   | 19 ++--
 lib/scripts/prefs2prefs_prefs.py | 38 +++-
 src/LyXRC.cpp|  2 +-
 4 files changed, 47 insertions(+), 14 deletions(-)

diff --git a/lib/configure.py b/lib/configure.py
index ca62e65d63..38503c7c5d 100644
--- a/lib/configure.py
+++ b/lib/configure.py
@@ -1863,7 +1863,7 @@ if __name__ == '__main__':
 lyx_check_config = True
 lyx_kpsewhich = True
 outfile = 'lyxrc.defaults'
-lyxrc_fileformat = 34
+lyxrc_fileformat = 35
 rc_entries = ''
 lyx_keep_temps = False
 version_suffix = ''
diff --git a/lib/scripts/prefs2prefs.py b/lib/scripts/prefs2prefs.py
index 493ddf57bf..351deb4e02 100644
--- a/lib/scripts/prefs2prefs.py
+++ b/lib/scripts/prefs2prefs.py
@@ -4,7 +4,7 @@
 # This file is part of LyX, the document processor.
 # Licence details can be found in the file COPYING.
 
-# author Richard Heck
+# author Richard Kimberly Heck
 
 # Full author contact details are available in file CREDITS
 
@@ -16,13 +16,13 @@
 # the preferences file.
 #
 # I've organized it this way because, in many ways, converting bind and ui
-# files  lfuns) and converting the preferences file are the same task. It's
+# files (lfuns) and converting the preferences file are the same task. It's
 # very line-by-line, unlike lyx2lyx and layout2layout, where changes can be
 # more "global". So we read the file, line by line, and give a bunch of
 # converter functions a chance to see if they want to modify that line.
 
 # The converter functions are all in the subsidiary files. They take a line
-# as  argument and return a list: (Bool, NewLine), where the Bool says if
+# as argument and return a list: (Bool, NewLine), where the Bool says if
 # we've modified anything and the NewLine is the new line, if so, which will
 # be used to replace the old line.
 
@@ -176,10 +176,15 @@ def main(argv):
 abort("Something is wrong with the conversion chain.")
 
 for c in convert:
-for i in range(len(lines)):
-(update, newline) = c(lines[i])
-if update:
-lines[i] = newline
+try:
+# first see if the routine will accept a list of lines
+c(lines)
+except:
+# if not, it wants individual lines
+for i in range(len(lines)):
+(update, newline) = c(lines[i])
+if update:
+lines[i] = newline
 
 update_format(lines)
 format = get_format(lines)
diff --git a/lib/scripts/prefs2prefs_prefs.py b/lib/scripts/prefs2prefs_prefs.py
index 598c06b794..4693d9a7e4 100644
--- a/lib/scripts/prefs2prefs_prefs.py
+++ b/lib/scripts/prefs2prefs_prefs.py
@@ -4,16 +4,32 @@
 # This file is part of LyX, the document processor.
 # Licence details can be found in the file COPYING.
 
-# author Richard Heck
+# author Richard Kimberly Heck
 
 # Full author contact details are available in file CREDITS
 
 # This file houses conversion information for the preferences file.
 
-# The converter functions take a line as argument and return a list:
+# There are two kinds of converter functions.
+# 
+# Most of them take a line as argument and return a list:
 # 	(Bool, NewLine),
-# where the Bool says if  we've modified anything and the NewLine is
+# where the Bool says if we've modified anything and the NewLine is
 # the new line, if so, which will be used to replace the old line.
+# This can be used to erase lines (return (True, "")) or to modify 
+# existing preference lines.
+# 
+# It is also possible for conversion routines to accept the whole
+# list of lines and process that. This is useful (as in the change
+# to format 35) when you need to add a preference if it's not already
+#

Re: Preference to disable input completion?

2020-12-01 Thread Joel Kulesza 
On Tue, Dec 1, 2020 at 4:29 AM Pavel Sanda  wrote:

> On Mon, Nov 30, 2020 at 05:54:27PM -0500, Maria Gouskova wrote:
> > I saw a similar discussion on lyx-devel a while back about enabling
> > continuous spellcheck by default, and I almost jumped in with a "please
> god
> > no".


I'm curious why this contribution and the rationale behind it wasn't
given.  Healthy discussion, with opposing views but properly framed, seems
like a good thing.


> This sort of behavior and bloat


I'm unsure where the bloat arises; the capability is there regardless of
its operational state.


> is what sent a lot of us running away
> > from "word processors" back in the early 2000's, and even in MS Word
> there
> > is a way to turn all that stuff off.
>

I believe the discussion was to enable the capability with the user able to
turn it off (rather than the current state: disabled with the user able to
enable it (if he/she realizes LyX has this capability).  This is consistent
with the behavior cited.  Perhaps I misunderstand?


> Yep, that was the major point why we left continuous spellcheck off years
> back.
>
> Now it seems that you missed the new thread about continuous spellcheck
> from
> one month back where left wing of devs come up with the reasoning that many
> users won't get idea about existing spellcheck in lyx unless it's on by
> default.
>

I've never been called left wing, and I'm pretty sure I don't qualify as
'dev,' but this goes beyond reasoning. I have several first-hand accounts
of technically savvy but new-to-LyX users being unaware of this feature
until it was announced to them.  I regret that this is anecdotal, for I
don't have affidavits to present, but I certainly have evidence beyond the
imagination.  I'm unsure about the experience of others.

Thanks,
Joel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Jean-Marc Lasgouttes 

Le 01/12/2020 à 12:27, Pavel Sanda a écrit :

Yep, that was the major point why we left continuous spellcheck off years back.

Now it seems that you missed the new thread about continuous spellcheck from
one month back where left wing of devs come up with the reasoning that many
users won't get idea about existing spellcheck in lyx unless it's on by
default.

I do not remember whether the patch made it into 2.4 or its pending.


No, the forces of FUD and reaction managed to stop progress (again).

Seriously, continuous spelling is much easier to disable (just an icon 
in plain sight) than completion.


And if the only problem of Word had been completion or spell checking, 
nobody would have flown away. Automatic correction, bad UI or problems 
with marge documents are a different story.


JMarc

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-12-01 Thread Pavel Sanda 
On Mon, Nov 30, 2020 at 05:54:27PM -0500, Maria Gouskova wrote:
> I saw a similar discussion on lyx-devel a while back about enabling
> continuous spellcheck by default, and I almost jumped in with a "please god
> no". This sort of behavior and bloat is what sent a lot of us running away
> from "word processors" back in the early 2000's, and even in MS Word there
> is a way to turn all that stuff off.

Yep, that was the major point why we left continuous spellcheck off years back.

Now it seems that you missed the new thread about continuous spellcheck from
one month back where left wing of devs come up with the reasoning that many
users won't get idea about existing spellcheck in lyx unless it's on by 
default.

I do not remember whether the patch made it into 2.4 or its pending.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-30 Thread Maria Gouskova 
On Sat, Nov 21, 2020 at 4:20 PM Scott Kostyshak  wrote:

> On Sat, Nov 21, 2020 at 09:55:03PM +0100, Pavel Sanda wrote:
> > On Sat, Nov 21, 2020 at 03:07:20PM -0500, Scott Kostyshak wrote:
> > > do something similar to preview with the combo box. Pavel, would you be
> > > fine with this or prefer not to add a new preference for this type of
> > > thing?
> >
> > I do not have any strong opinion. If the current behaviour infuriates two
> > people on the dev list its sufficient reason to do something about it.
>
> OK thanks.
>

Plus at least one person who reads lyx-devel but does not contribute! It's
been driving me up the wall for as long as the autocomplete feature has
been around. I want the same behavior as Scott described: tab autocomplete
in math only. I use tables all the time; it's my main reason for not using
TeX (moving columns around is too hard in TeX). And I'm just as likely to
input text as numbers or other things, so this comes up at least a few
times during each writing session. It seems like no-autocomplete should
actually be the default, or at least as easy to disable as automatic
spellcheck correction.

I saw a similar discussion on lyx-devel a while back about enabling
continuous spellcheck by default, and I almost jumped in with a "please god
no". This sort of behavior and bloat is what sent a lot of us running away
from "word processors" back in the early 2000's, and even in MS Word there
is a way to turn all that stuff off.


> Scott
> --
> lyx-devel mailing list
> lyx-devel@lists.lyx.org
> http://lists.lyx.org/mailman/listinfo/lyx-devel
>
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak 
On Sat, Nov 21, 2020 at 09:55:03PM +0100, Pavel Sanda wrote:
> On Sat, Nov 21, 2020 at 03:07:20PM -0500, Scott Kostyshak wrote:
> > do something similar to preview with the combo box. Pavel, would you be
> > fine with this or prefer not to add a new preference for this type of
> > thing?
> 
> I do not have any strong opinion. If the current behaviour infuriates two
> people on the dev list its sufficient reason to do something about it.

OK thanks.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Andrew Parsloe 



On 22/11/2020 3:36 am, Scott Kostyshak wrote:


You can alway put into your preferences change to the Tab shortcut

True. I want to turn input completion off for text completion but leave it on for math 
completion. Andrew and Joel, if you also want that I already have a patch that I think 
does this that I can use locally. Let me know if you want me to post it (it would require 
you to recompile LyX though). If you want to effectively "disable" input 
completion in both math and text, you can rebind Tab.

Scott


I've rebound Tab. I should have done it long ago.

Andrew

--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Pavel Sanda 
On Sat, Nov 21, 2020 at 03:07:20PM -0500, Scott Kostyshak wrote:
> do something similar to preview with the combo box. Pavel, would you be
> fine with this or prefer not to add a new preference for this type of
> thing?

I do not have any strong opinion. If the current behaviour infuriates two
people on the dev list its sufficient reason to do something about it.

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak 
On Sat, Nov 21, 2020 at 12:27:54PM -0700, Joel Kulesza wrote:
> On Sat, Nov 21, 2020 at 7:36 AM Scott Kostyshak  wrote:
> 
> > I want to turn input completion off for text completion but leave it on
> > for math completion. Andrew and Joel, if you also want that I already have
> > a patch that I think does this that I can use locally. Let me know if you
> > want me to post it (it would require you to recompile LyX though).
> >
> 
> The behavior described here is precisely what I'd like.  Please post, and I
> hope we can also find a way to incorporate this into master.

The patch is a hack and is not meant to be considered for master. It is
attached.

Let me know if you test it out and if it does what you want. If not, let
me know what you prefer and it might be easy to tweak it to what you
want. Again though, this is just for our own purposes. We need more
invasive changes for a correct patch for master.

Scott
diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
index d9e7fb2008..68ebdcef9b 100644
--- a/src/frontends/qt/GuiView.cpp
+++ b/src/frontends/qt/GuiView.cpp
@@ -2235,6 +2235,7 @@ bool GuiView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
 
 	case LFUN_COMPLETION_ACCEPT:
 		if (!d.current_work_area_
+			|| !currentBufferView()->cursor().inMathed()
 			|| (!d.current_work_area_->completer().popupVisible()
 			&& !d.current_work_area_->completer().inlineVisible()
 			&& !d.current_work_area_->completer().completionAvailable()))


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak 
On Sat, Nov 21, 2020 at 04:49:57PM +0100, Jean-Marc Lasgouttes wrote:
> Le 21/11/2020 à 16:15, Richard Kimberly Heck a écrit :
> > > True. I want to turn input completion off for text completion but leave 
> > > it on for math completion. Andrew and Joel, if you also want that I 
> > > already have a patch that I think does this that I can use locally. Let 
> > > me know if you want me to post it (it would require you to recompile LyX 
> > > though). If you want to effectively "disable" input completion in both 
> > > math and text, you can rebind Tab.
> > 
> > I think this makes a lot of sense. We have a similar setting for preview.
> 
> Making our preferences cleaner is always good. Try to reorganize them (maybe
> like previews indeed) rather than just add a checkbox. I find the current
> settings too complicated already.

It took me a while just to understand what was happening. For some
reason, I thought "automatic completion" is what is actually
"completion". Now that I understand the distinction it makes sense
though.

Reorganizing is a good idea. Not sure when or if I would get to this. If
anyone takes a shot at this though, we should note that this involves
adding at least one new preference. We can keep it one if we do indeed
do something similar to preview with the combo box. Pavel, would you be
fine with this or prefer not to add a new preference for this type of
thing?

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Joel Kulesza 
On Sat, Nov 21, 2020 at 7:36 AM Scott Kostyshak  wrote:

> I want to turn input completion off for text completion but leave it on
> for math completion. Andrew and Joel, if you also want that I already have
> a patch that I think does this that I can use locally. Let me know if you
> want me to post it (it would require you to recompile LyX though).
>

The behavior described here is precisely what I'd like.  Please post, and I
hope we can also find a way to incorporate this into master.

Thank you,
Joel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Jean-Marc Lasgouttes 

Le 21/11/2020 à 16:15, Richard Kimberly Heck a écrit :

True. I want to turn input completion off for text completion but leave it on for math 
completion. Andrew and Joel, if you also want that I already have a patch that I think 
does this that I can use locally. Let me know if you want me to post it (it would require 
you to recompile LyX though). If you want to effectively "disable" input 
completion in both math and text, you can rebind Tab.


I think this makes a lot of sense. We have a similar setting for preview.


Making our preferences cleaner is always good. Try to reorganize them 
(maybe like previews indeed) rather than just add a checkbox. I find the 
current settings too complicated already.


JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Richard Kimberly Heck 
On 11/21/20 9:36 AM, Scott Kostyshak wrote:
> On Sat, Nov 21, 2020 at 03:20:52PM +0100, Pavel Sanda wrote:
>> On Sat, Nov 21, 2020 at 09:14:43AM -0500, Scott Kostyshak wrote:
>>> On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote:
 On 21/11/2020 3:28 am, Joel Kulesza wrote:
> On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak  > wrote:
>
> Does anyone else find (non-automatic) completion annoying in text
> mode?
>
> However, when in a table and moving rightward through cells, it is my
> natural inclination to use tab, which initiates autocompletion, which
> infuriates me.
 +1 to this.
>>> Good to know. Thanks for the replies. Seems like a couple of us are annoyed 
>>> by it, but not sure it's enough to propose a new preference setting.
>> You can alway put into your preferences change to the Tab shortcut
> True. I want to turn input completion off for text completion but leave it on 
> for math completion. Andrew and Joel, if you also want that I already have a 
> patch that I think does this that I can use locally. Let me know if you want 
> me to post it (it would require you to recompile LyX though). If you want to 
> effectively "disable" input completion in both math and text, you can rebind 
> Tab.

I think this makes a lot of sense. We have a similar setting for preview.

Riki


-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak 
On Sat, Nov 21, 2020 at 03:20:52PM +0100, Pavel Sanda wrote:
> On Sat, Nov 21, 2020 at 09:14:43AM -0500, Scott Kostyshak wrote:
> > On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote:
> > > On 21/11/2020 3:28 am, Joel Kulesza wrote:
> > > > On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak  > > > > wrote:
> > > > 
> > > > Does anyone else find (non-automatic) completion annoying in text
> > > > mode?
> > > > 
> > > 
> > > > However, when in a table and moving rightward through cells, it is my
> > > > natural inclination to use tab, which initiates autocompletion, which
> > > > infuriates me.
> > > 
> > > +1 to this.
> > 
> > Good to know. Thanks for the replies. Seems like a couple of us are annoyed 
> > by it, but not sure it's enough to propose a new preference setting.
> 
> You can alway put into your preferences change to the Tab shortcut

True. I want to turn input completion off for text completion but leave it on 
for math completion. Andrew and Joel, if you also want that I already have a 
patch that I think does this that I can use locally. Let me know if you want me 
to post it (it would require you to recompile LyX though). If you want to 
effectively "disable" input completion in both math and text, you can rebind 
Tab.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Pavel Sanda 
On Sat, Nov 21, 2020 at 09:14:43AM -0500, Scott Kostyshak wrote:
> On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote:
> > On 21/11/2020 3:28 am, Joel Kulesza wrote:
> > > On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak  > > > wrote:
> > > 
> > > Does anyone else find (non-automatic) completion annoying in text
> > > mode?
> > > 
> > 
> > > However, when in a table and moving rightward through cells, it is my
> > > natural inclination to use tab, which initiates autocompletion, which
> > > infuriates me.
> > 
> > +1 to this.
> 
> Good to know. Thanks for the replies. Seems like a couple of us are annoyed 
> by it, but not sure it's enough to propose a new preference setting.

You can alway put into your preferences change to the Tab shortcut
P
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-21 Thread Scott Kostyshak 
On Sat, Nov 21, 2020 at 10:10:53AM +1300, Andrew Parsloe wrote:
> On 21/11/2020 3:28 am, Joel Kulesza wrote:
> > On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak  > > wrote:
> > 
> > Does anyone else find (non-automatic) completion annoying in text
> > mode?
> > 
> 
> > However, when in a table and moving rightward through cells, it is my
> > natural inclination to use tab, which initiates autocompletion, which
> > infuriates me.
> 
> +1 to this.

Good to know. Thanks for the replies. Seems like a couple of us are annoyed by 
it, but not sure it's enough to propose a new preference setting.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-20 Thread Andrew Parsloe 

On 21/11/2020 3:28 am, Joel Kulesza wrote:
On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak > wrote:


Does anyone else find (non-automatic) completion annoying in text
mode?



However, when in a table and moving rightward through cells, it is my 
natural inclination to use tab, which initiates autocompletion, which 
infuriates me.


+1 to this.

Andrew

That said, I manually modify tables rarely enough such that I've not 
pursued disabling this in some way.


- Joel

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-20 Thread Scott Kostyshak 
On Fri, Nov 20, 2020 at 03:22:17PM +0100, Pavel Sanda wrote:
> On Fri, Nov 20, 2020 at 09:12:57AM -0500, Scott Kostyshak wrote:
> > On Fri, Nov 20, 2020 at 08:33:24AM +0100, Pavel Sanda wrote:
> > > On Thu, Nov 19, 2020 at 10:27:50PM -0500, Scott Kostyshak wrote:
> > > > I like input completion in math but not for text. Sometimes when I press
> > > >  in text, it triggers an input completion because of the following
> > > > default binding:
> > > > 
> > > >   \bind "Tab""command-alternatives 
> > > > completion-accept;cell-forward;tab-insert;outline-in;depth-increment"
> > > > 
> > > > Does anyone else find (non-automatic) completion annoying in text mode?
> > > 
> > > What are your prefs in Preferences->Input Completion->In Text ?
> > 
> > Automatic inline completion: unchecked
> > Automatic popup: unchecked
> > Cursor indicator: greyed out (and checked)
> > 
> > A screenshot of all my completion prefs is here:
> > 
> 
> I see it's the same here now. So to answer your original question I am not 
> personally
> bothered because I can't remember it ever happened to me before... ;)

Fair enough :)

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-20 Thread Joel Kulesza 
On Thu, Nov 19, 2020 at 8:28 PM Scott Kostyshak  wrote:

> Does anyone else find (non-automatic) completion annoying in text mode?


I never use manual autocompletion in text mode (intentionally or
unintentionally), so I have no opinion on its behavior.

However, when in a table and moving rightward through cells, it is my
natural inclination to use tab, which initiates autocompletion, which
infuriates me.  That said, I manually modify tables rarely enough such that
I've not pursued disabling this in some way.

- Joel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-20 Thread Pavel Sanda 
On Fri, Nov 20, 2020 at 09:12:57AM -0500, Scott Kostyshak wrote:
> On Fri, Nov 20, 2020 at 08:33:24AM +0100, Pavel Sanda wrote:
> > On Thu, Nov 19, 2020 at 10:27:50PM -0500, Scott Kostyshak wrote:
> > > I like input completion in math but not for text. Sometimes when I press
> > >  in text, it triggers an input completion because of the following
> > > default binding:
> > > 
> > >   \bind "Tab""command-alternatives 
> > > completion-accept;cell-forward;tab-insert;outline-in;depth-increment"
> > > 
> > > Does anyone else find (non-automatic) completion annoying in text mode?
> > 
> > What are your prefs in Preferences->Input Completion->In Text ?
> 
> Automatic inline completion: unchecked
> Automatic popup: unchecked
> Cursor indicator: greyed out (and checked)
> 
> A screenshot of all my completion prefs is here:
> 

I see it's the same here now. So to answer your original question I am not 
personally
bothered because I can't remember it ever happened to me before... ;)

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-20 Thread Scott Kostyshak 
On Fri, Nov 20, 2020 at 08:33:24AM +0100, Pavel Sanda wrote:
> On Thu, Nov 19, 2020 at 10:27:50PM -0500, Scott Kostyshak wrote:
> > I like input completion in math but not for text. Sometimes when I press
> >  in text, it triggers an input completion because of the following
> > default binding:
> > 
> >   \bind "Tab""command-alternatives 
> > completion-accept;cell-forward;tab-insert;outline-in;depth-increment"
> > 
> > Does anyone else find (non-automatic) completion annoying in text mode?
> 
> What are your prefs in Preferences->Input Completion->In Text ?

Automatic inline completion: unchecked
Automatic popup: unchecked
Cursor indicator: greyed out (and checked)

A screenshot of all my completion prefs is here:

  https://www.dropbox.com/s/pn82yxgth5xfd2u/screenshot-completion.png?dl=0

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Preference to disable input completion?

2020-11-19 Thread Pavel Sanda 
On Thu, Nov 19, 2020 at 10:27:50PM -0500, Scott Kostyshak wrote:
> I like input completion in math but not for text. Sometimes when I press
>  in text, it triggers an input completion because of the following
> default binding:
> 
>   \bind "Tab""command-alternatives 
> completion-accept;cell-forward;tab-insert;outline-in;depth-increment"
> 
> Does anyone else find (non-automatic) completion annoying in text mode?

What are your prefs in Preferences->Input Completion->In Text ?

Pavel
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Preference to disable input completion?

2020-11-19 Thread Scott Kostyshak 
I like input completion in math but not for text. Sometimes when I press
 in text, it triggers an input completion because of the following
default binding:

  \bind "Tab""command-alternatives 
completion-accept;cell-forward;tab-insert;outline-in;depth-increment"

Does anyone else find (non-automatic) completion annoying in text mode?
It seems strange to me that we have very fine controlling of automatic
input-completion parameters but no way to just turn off input
completion. On the other hand, I don't remember anyone else complaining
about this so perhaps no one else is bothered.

Scott


signature.asc
Description: PGP signature
-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel