Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 03:33 AM, Richard Heck wrote: On 12/16/10 9:11 PM, Pavel Sanda wrote: unless there are some objections i will commit it. once in we'll see whether the new behaviour does not irritate the second half of people which has no performance problems... I have another patch in the

Re: Proposal for LyX performance problems when outliner is opened

On 17. des. 2010 03:11, Pavel Sanda wrote: Abdelrazak Younes wrote: Provided that it doesn't introduce regression, it looks good. But I would rather put a shorter timing here in order to avoid inconcistencies and crashes i did already testing before sending the patch and the updateView

Re: Proposal for LyX performance problems when outliner is opened

On Thu, Dec 16, 2010 at 3:43 AM, Pavel Sanda sa...@lyx.org wrote: hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems on your box, try to open user guide, set the nesting on

Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 01:05 PM, Vincent van Ravesteijn wrote: On Thu, Dec 16, 2010 at 3:43 AM, Pavel Sandasa...@lyx.org wrote: hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems on

Re: Proposal for LyX performance problems when outliner is opened

Why do we completely update the TOC if we just type something ? I certainly hope that this is not the case. As far as I understand Pavel slowness is just because the toc takes time to find the correct toc item to select. We completely update the TOC when pressing enter for instance.

Re: Proposal for LyX performance problems when outliner is opened

Vincent van Ravesteijn wrote: Why do we completely update the TOC if we just type something ? I certainly hope that this is not the case. As far as I understand Pavel slowness is just because the toc takes time to find the correct toc item to select. We completely update the TOC

Re: Proposal for LyX performance problems when outliner is opened

Richard Heck wrote: I have another patch in the works that may help here. How much, I am not sure. But one thing that is clear to me is that we are doing way too much data collection for the TOC. E.g., if you look at InsetBranch::addToToc(), you will see that we are adding a string

Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 04:19 PM, Pavel Sanda wrote: Vincent van Ravesteijn wrote: I think we shouldn't fall back into this kind of hack before we know i can offer some rc variable or small slider for the delay in outliner. if its not acceptable either, well, its another local patch again :)

Re: Proposal for LyX performance problems when outliner is opened

Pavel Sanda wrote: but it should be possible to find the problematic line of tocwidget::updateview just by lyxerr timing output. the timing delay for single run of this function is noticeable even by eyes. so i have tried. i'm 100% sure that slowness is triggered by tocwidget::updateView,

Re: Proposal for LyX performance problems when outliner is opened

Abdelrazak Younes wrote: On 12/17/2010 04:19 PM, Pavel Sanda wrote: Vincent van Ravesteijn wrote: I think we shouldn't fall back into this kind of hack before we know i can offer some rc variable or small slider for the delay in outliner. if its not acceptable either, well, its

Re: Proposal for LyX performance problems when outliner is opened

Pavel Sanda wrote: +// Enable if you dont want the delaying business, cf #7138. +#ifdef 0 + updateViewForce(); + return; +#endif erm #if 0 of course... pavel

Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 05:42 PM, Pavel Sanda wrote: Pavel Sanda wrote: +// Enable if you dont want the delaying business, cf #7138. +#ifdef 0 + updateViewForce(); + return; +#endif erm #if 0 of course... make it an #ifndef DELAY_UPDATE_VIEW and I'd be happy. Abdel. pavel

Re: Proposal for LyX performance problems when outliner is opened

Abdelrazak Younes wrote: erm #if 0 of course... make it an #ifndef DELAY_UPDATE_VIEW and I'd be happy. this means the bug remains effectively unfixed for all other users. pavel

Re: Proposal for LyX performance problems when outliner is opened

On 17/12/2010 18:18, Pavel Sanda wrote: Abdelrazak Younes wrote: erm #if 0 of course... make it an #ifndef DELAY_UPDATE_VIEW and I'd be happy. this means the bug remains effectively unfixed for all other users. No, you can of course set that to 1 by default of course (like

Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 03:33 AM, Richard Heck wrote: On 12/16/10 9:11 PM, Pavel Sanda wrote: unless there are some objections i will commit it. once in we'll see whether the new behaviour does not irritate the second half of people which has no performance problems... I have another patch in the

Re: Proposal for LyX performance problems when outliner is opened

On 17. des. 2010 03:11, Pavel Sanda wrote: Abdelrazak Younes wrote: Provided that it doesn't introduce regression, it looks good. But I would rather put a shorter timing here in order to avoid inconcistencies and crashes i did already testing before sending the patch and the updateView

Re: Proposal for LyX performance problems when outliner is opened

On Thu, Dec 16, 2010 at 3:43 AM, Pavel Sanda wrote: > hi, > > the attached patch has profound impact on the speed of moving with cursor > and typing as well. at least here. > > if you wonder how to reproduce the slowness problems on your box, try to open > user guide, set the

Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 01:05 PM, Vincent van Ravesteijn wrote: On Thu, Dec 16, 2010 at 3:43 AM, Pavel Sanda wrote: hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems

Re: Proposal for LyX performance problems when outliner is opened

>> >> Why do we completely update the TOC if we just type something ? >> > > I certainly hope that this is not the case. As far as I understand Pavel > slowness is just because the toc takes time to find the correct toc item to > select. > We completely update the TOC when pressing enter for

Re: Proposal for LyX performance problems when outliner is opened

Vincent van Ravesteijn wrote: > >> > >> Why do we completely update the TOC if we just type something ? > >> > > > > I certainly hope that this is not the case. As far as I understand Pavel > > slowness is just because the toc takes time to find the correct toc item to > > select. > > > > We

Re: Proposal for LyX performance problems when outliner is opened

Richard Heck wrote: > I have another patch in the works that may help here. How much, I am not > sure. But one thing that is clear to me is that we are doing way too much > data collection for the TOC. E.g., if you look at InsetBranch::addToToc(), > you will see that we are adding a string

Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 04:19 PM, Pavel Sanda wrote: Vincent van Ravesteijn wrote: I think we shouldn't fall back into this kind of hack before we know i can offer some rc variable or small slider for the delay in outliner. if its not acceptable either, well, its another local patch again :)

Re: Proposal for LyX performance problems when outliner is opened

Pavel Sanda wrote: > but it should be possible to find the problematic line of > tocwidget::updateview just by lyxerr timing output. the timing delay > for single run of this function is noticeable even by eyes. so i have tried. i'm 100% sure that slowness is triggered by tocwidget::updateView,

Re: Proposal for LyX performance problems when outliner is opened

Abdelrazak Younes wrote: > On 12/17/2010 04:19 PM, Pavel Sanda wrote: >> Vincent van Ravesteijn wrote: >> >>> I think we shouldn't fall back into this kind of hack before we know >>> >> i can offer some rc variable or small slider for the delay in outliner. >> if its not acceptable

Re: Proposal for LyX performance problems when outliner is opened

Pavel Sanda wrote: > +// Enable if you dont want the delaying business, cf #7138. > +#ifdef 0 > + updateViewForce(); > + return; > +#endif erm "#if 0" of course... pavel

Re: Proposal for LyX performance problems when outliner is opened

On 12/17/2010 05:42 PM, Pavel Sanda wrote: Pavel Sanda wrote: +// Enable if you dont want the delaying business, cf #7138. +#ifdef 0 + updateViewForce(); + return; +#endif erm "#if 0" of course... make it an #ifndef DELAY_UPDATE_VIEW and I'd be happy. Abdel.

Re: Proposal for LyX performance problems when outliner is opened

Abdelrazak Younes wrote: >> erm "#if 0" of course... >> > > make it an #ifndef DELAY_UPDATE_VIEW and I'd be happy. this means the bug remains effectively unfixed for all other users. pavel

Re: Proposal for LyX performance problems when outliner is opened

On 17/12/2010 18:18, Pavel Sanda wrote: Abdelrazak Younes wrote: erm "#if 0" of course... make it an #ifndef DELAY_UPDATE_VIEW and I'd be happy. this means the bug remains effectively unfixed for all other users. No, you can of course set that to 1 by default of course (like

Re: Proposal for LyX performance problems when outliner is opened

On 12/16/2010 03:43 AM, Pavel Sanda wrote: hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems on your box, try to open user guide, set the nesting on deepest level and try to type

Re: Proposal for LyX performance problems when outliner is opened

Abdelrazak Younes wrote: Provided that it doesn't introduce regression, it looks good. But I would rather put a shorter timing here in order to avoid inconcistencies and crashes i did already testing before sending the patch and the updateView routine is pretty robust even when you change

Re: Proposal for LyX performance problems when outliner is opened

On 12/16/10 9:11 PM, Pavel Sanda wrote: unless there are some objections i will commit it. once in we'll see whether the new behaviour does not irritate the second half of people which has no performance problems... I have another patch in the works that may help here. How much, I am not

Re: Proposal for LyX performance problems when outliner is opened

On 12/16/2010 03:43 AM, Pavel Sanda wrote: hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems on your box, try to open user guide, set the nesting on deepest level and try to type

Re: Proposal for LyX performance problems when outliner is opened

Abdelrazak Younes wrote: > Provided that it doesn't introduce regression, it looks good. But I would > rather put a shorter timing here in order to avoid inconcistencies and > crashes i did already testing before sending the patch and the updateView routine is pretty robust even when you change

Re: Proposal for LyX performance problems when outliner is opened

On 12/16/10 9:11 PM, Pavel Sanda wrote: unless there are some objections i will commit it. once in we'll see whether the new behaviour does not irritate the second half of people which has no performance problems... I have another patch in the works that may help here. How much, I am not

Proposal for LyX performance problems when outliner is opened

hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems on your box, try to open user guide, set the nesting on deepest level and try to type fastly or move with cursor, maybe you'll be

Proposal for LyX performance problems when outliner is opened

hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems on your box, try to open user guide, set the nesting on deepest level and try to type fastly or move with cursor, maybe you'll be