On 04/22/2012 07:38 PM, Scott Kostyshak wrote:
*From:* Richard Heck [rgh...@comcast.net]
*Sent:* Sunday, April 22, 2012 7:00 PM
>I guess this is a matter of preference. But somehow it just seemed
cleaner the way it was before.
---
>When I looked at it, I was worried by (2). It's also true that
From: Richard Heck [rgh...@comcast.net]
Sent: Sunday, April 22, 2012 7:00 PM
>I guess this is a matter of preference. But somehow it just seemed cleaner the
>way it was before.
---
>When I looked at it, I was worried by (2). It's also true that any kind of
>optimization here will probably be >in
On 04/22/2012 01:02 AM, Scott Kostyshak wrote:
*From:* Richard Heck [rgh...@comcast.net]
*Sent:* Saturday, April 21, 2012 4:25 PM
>Whitespace was a bit inconsistent in the patch. Possibly some sort of
setting in your editor.
I use vim and made the patch with git diff. I must have done somethi
From: Richard Heck [rgh...@comcast.net]
Sent: Saturday, April 21, 2012 4:25 PM
>Whitespace was a bit inconsistent in the patch. Possibly some sort of setting
>in your editor.
I use vim and made the patch with git diff. I must have done something strange.
Let me know if this happens again so I c
OK, I've committed this, and made a changed too to the name is_valid_.
Whitespace was a bit inconsistent in the patch. Possibly some sort of
setting in your editor.
Richard
On 04/21/2012 04:41 AM, Scott Kostyshak wrote:
*From:* Richard Heck [rgh...@comcast.net]
*Sent:* Friday, April 20, 201
From: Richard Heck [rgh...@comcast.net]
Sent: Friday, April 20, 2012 9:54 AM
>This seems sensible, overall. Minor comments below.
>It's a micro-optimization, but it might also make it more understandable not
>to do this every time, but to check is_valid_ first: If that's false, we
>shouldn't nee
On 04/20/2012 03:49 AM, Scott Kostyshak wrote:
go to document settings > local layout
enter a space
the "bug" is that you have to validate. This seems unnecessary.
Suppose someone accidentally entered some text (maybe they thought it
was the preamble) and then realized he was in the wrong spot
