RE: [patch] fix document settings branches GUI behavior

2012-03-03 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Friday, March 02, 2012 8:09 AM The attached implements this (part 1). Part 2 also implements the behaviour of GuiSelectionManager that Ctrl+Enter does quit the dialog. OK, I will study this to see how you did it. Thanks for the help and

Re: [patch] fix document settings branches GUI behavior

2012-03-03 Thread Vincent van Ravesteijn
Op 3-3-2012 9:09, Scott Kostyshak schreef: From: Vincent van Ravesteijn [v...@lyx.org] Sent: Friday, March 02, 2012 8:09 AM The attached implements this (part 1). Part 2 also implements the behaviour of GuiSelectionManager that Ctrl+Enter does quit the dialog. OK, I will study this to see how

Re: [patch] fix document settings branches GUI behavior

2012-03-03 Thread Vincent van Ravesteijn
I have a few issues after applying both of your patches. Note that I am using Ubuntu 11.10 64-bit. (2) Ctrl+Enter does not quit the dialog for me. I tried myself now on Ubuntu 11.10 64-bits. For me it works. Vincent

RE: [patch] fix document settings branches GUI behavior

2012-03-03 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Saturday, March 03, 2012 9:10 AM I have a few issues after applying both of your patches. Note that I am using Ubuntu 11.10 64-bit. (1) empty strings can be added by pressing enter. fix: remove the following part of branches_part1.diff: -

RE: [patch] fix document settings > branches GUI behavior

2012-03-03 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Friday, March 02, 2012 8:09 AM >The attached implements this (part 1). Part 2 also implements the >behaviour of GuiSelectionManager that Ctrl+Enter does quit the dialog. OK, I will study this to see how you did it. Thanks for the help and

Re: [patch] fix document settings > branches GUI behavior

2012-03-03 Thread Vincent van Ravesteijn
Op 3-3-2012 9:09, Scott Kostyshak schreef: From: Vincent van Ravesteijn [v...@lyx.org] Sent: Friday, March 02, 2012 8:09 AM The attached implements this (part 1). Part 2 also implements the behaviour of GuiSelectionManager that Ctrl+Enter does quit the dialog. OK, I will study this to see how

Re: [patch] fix document settings > branches GUI behavior

2012-03-03 Thread Vincent van Ravesteijn
I have a few issues after applying both of your patches. Note that I am using Ubuntu 11.10 64-bit. (2) Ctrl+Enter does not quit the dialog for me. I tried myself now on Ubuntu 11.10 64-bits. For me it works. Vincent

RE: [patch] fix document settings > branches GUI behavior

2012-03-03 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Saturday, March 03, 2012 9:10 AM >> I have a few issues after applying both of your patches. Note that I am >> using Ubuntu 11.10 64-bit. >> (1) empty strings can be added by pressing enter. >> fix: remove the following part of

Re: [patch] fix document settings branches GUI behavior

2012-03-02 Thread Vincent van Ravesteijn
Op 21-2-2012 22:49, Scott Kostyshak schreef: From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM What I would do is to study the code of the Insert-Citation dialog, which has the correct

Re: [patch] fix document settings > branches GUI behavior

2012-03-02 Thread Vincent van Ravesteijn
Op 21-2-2012 22:49, Scott Kostyshak schreef: From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM What I would do is to study the code of the Insert->Citation dialog, which has the correct

RE: [patch] fix document settings branches GUI behavior

2012-03-01 Thread Scott Kostyshak
From: Scott Kostyshak Sent: Tuesday, February 21, 2012 4:49 PM I'm getting closer. I realize that I need to connect the signal returnPressed from newBranchLE to on_addBranchPB_pressed. I did this, and it seems to have partially done what I want, but when I enter text into the LE and press

RE: [patch] fix document settings > branches GUI behavior

2012-03-01 Thread Scott Kostyshak
From: Scott Kostyshak Sent: Tuesday, February 21, 2012 4:49 PM >I'm getting closer. I realize that I need to connect the signal returnPressed >from newBranchLE to >on_addBranchPB_pressed. I did this, and it seems to have >partially done what I want, but when I enter text into the >LE and press

Re: [patch] fix document settings branches GUI behavior

2012-02-21 Thread Jean-Marc Lasgouttes
Le 21/02/2012 09:29, Scott Kostyshak a écrit : my fix for bug 1: 1. disable the add button (BranchesUi.ui) 2. enable the add button when there is text in the text box (GuiBranches.cpp) my (partially implemented) idea for bug 2: set the add button as default when there is text in the text box

RE: [patch] fix document settings branches GUI behavior

2012-02-21 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM What I would do is to study the code of the Insert-Citation dialog, which has the correct behaviour in the search (find?) field, if I understand

RE: [patch] fix document settings branches GUI behavior

2012-02-21 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM What I would do is to study the code of the Insert-Citation dialog, which has the correct behaviour in the search (find?) field, if I understand

Re: [patch] fix document settings > branches GUI behavior

2012-02-21 Thread Jean-Marc Lasgouttes
Le 21/02/2012 09:29, Scott Kostyshak a écrit : my fix for bug 1: 1. disable the add button (BranchesUi.ui) 2. enable the add button when there is text in the text box (GuiBranches.cpp) my (partially implemented) idea for bug 2: set the add button as default when there is text in the text box

RE: [patch] fix document settings > branches GUI behavior

2012-02-21 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM >What I would do is to study the code of the Insert->Citation dialog, >which has the correct behaviour in the search (find?) field, if I

RE: [patch] fix document settings > branches GUI behavior

2012-02-21 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM >What I would do is to study the code of the Insert->Citation dialog, >which has the correct behaviour in the search (find?) field, if I