Re: Warnings while compiling branch
Le 20/12/2020 à 11:37, Kornel Benko a écrit : This works, but I just wondered why cmake did not need to compile any sources in hunspell/1.7.0/src/parsers. Do we need only the header files there? Because we do not need this directory! I removed it. Thanks, JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Warnings while compiling branch
Am Sat, 19 Dec 2020 20:57:24 +0100 schrieb Jean-Marc Lasgouttes : > Le 17/12/2020 à 11:46, Kornel Benko a écrit : > > Am Thu, 17 Dec 2020 11:40:36 +0100 > > schrieb Jean-Marc Lasgouttes : > I guess it can wait for 2.3.7. Looking at "git log" for > 3rdparty/hunspell, there is one main commit (c3484fa6c), 2 fixups > (91c58d9a68ca2 and cf980435b), plus a fistful of commits by Kornel > that may or may not be related. > >> > >> Kornel, is it OK if I backport the main commits and let you take care of > >> the rest? > > > > If the rest is meant 'cmake', go ahead. > > > > I backported the 3 commits mentionned above. Kornel, I'll let you look > at "git log" and see what else may be needed. > > JMarc > This works, but I just wondered why cmake did not need to compile any sources in hunspell/1.7.0/src/parsers. Do we need only the header files there? Kornel pgpaVxEeh99Ji.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Warnings while compiling branch
Le 17/12/2020 à 11:46, Kornel Benko a écrit : Am Thu, 17 Dec 2020 11:40:36 +0100 schrieb Jean-Marc Lasgouttes : I guess it can wait for 2.3.7. Looking at "git log" for 3rdparty/hunspell, there is one main commit (c3484fa6c), 2 fixups (91c58d9a68ca2 and cf980435b), plus a fistful of commits by Kornel that may or may not be related. Kornel, is it OK if I backport the main commits and let you take care of the rest? If the rest is meant 'cmake', go ahead. I backported the 3 commits mentionned above. Kornel, I'll let you look at "git log" and see what else may be needed. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Warnings while compiling branch
Am Thu, 17 Dec 2020 11:40:36 +0100 schrieb Jean-Marc Lasgouttes : > Le 02/11/2020 à 19:44, Richard Kimberly Heck a écrit : > > On 11/2/20 12:16 PM, Jean-Marc Lasgouttes wrote: > >> Le 02/11/2020 à 16:59, Richard Kimberly Heck a écrit : > Yes, hunspell has been updated in master to 1.7.0, but not in > branch. Riki, would it make sense to do that, given that we want to > leave 2.3 in the best possible state before we move on? > >>> > >>> Probably does make sense. Do you think it is safe to do for 2.3.6 > >>> (fairly imminent) or should we wait until after that and just have it > >>> in 2.3.7 (which I expect to be the final release)? > >> > >> I guess it can wait for 2.3.7. Looking at "git log" for > >> 3rdparty/hunspell, there is one main commit (c3484fa6c), 2 fixups > >> (91c58d9a68ca2 and cf980435b), plus a fistful of commits by Kornel > >> that may or may not be related. > >> > >> For reference, version 1.7.0 is from November 2018, and it has not > >> really moved since then. > > > > OK. Let's plan to update it as soon as 2.3.6 is done. > > Kornel, is it OK if I backport the main commits and let you take care of > the rest? > > JMarc If the rest is meant 'cmake', go ahead. Kornel pgpWk2R1s3rvD.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Warnings while compiling branch
Le 02/11/2020 à 19:44, Richard Kimberly Heck a écrit : On 11/2/20 12:16 PM, Jean-Marc Lasgouttes wrote: Le 02/11/2020 à 16:59, Richard Kimberly Heck a écrit : Yes, hunspell has been updated in master to 1.7.0, but not in branch. Riki, would it make sense to do that, given that we want to leave 2.3 in the best possible state before we move on? Probably does make sense. Do you think it is safe to do for 2.3.6 (fairly imminent) or should we wait until after that and just have it in 2.3.7 (which I expect to be the final release)? I guess it can wait for 2.3.7. Looking at "git log" for 3rdparty/hunspell, there is one main commit (c3484fa6c), 2 fixups (91c58d9a68ca2 and cf980435b), plus a fistful of commits by Kornel that may or may not be related. For reference, version 1.7.0 is from November 2018, and it has not really moved since then. OK. Let's plan to update it as soon as 2.3.6 is done. Kornel, is it OK if I backport the main commits and let you take care of the rest? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Warnings while compiling branch
Le 02/11/2020 à 15:39, Jean-Pierre Chrétien a écrit : Dear developers While compiling the latest branch with this config I see this : ../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx: In member function ‘bool HunspellImpl::spell(const string&, int*, std::__cxx11::string*)’: ../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx:562:7: warning: this statement may fall through [-Wimplicit-fallthrough=] } ^ Yes, hunspell has been updated in master to 1.7.0, but not in branch. Riki, would it make sense to do that, given that we want to leave 2.3 in the best possible state before we move on? JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Warnings while compiling branch
Dear developers
While compiling the latest branch with this config
Configuration
Host type: x86_64-pc-linux-gnu
Special build flags: build=development std-regex warnings assertions
stdlib-debug use-hunspell
Bundled libraries:boost hunspell mythes
C++ Compiler:g++ (8.3.0)
C++ Compiler flags: -Wall -Wextra -fPIC -g -O -std=c++14
C++ Compiler user flags:
Linker flags:
Linker user flags:
Qt Frontend:
Qt version: 5.11.3
Packaging: posix
LyX binary dir: /usr/local/bin
LyX files dir: /usr/local/share/lyx-2.3.6dev
I see this :
../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx: In member
function ‘bool HunspellImpl::spell(const string&, int*, std::__cxx11::string*)’:
../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx:562:7: warning:
this statement may fall through [-Wimplicit-fallthrough=]
}
^
../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx:564:5: note:
here
case INITCAP: {
^~~~
../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx: In member
function ‘std::__debug::vector >
HunspellImpl::suggest(const string&)’:
../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx:900:16:
warning: this statement may fall through [-Wimplicit-fallthrough=]
capwords = 1;
~^~~
../../../2.3.x/3rdparty/hunspell/1.6.
/src/hunspell/hunspell.cxx:901:5: note: here
case HUHCAP: {
^~~~
../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx:1012:18:
warning: this statement may fall through [-Wimplicit-fallthrough=]
capwords = 1;
~^~~
../../../2.3.x/3rdparty/hunspell/1.6.2/src/hunspell/hunspell.cxx:1013:7: note:
here
case HUHCAP: {
^~~~
../../../2.3.x/3rdparty/hunspell/1.6.2/src/parsers/manparser.cxx: In member
function ‘virtual bool ManParser::next_token(std::__cxx11::string&)’:
../../../2.3.x/3rdparty/hunspell/1.6.2/src/parsers/manparser.cxx:72:17: warning:
this statement may fall through [-Wimplicit-fallthrough=]
state = 2;
~~^~~
../../../2.3.x/3rdparty/hunspell/1.6.2/src/parsers/manparser.cxx:75:7: note:
here
case 2: // non word chars
I guess this is harmless.
--
Jean-Pierre
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
