Re: [PATCH] to avoid crash in misspelled marker painting while deleting table rows fast

2017-10-12 Thread Stephan Witt
Am 11.10.2017 um 12:10 schrieb Jean-Marc Lasgouttes : > > Le 08/10/2017 à 18:01, Stephan Witt a écrit : >> Hi, >> these days I’ve got a crash while deleting multiple rows from a table with >> bottom table toolbar quickly. >> This happened with LyX 2.2. - I can reproduce it

Re: LyX 2.3 failure to convert from layout format 60 to 64

2017-10-12 Thread Kornel Benko
Am Donnerstag, 12. Oktober 2017 um 13:47:09, schrieb Jürgen Spitzmüller > 2017-10-12 11:38 GMT+02:00 Helge Hafting: > > > If there is a problem in layout2layout, finding it may be useful before > > release? > > > > Yes. Can you try if the attached patch fixes the problem? > >

Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2017 à 01:29, Scott Kostyshak a écrit : PS: I would not be surprised that there are other cases that I did not catch. Could an assertion help catch more? Not really, since the cursor current can be different from the font at position. This happens when the user uses C-e to switch

Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-12 Thread Jean-Marc Lasgouttes
Le 12/10/2017 à 01:29, Scott Kostyshak a écrit : On Wed, Oct 11, 2017 at 10:05:46AM +, Jean-Marc Lasgouttes wrote: So, shall I push to 2.3.x too? Yes, please. Thanks, done. JMarc

Re: LyX-Workarea: Background not shown correctly

2017-10-12 Thread Jean-Marc Lasgouttes
Le 08/10/2017 à 18:57, pdv a écrit : The new code contains twice a viewport()->update() without specification of a rectangle. Since > Qt normally erases the widget's area before the paintEvent() call I guess that the whole viewport is erased. Subsequently only part of it is redrawn except for

Re: Bad Math Display Regression in 2.3.x

2017-10-12 Thread Jean-Marc Lasgouttes
Le 08/10/2017 à 08:56, Jean-Marc Lasgouttes a écrit : The bisect is probably enough for me to find the bug (he said confidently). Here is a tentative patch that I will not be able to test and push until Monday. I will be interesting by some feedback, though. JMarc >From

Re: [LyX/master] Do not forget to set cursor current font when selecting

2017-10-12 Thread Scott Kostyshak
On Thu, Oct 12, 2017 at 07:16:13PM +, Jean-Marc Lasgouttes wrote: > Le 12/10/2017 à 01:29, Scott Kostyshak a écrit : > > > PS: I would not be surprised that there are other cases that I did not > > > catch. > > > > Could an assertion help catch more? > > Not really, since the cursor current

LyX 2.3 failure to convert from layout format 60 to 64

2017-10-12 Thread Helge Hafting
I compiled lyx 2.3 this week (from git). Today, I opened a file using one of my own layouts, and got a failure to convet the layout file from version 60 to version 64. Assuming the format change is about new features (and not depreciation of old stuff), I simply changed the version number

Re: LyX 2.3 failure to convert from layout format 60 to 64

2017-10-12 Thread Jürgen Spitzmüller
2017-10-12 11:38 GMT+02:00 Helge Hafting: > If there is a problem in layout2layout, finding it may be useful before > release? > Yes. Can you try if the attached patch fixes the problem? Jürgen > > > Helge Hafting > > diff --git a/lib/scripts/layout2layout.py b/lib/scripts/layout2layout.py