Re: LyX 2.3.2

2018-12-17 Thread Jean-Marc Lasgouttes
Le 12/12/2018 à 17:45, Richard Kimberly Heck a écrit : Bisect leads me to ef1d5020. There are some other oddities in the previous commit 7b8b3e38, involving how the caret is drawn during zoom, but the previews do reset correctly (and right away). So I'm pretty sure it is this commit that is the

Re: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread David Binderman
Hello there, >> I recommend cppcheck for all C & C++ development work. >I'll give it another go eventually. What flags do you recommend? --enable=all --language=c++ seems to work well for me. I can use grep -v to filter out message I think are pointless.

Apply last (text style) toolbar button has misleading grouping and appearance

2018-12-17 Thread Daniel
The Apply last (text style) button has gotten a more important function since the change of the text style dialog does not allow for the same function any more. So, I actually used it now. However, the toolbar button is grouped with the Toggle emphasis and noun buttons and shares their

Re: Misdrawn lines

2018-12-17 Thread Jürgen Spitzmüller
Am Montag, den 17.12.2018, 15:59 +0100 schrieb Jürgen Spitzmüller: > In current master, lines (misspelling marks, underlining, language > marks) are drawn too high. Also in stable. Jürgen > > See attached screenshot. > > Jürgen signature.asc Description: This is a digitally signed message

Re: Apply last (text style) toolbar button has misleading grouping and appearance

2018-12-17 Thread Daniel
On 18/12/2018 07:40, Daniel wrote: The Apply last (text style) button has gotten a more important function since the change of the text style dialog does not allow for the same function any more. So, I actually used it now. However, the toolbar button is grouped with the Toggle emphasis and

Re: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread Kornel Benko
Am Montag, 17. Dezember 2018 18:00:31 CET schrieb David Binderman : > Hello there, > > > > >> I recommend cppcheck for all C & C++ development work. > > >I'll give it another go eventually. What flags do you recommend? > > --enable=all --language=c++ seems to

Re: [LyX/master] Update to boost 1.68

2018-12-17 Thread Jean-Marc Lasgouttes
Le 16/12/2018 à 21:56, Jean-Marc Lasgouttes a écrit : With clang 7, I get lots of the following warnings. Shall we fix them or disable the warning? ../../../../master/src/frontends/qt4/GuiApplication.h:73:7: warning: 'event' overrides a member   function but is not marked 'override'

Re: [LyX/master] GuiCharacter: Add "Reset" and "Restore Defaults" buttons

2018-12-17 Thread Kornel Benko
Am Montag, 17. Dezember 2018 12:58:26 CET schrieb Juergen Spitzmueller : > commit 5f038896093eb8d8e6c5804ef0a8d4a8d4d2d338 > Author: Juergen Spitzmueller > Date: Mon Dec 17 12:59:40 2018 +0100 > > GuiCharacter: Add "Reset" and "Restore Defaults" buttons > > Addresses #11415 The

lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread David Binderman
Hello there, Source code is bool empty() const { return wid == 0 && asc == 0 && wid == 0; } Maybe better code bool empty() const { return wid == 0 && asc == 0 && des == 0; } Regards David Binderman

Re: [LyX/master] Fix embarrassing typo

2018-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2018 à 15:31, Jean-Marc Lasgouttes a écrit : commit 058c6750ac83b43819445ccf723283afb850ef91 Author: Jean-Marc Lasgouttes Date: Mon Dec 17 12:28:32 2018 +0100 Fix embarrassing typo Not clear whether this caused any bug. Riki, OK, for 2.3.x? JMarc - ///

Re: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2018 à 12:23, David Binderman a écrit : Hello there, Source code is        bool empty() const { return wid == 0 && asc == 0 && wid == 0; } Maybe better code        bool empty() const { return wid == 0 && asc == 0 && des == 0; } This is very embarrassing, but I am not sure that

Re: [ANNOUNCE] LyX 2.2.3 Released

2018-12-17 Thread Daniel
On 2018-12-14 17:09, Chris Menzel wrote: I'm always hesitant to complain about this brilliant piece of software but, for me (Mojave 10.14.2 Beta) with this version, forward search (LyX ⟶ Skim) is still very slow and reverse search (Skim ⟶ LyX) appears to be nonfunctional. I've of course

Re: [LyX/master] Fix embarrassing typo

2018-12-17 Thread Richard Kimberly Heck
On 12/17/18 9:36 AM, Jean-Marc Lasgouttes wrote: > Le 17/12/2018 à 15:31, Jean-Marc Lasgouttes a écrit : >> commit 058c6750ac83b43819445ccf723283afb850ef91 >> Author: Jean-Marc Lasgouttes >> Date:   Mon Dec 17 12:28:32 2018 +0100 >> >> Fix embarrassing typo >> Not clear whether

Re: [LyX/master] Fix embarrassing typo

2018-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2018 à 17:17, Richard Kimberly Heck a écrit : On 12/17/18 9:36 AM, Jean-Marc Lasgouttes wrote: Le 17/12/2018 à 15:31, Jean-Marc Lasgouttes a écrit : commit 058c6750ac83b43819445ccf723283afb850ef91 Author: Jean-Marc Lasgouttes Date:   Mon Dec 17 12:28:32 2018 +0100 Fix

Misdrawn lines

2018-12-17 Thread Jürgen Spitzmüller
In current master, lines (misspelling marks, underlining, language marks) are drawn too high. See attached screenshot. Jürgen signature.asc Description: This is a digitally signed message part

Re: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread Jean-Marc Lasgouttes
Le 17/12/2018 à 16:00, David Binderman a écrit : I wonder why gcc, clang or coverity do not spot this, though. gcc and clang are compilers. Too often "you asked for it, you got it" seems to apply to C compilers. Well, with -Wall -Wextra (which we use) they already detect a number of things.

Re: lyx-2.3.2/src/Dimension.h:36]: (style) Same expression ?

2018-12-17 Thread David Binderman
Hello there, >Thanks a lot for spotting it. You are welcome. >I wonder why gcc, clang or coverity do not spot this, though. gcc and clang are compilers. Too often "you asked for it, you got it" seems to apply to C compilers. The static analyser coverity