Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Kornel Benko]

Am Freitag, 27. Oktober 2017 um 19:31:50, schrieb Guenter Milde 

> On 2017-10-27, Kornel Benko wrote:
> 
> > [-- Type: text/plain, Encoding: 7bit --]
> 
> > Am Freitag, 27. Oktober 2017 um 13:52:36, schrieb Scott Kostyshak 
> > 
> >> On Fri, Oct 27, 2017 at 01:46:38PM +, Guenter Milde wrote:
> 
> >> > > So, remove the eu_UserGuide.lyx from export test or correct the paths 
> >> > > and add again LaTeX.png?
> >> > 
> >> > I propose to remove (ignore) the export test.
> 
> >> I'm fine with either way.
> 
> >> Scott
> 
> > I'd like to keep it as a testfile. For this it has to be without wrong
> > references.
> 
> In this case, feel free to fix the document, whatever suits best.
> 
> Günter

Done at 7e18756.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Guenter Milde]

On 2017-10-27, Kornel Benko wrote:

> [-- Type: text/plain, Encoding: 7bit --]

> Am Freitag, 27. Oktober 2017 um 13:52:36, schrieb Scott Kostyshak 
> 
>> On Fri, Oct 27, 2017 at 01:46:38PM +, Guenter Milde wrote:

>> > > So, remove the eu_UserGuide.lyx from export test or correct the paths 
>> > > and add again LaTeX.png?
>> > 
>> > I propose to remove (ignore) the export test.

>> I'm fine with either way.

>> Scott

> I'd like to keep it as a testfile. For this it has to be without wrong
> references.

In this case, feel free to fix the document, whatever suits best.

Günter

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Kornel Benko]

Am Freitag, 27. Oktober 2017 um 13:52:36, schrieb Scott Kostyshak 

> On Fri, Oct 27, 2017 at 01:46:38PM +, Guenter Milde wrote:
> 
> > > So, remove the eu_UserGuide.lyx from export test or correct the paths and 
> > > add again LaTeX.png?
> > 
> > I propose to remove (ignore) the export test.
> 
> I'm fine with either way.
> 
> Scott

I'd like to keep it as a testfile. For this it has to be without wrong 
references.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Scott Kostyshak]

On Fri, Oct 27, 2017 at 01:46:38PM +, Guenter Milde wrote:

> > So, remove the eu_UserGuide.lyx from export test or correct the paths and 
> > add again LaTeX.png?
> 
> I propose to remove (ignore) the export test.

I'm fine with either way.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Guenter Milde]

On 2017-10-27, Kornel Benko wrote:
> Am Donnerstag, 26. Oktober 2017 um 17:04:41, schrieb Scott Kostyshak 
> 
>> On Thu, Oct 26, 2017 at 08:44:34PM +, Kornel Benko wrote:

>> > > > Thanks, Kornel. Why not put the string inside "diestack" instead of
>> > > > separate print?
>> > > 
>> > > I did it at first, but the string did not appear in the output. Will 
>> > > investigate why.
>> > > 
>> > > > Scott
>> > > 
>> > 
>> > Hm, must have been blinded.

>> Thanks for checking it out.

>> Scott

> The new export test shows *many* wrong paths in attic/eu_UserGuide_pdf2.
> Most of them can be corrected using extension 'svgz' instead of 'png'.

> Only LaTeX.png is totally missing. (But still exists in lyx2.1).

> So, remove the eu_UserGuide.lyx from export test or correct the paths and add 
> again LaTeX.png?

I propose to remove (ignore) the export test.

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Kornel Benko]

Am Donnerstag, 26. Oktober 2017 um 17:04:41, schrieb Scott Kostyshak 

> On Thu, Oct 26, 2017 at 08:44:34PM +, Kornel Benko wrote:
> 
> > > > Thanks, Kornel. Why not put the string inside "diestack" instead of
> > > > separate print?
> > > 
> > > I did it at first, but the string did not appear in the output. Will 
> > > investigate why.
> > > 
> > > > Scott
> > > 
> > 
> > Hm, must have been blinded.
> 
> Thanks for checking it out.
> 
> Scott

The new export test shows *many* wrong paths in attic/eu_UserGuide_pdf2.
Most of them can be corrected using extension 'svgz' instead of 'png'.

Only LaTeX.png is totally missing. (But still exists in lyx2.1).

So, remove the eu_UserGuide.lyx from export test or correct the paths and add 
again LaTeX.png?

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 08:44:34PM +, Kornel Benko wrote:

> > > Thanks, Kornel. Why not put the string inside "diestack" instead of
> > > separate print?
> > 
> > I did it at first, but the string did not appear in the output. Will 
> > investigate why.
> > 
> > > Scott
> > 
> 
> Hm, must have been blinded.

Thanks for checking it out.

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Kornel Benko]

Am Donnerstag, 26. Oktober 2017 um 22:32:52, schrieb Kornel Benko 

> Am Donnerstag, 26. Oktober 2017 um 16:30:14, schrieb Scott Kostyshak 
> 
> > On Thu, Oct 26, 2017 at 07:49:36PM +, Kornel Benko wrote:
> > > commit d63a866106a088fbf42504215a0a9193437e70de
> > > Author: Kornel Benko 
> > > Date:   Thu Oct 26 21:48:33 2017 +0200
> > > 
> > > Cmake export tests: Make test fail if there is some non-existant 
> > > sub-file
> > > ---
> > >  development/autotests/useSystemFonts.pl |7 +++
> > >  1 files changed, 7 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/development/autotests/useSystemFonts.pl 
> > > b/development/autotests/useSystemFonts.pl
> > > index 58006b0..61eee4d 100644
> > > --- a/development/autotests/useSystemFonts.pl
> > > +++ b/development/autotests/useSystemFonts.pl
> > > @@ -252,6 +252,13 @@ sub interpretedCopy()
> > > $res += $res1;
> > >   }
> > > }
> > > +   else {
> > > + if (! -e "$f") {
> > > +   # Non relative (e.g. with absolute path) file should exist
> > > +   print "File $f not found\n";
> > > +   diestack("");
> > > + }
> > > +   }
> > >   }
> > >   if ($foundrelative) {
> > > $rF->[$fidx] = join($separator, @{$filelist});
> > 
> > Thanks, Kornel. Why not put the string inside "diestack" instead of
> > separate print?
> 
> I did it at first, but the string did not appear in the output. Will 
> investigate why.
> 
> > Scott
> 

Hm, must have been blinded.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 08:32:52PM +, Kornel Benko wrote:

> I did it at first, but the string did not appear in the output. Will 
> investigate why.

I was just curious. If we do stay with print, let's at least print to
STDERR?

Scott


signature.asc
Description: PGP signature

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Kornel Benko]

Am Donnerstag, 26. Oktober 2017 um 16:30:14, schrieb Scott Kostyshak 

> On Thu, Oct 26, 2017 at 07:49:36PM +, Kornel Benko wrote:
> > commit d63a866106a088fbf42504215a0a9193437e70de
> > Author: Kornel Benko 
> > Date:   Thu Oct 26 21:48:33 2017 +0200
> > 
> > Cmake export tests: Make test fail if there is some non-existant 
> > sub-file
> > ---
> >  development/autotests/useSystemFonts.pl |7 +++
> >  1 files changed, 7 insertions(+), 0 deletions(-)
> > 
> > diff --git a/development/autotests/useSystemFonts.pl 
> > b/development/autotests/useSystemFonts.pl
> > index 58006b0..61eee4d 100644
> > --- a/development/autotests/useSystemFonts.pl
> > +++ b/development/autotests/useSystemFonts.pl
> > @@ -252,6 +252,13 @@ sub interpretedCopy()
> >   $res += $res1;
> > }
> >   }
> > + else {
> > +   if (! -e "$f") {
> > + # Non relative (e.g. with absolute path) file should exist
> > + print "File $f not found\n";
> > + diestack("");
> > +   }
> > + }
> > }
> > if ($foundrelative) {
> >   $rF->[$fidx] = join($separator, @{$filelist});
> 
> Thanks, Kornel. Why not put the string inside "diestack" instead of
> separate print?

I did it at first, but the string did not appear in the output. Will 
investigate why.

> Scott

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Cmake export tests: Make test fail if there is some non-existant sub-file

[Scott Kostyshak]

On Thu, Oct 26, 2017 at 07:49:36PM +, Kornel Benko wrote:
> commit d63a866106a088fbf42504215a0a9193437e70de
> Author: Kornel Benko 
> Date:   Thu Oct 26 21:48:33 2017 +0200
> 
> Cmake export tests: Make test fail if there is some non-existant sub-file
> ---
>  development/autotests/useSystemFonts.pl |7 +++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/development/autotests/useSystemFonts.pl 
> b/development/autotests/useSystemFonts.pl
> index 58006b0..61eee4d 100644
> --- a/development/autotests/useSystemFonts.pl
> +++ b/development/autotests/useSystemFonts.pl
> @@ -252,6 +252,13 @@ sub interpretedCopy()
> $res += $res1;
>   }
> }
> +   else {
> + if (! -e "$f") {
> +   # Non relative (e.g. with absolute path) file should exist
> +   print "File $f not found\n";
> +   diestack("");
> + }
> +   }
>   }
>   if ($foundrelative) {
> $rF->[$fidx] = join($separator, @{$filelist});

Thanks, Kornel. Why not put the string inside "diestack" instead of
separate print?

Scott


signature.asc
Description: PGP signature