Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 11:05:45AM -0500, Scott Kostyshak wrote: > Done in master at c5301a64. Riki, can this go to 2.3.x? Riki gave the OK (I accidentally sent an email without CC'ing devel). Pushed to 2.3.x at 4ea6d814. Scott signature.asc Description: PGP signature

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 03:48:37PM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 09:44 -0500 schrieb Scott Kostyshak: > > Tested and works well. Do we also have to test that the inset's texts > > are the same? Just thinking about what you said above, it seems > > possible > > that

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 09:44 -0500 schrieb Scott Kostyshak: > Tested and works well. Do we also have to test that the inset's texts > are the same? Just thinking about what you said above, it seems > possible > that the pit and the cell could be the same, but be in different > inset's >

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 09:31:21AM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 02:29 -0500 schrieb Scott Kostyshak: > > Attached is a patch. It seems that the problem is: > > > > bool const in_last_par = (it.pit() == cur.selectionEnd().pit()); > > > > Apparently this doesn't

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 02:29 -0500 schrieb Scott Kostyshak: > Attached is a patch. It seems that the problem is: > > bool const in_last_par = (it.pit() == cur.selectionEnd().pit()); > > Apparently this doesn't always do what I thought it did. Replacing it > with > > bool const

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-27 Thread Scott Kostyshak
On Thu, Dec 27, 2018 at 07:56:23PM -0500, Scott Kostyshak wrote: > On Thu, Dec 27, 2018 at 01:22:16PM +0100, Jürgen Spitzmüller wrote: > > Am Donnerstag, den 27.12.2018, 12:57 +0100 schrieb Kornel Benko: > > > Only crashes if opened rw here (e.g. not from Help menu) > > > > That's what I did as

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-27 Thread Scott Kostyshak
On Thu, Dec 27, 2018 at 01:22:16PM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, den 27.12.2018, 12:57 +0100 schrieb Kornel Benko: > > Only crashes if opened rw here (e.g. not from Help menu) > > That's what I did as well (open rw). I can reproduce. I'll look into it. > It probably depends

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-27 Thread Jürgen Spitzmüller
Am Donnerstag, den 27.12.2018, 12:57 +0100 schrieb Kornel Benko: > Only crashes if opened rw here (e.g. not from Help menu) That's what I did as well (open rw). It probably depends on whether some feature is enabled. Jürgen signature.asc Description: This is a digitally signed message part

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-27 Thread Kornel Benko
Am Donnerstag, 27. Dezember 2018 09:37:56 CET schrieb Jürgen Spitzmüller : > Am Freitag, den 27.07.2018, 21:42 +0200 schrieb Scott Kostyshak: > > commit d12798759aeb7bae77bec63098fd81f8cc9e554b > > Author: Scott Kostyshak > > Date: Fri Jul 27 15:28:22 2018 -0400 > > > > Fix crash when

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-27 Thread Jürgen Spitzmüller
Am Freitag, den 27.07.2018, 21:42 +0200 schrieb Scott Kostyshak: > commit d12798759aeb7bae77bec63098fd81f8cc9e554b > Author: Scott Kostyshak > Date: Fri Jul 27 15:28:22 2018 -0400 > > Fix crash when selecting text with changes > > When selecting text, in some cases a DocIterator