Re: [LyX/master] New method zoomedPixel to compute pixel amount also in HiDpi

2018-01-26 Thread Joel Kulesza 
On Fri, Jan 26, 2018 at 2:10 AM, Jean-Marc Lasgouttes 
wrote:
>
> You mean that I should have tested my code before committing? Should be
> fixed now.
>

It's fixed for me.

Thanks,
Joel

P.S. I've been told that real men treat code checkins/commits as
fire-and-forget .  No
worries.  :-)

Re: [LyX/master] New method zoomedPixel to compute pixel amount also in HiDpi

2018-01-26 Thread Jean-Marc Lasgouttes 

Le 26/01/2018 à 06:49, Scott Kostyshak a écrit :

After this commit, when I open and start a new document, I cannot see
what I type. If I try to zoom out, LyX hangs.


You mean that I should have tested my code before committing? Should be 
fixed now.


Sorry,
JMarc

Re: [LyX/master] New method zoomedPixel to compute pixel amount also in HiDpi

2018-01-25 Thread Joel Kulesza 
On Thu, Jan 25, 2018 at 10:49 PM, Scott Kostyshak  wrote:

> On Thu, Jan 25, 2018 at 09:08:41PM +, Jean-Marc Lasgouttes wrote:
> > commit 1a969fa4a6130506ab52e72098ae0edce48d3231
> > Author: Jean-Marc Lasgouttes 
> > Date:   Thu Jan 25 22:06:03 2018 +0100
> >
> > New method zoomedPixel to compute pixel amount also in HiDpi
> >
> > The function does not use for now any information from the BufferView
> > (only lyxrc), but this should eventually change if we want to honor
> > multi monitor setups properly.
>
> After this commit, when I open and start a new document, I cannot see
> what I type. If I try to zoom out, LyX hangs.


I experience the same (OS X 10.11.6, 27-inch 5k monitor).

LyX Version 2.4.0dev

(not released yet)

Built from git commit hash c7d7ac31

Library directory: /local/LyX_DEV.app/Contents/Resources/

User directory: ~/Library/Application Support/LyX/

Qt Version (run-time): 5.10.0

Qt Version (compile-time): 5.10.0


- Joel

Re: [LyX/master] New method zoomedPixel to compute pixel amount also in HiDpi

2018-01-25 Thread Scott Kostyshak 
On Thu, Jan 25, 2018 at 09:08:41PM +, Jean-Marc Lasgouttes wrote:
> commit 1a969fa4a6130506ab52e72098ae0edce48d3231
> Author: Jean-Marc Lasgouttes 
> Date:   Thu Jan 25 22:06:03 2018 +0100
> 
> New method zoomedPixel to compute pixel amount also in HiDpi
> 
> The function does not use for now any information from the BufferView
> (only lyxrc), but this should eventually change if we want to honor
> multi monitor setups properly.

After this commit, when I open and start a new document, I cannot see
what I type. If I try to zoom out, LyX hangs.

Scott


signature.asc
Description: PGP signature