Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Fri, 17 Aug 2007, Abdelrazak Younes wrote: The patch itself is not that big. The changes in BufferView is all about removal of function and removal of test of the type 'if (buffer_)' which does not make sense anymore. So, objection? Thanks for the updated description, I may even dare to try and look at the patch/code this weekend now:-) As it's Friday evening after a long day, I'd like to ask if I've understood the description reasonably correct. Ignoring Qt specializations. LyXView | tab-widget | (many) WorkArea --- Buffer | BufferView | Cursor Don't know how to represent that there may be many WorkAreas in the tab widget, or that there may be more buffers in the system. Anyway, if the image is reasonably accurate, I think it might help to be placed with the descriptive text. Should there be an 'Application' somewhere in there as well? /C -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
Abdelrazak Younes wrote: Here is my most recent patch. What is not working yet: - the close tab button: it is implemented but does not show up. - the splash screen: it is implemented but does not show up. I solved the splash screen bug and there is apparently no objection so I will commit it. Abdel.
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Fri, 17 Aug 2007, Abdelrazak Younes wrote: Abdelrazak Younes wrote: I solved the splash screen bug and there is apparently no objection so I will commit it. Please don't get this wrong, I'm serious with the question: What's the rush? What's the consequence from a development point of view if you wait longer? As for no comments, it's only been a few hours and that was 3000 lines. Some of use are at work you know... ;-) Speaking of rush, I've have to hurry now. /C -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Friday 17 August 2007 17:49:18 Abdelrazak Younes wrote: Some of use are at work you know... ;-) I know and my real work has suffered from this patch simplification which I still think was worth nothing. The purpose of longer delays applies only to large patches, not to small ones. Usually (but not always) a large patch is due to some architectural change. That is why the commit log helps (as you did with this patch) a lot more than any incremental logs. I'll wait until tomorrow. OK, thanks. :-) Abdel. -- José Abílio
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
[EMAIL PROTECTED] wrote: On Fri, 17 Aug 2007, Abdelrazak Younes wrote: Abdelrazak Younes wrote: I solved the splash screen bug and there is apparently no objection so I will commit it. Please don't get this wrong, I'm serious with the question: What's the rush? I assume the people interested have already looked at the incremental diffs. And the first version of patch has been sent on Sunday. What's the consequence from a development point of view if you wait longer? As for no comments, it's only been a few hours and that was 3000 lines. Most of it is deletion and third of it is just the BufferView::buffer_ test removal. Some of use are at work you know... ;-) I know and my real work has suffered from this patch simplification which I still think was worth nothing. I'll wait until tomorrow. Abdel.
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
[EMAIL PROTECTED] wrote: On Fri, 17 Aug 2007, Abdelrazak Younes wrote: The patch itself is not that big. The changes in BufferView is all about removal of function and removal of test of the type 'if (buffer_)' which does not make sense anymore. So, objection? Thanks for the updated description, I may even dare to try and look at the patch/code this weekend now:-) As it's Friday evening after a long day, I'd like to ask if I've understood the description reasonably correct. Ignoring Qt specializations. LyXView | tab-widget | (many) WorkArea --- Buffer | BufferView | Cursor If the --- means a refernce or a pointer then it's more something like this: BufferList (N Buffer) | Buffer-a Buffer-b Buffer-c Buffer-d Application (this is the frontend really, should probably be renamed). | LyXView-1 (M1 WorkAreas, M1 = N) | | | tab-widget | | (many) | WorkArea-1 | | | BufferView --- Buffer-c | | | Cursor | LyXView-2 (M2 WorkAreas, M2 = N, M2 independent of M1) | ... Don't know how to represent that there may be many WorkAreas in the tab widget, or that there may be more buffers in the system. Anyway, if the image is reasonably accurate, I think it might help to be placed with the descriptive text. Should there be an 'Application' somewhere in there as well? See above.
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Fri, Aug 17, 2007 at 06:13:46PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Here is my most recent patch. What is not working yet: - the close tab button: it is implemented but does not show up. - the splash screen: it is implemented but does not show up. I solved the splash screen bug and there is apparently no objection so I will commit it. No detailed review for a 3167 line patch within a whopping 6 hours and 25 minutes? What a lazy bunch we all are. Andre' PS: A 'few days' would be appropriate.
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Fri, 17 Aug 2007, Abdelrazak Younes wrote: The patch itself is not that big. The changes in BufferView is all about removal of function and removal of test of the type 'if (buffer_)' which does not make sense anymore. So, objection? Thanks for the updated description, I may even dare to try and look at the patch/code this weekend now:-) As it's Friday evening after a long day, I'd like to ask if I've understood the description reasonably correct. Ignoring Qt specializations. LyXView | | (many) WorkArea <---> Buffer | BufferView | Cursor Don't know how to represent that there may be many WorkAreas in the tab widget, or that there may be more buffers in the system. Anyway, if the image is reasonably accurate, I think it might help to be placed with the descriptive text. Should there be an 'Application' somewhere in there as well? /C -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
Abdelrazak Younes wrote: Here is my most recent patch. What is not working yet: - the close tab button: it is implemented but does not show up. - the splash screen: it is implemented but does not show up. I solved the splash screen bug and there is apparently no objection so I will commit it. Abdel.
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Fri, 17 Aug 2007, Abdelrazak Younes wrote: Abdelrazak Younes wrote: I solved the splash screen bug and there is apparently no objection so I will commit it. Please don't get this wrong, I'm serious with the question: What's the rush? What's the consequence from a development point of view if you wait longer? As for no comments, it's only been a few hours and that was 3000 lines. Some of use are at work you know... ;-) Speaking of rush, I've have to hurry now. /C -- Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Friday 17 August 2007 17:49:18 Abdelrazak Younes wrote: > > Some of use are at work you know... ;-) > > I know and my real work has suffered from this patch simplification > which I still think was worth nothing. The purpose of longer delays applies only to large patches, not to small ones. Usually (but not always) a large patch is due to some architectural change. That is why the commit log helps (as you did with this patch) a lot more than any incremental logs. > I'll wait until tomorrow. OK, thanks. :-) > Abdel. -- José Abílio
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
[EMAIL PROTECTED] wrote: On Fri, 17 Aug 2007, Abdelrazak Younes wrote: Abdelrazak Younes wrote: I solved the splash screen bug and there is apparently no objection so I will commit it. Please don't get this wrong, I'm serious with the question: What's the rush? I assume the people interested have already looked at the incremental diffs. And the first version of patch has been sent on Sunday. What's the consequence from a development point of view if you wait longer? As for no comments, it's only been a few hours and that was 3000 lines. Most of it is deletion and third of it is just the BufferView::buffer_ test removal. Some of use are at work you know... ;-) I know and my real work has suffered from this patch simplification which I still think was worth nothing. I'll wait until tomorrow. Abdel.
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
[EMAIL PROTECTED] wrote: On Fri, 17 Aug 2007, Abdelrazak Younes wrote: The patch itself is not that big. The changes in BufferView is all about removal of function and removal of test of the type 'if (buffer_)' which does not make sense anymore. So, objection? Thanks for the updated description, I may even dare to try and look at the patch/code this weekend now:-) As it's Friday evening after a long day, I'd like to ask if I've understood the description reasonably correct. Ignoring Qt specializations. LyXView | | (many) WorkArea <---> Buffer | BufferView | Cursor If the <---> means a refernce or a pointer then it's more something like this: BufferList (N Buffer) | Buffer-a Buffer-b Buffer-c Buffer-d Application (this is the frontend really, should probably be renamed). | LyXView-1 (M1 WorkAreas, M1 <= N) | | | | | (many) | WorkArea-1 | | | BufferView <---> Buffer-c | | | Cursor | LyXView-2 (M2 WorkAreas, M2 <= N, M2 independent of M1) | ... Don't know how to represent that there may be many WorkAreas in the tab widget, or that there may be more buffers in the system. Anyway, if the image is reasonably accurate, I think it might help to be placed with the descriptive text. Should there be an 'Application' somewhere in there as well? See above.
Re: [PATCH] BufferView/WorkArea/LyXView reorg a.k.a Multiple WorkAreas
On Fri, Aug 17, 2007 at 06:13:46PM +0200, Abdelrazak Younes wrote: > Abdelrazak Younes wrote: > >Here is my most recent patch. What is not working yet: > >- the close tab button: it is implemented but does not show up. > >- the splash screen: it is implemented but does not show up. > > I solved the splash screen bug and there is apparently no objection so I > will commit it. No detailed review for a 3167 line patch within a whopping 6 hours and 25 minutes? What a lazy bunch we all are. Andre' PS: A 'few days' would be appropriate.
