Re: [PATCH] Re: Plan for final steps of 2.3.0 release

2018-02-13 Thread Scott Kostyshak
On Mon, Feb 12, 2018 at 05:45:19PM +, Jean-Marc Lasgouttes wrote: > Le 12/02/2018 à 17:41, Scott Kostyshak a écrit : > > Why do you leave in the following code? > > > > #if defined(Q_WS_X11) || defined(QPA_XCB) > > pixmapCacheCB->setEnabled(false); > > #endif > > > > I'm guessing

Re: [PATCH] Re: Plan for final steps of 2.3.0 release

2018-02-12 Thread Jean-Marc Lasgouttes
Le 12/02/2018 à 17:41, Scott Kostyshak a écrit : Why do you leave in the following code? #if defined(Q_WS_X11) || defined(QPA_XCB) pixmapCacheCB->setEnabled(false); #endif I'm guessing it's because you want to make as minimal changes as possible? Yes. JMarc

Re: [PATCH] Re: Plan for final steps of 2.3.0 release

2018-02-12 Thread Scott Kostyshak
On Mon, Feb 12, 2018 at 10:18:16AM +, Jean-Marc Lasgouttes wrote: > This seems simple enough, but of course should be checked by Mac/Win people. +1 > I also removed traces of it in the English User's Guide, and added some > entries in release notes. Feel free to improve on the wording. Than

Re: [PATCH] Re: Plan for final steps of 2.3.0 release

2018-02-12 Thread Jean-Marc Lasgouttes
Le 12/02/2018 à 11:18, Jean-Marc Lasgouttes a écrit : Le 10/02/2018 à 22:24, Jean-Marc Lasgouttes a écrit : I can propose something simple on Monday: remove from GUI (like we do in Linux) and always act as if the pref is off. Here is what I had in mind. I discovered that the checkbox was not