I can confirm that patch also works for qt 4.2.0.
On 5/14/07, Ozgur Ugras BARAN [EMAIL PROTECTED] wrote:
Attached patch solves TOC bug 3529 for Qt-4.3-pre. The problem was
blocked selectionchanged signal for selectionModel prevents correct
repainting. I have no idea whether this patch works
Ozgur Ugras BARAN wrote:
Attached patch solves TOC bug 3529 for Qt-4.3-pre. The problem was
blocked selectionchanged signal for selectionModel prevents correct
repainting. I have no idea whether this patch works for qt-4.2 or not.
Therefore, please somebody test it?
Works for me (qt 4.2.3).
Oh, there is another problem, now. Please do not apply patch. When you
change the selection with mouse, cursor goes to the beginning of the
section. With keyboard there is no problem.
I will solve this and resend the patch.
sorry..
Ugras
On 5/15/07, Jürgen Spitzmüller [EMAIL PROTECTED] wrote:
This one should be better in behaviour, but ugly as hell.
Would you please test it, again?
regards,
Ugras
On 5/15/07, Ozgur Ugras BARAN [EMAIL PROTECTED] wrote:
Oh, there is another problem, now. Please do not apply patch. When you
change the selection with mouse, cursor goes to the
Ozgur Ugras BARAN wrote:
This one should be better in behaviour, but ugly as hell.
Would you please test it, again?
Works for me AFAICT. As said, I can commit it for you if I get o.k. from Abdel
and José (and a log file entry from you).
Jürgen
On Tuesday 15 May 2007 08:40:44 Jürgen Spitzmüller wrote:
Ozgur Ugras BARAN wrote:
This one should be better in behaviour, but ugly as hell.
Would you please test it, again?
Works for me AFAICT. As said, I can commit it for you if I get o.k. from
Abdel and José (and a log file entry from
Ozgur Ugras BARAN wrote:
Oh, there is another problem, now. Please do not apply patch. When you
change the selection with mouse, cursor goes to the beginning of the
section. With keyboard there is no problem.
Yes, to answer Jurgen, that was one of the reason for blocking the
signal IIRC.
Ozgur Ugras BARAN wrote:
This one should be better in behaviour, but ugly as hell.
Let me judge it first ;-)
Index: frontends/qt4/TocWidget.cpp
===
---
Abdelrazak Younes wrote:
As far as I see this patch looks correct. Jurgen, if you tested it
carefully with mouse and keyboard navigation, and with the different
buttons and lists, I think you can commit it.
Yes, I tested all cases I could think of. I'll commit as soon as Ugras sends a
log
Correct bug 3529-(TOC widget does not select the current
part/section/subsection correctly) by replacing blockSignal()
directives for tocTV- selectionModel() with disconnect and reconnect
relevant signal.
Thanks Jurgen, Abdel.
ugras
On 5/15/07, Jürgen Spitzmüller [EMAIL PROTECTED] wrote:
Ozgur Ugras BARAN wrote:
Correct bug 3529-(TOC widget does not select the current
part/section/subsection correctly) by replacing blockSignal()
directives for tocTV- selectionModel() with disconnect and reconnect
relevant signal.
Thanks Jurgen, Abdel.
Applied. However, I rather meant
On Tuesday 15 May 2007 12:08:13 Ozgur Ugras BARAN wrote:
Correct bug 3529-(TOC widget does not select the current
part/section/subsection correctly) by replacing blockSignal()
directives for tocTV- selectionModel() with disconnect and reconnect
relevant signal.
Thanks Jurgen, Abdel.
ugras
I can confirm that patch also works for qt 4.2.0.
On 5/14/07, Ozgur Ugras BARAN <[EMAIL PROTECTED]> wrote:
Attached patch solves TOC bug 3529 for Qt-4.3-pre. The problem was
blocked selectionchanged signal for selectionModel prevents correct
repainting. I have no idea whether this patch works
Ozgur Ugras BARAN wrote:
> Attached patch solves TOC bug 3529 for Qt-4.3-pre. The problem was
> blocked selectionchanged signal for selectionModel prevents correct
> repainting. I have no idea whether this patch works for qt-4.2 or not.
> Therefore, please somebody test it?
Works for me (qt
Oh, there is another problem, now. Please do not apply patch. When you
change the selection with mouse, cursor goes to the beginning of the
section. With keyboard there is no problem.
I will solve this and resend the patch.
sorry..
Ugras
On 5/15/07, Jürgen Spitzmüller <[EMAIL PROTECTED]>
This one should be better in behaviour, but ugly as hell.
Would you please test it, again?
regards,
Ugras
On 5/15/07, Ozgur Ugras BARAN <[EMAIL PROTECTED]> wrote:
Oh, there is another problem, now. Please do not apply patch. When you
change the selection with mouse, cursor goes to the
Ozgur Ugras BARAN wrote:
> This one should be better in behaviour, but ugly as hell.
>
> Would you please test it, again?
Works for me AFAICT. As said, I can commit it for you if I get o.k. from Abdel
and José (and a log file entry from you).
Jürgen
On Tuesday 15 May 2007 08:40:44 Jürgen Spitzmüller wrote:
> Ozgur Ugras BARAN wrote:
> > This one should be better in behaviour, but ugly as hell.
> >
> > Would you please test it, again?
>
> Works for me AFAICT. As said, I can commit it for you if I get o.k. from
> Abdel and José (and a log file
Ozgur Ugras BARAN wrote:
Oh, there is another problem, now. Please do not apply patch. When you
change the selection with mouse, cursor goes to the beginning of the
section. With keyboard there is no problem.
Yes, to answer Jurgen, that was one of the reason for blocking the
signal IIRC.
Ozgur Ugras BARAN wrote:
This one should be better in behaviour, but ugly as hell.
Let me judge it first ;-)
Index: frontends/qt4/TocWidget.cpp
===
---
Abdelrazak Younes wrote:
> As far as I see this patch looks correct. Jurgen, if you tested it
> carefully with mouse and keyboard navigation, and with the different
> buttons and lists, I think you can commit it.
Yes, I tested all cases I could think of. I'll commit as soon as Ugras sends a
log
Correct bug 3529-(TOC widget does not select the current
part/section/subsection correctly) by replacing blockSignal()
directives for tocTV- selectionModel() with disconnect and reconnect
relevant signal.
Thanks Jurgen, Abdel.
ugras
On 5/15/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote:
Ozgur Ugras BARAN wrote:
> Correct bug 3529-(TOC widget does not select the current
> part/section/subsection correctly) by replacing blockSignal()
> directives for tocTV- selectionModel() with disconnect and reconnect
> relevant signal.
>
> Thanks Jurgen, Abdel.
Applied. However, I rather meant
On Tuesday 15 May 2007 12:08:13 Ozgur Ugras BARAN wrote:
> Correct bug 3529-(TOC widget does not select the current
> part/section/subsection correctly) by replacing blockSignal()
> directives for tocTV- selectionModel() with disconnect and reconnect
> relevant signal.
>
> Thanks Jurgen, Abdel.
>
24 matches
Mail list logo
