Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-20 Thread Christian Ridderström 
On 20 March 2017 at 07:11, Guillaume MM  wrote:

> What is this patch that fixes make distcheck? Can it be applied in master?


I've found the thread with the patch (by searching for Fix-distclean-for
-recent-automake-versions) and did a reply in that thread, better discussed
there I think.
/C

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #107

2017-03-20 Thread Pavel Sanda 
Guillaume MM wrote:
> What is this patch that fixes make distcheck? Can it be applied in master?

https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg198636.html
p

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-20 Thread Guillaume MM 

Le 19/03/2017 à 12:26, Christian Ridderström a écrit :


# Temporary fix: Apply JMarc's patch to allow 'make distcheck' to
complete
patch -p1 <
/builds/0001-Fix-distclean-for-recent-automake-versions.patch


Jean-Marc, perhaps that patch should no longer be applied?  It was
needed earlier to make the checks pass.
I've created another CI job that's not applying that patch and that's
currently running, so we'll see what happens.
/Christian




What is this patch that fixes make distcheck? Can it be applied in master?

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-19 Thread Jean-Marc Lasgouttes 
Yes, it is probably the reason : this patch has moved the dummy functions file 
around. It is probably possible to fix it, though.

JMarc

Le 19 mars 2017 12:26:23 GMT+01:00, "Christian Ridderström"  a 
écrit :
>On 19 March 2017 at 12:14, Christian Ridderström  wrote:
>
>>
>> But I think someone should take a log at the error output and see if
>they
>> can figure out why it's breaking, I think it's a real breakage.
>>
>
>Could perhaps the following line in the CI job's configuration be
>related...:
>
># Temporary fix: Apply JMarc's patch to allow 'make distcheck' to
>complete
>patch -p1 <
>/builds/0001-Fix-distclean-for-recent-automake-versions.patch
>
>
>Jean-Marc, perhaps that patch should no longer be applied?  It was
>needed
>earlier to make the checks pass.
>I've created another CI job that's not applying that patch and that's
>currently running, so we'll see what happens.
>/Christian

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-19 Thread Christian Ridderström 
On 19 March 2017 at 12:14, Christian Ridderström  wrote:

>
> But I think someone should take a log at the error output and see if they
> can figure out why it's breaking, I think it's a real breakage.
>

Could perhaps the following line in the CI job's configuration be
related...:

# Temporary fix: Apply JMarc's patch to allow 'make distcheck' to complete
patch -p1 < /builds/0001-Fix-distclean-for-recent-automake-versions.patch


Jean-Marc, perhaps that patch should no longer be applied?  It was needed
earlier to make the checks pass.
I've created another CI job that's not applying that patch and that's
currently running, so we'll see what happens.
/Christian

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-19 Thread Christian Ridderström 
On 18 March 2017 at 22:20, Christian Ridderström  wrote:

> Christian, does the check start from a fresh tree? If you do 'make
>>> clean' and the rules have changed, it might be that some .o files remain
>>> at the wrong place
>>>
>>
>> I think most CI jobs are configured to start from a completely empty work
>> folders.
>>
>
> I checked just now by looking here (you may have to be logged in):
>https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-
> xenial-qt4-autotools-extended/configure
> and under the section
>Build environment
> the setting
>Delete workspace before build starts
> is checked...  So the build really should be starting from a clean slate.
>

The build still fails, so I don't think it's related to the build process...
I'm going to see if I can set up a CI job for "parametrised build", where
it's possible to provide e.g. the commit hash. We can then go back and
re-build "#104" to confirm that commit build. Then we can step forward and
see where it breaks.

But I think someone should take a log at the error output and see if they
can figure out why it's breaking, I think it's a real breakage.
/Christian

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-18 Thread Christian Ridderström 
On 18 March 2017 at 16:46, Christian Ridderström  wrote:

> Christian, does the check start from a fresh tree? If you do 'make
>> clean' and the rules have changed, it might be that some .o files remain
>> at the wrong place
>>
>
> I think most CI jobs are configured to start from a completely empty work
> folders.
>

I checked just now by looking here (you may have to be logged in):

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/configure
and under the section
   Build environment
the setting
   Delete workspace before build starts
is checked...  So the build really should be starting from a clean slate.

However, it's possible to manually trigger the deletion of the workspace by
going to look at the workdir:

https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/ws/
and on the left side there's a link to "Wipe out current workspace".  I
tried to execute that, but it failed.
So I surmise that there's a problem with the permissions, resulting in the
CI server not being able to properly delete the workdir.

I SSH:d to the CI worker and deleted the workdir and have started the build
manually. We'll see if it builds now.
If it does, I can see if it's possible to e.g. add some "cleanup" command
to the CI job that's done at the beginning.
/Christian

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-18 Thread Christian Ridderström 
On Fri, 17 Mar 2017 at 21:10, Jean-Marc Lasgouttes 
wrote:

> Le 15/03/2017 à 12:12, Kornel Benko a écrit :
> > Probably some automake failure. Using old
> ./src/support/tests/dummy_functions.o in the build dir.
> > Removing that file, it will be rebuild with
> >   make check-recursive
> > and './src/check_layout' is linked.
> >
> > Don't understand, why in this case dummy_functions.o does not depend on
> dummy_functions.cpp
>
> I cannot reproduce, either with new style automake nor with old-style.
>
> Christian, does the check start from a fresh tree? If you do 'make
> clean' and the rules have changed, it might be that some .o files remain
> at the wrong place
>

I think most CI jobs are configured to start from a completely empty work
folders.

Maybe I'll have time to confirm this tonight (it's visible in the
configuration of the job).
Christian

>
>
>

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-17 Thread Jean-Marc Lasgouttes 

Le 15/03/2017 à 12:12, Kornel Benko a écrit :

Probably some automake failure. Using old ./src/support/tests/dummy_functions.o 
in the build dir.
Removing that file, it will be rebuild with
make check-recursive
and './src/check_layout' is linked.

Don't understand, why in this case dummy_functions.o does not depend on 
dummy_functions.cpp


I cannot reproduce, either with new style automake nor with old-style.

Christian, does the check start from a fresh tree? If you do 'make 
clean' and the rules have changed, it might be that some .o files remain 
at the wrong place.


JMarc

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #107

2017-03-15 Thread Kornel Benko 
Am Mittwoch, 15. März 2017 um 11:51:29, schrieb ci-...@inria.fr
> https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/107/Changes:

...

> Makefile:2134: recipe for target 'check_layout' failed
> make[4]: Leaving directory '/build/workspace/src'
> Makefile:2806: recipe for target 'check-am' failed
> make[3]: Leaving directory '/build/workspace/src'
> Makefile:2481: recipe for target 'check-recursive' failed
> make[2]: Leaving directory '/build/workspace/src'
> Makefile:2809: recipe for target 'check' failed
> make[1]: Leaving directory '/build/workspace/src'
> Makefile:575: recipe for target 'check-recursive' failed
> Command 'make check' failed, exiting
> Lexer.o: In function `lyx::Lexer::Pimpl::setFile(lyx::support::FileName 
> const&)':
> /build/workspace/src/Lexer.cpp:242: undefined reference to `lyx::theFormats()'
> collect2: error: ld returned 1 exit status
> make[4]: *** [check_layout] Error 1
> make[3]: *** [check-am] Error 2
> make[2]: *** [check-recursive] Error 1
> make[1]: *** [check] Error 2
> make: *** [check-recursive] Error 1
> Build step 'Execute shell' marked build as failure

Probably some automake failure. Using old ./src/support/tests/dummy_functions.o 
in the build dir.
Removing that file, it will be rebuild with
make check-recursive
and './src/check_layout' is linked.

Don't understand, why in this case dummy_functions.o does not depend on 
dummy_functions.cpp

Kornel

signature.asc
Description: This is a digitally signed message part.