Re: Changes in lettre.cls

[Scott Kostyshak]

On Wed, Mar 28, 2018 at 09:24:51AM +, Jean-Pierre Chrétien wrote:

> Oups, I put the link in the file itself, sorry.

That works also. Thanks,

Scott


signature.asc
Description: PGP signature

Re: Changes in lettre.cls

[Jean-Pierre Chrétien]

Le 27/03/2018 à 18:23, Scott Kostyshak a écrit :

On Tue, Mar 27, 2018 at 04:10:43PM +, Jean-Pierre Chrétien wrote:

Le 16/09/2017 à 20:44, Jean-Pierre a écrit :

Le 16 septembre 2017 6:39:06 PM Scott Kostyshak  a écrit :


On Sun, Aug 13, 2017 at 06:39:16PM +0200, Jean-Pierre Chrétien wrote:

Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :



Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
upgrade I see the following test failures:

  6221 - export/templates/lettre_dvi3_systemF (Failed)
  6226 - export/templates/lettre_pdf4_systemF (Failed)
  6228 - export/templates/lettre_pdf5_systemF (Failed)


I see the errors when I run xelatex manually, seems en polyglossia problem,
I will investigate.


Jean-Pierre, did you have time to investigate? Anything you think we
should do for 2.3.0 on this? I have not tried to see if a tlmgr update
magically made these issues go away.



Sorry, I'm away from my desktop right now, ans I was busy with translations 
before.
I will check when I'm back.



Sorry again, it took me some time to come back to this.


No problem, thanks for tackling this annoying issue.


There is a quite intricate problem with polyglossia in the additional preamble 
code.

If I force babel as linguistic package, the three exports work manually.
However there are error/warnings from the dvi viewer which need further
investigation;


I might suggest to not even investigate dvi issues, if all PDF exports
are working well, unless you think it could be incorrect code written by
LyX.


Thes errors are font management errors, might disappear with other fonts than 
FreeSans. I'll check later.


[...]


In your commit message could you give a few details and maybe link to
this ML thread? This way if someone in two years wants to know why babel
was forced (e.g. from git log lettre.lyx or git blame), they will
quickly find this discussion.


Oups, I put the link in the file itself, sorry.

--
Jean-Pierre

Re: Changes in lettre.cls

[Richard Kimberly Heck]

On 03/27/2018 12:10 PM, Jean-Pierre Chrétien wrote:
> Le 16/09/2017 à 20:44, Jean-Pierre a écrit :
>> Le 16 septembre 2017 6:39:06 PM Scott Kostyshak  a
>> écrit :
>>
>>> On Sun, Aug 13, 2017 at 06:39:16PM +0200, Jean-Pierre Chrétien wrote:
 Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :

 >
 > Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
 > upgrade I see the following test failures:
 >
 > 6221 - export/templates/lettre_dvi3_systemF (Failed)
 > 6226 - export/templates/lettre_pdf4_systemF (Failed)
 > 6228 - export/templates/lettre_pdf5_systemF (Failed)

 I see the errors when I run xelatex manually, seems en polyglossia
 problem,
 I will investigate.
>>>
>>> Jean-Pierre, did you have time to investigate? Anything you think we
>>> should do for 2.3.0 on this? I have not tried to see if a tlmgr update
>>> magically made these issues go away.
>>>
>>
>> Sorry, I'm away from my desktop right now, ans I was busy with
>> translations before.
>> I will check when I'm back.
>>
>
> Sorry again, it took me some time to come back to this.
>
> [...]
>
> Currently, I suggest to solve the issue by committing the change in
> the lettre.lyx template, see attachment (I left TeX fonts as default).
> OK to commit to master?
>
> Riki, OK to commit to 2.3.x as well?

OK.

Riki

Re: Changes in lettre.cls

[Scott Kostyshak]

On Tue, Mar 27, 2018 at 04:10:43PM +, Jean-Pierre Chrétien wrote:
> Le 16/09/2017 à 20:44, Jean-Pierre a écrit :
> > Le 16 septembre 2017 6:39:06 PM Scott Kostyshak  a écrit :
> > 
> > > On Sun, Aug 13, 2017 at 06:39:16PM +0200, Jean-Pierre Chrétien wrote:
> > > > Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :
> > > > 
> > > > >
> > > > > Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
> > > > > upgrade I see the following test failures:
> > > > >
> > > > > 6221 - export/templates/lettre_dvi3_systemF (Failed)
> > > > > 6226 - export/templates/lettre_pdf4_systemF (Failed)
> > > > > 6228 - export/templates/lettre_pdf5_systemF (Failed)
> > > > 
> > > > I see the errors when I run xelatex manually, seems en polyglossia 
> > > > problem,
> > > > I will investigate.
> > > 
> > > Jean-Pierre, did you have time to investigate? Anything you think we
> > > should do for 2.3.0 on this? I have not tried to see if a tlmgr update
> > > magically made these issues go away.
> > > 
> > 
> > Sorry, I'm away from my desktop right now, ans I was busy with translations 
> > before.
> > I will check when I'm back.
> > 
> 
> Sorry again, it took me some time to come back to this.

No problem, thanks for tackling this annoying issue.

> There is a quite intricate problem with polyglossia in the additional 
> preamble code.
> 
> If I force babel as linguistic package, the three exports work manually.
> However there are error/warnings from the dvi viewer which need further
> investigation;

I might suggest to not even investigate dvi issues, if all PDF exports
are working well, unless you think it could be incorrect code written by
LyX.

> Currently, I suggest to solve the issue by committing the change in the
> lettre.lyx template, see attachment (I left TeX fonts as default). OK to
> commit to master?
> 

I've tested your patch on two systems, one where lettre had failing
ctests, and one where lettre had no failing ctests (because of an
outdated TL system). After your patch, the ctests were fixed on the
system that had failings, and on the system that had no failings nothing
changed (which is good). So although I know nothing about the problem, I
would say go ahead and commit.

Thanks for putting a note in the .lyx file explaining the problem. I
think that's a good idea.

In your commit message could you give a few details and maybe link to
this ML thread? This way if someone in two years wants to know why babel
was forced (e.g. from git log lettre.lyx or git blame), they will
quickly find this discussion.

Thanks for the fix!

Scott


signature.asc
Description: PGP signature

Re: Changes in lettre.cls

[Jean-Pierre Chrétien]

Le 16/09/2017 à 20:44, Jean-Pierre a écrit :

Le 16 septembre 2017 6:39:06 PM Scott Kostyshak  a écrit :


On Sun, Aug 13, 2017 at 06:39:16PM +0200, Jean-Pierre Chrétien wrote:

Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :

>
> Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
> upgrade I see the following test failures:
>
> 6221 - export/templates/lettre_dvi3_systemF (Failed)
> 6226 - export/templates/lettre_pdf4_systemF (Failed)
> 6228 - export/templates/lettre_pdf5_systemF (Failed)

I see the errors when I run xelatex manually, seems en polyglossia problem,
I will investigate.


Jean-Pierre, did you have time to investigate? Anything you think we
should do for 2.3.0 on this? I have not tried to see if a tlmgr update
magically made these issues go away.



Sorry, I'm away from my desktop right now, ans I was busy with translations 
before.
I will check when I'm back.



Sorry again, it took me some time to come back to this.

There is a quite intricate problem with polyglossia in the additional preamble 
code.

If I force babel as linguistic package, the three exports work manually. However 
there are error/warnings from the dvi viewer which need further investigation;



kpathsea:make_tex: Invalid fontname 
`FreeSans:mode=node;script=latn;language=DFLT;+tlig;', contains ':'
xdvi: Can't find pixel font FreeSans:mode=node;script=latn;language=DFLT;+tlig;; 
using cmr10 instead at 600 dpi.
kpathsea:make_tex: Invalid fontname 
`FreeSans:mode=node;script=latn;language=DFLT;+tlig;', contains ':'
xdvi: Error: Can't find font 
FreeSans:mode=node;script=latn;language=DFLT;+tlig;; using cmr10 instead. Expect 
ugly output.
kpathsea:make_tex: Invalid fontname 
`FreeSans:mode=node;script=latn;language=DFLT;+tlig;', contains ':'
xdvi: Error: Can't find font 
FreeSans:mode=node;script=latn;language=DFLT;+tlig;; using cmr10 instead. Expect 
ugly output.

kpathsea:make_tex: Invalid fontname `[lmmono10-regular]:', contains '['
xdvi: Error: Can't find font [lmmono10-regular]:; using cmr10 instead. Expect 
ugly output.
kpathsea:make_tex: Invalid fontname 
`FreeSans:mode=node;script=latn;language=DFLT;+tlig;', contains ':'
xdvi: Error: Can't find font 
FreeSans:mode=node;script=latn;language=DFLT;+tlig;; using cmr10 instead. Expect 
ugly output.

xdvi-xaw: Warning: Character 232 not defined in font cmr10
xdvi-xaw: Warning: Character 233 not defined in font cmr10
xdvi-xaw: Warning: Character 8217 not defined in font cmr10


Currently, I suggest to solve the issue by committing the change in the 
lettre.lyx template, see attachment (I left TeX fonts as default). OK to commit 
to master?


Riki, OK to commit to 2.3.x as well?

--
Jean-Pierre



diff --git a/lib/templates/lettre.lyx b/lib/templates/lettre.lyx
index 17c283a428..611655ec64 100644
--- a/lib/templates/lettre.lyx
+++ b/lib/templates/lettre.lyx
@@ -8,7 +8,7 @@
 \use_default_options false
 \maintain_unincluded_children false
 \language french
-\language_package default
+\language_package babel
 \inputencoding auto
 \fontencoding global
 \font_roman "default" "FreeSans"
@@ -92,6 +92,15 @@ L'ordre des éléments est indifférent.
 \end_layout
 
 \begin_layout Plain Layout
+Le paquetage de langue est forcé à 
+\family sans
+babel
+\family default
+, l'utilisation de polyglossia (implicite normalement avec des polices non-TeX)
+ provoque des erreurs.
+\end_layout
+
+\begin_layout Plain Layout
 Le format de la page est codé en dur en Iso A4 jusqu'à la version 2.351 de
  la classe (09/09/2014, TeXLive 2015/2016), qui interprète correctement
  l'option de classe 

Re: Changes in lettre.cls

[Scott Kostyshak]

On Sat, Sep 16, 2017 at 08:44:36PM +0200, Jean-Pierre wrote:
> Le 16 septembre 2017 6:39:06 PM Scott Kostyshak  a écrit :
> 
> > On Sun, Aug 13, 2017 at 06:39:16PM +0200, Jean-Pierre Chrétien wrote:
> > > Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :
> > > 
> > > >
> > > > Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
> > > > upgrade I see the following test failures:
> > > >
> > > > 6221 - export/templates/lettre_dvi3_systemF (Failed)
> > > > 6226 - export/templates/lettre_pdf4_systemF (Failed)
> > > > 6228 - export/templates/lettre_pdf5_systemF (Failed)
> > > 
> > > I see the errors when I run xelatex manually, seems en polyglossia 
> > > problem,
> > > I will investigate.
> > 
> > Jean-Pierre, did you have time to investigate? Anything you think we
> > should do for 2.3.0 on this? I have not tried to see if a tlmgr update
> > magically made these issues go away.
> > 
> 
> Sorry, I'm away from my desktop right now, ans I was busy with translations
> before.
> I will check when I'm back.

No problem, Jean-Pierre.

Scott


signature.asc
Description: PGP signature

Re: Changes in lettre.cls

[Jean-Pierre]

Le 16 septembre 2017 6:39:06 PM Scott Kostyshak  a écrit :


On Sun, Aug 13, 2017 at 06:39:16PM +0200, Jean-Pierre Chrétien wrote:

Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :

>
> Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
> upgrade I see the following test failures:
>
> 6221 - export/templates/lettre_dvi3_systemF (Failed)
> 6226 - export/templates/lettre_pdf4_systemF (Failed)
> 6228 - export/templates/lettre_pdf5_systemF (Failed)

I see the errors when I run xelatex manually, seems en polyglossia problem,
I will investigate.


Jean-Pierre, did you have time to investigate? Anything you think we
should do for 2.3.0 on this? I have not tried to see if a tlmgr update
magically made these issues go away.



Sorry, I'm away from my desktop right now, ans I was busy with translations 
before.

I will check when I'm back.

--
Jean-Pierre

Re: Changes in lettre.cls

[Scott Kostyshak]

On Sun, Aug 13, 2017 at 06:39:16PM +0200, Jean-Pierre Chrétien wrote:
> Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :
> 
> > 
> > Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
> > upgrade I see the following test failures:
> > 
> > 6221 - export/templates/lettre_dvi3_systemF (Failed)
> > 6226 - export/templates/lettre_pdf4_systemF (Failed)
> > 6228 - export/templates/lettre_pdf5_systemF (Failed)
> 
> I see the errors when I run xelatex manually, seems en polyglossia problem,
> I will investigate.

Jean-Pierre, did you have time to investigate? Anything you think we
should do for 2.3.0 on this? I have not tried to see if a tlmgr update
magically made these issues go away.

Scott


signature.asc
Description: PGP signature

Re: Changes in lettre.cls

[Jean-Pierre Chrétien]

Le 09/08/2017 à 10:00, Scott Kostyshak a écrit :



Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
upgrade I see the following test failures:

6221 - export/templates/lettre_dvi3_systemF (Failed)
6226 - export/templates/lettre_pdf4_systemF (Failed)
6228 - export/templates/lettre_pdf5_systemF (Failed)


I see the errors when I run xelatex manually, seems en polyglossia problem, I 
will investigate.


--
Jean-Pierre

Re: Changes in lettre.cls

[Scott Kostyshak]

On Tue, Aug 08, 2017 at 05:08:05PM +0200, Jean-Pierre Chrétien wrote:
> Hello,
> 
> A new version of the lettre class has been loaded on CTAN (ref. number 3.000
> instead of 2.353).
> 
> The major improvement from the point of view of LyX is the addition of class
> options a4paper, letterpaper, legalpaper, executivepaper,
> b5paper, et a5paper (a4paper was hardcoded before, leading to incorrect
> pages sizes when US letter formats were used). Now one can select US letter
> in the Document>Settings>Page format to get the correct result.
> 
> The mechanism allowing to print the address and other informations of the
> institute has changed: now the file containing the information is named
>lettre-.cfg
> instead of
>.ins
> The backward compatibility is guaranteed (old file ames are recognized), and
> this feature being not supported in the LyX template, I think that nothing
> has to be done from the POV of backward compatibiliy in LyX. I will just
> point this out in the note at the beginning of the template. Is that OK?

Thanks for looking into this, Jean-Pierre. Note that after a tlmgr
upgrade I see the following test failures:

6221 - export/templates/lettre_dvi3_systemF (Failed)
6226 - export/templates/lettre_pdf4_systemF (Failed)
6228 - export/templates/lettre_pdf5_systemF (Failed)

Scott


signature.asc
Description: PGP signature