Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > No it is not a recursion issue, but about knowing who asked for update. I Then I did not get the underlying problem correctly, anyway proceed as you wish ;) P

Re: Initial view of document (master)

Le 2 novembre 2017 11:24:19 GMT+01:00, Pavel Sanda a écrit : >Jean-Marc Lasgouttes wrote: >> Le 31 octobre 2017 13:36:47 GMT+01:00, Jean-Marc Lasgouttes > a écrit : >> >Yes 2 is good for fixing the symptom, but it is very fragile... >> >> We could also try >>

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Le 31 octobre 2017 13:36:47 GMT+01:00, Jean-Marc Lasgouttes > a écrit : > >Yes 2 is good for fixing the symptom, but it is very fragile... > > We could also try > 4. Note when we have requested a repaint and exit early from paintEvent() > when

Re: Initial view of document (master)

Le 31 octobre 2017 13:36:47 GMT+01:00, Jean-Marc Lasgouttes a écrit : >Yes 2 is good for fixing the symptom, but it is very fragile... We could also try 4. Note when we have requested a repaint and exit early from paintEvent() when we did not ask for this repaint. (Or even

Re: Initial view of document (master)

Le 31 octobre 2017 11:52:57 GMT+01:00, Pavel Sanda a écrit : >Jean-Marc Lasgouttes wrote: >> Yes, this is needed in some cases. I see 3 types of fixes >> 1. Convince qt that there is no need to update a whole window when >the status bar changes >> 2. Audit the uses of

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Yes, this is needed in some cases. I see 3 types of fixed > 1. Convince qt that there is no need to update a whole window when the status > bar changes > 2. Audit the uses of Buffer::message and use something else when possible. > 3. Change row painting code so that

Re: Initial view of document (master)

Le 30 octobre 2017 16:00:13 GMT+01:00, Pavel Sanda a écrit : >Jean-Marc Lasgouttes wrote: >My guess is that if we do it generally for all cases some messaging >gets >broken (like the updates for longer lfuns - e.g. reconfiguration or >compilation). Yes, this is needed in some

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > The patch does the right thing by using Cursor::message instead (so that I can confirm that the crash is fixed. > where this may happen. I'd be grateful for ideas that would make > buffer::message and BufferView::message safer. It might be enough to just > delay

Re: Initial view of document (master)

Am Mittwoch, 25. Oktober 2017 um 15:24:33, schrieb Richard Heck > On 10/25/2017 02:35 PM, Kornel Benko wrote: > > Am Dienstag, 24. Oktober 2017 um 19:51:41, schrieb Jean-Marc Lasgouttes > > > >> Le 23/10/2017 à 22:26, Pavel Sanda a écrit : > >>> And I have

Re: Initial view of document (master)

Le 23/10/2017 à 22:26, Pavel Sanda a écrit : And I have reproducible crash: 1. start new document 2. write "ambititious ", spellcheck correctly underlies text. 3. try to fix spelling via context menu, choose "ambitious" 4. kaboom Here is a patch, that raises as many question as is solves. The

Re: Initial view of document (master)

Le 27/10/2017 à 15:14, Kornel Benko a écrit : BTW, I get the same crash also with QT4. Every time the word to correct is 2 chars longer as the wrong spelled. For instance using 'tesest' and correct to 'test'. I used Hunspell, but using Enchant or Aspell made no difference. 2 characters, of

Re: Initial view of document (master)

Am Freitag, 27. Oktober 2017 um 14:37:08, schrieb Kornel Benko > > > I can reproduce with continuous spellcheck enabled. Qt5. > > > > > > It crashes on LASSERT(LASSERT(end > start && end <= size() + 1, return > > > false); > > > at src/Paragraph.cpp:612 > > > > I still can't

Re: Initial view of document (master)

Am Freitag, 27. Oktober 2017 um 14:07:35, schrieb Jean-Marc Lasgouttes > Le 25/10/2017 à 20:35, Kornel Benko a écrit : > > Am Dienstag, 24. Oktober 2017 um 19:51:41, schrieb Jean-Marc Lasgouttes > > > >> Le 23/10/2017 à 22:26, Pavel Sanda a écrit : > >>>

Re: Initial view of document (master)

Le 25/10/2017 à 20:35, Kornel Benko a écrit : Am Dienstag, 24. Oktober 2017 um 19:51:41, schrieb Jean-Marc Lasgouttes Le 23/10/2017 à 22:26, Pavel Sanda a écrit : And I have reproducible crash: 1. start new document 2. write "ambititious ", spellcheck correctly underlies

Re: Initial view of document (master)

On 10/25/2017 02:35 PM, Kornel Benko wrote: > Am Dienstag, 24. Oktober 2017 um 19:51:41, schrieb Jean-Marc Lasgouttes > >> Le 23/10/2017 à 22:26, Pavel Sanda a écrit : >>> And I have reproducible crash: >>> 1. start new document >>> 2. write "ambititious ", spellcheck

Re: Initial view of document (master)

Am Dienstag, 24. Oktober 2017 um 19:51:41, schrieb Jean-Marc Lasgouttes > Le 23/10/2017 à 22:26, Pavel Sanda a écrit : > > And I have reproducible crash: > > 1. start new document > > 2. write "ambititious ", spellcheck correctly underlies text. > > 3. try to fix spelling via

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Le 23/10/2017 ?? 22:21, Pavel Sanda a écrit : >> Another cursor issue (I have vague memory this was already discussed): >> while editing paragraph of text go to the end of last word. >> Hit spacebar - space is inserted, but cursor stays at the end of word >> and shows

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Le 23/10/2017 ?? 22:26, Pavel Sanda a écrit : >> And I have reproducible crash: >> 1. start new document >> 2. write "ambititious ", spellcheck correctly underlies text. >> 3. try to fix spelling via context menu, choose "ambitious" >> 4. kaboom > > I can't reproduce.

Re: Initial view of document (master)

Le 23/10/2017 à 22:26, Pavel Sanda a écrit : And I have reproducible crash: 1. start new document 2. write "ambititious ", spellcheck correctly underlies text. 3. try to fix spelling via context menu, choose "ambitious" 4. kaboom I can't reproduce. Qt4 or Qt5? JMarc

Re: Initial view of document (master)

Le 23/10/2017 à 22:21, Pavel Sanda a écrit : Another cursor issue (I have vague memory this was already discussed): while editing paragraph of text go to the end of last word. Hit spacebar - space is inserted, but cursor stays at the end of word and shows only after inserting the next non

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: >> After some testing: >> - initial thread report present > > Which one? https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg202482.html >> - a is present > > I think it is gone now Confirmed, this issue is gone. >> - c mostly fixed, ghost c3*** still remains

Re: Initial view of document (master)

I added an early return for Update::None that got forgotten. Le 20/10/2017 à 16:56, Pavel Sanda a écrit : After some testing: - initial thread report present Which one? - a is present I think it is gone now - b is fixed - c mostly fixed, ghost c3*** still remains Cannot reproduce, but

Re: Initial view of document (master)

Pavel Sanda wrote: > Pavel Sanda wrote: > > Jean-Marc Lasgouttes wrote: > > > Le 19/10/2017 ?? 15:05, Pavel Sanda a écrit : > > >> Pavel Sanda wrote: > > >>> d) Editing problems > > >>> Don't see how to produce solid recipy but something is wrong with > > >>> editing > > >>> as well. > > >> Try

Re: Initial view of document (master)

Pavel Sanda wrote: > Jean-Marc Lasgouttes wrote: > > Le 19/10/2017 ?? 15:05, Pavel Sanda a écrit : > >> Pavel Sanda wrote: > >>> d) Editing problems > >>> Don't see how to produce solid recipy but something is wrong with editing > >>> as well. > >> Try couple times this one: > >> 1. open user

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Le 19/10/2017 ?? 15:05, Pavel Sanda a écrit : >> Pavel Sanda wrote: >>> d) Editing problems >>> Don't see how to produce solid recipy but something is wrong with editing >>> as well. >> Try couple times this one: >> 1. open user guid, uncheck disable editing >> 2. go

Re: Initial view of document (master)

Le 19/10/2017 à 15:05, Pavel Sanda a écrit : Pavel Sanda wrote: d) Editing problems Don't see how to produce solid recipy but something is wrong with editing as well. Try couple times this one: 1. open user guid, uncheck disable editing 2. go to in front of "i" in "What is LyX" 3. hit delete

Re: Initial view of document (master)

Le 19/10/2017 à 14:59, Pavel Sanda a écrit : Pavel Sanda wrote: While doing the above steps in c) and jumping to different tabs or undoing I randomly get LyX crashing: Assertion false violated in Coordcache.cpp:31. Recipy is rather simple: 1. open new document 2. insert LyX note 3. kaboom

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Thanks for testing. I complain, but I appreciate (time to find a shrink?) I appreciate. Until the new painting stuff is merged into stable I need to stay with lyx 2.0... Pavel

Re: Initial view of document (master)

Le 19/10/2017 à 14:38, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Could you have a go at this updated patch? I had to do now a rewrite of processUpdateFlags that I planned to do later. Indeed, the reported issues seem to be solved (qt5 test). But I see new ones (all of these with

Re: Initial view of document (master)

Pavel Sanda wrote: > d) Editing problems > Don't see how to produce solid recipy but something is wrong with editing as > well. Try couple times this one: 1. open user guid, uncheck disable editing 2. go to in front of "i" in "What is LyX" 3. hit delete 4. in most cases the character does not

Re: Initial view of document (master)

Pavel Sanda wrote: > > While doing the above steps in c) and jumping to different tabs or undoing > > I randomly get LyX crashing: > > Assertion false violated in Coordcache.cpp:31. Recipy is rather simple: 1. open new document 2. insert LyX note 3. kaboom

Re: Initial view of document (master)

Pavel Sanda wrote: > But I see new ones (all of these with applied patch, but they might apply to > 2.3 as well): > a) > 1. edit document > 2. scroll to different page via mouse wheel > 3. hit ctrl+s to save > 4. caret suddenly appears on screen on totally wrong position >unrelated to current

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Could you have a go at this updated patch? I had to do now a rewrite of > processUpdateFlags that I planned to do later. Indeed, the reported issues seem to be solved (qt5 test). But I see new ones (all of these with applied patch, but they might apply to 2.3 as

Re: Initial view of document (master)

Le 18/10/2017 à 01:59, Pavel Sanda a écrit : 1. Mouse-wheel scrolling broken, scrolling via the scrollbar at right broken 2. Keys navigation broken (eg open manual and just hold down arrow up/down for a while when it hits start and end), the same for many pg-up/downs. 3. Go to the end of

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > It was fixing the math completion thing, and other things that have not been > identified yet... Ok I stay tuned for the next merge :) P

Re: Initial view of document (master)

Le 18 octobre 2017 02:05:12 GMT+02:00, Pavel Sanda a écrit : >Jean-Marc Lasgouttes wrote: >> OK, I reverted it. > >Was this commit fixing some issue or is it refactoring type of work >to make things better in the future? > >Pavel It was fixing the math completion thing, and other

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > OK, I reverted it. Was this commit fixing some issue or is it refactoring type of work to make things better in the future? Pavel

Re: Initial view of document (master)

Jean-Marc Lasgouttes wrote: > Le 17/10/2017 ?? 18:46, Pavel Sanda a écrit : >> Bisect leads to c19c54dd5b85. >> JMarc, this commit renders master editing/scrolling unusable. >> (Qt5/debian stable). > > OK, I reverted it. Before you update master, I'd appreciate a list of other > buggy situations,

Re: Initial view of document (master)

Le 17/10/2017 à 18:46, Pavel Sanda a écrit : Bisect leads to c19c54dd5b85. JMarc, this commit renders master editing/scrolling unusable. (Qt5/debian stable). OK, I reverted it. Before you update master, I'd appreciate a list of other buggy situations, so that I can do some damage control.

Re: Initial view of document (master)

Pavel Sanda wrote: > Anyway you are right. Any editing in master seems to be seriously > broken now, combo of painting issues and cursor shadows reported > previously. After recent update it became so bad that I don't > even know what to report first :) Bisect leads to c19c54dd5b85. JMarc, this

Re: Initial view of document (master)

Pavel Sanda wrote: > This is unrelated and likely connected to the problem JMarc is > solving with Stephan on Mac. (But you run linux, right?) Anyway you are right. Any editing in master seems to be seriously broken now, combo of painting issues and cursor shadows reported previously. After

Re: Initial view of document (master)

Kornel Benko wrote: > I see something different: > 1. Open document than spans more than single screen. > 2. Resize the lyx window ==> black window This is unrelated and likely connected to the problem JMarc is solving with Stephan on Mac. (But you run linux, right?) My problem is rather

Re: Initial view of document (master)

Am Dienstag, 17. Oktober 2017 um 17:55:41, schrieb Pavel Sanda > Hi, > > I see regression wrt LyX 2.0. > 1. Open document than spans more than single screen. > 2. Set cursor at the very end of the document > 3. Close LyX > 4. Launch LyX and reopen the same document > 5. The cursor