Re: One reaction and one question regarding 2.3.2
On 21/12/2018 17:13, Jürgen Spitzmüller wrote: Am Freitag, den 21.12.2018, 15:56 +0100 schrieb Kornel Benko: So, if I want to change some words to say 'emph+bold', I have to set it again and again for each word? No, you can use the 'Apply last text properties' button once you have applied it from the dialog. Also the use of 'Apply last text properties' does not work anymore :( Could you elaborate? It works for me. 1.) German document 2.) Paragraph in English 3.) select a word in this paragraph 4.) change to emph through bind 'font-emph' 5.) sect another word 6.) try 'Apply last text properties' The word is now German (instead of English), and not emphasized. textstyle-apply never worked with font-emph. It uses the cached settings from freefont, and freefont is only updated in textstyle- update (which is used by the character dialog). It still works (as before) if you use the dialog for setting the Emphasizing. Just wanted to point out that this is evidence for my point that "Apply last (text style) toolbar button has misleading grouping and appearance" and I have suggested a patch for it: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg207184.html Daniel
Re: One reaction and one question regarding 2.3.2
On 12/21/18 8:59 AM, Enrico Forestieri wrote: > On Fri, Dec 21, 2018 at 12:33:31PM +0100, Jürgen Spitzmüller wrote: > >> Riki, let me know if I should backport this. > I think this has to be backported because it re-allows a workflow which > seems to be very common. Go ahead, then. Riki
Re: One reaction and one question regarding 2.3.2
Am Freitag, 21. Dezember 2018 17:13:15 CET schrieb Jürgen Spitzmüller : > Am Freitag, den 21.12.2018, 15:56 +0100 schrieb Kornel Benko: > > So, if I want to change some words to say 'emph+bold', I have to set > > it again and again for each word? > > No, you can use the 'Apply last text properties' button once you have > applied it from the dialog. > > > > > Also the use of 'Apply last text properties' does not work > > > > anymore :( > > > > > > Could you elaborate? It works for me. > > > > 1.) German document > > 2.) Paragraph in English > > 3.) select a word in this paragraph > > 4.) change to emph through bind 'font-emph' > > 5.) sect another word > > 6.) try 'Apply last text properties' > > The word is now German (instead of English), and not emphasized. > > textstyle-apply never worked with font-emph. It uses the cached > settings from freefont, and freefont is only updated in textstyle- > update (which is used by the character dialog). > > It still works (as before) if you use the dialog for setting the > Emphasizing. Ah yes, one has always set the 'Reset' accordingly first. > Jürgen Kornel signature.asc Description: This is a digitally signed message part.
Re: One reaction and one question regarding 2.3.2
Am Freitag, den 21.12.2018, 15:56 +0100 schrieb Kornel Benko: > So, if I want to change some words to say 'emph+bold', I have to set > it again and again for each word? No, you can use the 'Apply last text properties' button once you have applied it from the dialog. > > > Also the use of 'Apply last text properties' does not work > > > anymore :( > > > > Could you elaborate? It works for me. > > 1.) German document > 2.) Paragraph in English > 3.) select a word in this paragraph > 4.) change to emph through bind 'font-emph' > 5.) sect another word > 6.) try 'Apply last text properties' > The word is now German (instead of English), and not emphasized. textstyle-apply never worked with font-emph. It uses the cached settings from freefont, and freefont is only updated in textstyle- update (which is used by the character dialog). It still works (as before) if you use the dialog for setting the Emphasizing. Jürgen > > > Jürgen > > Kornel > signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
Am Freitag, 21. Dezember 2018 15:29:25 CET schrieb Jürgen Spitzmüller : > Am Freitag, den 21.12.2018, 15:20 +0100 schrieb Kornel Benko: > > Selecting to 'Reset All To No Change' does as expected, but the first > > use of 'Apply' > > resets all again. Selecting next word while the dialog is open resets > > too :( > > Sure, this is how the font dialog works now. You want the old dialog > back, but I won't do that. There was plenty of time to discuss the > redesign. So, if I want to change some words to say 'emph+bold', I have to set it again and again for each word? > > Also the use of 'Apply last text properties' does not work anymore :( > > Could you elaborate? It works for me. 1.) German document 2.) Paragraph in English 3.) select a word in this paragraph 4.) change to emph through bind 'font-emph' 5.) sect another word 6.) try 'Apply last text properties' The word is now German (instead of English), and not emphasized. > Jürgen Kornel signature.asc Description: This is a digitally signed message part.
Re: One reaction and one question regarding 2.3.2
Am Freitag, den 21.12.2018, 15:20 +0100 schrieb Kornel Benko: > Selecting to 'Reset All To No Change' does as expected, but the first > use of 'Apply' > resets all again. Selecting next word while the dialog is open resets > too :( Sure, this is how the font dialog works now. You want the old dialog back, but I won't do that. There was plenty of time to discuss the redesign. > Also the use of 'Apply last text properties' does not work anymore :( Could you elaborate? It works for me. Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
Am Freitag, 21. Dezember 2018 13:38:02 CET schrieb Jürgen Spitzmüller : > Am Freitag, den 21.12.2018, 12:52 +0100 schrieb Kornel Benko: > > In file included from /usr2/src/lyx/lyx- > > git/src/frontends/qt4/GuiCharacter.cpp:16:0: > > /usr2/src/lyx/lyx-git/src/frontends/qt4/GuiCharacter.h:115:32: error: > > no matching function for call to ‘QAction::QAction()’ > > QAction * resetdefault_ = new QAction; > > Try again. > > Jürgen > It compiles, but the new handling is _really_ unsatisfying. Selecting to 'Reset All To No Change' does as expected, but the first use of 'Apply' resets all again. Selecting next word while the dialog is open resets too :( Also the use of 'Apply last text properties' does not work anymore :( Kornel signature.asc Description: This is a digitally signed message part.
Re: One reaction and one question regarding 2.3.2
On Fri, Dec 21, 2018 at 12:33:31PM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, den 20.12.2018, 17:31 +0100 schrieb Enrico Forestieri: > > Maybe. However, I wonder how many read it (want it) in the same way. > > Be it as it may, both is now possible in master. Ok, thanks Jürgen. > Riki, let me know if I should backport this. I think this has to be backported because it re-allows a workflow which seems to be very common. -- Enrico
Re: One reaction and one question regarding 2.3.2
Am Freitag, den 21.12.2018, 12:52 +0100 schrieb Kornel Benko: > In file included from /usr2/src/lyx/lyx- > git/src/frontends/qt4/GuiCharacter.cpp:16:0: > /usr2/src/lyx/lyx-git/src/frontends/qt4/GuiCharacter.h:115:32: error: > no matching function for call to ‘QAction::QAction()’ > QAction * resetdefault_ = new QAction; Try again. Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
Am Freitag, 21. Dezember 2018 12:33:31 CET schrieb Jürgen Spitzmüller : > Am Donnerstag, den 20.12.2018, 17:31 +0100 schrieb Enrico Forestieri: > > Maybe. However, I wonder how many read it (want it) in the same way. > > Be it as it may, both is now possible in master. > > Riki, let me know if I should backport this. > > Jürgen > In file included from /usr2/src/lyx/lyx-git/src/frontends/qt4/GuiCharacter.cpp:16:0: /usr2/src/lyx/lyx-git/src/frontends/qt4/GuiCharacter.h:115:32: error: no matching function for call to ‘QAction::QAction()’ QAction * resetdefault_ = new QAction; ^ In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QAction:1:0, from /BUILD/BUILDMint18/BuildLyxGitQt5.6.1local-gcc5.4.0/src/frontends/qt4/ui_CharacterUi.h:13, from /usr2/src/lyx/lyx-git/src/frontends/qt4/GuiCharacter.h:18, from /usr2/src/lyx/lyx-git/src/frontends/qt4/GuiCharacter.cpp:16: /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qaction.h:174:5: note: candidate: QAction::QAction(QActionPrivate&, QObject*) QAction(QActionPrivate , QObject *parent); Kornel signature.asc Description: This is a digitally signed message part.
Re: One reaction and one question regarding 2.3.2
Am Donnerstag, den 20.12.2018, 17:31 +0100 schrieb Enrico Forestieri: > Maybe. However, I wonder how many read it (want it) in the same way. Be it as it may, both is now possible in master. Riki, let me know if I should backport this. Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
Am Donnerstag, 20. Dezember 2018 17:53:42 CET schrieb Enrico Forestieri : > On Thu, Dec 20, 2018 at 05:06:47PM +0100, Jürgen Spitzmüller wrote: > > Am Donnerstag, den 20.12.2018, 16:39 +0100 schrieb Enrico Forestieri: > > > Indeed, when you change a > > > property with the Text Style dialog and want to apply this only > > > change > > > to different selections of text, you have to take care to change to > > > "No Change" all other properties. This is a big nuisance. > > > > Observe, though, that the dialog sets the combos to "No Change" (and > > the check boxes to an undecided state) if you select text where a > > setting differs. So what you describe above should not be a problem. > > It is. Load the attached document, select "first" and make it italic > through the Text Style dialog. Now, in the intent of adding the italic > property to it, select "third" and press the "Apply last" toolbar button. > See that it is now italic but all other formatting is lost. > > Thus, this workflow is now lost. Other than choosing italic, you have to > manually set to "No Change" everything else. That's a PITA. > +1 If one wants italic that does not mean remove all the other features. Kornel signature.asc Description: This is a digitally signed message part.
Re: One reaction and one question regarding 2.3.2
On Thu, Dec 20, 2018 at 05:06:47PM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, den 20.12.2018, 16:39 +0100 schrieb Enrico Forestieri: > > Indeed, when you change a > > property with the Text Style dialog and want to apply this only > > change > > to different selections of text, you have to take care to change to > > "No Change" all other properties. This is a big nuisance. > > Observe, though, that the dialog sets the combos to "No Change" (and > the check boxes to an undecided state) if you select text where a > setting differs. So what you describe above should not be a problem. It is. Load the attached document, select "first" and make it italic through the Text Style dialog. Now, in the intent of adding the italic property to it, select "third" and press the "Apply last" toolbar button. See that it is now italic but all other formatting is lost. Thus, this workflow is now lost. Other than choosing italic, you have to manually set to "No Change" everything else. That's a PITA. -- Enrico #LyX 2.3 created this file. For more info see http://www.lyx.org/ \lyxformat 544 \begin_document \begin_header \save_transient_properties true \origin unavailable \textclass article \use_default_options true \maintain_unincluded_children false \language english \language_package default \inputencoding auto \fontencoding global \font_roman "default" "default" \font_sans "default" "default" \font_typewriter "default" "default" \font_math "auto" "auto" \font_default_family default \use_non_tex_fonts false \font_sc false \font_osf false \font_sf_scale 100 100 \font_tt_scale 100 100 \use_microtype false \use_dash_ligatures true \graphics default \default_output_format default \output_sync 0 \bibtex_command default \index_command default \paperfontsize default \use_hyperref false \papersize default \use_geometry false \use_package amsmath 1 \use_package amssymb 1 \use_package cancel 1 \use_package esint 1 \use_package mathdots 1 \use_package mathtools 1 \use_package mhchem 1 \use_package stackrel 1 \use_package stmaryrd 1 \use_package undertilde 1 \cite_engine basic \cite_engine_type default \use_bibtopic false \use_indices false \paperorientation portrait \suppress_date false \justification true \use_refstyle 1 \use_minted 0 \index Index \shortcut idx \color #008000 \end_index \secnumdepth 3 \tocdepth 3 \paragraph_separation indent \paragraph_indentation default \is_math_indent 0 \math_numbering_side default \quotes_style english \dynamic_quotes 0 \papercolumns 1 \papersides 1 \paperpagestyle default \tracking_changes false \output_changes false \html_math_output 0 \html_css_as_file 0 \html_be_strict false \end_header \begin_body \begin_layout Standard first second \series bold \size large third \end_layout \end_body \end_document
Re: One reaction and one question regarding 2.3.2
On Thu, Dec 20, 2018 at 05:23:59PM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, den 20.12.2018, 17:19 +0100 schrieb Enrico Forestieri: > > This is not what the reporter of #11415 meant. > > ... in your reading. Maybe. However, I wonder how many read it (want it) in the same way. -- Enrico
Re: One reaction and one question regarding 2.3.2
Am Donnerstag, den 20.12.2018, 17:19 +0100 schrieb Enrico Forestieri: > This is not what the reporter of #11415 meant. ... in your reading. Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
On Thu, Dec 20, 2018 at 04:59:54PM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, den 20.12.2018, 16:39 +0100 schrieb Enrico Forestieri: > > I would say that a button "Restore No Change" is more useful than > > "Restore Defaults". > > I added this per user request: > https://www.lyx.org/trac/ticket/11415 Yes, but I think that the request was not formulated clearly. The reporter of that bug says: Would it possible to add a button to the dialog, which, if clicked sets all items to "Default"? Making repeated changes (a common occurrence in my workflow) is still cumbersome, requiring multiple changes if you only want to make one change and use the defaults for all others... It is clear that he wanted a "Restore No Change" button rather than a "Restore Defaults". Indeed, with a "Restore Defaults" button you would not change only one property but multiple ones. For example, using the Text Style dialog you select a word which has all default properties and make it italic. Now you select another word which has only boldface as non-default property and hit the "Apply last" toolbar button. Now the word is in italic but not bold anymore... This is not what the reporter of #11415 meant. He meant to have the word in italic but still boldface. So, every occurrence of "default" in his request has to be changed into "no change", IMO. -- Enrico
Re: One reaction and one question regarding 2.3.2
Am Donnerstag, den 20.12.2018, 16:39 +0100 schrieb Enrico Forestieri: > Indeed, when you change a > property with the Text Style dialog and want to apply this only > change > to different selections of text, you have to take care to change to > "No Change" all other properties. This is a big nuisance. Observe, though, that the dialog sets the combos to "No Change" (and the check boxes to an undecided state) if you select text where a setting differs. So what you describe above should not be a problem. Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
Am Donnerstag, den 20.12.2018, 16:39 +0100 schrieb Enrico Forestieri: > I would say that a button "Restore No Change" is more useful than > "Restore Defaults". I added this per user request: https://www.lyx.org/trac/ticket/11415 Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
On Thu, Dec 20, 2018 at 04:18:56PM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, den 20.12.2018, 09:45 -0500 schrieb Paul A. Rubin: > > If "defaults" means document-wide > > settings, I'm not sure how that would differ from the "Reset" button > > action. > > Reset resets to the settings at cursor positions (the initial settings > when you opened the dialog). > > As to your proposal, I am reluctant to add a third button to that > dialog. Jürgen, there is actually a big usability issue to address. Now what was a simple action (for example adding the italic property to different selections of text) becomes a cumbersome one. Indeed, when you change a property with the Text Style dialog and want to apply this only change to different selections of text, you have to take care to change to "No Change" all other properties. This is a big nuisance. I would say that a button "Restore No Change" is more useful than "Restore Defaults". -- Enrico
Re: One reaction and one question regarding 2.3.2
Am Donnerstag, den 20.12.2018, 09:45 -0500 schrieb Paul A. Rubin: > If "defaults" means document-wide > settings, I'm not sure how that would differ from the "Reset" button > action. Reset resets to the settings at cursor positions (the initial settings when you opened the dialog). As to your proposal, I am reluctant to add a third button to that dialog. Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
On 12/20/18 8:18 AM, Daniel wrote: On 20/12/2018 14:06, Jürgen Spitzmüller wrote: Am Mittwoch, den 19.12.2018, 19:58 -0500 schrieb Paul A. Rubin: Assuming this is the new normal for the style dialog, any chance there could at least be a button at the bottom that would clear all settings? In the next release, the dialog will have a "Restore Defaults" button that will set all widgets to default (and a "Reset" button that will reset the initial value). Jürgen If I understood correctly, Paul would like to have an additional "set all to No change" button (which is neither Default nor the initial value), so that he can easily set and apply (say) one attribute only without changing any other attributes. (And having all attributes set to "No change" used to be the standard in earlier versions of LyX. Hence no (or less) need for such a button in previous versions of LyX.) Daniel Yes, exactly. So if "defaults" means "change nothing", the "Restore Defaults" button is what I would like. If "defaults" means document-wide settings, I'm not sure how that would differ from the "Reset" button action. Paul
Re: One reaction and one question regarding 2.3.2
On 20/12/2018 14:06, Jürgen Spitzmüller wrote: Am Mittwoch, den 19.12.2018, 19:58 -0500 schrieb Paul A. Rubin: Assuming this is the new normal for the style dialog, any chance there could at least be a button at the bottom that would clear all settings? In the next release, the dialog will have a "Restore Defaults" button that will set all widgets to default (and a "Reset" button that will reset the initial value). Jürgen If I understood correctly, Paul would like to have an additional "set all to No change" button (which is neither Default nor the initial value), so that he can easily set and apply (say) one attribute only without changing any other attributes. (And having all attributes set to "No change" used to be the standard in earlier versions of LyX. Hence no (or less) need for such a button in previous versions of LyX.) Daniel
Re: One reaction and one question regarding 2.3.2
Am Mittwoch, den 19.12.2018, 19:58 -0500 schrieb Paul A. Rubin: > Assuming this is the new normal for the style dialog, any chance > there could at least be a button at the bottom that would clear all > settings? In the next release, the dialog will have a "Restore Defaults" button that will set all widgets to default (and a "Reset" button that will reset the initial value). Jürgen signature.asc Description: This is a digitally signed message part
Re: One reaction and one question regarding 2.3.2
On 20/12/2018 01:58, Paul A. Rubin wrote: Hi all, I just installed 2.3.2 and I have a question regarding change tracking. I'm not sure if this is a change in 2.3.2, or if it's always been this way and I just never tripped over it. If I have change tracking turned on and I change the font of a selection (for instance, by clicking the emphasis button, or via the text style dialog), the selection is /not/ marked as changed. That's very unhandy ... This has always been that way and been on the enhancement request list for a long time: https://www.lyx.org/trac/ticket/1043. Tracked changes is steadily improving but slowly and it has not come so far yet. ... but not as unhandy as the new feature in the text style dialog that causes it to pick up the current settings of the selected (rather than initializing everything to "No change"). I frequently change just the series to bold and then use the apply last style button repeatedly. That will now screw up other text that I'm making bold if it has any characteristic different from the first text I made bold. Changing each of the other boxes in the style dialog to "No change" is a royal PITA. Assuming this is the new normal for the style dialog, any chance there could at least be a button at the bottom that would clear all settings? Maybe you can file a bug report with the keyword "regression" for this? In the current stable development version the font dialog sets all settings to default if none have been changed (see https://www.lyx.org/trac/ticket/11385). That is already an improvement, I think. But this does not get you what you want. I think the idea behind the new dialog is to show users the formatting of the current selection which is how it works in other writer apps. That seems sensible. And writer apps normally apply the text properties from one selection to another. That is also how it works now. What you request is nothing I have seen in other writer apps but I agree that it is a desirable feature and this is a regression from earlier versions of LyX. Can you can file a bug report with the keyword "regression". Daniel
