Re: Windows Installer for Testing
Am Samstag, den 01.09.2018, 15:36 -0400 schrieb Richard Kimberly Heck: > > Here's a simple patch which would need a bit of additional work, > > but can > > be a kind of proof of concept (and be tested). Comments? The one which you accidentally committed looks promising. Jürgen > Updated patch. > > Riki > signature.asc Description: This is a digitally signed message part
Re: Windows Installer for Testing
On 1/09/2018 11:49 p.m., Enrico Forestieri wrote: On Sat, Sep 01, 2018 at 11:09:58AM +0200, Jürgen Spitzmüller wrote: Am Samstag, den 01.09.2018, 20:27 +1200 schrieb Andrew Parsloe: OK, this time I inserted a Bib(la)TeX Bibliography via Insert > List/TOC, using an old BibTeX .bib file I had lying around. Even a small trial document is noticeably slower for things like starting a new paragraph, although the delay is more like quarter to half a second rather than the 2 to 4 seconds you report. Nonetheless it's still noticeable. The crucial info we need is what makes this so slow only on Windows (and not on any other OS). Can we do profiling on Win? Just a shot in the dark: If you enable the "Files" debug output in View Messages, is there any indication that (attempts to) file removal (aux file and/or bbl file) take your time? I am just guessing that removeBiblioTempFiles() (involved in the BibinfoCache invalidation) might be the culprit, since it involves QFile, and this is an obvious candidate for OS-specific weirdness. Using the --verbose switch it can be seen that each time a new paragraph is started LyX runs kpsewhich for each bibtex catalog to be found in the texmf tree. So, if you have 5 catalogs, kpsewhich is run for 5 times everytime you hit the Enter key. This was not the case in 2.3.0. I see that MiKTeX keeps a kpsewhich.log (which must itself cause a performance penalty). It's not just starting a new paragraph, but other basic operations also result in calls to kpsewhich. In case it's helpful (this is with a single .bib file): 1. Deleting a letter with Del or Backspace: no call to kpsewhich; *selecting* the letter then deleting it, 1 call. 2. Inserting a space before another space then clicking elsewhere so that LyX automatically removes the extra space: 2 calls. Andrew --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
Re: Windows Installer for Testing
On 09/01/2018 03:34 PM, Jürgen Spitzmüller wrote: > Scott Kostyshak mailto:skost...@lyx.org>> schrieb > am Sa., 1. Sep. 2018, 21:26: > > On Sat, Sep 01, 2018 at 01:47:54PM -0400, Richard Kimberly Heck wrote: > > > Another option for 2.3.1 would be to revert the commits that > fixed #9158. > > +1 The bug does not seem important enough to risk anything at this > point. > > > I'd vote for that, too. Let's try to get it right for 2.3.2. OK, I'll plan to go that way. I'll issue new tarballs tomorrow probably. I have most of a patch at this point and will try to finish it over the weekend. Riki
Re: Windows Installer for Testing
On 09/01/2018 01:36 PM, Richard Kimberly Heck wrote:
> On 09/01/2018 12:58 PM, Richard Kimberly Heck wrote:
>> On 09/01/2018 10:02 AM, Jürgen Spitzmüller wrote:
>>> Am Samstag, den 01.09.2018, 13:49 +0200 schrieb Enrico Forestieri:
Using the --verbose switch it can be seen that each time a new
paragraph
is started LyX runs kpsewhich for each bibtex catalog to be found in
the
texmf tree. So, if you have 5 catalogs, kpsewhich is run for 5 times
everytime you hit the Enter key.
>>> Indeed, that's likely the culprit.
>>>
>>> The call is in InsetBibtex::getBibTeXPath(), which is called by
>>> InsetBibtex::getBibFiles(), which is called by
>>> InsetBibTeX::updateBuffer(), which is called by Buffer::updateBuffer()
>>>
>>> Would it make sense to cache those paths, too? After all, they are
>>> unlikely to change that often.
>> Weird that no-one saw this problem on Linux.
> Here's a simple patch which would need a bit of additional work, but can
> be a kind of proof of concept (and be tested). Comments?
Updated patch.
Riki
commit 995e5ddaa031931bad121fa597a8f84b73371c49
Author: Richard Kimberly Heck
Date: Sat Sep 1 15:16:01 2018 -0400
Fix slowness on Windows. See bug #9158.
diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 8ca74103a2..bbcbd9c62c 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -143,7 +143,6 @@ typedef map > RefCache;
// A storehouse for the cloned buffers.
list cloned_buffers;
-
class Buffer::Impl
{
public:
@@ -2438,6 +2437,31 @@ void Buffer::registerBibfiles(FileNamePairList const &
bf) const
}
+static map bibfileCache;
+
+
+bool Buffer::bibCacheHasFile(docstring const & bibid)
+{
+ map::const_iterator it =
+ bibfileCache.find(bibid);
+ return it != bibfileCache.end();
+}
+
+
+void Buffer::updateBibCacheFileName(docstring const & bibid,
+ support::FileName const & fn)
+{
+ bibfileCache[bibid] = fn;
+}
+
+
+FileName Buffer::getBibCacheFileName(docstring const & bibid)
+{
+ LASSERT(bibCacheHasFile(bibid), return FileName());
+ return bibfileCache[bibid];
+}
+
+
void Buffer::checkIfBibInfoCacheIsValid() const
{
// use the master's cache
diff --git a/src/Buffer.h b/src/Buffer.h
index 50d086f287..2f287a2c57 100644
--- a/src/Buffer.h
+++ b/src/Buffer.h
@@ -766,6 +766,13 @@ public:
void updateChangesPresent() const;
///
void registerBibfiles(support::FileNamePairList const & bf) const;
+ ///
+ static bool bibCacheHasFile(docstring const & bibid);
+ /// will add or update as required
+ static void updateBibCacheFileName(docstring const & bibid,
+ support::FileName const & fn);
+ ///
+ static support::FileName getBibCacheFileName(docstring const & bibid);
private:
friend class MarkAsExporting;
diff --git a/src/insets/InsetBibtex.cpp b/src/insets/InsetBibtex.cpp
index d2e7284052..03cd44c8a5 100644
--- a/src/insets/InsetBibtex.cpp
+++ b/src/insets/InsetBibtex.cpp
@@ -397,7 +397,13 @@ FileNamePairList InsetBibtex::getBibFiles() const
vector::const_iterator it = bibfilelist.begin();
vector::const_iterator en = bibfilelist.end();
for (; it != en; ++it) {
- FileName const file = getBibTeXPath(*it, buffer());
+ FileName file;
+ if (buffer().bibCacheHasFile(*it)) {
+ file = buffer().getBibCacheFileName(*it);
+ } else {
+ file = getBibTeXPath(*it, buffer());
+ buffer().updateBibCacheFileName(*it, file);
+ }
if (!file.empty())
vec.push_back(make_pair(*it, file));
Re: Windows Installer for Testing
Scott Kostyshak schrieb am Sa., 1. Sep. 2018, 21:26: > On Sat, Sep 01, 2018 at 01:47:54PM -0400, Richard Kimberly Heck wrote: > > > Another option for 2.3.1 would be to revert the commits that fixed #9158. > > +1 The bug does not seem important enough to risk anything at this > point. > I'd vote for that, too. Let's try to get it right for 2.3.2. Jürgen > Scott >
Re: Windows Installer for Testing
On Sat, Sep 01, 2018 at 01:47:54PM -0400, Richard Kimberly Heck wrote: > Another option for 2.3.1 would be to revert the commits that fixed #9158. +1 The bug does not seem important enough to risk anything at this point. Scott signature.asc Description: PGP signature
Re: Windows Installer for Testing
On 09/01/2018 01:36 PM, Richard Kimberly Heck wrote: > On 09/01/2018 12:58 PM, Richard Kimberly Heck wrote: >> On 09/01/2018 10:02 AM, Jürgen Spitzmüller wrote: >>> Am Samstag, den 01.09.2018, 13:49 +0200 schrieb Enrico Forestieri: Using the --verbose switch it can be seen that each time a new paragraph is started LyX runs kpsewhich for each bibtex catalog to be found in the texmf tree. So, if you have 5 catalogs, kpsewhich is run for 5 times everytime you hit the Enter key. >>> Indeed, that's likely the culprit. >>> >>> The call is in InsetBibtex::getBibTeXPath(), which is called by >>> InsetBibtex::getBibFiles(), which is called by >>> InsetBibTeX::updateBuffer(), which is called by Buffer::updateBuffer() >>> >>> Would it make sense to cache those paths, too? After all, they are >>> unlikely to change that often. >> Weird that no-one saw this problem on Linux. > Here's a simple patch which would need a bit of additional work, but can > be a kind of proof of concept (and be tested). Comments? > > The only danger of using this as is in 2.3.1 is that, if paths changed, > we would never know. But that is unlikely to happen. Another option for 2.3.1 would be to revert the commits that fixed #9158. Riki
Re: Windows Installer for Testing
On 09/01/2018 12:58 PM, Richard Kimberly Heck wrote:
> On 09/01/2018 10:02 AM, Jürgen Spitzmüller wrote:
>> Am Samstag, den 01.09.2018, 13:49 +0200 schrieb Enrico Forestieri:
>>> Using the --verbose switch it can be seen that each time a new
>>> paragraph
>>> is started LyX runs kpsewhich for each bibtex catalog to be found in
>>> the
>>> texmf tree. So, if you have 5 catalogs, kpsewhich is run for 5 times
>>> everytime you hit the Enter key.
>> Indeed, that's likely the culprit.
>>
>> The call is in InsetBibtex::getBibTeXPath(), which is called by
>> InsetBibtex::getBibFiles(), which is called by
>> InsetBibTeX::updateBuffer(), which is called by Buffer::updateBuffer()
>>
>> Would it make sense to cache those paths, too? After all, they are
>> unlikely to change that often.
> Weird that no-one saw this problem on Linux.
Here's a simple patch which would need a bit of additional work, but can
be a kind
of proof of concept (and be tested). Comments?
The only danger of using this as is in 2.3.1 is that, if paths changed,
we would never
know. But that is unlikely to happen.
Riki
diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 8ca74103a2..58dd878b5e 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -142,6 +142,7 @@ typedef map > RefCache;
// A storehouse for the cloned buffers.
list cloned_buffers;
+FileNamePairList Buffer::bibfileCache;
class Buffer::Impl
diff --git a/src/Buffer.h b/src/Buffer.h
index 50d086f287..9d34f9c1c3 100644
--- a/src/Buffer.h
+++ b/src/Buffer.h
@@ -766,6 +766,8 @@ public:
void updateChangesPresent() const;
///
void registerBibfiles(support::FileNamePairList const & bf) const;
+ ///
+ static support::FileNamePairList bibfileCache;
private:
friend class MarkAsExporting;
diff --git a/src/insets/InsetBibtex.cpp b/src/insets/InsetBibtex.cpp
index d2e7284052..4b6760c62b 100644
--- a/src/insets/InsetBibtex.cpp
+++ b/src/insets/InsetBibtex.cpp
@@ -397,7 +397,20 @@ FileNamePairList InsetBibtex::getBibFiles() const
vector::const_iterator it = bibfilelist.begin();
vector::const_iterator en = bibfilelist.end();
for (; it != en; ++it) {
- FileName const file = getBibTeXPath(*it, buffer());
+ FileNamePairList & cache = buffer().bibfileCache;
+ FileName file;
+ bool found = false;
+ for (auto const & p : cache) {
+ if (p.first == *it) {
+ file = p.second;
+ found = true;
+ break;
+ }
+ }
+ if (!found) {
+ file = getBibTeXPath(*it, buffer());
+ cache.push_back(make_pair(*it, file));
+ }
if (!file.empty())
vec.push_back(make_pair(*it, file));
Re: Windows Installer for Testing
On 09/01/2018 10:02 AM, Jürgen Spitzmüller wrote: > Am Samstag, den 01.09.2018, 13:49 +0200 schrieb Enrico Forestieri: >> Using the --verbose switch it can be seen that each time a new >> paragraph >> is started LyX runs kpsewhich for each bibtex catalog to be found in >> the >> texmf tree. So, if you have 5 catalogs, kpsewhich is run for 5 times >> everytime you hit the Enter key. > Indeed, that's likely the culprit. > > The call is in InsetBibtex::getBibTeXPath(), which is called by > InsetBibtex::getBibFiles(), which is called by > InsetBibTeX::updateBuffer(), which is called by Buffer::updateBuffer() > > Would it make sense to cache those paths, too? After all, they are > unlikely to change that often. Weird that no-one saw this problem on Linux. Here's a possibility: Cache the paths, as you suggest, and then, if there's no file at that location (when we look for it), re-run findtexfile to try to find it. So we'd need to find all the places the path is used. I note Buffer::checkIfBibInfoCacheIsValid (checking timestamps) and InsetBibtex::parseBibTeXFiles (which calls getBibfiles again) and Buffer::prepareBibFilePaths (which is passed the list). I'm not entirely sure where it's best to put the cache. InsetBibtex is an option, but we really only need a single global one. So maybe a static std::map there? Actually, if we do this, then we probably don't even need the FileNamePairList any more. We can just store the name as entered and use the cache to find the full path. But maybe we don't want to do anything so dramatic right now? Riki
Re: Windows Installer for Testing
On 01/09/2018 01:11, Richard Kimberly Heck wrote: On 08/31/2018 05:58 PM, Daniel wrote: On 2018-08-31 22:51, Richard Kimberly Heck wrote: On 08/31/2018 01:31 PM, Daniel wrote: On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki Not fully sure what details you are asking for. I still cannot find the post I was referring to. And lag kick in one a bibliography is inserted into a document. Writing characters is fine but, for example, deleting a passage or creating a new paragraph lags. I have verified that most of the fix that's in master is also in 2.3.x (and so in 2.3.1). So it's a bit of mystery why this has changed in 2.3.1. That said, there were some other changes that were supposed to help further. Do these documents use master-child stuff? Riki I noticed it first in a document with master-child stuff. But I could reproduce it by just adding a bibliography to a newly created document. It was less of a delay, maybe due to its lesser complexity (and less bibliographies), but the delay was there none the less. Are you able to compile these days? If so, can you try the attached patch with "-dbg files" and let me know what you see? Riki Still haven't set up LyX to compile on my new system... Daniel
Re: Windows Installer for Testing
Am Samstag, den 01.09.2018, 13:49 +0200 schrieb Enrico Forestieri: > Using the --verbose switch it can be seen that each time a new > paragraph > is started LyX runs kpsewhich for each bibtex catalog to be found in > the > texmf tree. So, if you have 5 catalogs, kpsewhich is run for 5 times > everytime you hit the Enter key. Indeed, that's likely the culprit. The call is in InsetBibtex::getBibTeXPath(), which is called by InsetBibtex::getBibFiles(), which is called by InsetBibTeX::updateBuffer(), which is called by Buffer::updateBuffer() Would it make sense to cache those paths, too? After all, they are unlikely to change that often. Jürgen > This was not the case in 2.3.0. > signature.asc Description: This is a digitally signed message part
Re: Windows Installer for Testing
On Sat, Sep 01, 2018 at 11:09:58AM +0200, Jürgen Spitzmüller wrote: > Am Samstag, den 01.09.2018, 20:27 +1200 schrieb Andrew Parsloe: > > OK, this time I inserted a Bib(la)TeX Bibliography via Insert > > > List/TOC, using an old BibTeX .bib file I had lying around. Even a > > small > > trial document is noticeably slower for things like starting a new > > paragraph, although the delay is more like quarter to half a second > > rather than the 2 to 4 seconds you report. Nonetheless it's still > > noticeable. > > The crucial info we need is what makes this so slow only on Windows > (and not on any other OS). Can we do profiling on Win? > > Just a shot in the dark: If you enable the "Files" debug output in View > > Messages, is there any indication that (attempts to) file removal > (aux file and/or bbl file) take your time? I am just guessing that > removeBiblioTempFiles() (involved in the BibinfoCache invalidation) > might be the culprit, since it involves QFile, and this is an obvious > candidate for OS-specific weirdness. Using the --verbose switch it can be seen that each time a new paragraph is started LyX runs kpsewhich for each bibtex catalog to be found in the texmf tree. So, if you have 5 catalogs, kpsewhich is run for 5 times everytime you hit the Enter key. This was not the case in 2.3.0. -- Enrico
Re: Windows Installer for Testing
Am Samstag, den 01.09.2018, 12:40 +0200 schrieb Jean-Marc Lasgouttes: > Le 01/09/2018 à 11:09, Jürgen Spitzmüller a écrit : > > The crucial info we need is what makes this so slow only on Windows > > (and not on any other OS). Can we do profiling on Win? > > Could we have a document that exhibits the problem? I understand that you just need a document with a fairly big BibTeX database. Jürgen > > JMarc > signature.asc Description: This is a digitally signed message part
Re: Windows Installer for Testing
Le 01/09/2018 à 11:09, Jürgen Spitzmüller a écrit : The crucial info we need is what makes this so slow only on Windows (and not on any other OS). Can we do profiling on Win? Could we have a document that exhibits the problem? JMarc
Re: Windows Installer for Testing
Am Samstag, den 01.09.2018, 20:27 +1200 schrieb Andrew Parsloe: > OK, this time I inserted a Bib(la)TeX Bibliography via Insert > > List/TOC, using an old BibTeX .bib file I had lying around. Even a > small > trial document is noticeably slower for things like starting a new > paragraph, although the delay is more like quarter to half a second > rather than the 2 to 4 seconds you report. Nonetheless it's still > noticeable. The crucial info we need is what makes this so slow only on Windows (and not on any other OS). Can we do profiling on Win? Just a shot in the dark: If you enable the "Files" debug output in View > Messages, is there any indication that (attempts to) file removal (aux file and/or bbl file) take your time? I am just guessing that removeBiblioTempFiles() (involved in the BibinfoCache invalidation) might be the culprit, since it involves QFile, and this is an obvious candidate for OS-specific weirdness. Jürgen > > Andrew signature.asc Description: This is a digitally signed message part
Re: Windows Installer for Testing
On 1/09/2018 7:13 p.m., Daniel wrote: On 2018-09-01 08:57, Andrew Parsloe wrote: On 1/09/2018 11:11 a.m., Richard Kimberly Heck wrote: On 08/31/2018 05:58 PM, Daniel wrote: On 2018-08-31 22:51, Richard Kimberly Heck wrote: On 08/31/2018 01:31 PM, Daniel wrote: On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki Not fully sure what details you are asking for. I still cannot find the post I was referring to. And lag kick in one a bibliography is inserted into a document. Writing characters is fine but, for example, deleting a passage or creating a new paragraph lags. I have verified that most of the fix that's in master is also in 2.3.x (and so in 2.3.1). So it's a bit of mystery why this has changed in 2.3.1. That said, there were some other changes that were supposed to help further. Do these documents use master-child stuff? Riki I noticed it first in a document with master-child stuff. But I could reproduce it by just adding a bibliography to a newly created document. It was less of a delay, maybe due to its lesser complexity (and less bibliographies), but the delay was there none the less. Are you able to compile these days? If so, can you try the attached patch with "-dbg files" and let me know what you see? Riki To provide another data point for this discussion, 2.3.1 installed without problems on my windows 7 system and is not showing any delay for the kinds of operations Daniel mentioned. This is with a master-child document. The bibliography has 19 entries but is 'built-in' rather than using an external bib database. Andrew By 'built-in' you mean not using the bibliography inset? If so, can you try with one? Daniel OK, this time I inserted a Bib(la)TeX Bibliography via Insert > List/TOC, using an old BibTeX .bib file I had lying around. Even a small trial document is noticeably slower for things like starting a new paragraph, although the delay is more like quarter to half a second rather than the 2 to 4 seconds you report. Nonetheless it's still noticeable. Andrew --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
Re: Windows Installer for Testing
On 1/09/2018 7:13 p.m., Daniel wrote:
On 2018-09-01 08:57, Andrew Parsloe wrote:
On 1/09/2018 11:11 a.m., Richard Kimberly Heck wrote:
On 08/31/2018 05:58 PM, Daniel wrote:
On 2018-08-31 22:51, Richard Kimberly Heck wrote:
On 08/31/2018 01:31 PM, Daniel wrote:
On 2018-08-31 19:23, Richard Kimberly Heck wrote:
On 08/31/2018 10:33 AM, Daniel wrote:
It might be the same problem as plagued the 2.3.0 version at
first.
Once I have a bibliography included the delay is there (and the
more
bibliographies the worse). I can't find the posting from the last
version but I seem to remember that Jürgen and Riki were
involved in
its solution.
Yes, I thought we had sorted that out, but perhaps not. Can you
give a
few more details?
Riki
Not fully sure what details you are asking for. I still cannot find
the post I was referring to. And lag kick in one a bibliography is
inserted into a document. Writing characters is fine but, for
example,
deleting a passage or creating a new paragraph lags.
I have verified that most of the fix that's in master is also in
2.3.x
(and so in 2.3.1). So it's a bit of mystery why this has changed in
2.3.1. That said, there were some other changes that were supposed to
help further.
Do these documents use master-child stuff?
Riki
I noticed it first in a document with master-child stuff. But I could
reproduce it by just adding a bibliography to a newly created
document. It was less of a delay, maybe due to its lesser complexity
(and less bibliographies), but the delay was there none the less.
Are you able to compile these days? If so, can you try the attached
patch with "-dbg files" and let me know what you see?
Riki
To provide another data point for this discussion, 2.3.1 installed
without problems on my windows 7 system and is not showing any delay
for the kinds of operations Daniel mentioned. This is with a
master-child document. The bibliography has 19 entries but is
'built-in' rather than using an external bib database.
Andrew
By 'built-in' you mean not using the bibliography inset? If so, can
you try with one?
Daniel
I meant that I went to the layout drop-down box and clicked on
Bibliography, which inserted a heading "Bibliography". I presume this is
the "bibliography inset"? Pressing Enter below the heading gives me a
key-1[] prompt. I type in bibliographic details beside that, so that
the entry is part of the document ('built-in') rather than being stored
in an external file.
Andrew
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
Re: Windows Installer for Testing
Am Freitag, den 31.08.2018, 23:56 +0200 schrieb Daniel: > > The thread with "Beta1 is slow on undo“ perhaps? > > > > Stephan > > > > Probably, I seem not to be able to access them from here. https://marc.info/?l=lyx-devel=150739249920974=2 The respective ticket is https://www.lyx.org/trac/ticket/9158 Jürgen > > Daniel > > signature.asc Description: This is a digitally signed message part
Re: Windows Installer for Testing
On 2018-09-01 08:57, Andrew Parsloe wrote: On 1/09/2018 11:11 a.m., Richard Kimberly Heck wrote: On 08/31/2018 05:58 PM, Daniel wrote: On 2018-08-31 22:51, Richard Kimberly Heck wrote: On 08/31/2018 01:31 PM, Daniel wrote: On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki Not fully sure what details you are asking for. I still cannot find the post I was referring to. And lag kick in one a bibliography is inserted into a document. Writing characters is fine but, for example, deleting a passage or creating a new paragraph lags. I have verified that most of the fix that's in master is also in 2.3.x (and so in 2.3.1). So it's a bit of mystery why this has changed in 2.3.1. That said, there were some other changes that were supposed to help further. Do these documents use master-child stuff? Riki I noticed it first in a document with master-child stuff. But I could reproduce it by just adding a bibliography to a newly created document. It was less of a delay, maybe due to its lesser complexity (and less bibliographies), but the delay was there none the less. Are you able to compile these days? If so, can you try the attached patch with "-dbg files" and let me know what you see? Riki To provide another data point for this discussion, 2.3.1 installed without problems on my windows 7 system and is not showing any delay for the kinds of operations Daniel mentioned. This is with a master-child document. The bibliography has 19 entries but is 'built-in' rather than using an external bib database. Andrew By 'built-in' you mean not using the bibliography inset? If so, can you try with one? Daniel
Re: Windows Installer for Testing
On 1/09/2018 11:11 a.m., Richard Kimberly Heck wrote: On 08/31/2018 05:58 PM, Daniel wrote: On 2018-08-31 22:51, Richard Kimberly Heck wrote: On 08/31/2018 01:31 PM, Daniel wrote: On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki Not fully sure what details you are asking for. I still cannot find the post I was referring to. And lag kick in one a bibliography is inserted into a document. Writing characters is fine but, for example, deleting a passage or creating a new paragraph lags. I have verified that most of the fix that's in master is also in 2.3.x (and so in 2.3.1). So it's a bit of mystery why this has changed in 2.3.1. That said, there were some other changes that were supposed to help further. Do these documents use master-child stuff? Riki I noticed it first in a document with master-child stuff. But I could reproduce it by just adding a bibliography to a newly created document. It was less of a delay, maybe due to its lesser complexity (and less bibliographies), but the delay was there none the less. Are you able to compile these days? If so, can you try the attached patch with "-dbg files" and let me know what you see? Riki To provide another data point for this discussion, 2.3.1 installed without problems on my windows 7 system and is not showing any delay for the kinds of operations Daniel mentioned. This is with a master-child document. The bibliography has 19 entries but is 'built-in' rather than using an external bib database. Andrew --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
Re: Windows Installer for Testing
On Fri, Aug 31, 2018 at 01:23:19PM -0400, Richard Kimberly Heck wrote: > On 08/31/2018 10:44 AM, Daniel wrote: > >> First, here is the information: > >> > >> LyX Version 2.3.1 > >> (30 August 2018) > >> Built from git commit hash 65bc3149 > >> Library directory: C:\Program Files (x86)\LyX 2.3\Resources\ > >> User directory: ~\AppData\Roaming\LyX2.3\ > >> Qt Version (run-time): 5.10.1 > >> Qt Version (compile-time): 5.10.1 > > > > Of course your question concerned the comparison: > > > > LyX Version 2.3.0 > > (06 July 2018) > > Built from git commit hash 2a8c7061 > > Library directory: C:\Program Files (x86)\LyX 2.3\Resources\ > > User directory: ~\AppData\Roaming\LyX2.3\ > > Qt Version (run-time): 5.10.1 > > Qt Version (compile-time): 5.10.1 > > FYI, the ONLY difference between the 2.3.1 and 2.3.0 packages is the LyX > binary. I did not make any other updates to the installer. Good to know. So not a Qt issue then. Scott signature.asc Description: PGP signature
Re: Windows Installer for Testing
On 08/31/2018 05:58 PM, Daniel wrote: > On 2018-08-31 22:51, Richard Kimberly Heck wrote: >> On 08/31/2018 01:31 PM, Daniel wrote: >>> On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: > > It might be the same problem as plagued the 2.3.0 version at first. > Once I have a bibliography included the delay is there (and the more > bibliographies the worse). I can't find the posting from the last > version but I seem to remember that Jürgen and Riki were involved in > its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki >>> >>> Not fully sure what details you are asking for. I still cannot find >>> the post I was referring to. And lag kick in one a bibliography is >>> inserted into a document. Writing characters is fine but, for example, >>> deleting a passage or creating a new paragraph lags. >> >> I have verified that most of the fix that's in master is also in 2.3.x >> (and so in 2.3.1). So it's a bit of mystery why this has changed in >> 2.3.1. That said, there were some other changes that were supposed to >> help further. >> >> Do these documents use master-child stuff? >> >> Riki > > I noticed it first in a document with master-child stuff. But I could > reproduce it by just adding a bibliography to a newly created > document. It was less of a delay, maybe due to its lesser complexity > (and less bibliographies), but the delay was there none the less. Are you able to compile these days? If so, can you try the attached patch with "-dbg files" and let me know what you see? Riki diff --git a/src/Buffer.cpp b/src/Buffer.cpp index da3db82fa5..a8b6115678 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -2416,6 +2416,7 @@ void Buffer::reloadBibInfoCache() const if (d->bibinfo_cache_valid_) return; + LYXERR(Debug::FILES, "Reloading bibinfo cache!"); d->bibinfo_.clear(); FileNameList checkedFiles; collectBibKeys(checkedFiles);
Re: Windows Installer for Testing
On 2018-08-31 22:51, Richard Kimberly Heck wrote: On 08/31/2018 01:31 PM, Daniel wrote: On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki Not fully sure what details you are asking for. I still cannot find the post I was referring to. And lag kick in one a bibliography is inserted into a document. Writing characters is fine but, for example, deleting a passage or creating a new paragraph lags. I have verified that most of the fix that's in master is also in 2.3.x (and so in 2.3.1). So it's a bit of mystery why this has changed in 2.3.1. That said, there were some other changes that were supposed to help further. Do these documents use master-child stuff? Riki I noticed it first in a document with master-child stuff. But I could reproduce it by just adding a bibliography to a newly created document. It was less of a delay, maybe due to its lesser complexity (and less bibliographies), but the delay was there none the less. Daniel
Re: Windows Installer for Testing
On 2018-08-31 22:15, Stephan Witt wrote: Am 31.08.2018 um 19:31 schrieb Daniel : On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki Not fully sure what details you are asking for. I still cannot find the post I was referring to. And lag kick in one a bibliography is inserted into a document. Writing characters is fine but, for example, deleting a passage or creating a new paragraph lags. Daniel The thread with "Beta1 is slow on undo“ perhaps? Stephan Probably, I seem not to be able to access them from here. Daniel
Re: Windows Installer for Testing
On 08/31/2018 01:31 PM, Daniel wrote: > On 2018-08-31 19:23, Richard Kimberly Heck wrote: >> On 08/31/2018 10:33 AM, Daniel wrote: >>> >>> It might be the same problem as plagued the 2.3.0 version at first. >>> Once I have a bibliography included the delay is there (and the more >>> bibliographies the worse). I can't find the posting from the last >>> version but I seem to remember that Jürgen and Riki were involved in >>> its solution. >> >> Yes, I thought we had sorted that out, but perhaps not. Can you give a >> few more details? >> >> Riki > > Not fully sure what details you are asking for. I still cannot find > the post I was referring to. And lag kick in one a bibliography is > inserted into a document. Writing characters is fine but, for example, > deleting a passage or creating a new paragraph lags. I have verified that most of the fix that's in master is also in 2.3.x (and so in 2.3.1). So it's a bit of mystery why this has changed in 2.3.1. That said, there were some other changes that were supposed to help further. Do these documents use master-child stuff? Riki
Re: Windows Installer for Testing
Am 31.08.2018 um 19:31 schrieb Daniel : > > On 2018-08-31 19:23, Richard Kimberly Heck wrote: >> On 08/31/2018 10:33 AM, Daniel wrote: >>> >>> It might be the same problem as plagued the 2.3.0 version at first. >>> Once I have a bibliography included the delay is there (and the more >>> bibliographies the worse). I can't find the posting from the last >>> version but I seem to remember that Jürgen and Riki were involved in >>> its solution. >> Yes, I thought we had sorted that out, but perhaps not. Can you give a >> few more details? >> Riki > > Not fully sure what details you are asking for. I still cannot find the post > I was referring to. And lag kick in one a bibliography is inserted into a > document. Writing characters is fine but, for example, deleting a passage or > creating a new paragraph lags. > > Daniel The thread with "Beta1 is slow on undo“ perhaps? Stephan
Re: Windows Installer for Testing
On 2018-08-31 19:23, Richard Kimberly Heck wrote: On 08/31/2018 10:33 AM, Daniel wrote: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki Not fully sure what details you are asking for. I still cannot find the post I was referring to. And lag kick in one a bibliography is inserted into a document. Writing characters is fine but, for example, deleting a passage or creating a new paragraph lags. Daniel
Re: Windows Installer for Testing
On 08/31/2018 10:33 AM, Daniel wrote: > > It might be the same problem as plagued the 2.3.0 version at first. > Once I have a bibliography included the delay is there (and the more > bibliographies the worse). I can't find the posting from the last > version but I seem to remember that Jürgen and Riki were involved in > its solution. Yes, I thought we had sorted that out, but perhaps not. Can you give a few more details? Riki
Re: Windows Installer for Testing
On 08/31/2018 10:44 AM, Daniel wrote: > On 31/08/2018 16:33, Daniel wrote: >> On 31/08/2018 16:09, Scott Kostyshak wrote: >>> On Fri, Aug 31, 2018 at 03:59:34PM +0200, Daniel wrote: On 31/08/2018 15:18, Jean-Marc Lasgouttes wrote: > Le 31/08/2018 à 13:27, Daniel a écrit : >> Unfortunately, LyX 2.3.1 is not usable for me. Many simple things >> take a couple of seconds, like when I press enter for a new >> paragraph, delete something, click on another paragraph, etc. > > That is very very weird. I have to give it a go. A couple of > seconds is > a lot. > > JMarc Yes it is (something between 2 to 4 second - but I guess any really noticeable delay renders it unusable). I am now back to 2.3.0. No problems there. >>> >>> Thanks for testing, Daniel. When you go to Help > About, is the >>> information the same except for "2.3.1" instead of "2.3.0" ? (don't >>> re-install LyX 2.3.1 just to answer this question. I only ask in the >>> case that you have them installed side-by-side) >>> >>> Scott >> >> First, here is the information: >> >> LyX Version 2.3.1 >> (30 August 2018) >> Built from git commit hash 65bc3149 >> Library directory: C:\Program Files (x86)\LyX 2.3\Resources\ >> User directory: ~\AppData\Roaming\LyX2.3\ >> Qt Version (run-time): 5.10.1 >> Qt Version (compile-time): 5.10.1 > > Of course your question concerned the comparison: > > LyX Version 2.3.0 > (06 July 2018) > Built from git commit hash 2a8c7061 > Library directory: C:\Program Files (x86)\LyX 2.3\Resources\ > User directory: ~\AppData\Roaming\LyX2.3\ > Qt Version (run-time): 5.10.1 > Qt Version (compile-time): 5.10.1 FYI, the ONLY difference between the 2.3.1 and 2.3.0 packages is the LyX binary. I did not make any other updates to the installer. Riki
Re: Windows Installer for Testing
On 31/08/2018 16:33, Daniel wrote: On 31/08/2018 16:09, Scott Kostyshak wrote: On Fri, Aug 31, 2018 at 03:59:34PM +0200, Daniel wrote: On 31/08/2018 15:18, Jean-Marc Lasgouttes wrote: Le 31/08/2018 à 13:27, Daniel a écrit : Unfortunately, LyX 2.3.1 is not usable for me. Many simple things take a couple of seconds, like when I press enter for a new paragraph, delete something, click on another paragraph, etc. That is very very weird. I have to give it a go. A couple of seconds is a lot. JMarc Yes it is (something between 2 to 4 second - but I guess any really noticeable delay renders it unusable). I am now back to 2.3.0. No problems there. Thanks for testing, Daniel. When you go to Help > About, is the information the same except for "2.3.1" instead of "2.3.0" ? (don't re-install LyX 2.3.1 just to answer this question. I only ask in the case that you have them installed side-by-side) Scott First, here is the information: LyX Version 2.3.1 (30 August 2018) Built from git commit hash 65bc3149 Library directory: C:\Program Files (x86)\LyX 2.3\Resources\ User directory: ~\AppData\Roaming\LyX2.3\ Qt Version (run-time): 5.10.1 Qt Version (compile-time): 5.10.1 Of course your question concerned the comparison: LyX Version 2.3.0 (06 July 2018) Built from git commit hash 2a8c7061 Library directory: C:\Program Files (x86)\LyX 2.3\Resources\ User directory: ~\AppData\Roaming\LyX2.3\ Qt Version (run-time): 5.10.1 Qt Version (compile-time): 5.10.1
Re: Windows Installer for Testing
On 31/08/2018 16:09, Scott Kostyshak wrote: On Fri, Aug 31, 2018 at 03:59:34PM +0200, Daniel wrote: On 31/08/2018 15:18, Jean-Marc Lasgouttes wrote: Le 31/08/2018 à 13:27, Daniel a écrit : Unfortunately, LyX 2.3.1 is not usable for me. Many simple things take a couple of seconds, like when I press enter for a new paragraph, delete something, click on another paragraph, etc. That is very very weird. I have to give it a go. A couple of seconds is a lot. JMarc Yes it is (something between 2 to 4 second - but I guess any really noticeable delay renders it unusable). I am now back to 2.3.0. No problems there. Thanks for testing, Daniel. When you go to Help > About, is the information the same except for "2.3.1" instead of "2.3.0" ? (don't re-install LyX 2.3.1 just to answer this question. I only ask in the case that you have them installed side-by-side) Scott I actually re-installed it now to do some more testing for which I had no time before. First, here is the information: LyX Version 2.3.1 (30 August 2018) Built from git commit hash 65bc3149 Library directory: C:\Program Files (x86)\LyX 2.3\Resources\ User directory: ~\AppData\Roaming\LyX2.3\ Qt Version (run-time): 5.10.1 Qt Version (compile-time): 5.10.1 Now to the testing: It might be the same problem as plagued the 2.3.0 version at first. Once I have a bibliography included the delay is there (and the more bibliographies the worse). I can't find the posting from the last version but I seem to remember that Jürgen and Riki were involved in its solution. Daniel
Re: Windows Installer for Testing
On Fri, Aug 31, 2018 at 03:59:34PM +0200, Daniel wrote: > On 31/08/2018 15:18, Jean-Marc Lasgouttes wrote: > > Le 31/08/2018 à 13:27, Daniel a écrit : > > > Unfortunately, LyX 2.3.1 is not usable for me. Many simple things > > > take a couple of seconds, like when I press enter for a new > > > paragraph, delete something, click on another paragraph, etc. > > > > That is very very weird. I have to give it a go. A couple of seconds is > > a lot. > > > > JMarc > > Yes it is (something between 2 to 4 second - but I guess any really > noticeable delay renders it unusable). I am now back to 2.3.0. No problems > there. Thanks for testing, Daniel. When you go to Help > About, is the information the same except for "2.3.1" instead of "2.3.0" ? (don't re-install LyX 2.3.1 just to answer this question. I only ask in the case that you have them installed side-by-side) Scott signature.asc Description: PGP signature
Re: Windows Installer for Testing
On 31/08/2018 15:18, Jean-Marc Lasgouttes wrote: Le 31/08/2018 à 13:27, Daniel a écrit : Unfortunately, LyX 2.3.1 is not usable for me. Many simple things take a couple of seconds, like when I press enter for a new paragraph, delete something, click on another paragraph, etc. That is very very weird. I have to give it a go. A couple of seconds is a lot. JMarc Yes it is (something between 2 to 4 second - but I guess any really noticeable delay renders it unusable). I am now back to 2.3.0. No problems there. Daniel
Re: Windows Installer for Testing
Le 31/08/2018 à 13:27, Daniel a écrit : Unfortunately, LyX 2.3.1 is not usable for me. Many simple things take a couple of seconds, like when I press enter for a new paragraph, delete something, click on another paragraph, etc. That is very very weird. I have to give it a go. A couple of seconds is a lot. JMarc
Re: Windows Installer for Testing
On 31/08/2018 00:52, Richard Kimberly Heck wrote: Windows installers for 2.3.1 are at http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/. Please let me know if you have any problems. But I know there are some weird issues with MiKTeX right now, and I've seen signs of that in my own testing. Riki Unfortunately, LyX 2.3.1 is not usable for me. Many simple things take a couple of seconds, like when I press enter for a new paragraph, delete something, click on another paragraph, etc. I used the non-bundle installer on Windows 10. Reverting back to 2.3.0... Daniel
Re: Windows Installer for Testing
On 31/08/2018 00:52, Richard Kimberly Heck wrote:
Windows installers for 2.3.1 are at
http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/. Please let me know if you
have any problems. But I know there are some weird issues with MiKTeX
right now, and I've seen signs of that in my own testing.
Riki
Here are a couple of warnings from the log while installing ("for
everyone on the computer"). But they have been there in the last
versions, I think.
[...]
Configuring LyX (MiKTeX may download missing packages, this can take
some time) ...
Operating on the shared (system-wide) MiKTeX setup
downloading
https://ftp.acc.umu.se/mirror/CTAN/systems/win32/miktex/tm/packages/miktex-zzdb2-2.9.tar.lzma...
1026237 bytes, 2438.41 KB/Sec
updating package definition directory ("C:\Program Files\MiKTeX
2.9\tpm\packages")...
installed 3048 package definition files
visiting repository
https://ftp.acc.umu.se/mirror/CTAN/systems/win32/miktex/tm/packages/...
repository type: remote package repository
loading lightweight database...
downloading
https://ftp.acc.umu.se/mirror/CTAN/systems/win32/miktex/tm/packages/miktex-zzdb1-2.9.tar.lzma...
180468 bytes, 2517.69 KB/Sec
Operating on the shared (system-wide) MiKTeX setup
Sorry, but "MiKTeX Package Manager" did not succeed.
The log file hopefully contains the information to get MiKTeX going again:
C:/ProgramData/MiKTeX/2.9/miktex/log/mpmcli_admin.log
You may want to visit the MiKTeX project page, if you need help.
Configuring LyX (MiKTeX may download missing packages, this can take
some time) ...
checking for DVI to DTL converter...
+checking for "dv2dt"... no
checking for a Latex2e program...
+checking for "latex"... yes
checking for a DVI postprocessing program...
+checking for "pplatex"... no
checking for pLaTeX, the Japanese LaTeX...
+checking for "platex"... no
latex: warning: running with administrator privileges
initexmf: warning: Option --admin should be specified when running this
program with administrative privileges
initexmf: warning: Option --admin should be specified when running this
program with administrative privileges
Re: Windows Installer for Testing
On 31/08/2018 00:52, Richard Kimberly Heck wrote: Windows installers for 2.3.1 are at http://ftp.lyx.org/pub/lyx/devel/lyx-2.3/. Please let me know if you have any problems. But I know there are some weird issues with MiKTeX right now, and I've seen signs of that in my own testing. Riki Just got the message attached again. One has to click on "More info" and "Run anyway". Maybe it is worth explaining this somewhere - just in case. Sorry, if I have missed that it is already. I should have taken a screenshot of the second screen as well. Next time. Daniel
