[9] Review request for 8036598 [macosx] Create AquaIcons from image representations

2014-03-04 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8036598 webrev: http://cr.openjdk.java.net/~alexsch/8036598/webrev.00 The fix creates an AquaIcon based on resolution variants. It becomes possible after the fix 8033534 where CImage returns a

Re: [9] Review request for 8036598 [macosx] Create AquaIcons from image representations

2014-03-04 Thread Petr Pchelko
Hello, Alexander. I've been also looking around this code and I have a related question: when we call getThisApplicationsIcon we are drawing the Dock icon on top of a multi-resolution background image. However as I see, the dock icon image created with getThisApplicationsIcon and

Re: [9] Review request for 8036598 [macosx] Create AquaIcons from image representations

2014-03-04 Thread Sergey Bylokhov
Hi, Alexander. I have only two suggestions about MultiResolutionBufferedImage - It could be final and its fields can be private final. - .toArray(length - new Image[length])); can be replaced .toArray(Image[]::new)); On 3/4/14 5:32 PM, Alexander Scherbatiy wrote: Hello, Could you review