Hi, Alexander.
The fix looks good. But can you remove the text " in Quartz" from the
comments before the push.
Thanks.
On 4/7/14 7:30 PM, Alexander Scherbatiy wrote:
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8038113/webrev.02
- CachableJRSUIIcon exp
Hello, Alexander.
The new version looks good to me.
With best regards. Petr.
On 07.04.2014, at 19:30, Alexander Scherbatiy
wrote:
>
> Hello,
>
> Could you review the updated fix:
>http://cr.openjdk.java.net/~alexsch/8038113/webrev.02
>
> - CachableJRSUIIcon explicitly implements Icon
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8038113/webrev.02
- CachableJRSUIIcon explicitly implements Icon interface now
- getOptimizedImage() method is removed from the CachingScalingIcon
because NSImage always scales an image to the requested size
Hello, Alexander.
Could you please add the @Override to the paintIcon method.
Also I suggest to reuse the paintIcon in the createIcon.
With best regards. Petr.
On 02.04.2014, at 16:20, Alexander Scherbatiy
wrote:
>
> Hello,
>
> Could you review the updated fix:
>http://cr.openjdk.ja
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8038113/webrev.01/
The CachableJRSUIIcon creates an image twice: in createImage() and in
the AquaPainter.paint() methods.
The fix paints the icon directly from the AquaPainter.paint() method
which uses
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8038113
webrev: http://cr.openjdk.java.net/~alexsch/8038113/webrev.00
MultiResolution image is used to create resolution variants for the
JTree icons.
The fix assumes that AquaPainter uses the graphics tra
