Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-20 Thread Brent Christian
On 6/13/16 5:14 PM, Naoto Sato wrote: On 13/06/2016 16:20, Brent Christian wrote: Following the call to setupMacOSXLocale() in ParseLocale()[1], mapLookup() is called to map the language to a default country So does this mean the new code will not honor the "Region" in the OSX's system prefer

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-20 Thread Naoto Sato
Good! Wasn't aware there is "British English" in the language selection. Looks like all is working as expected. Naoto On 6/20/16 2:34 PM, Brent Christian wrote: On 6/13/16 5:14 PM, Naoto Sato wrote: On 13/06/2016 16:20, Brent Christian wrote: Following the call to setupMacOSXLocale() in Par

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-20 Thread Brent Christian
Alex - thanks for your response. More below... On 6/13/16 4:51 PM, Alex Strange wrote: 2. In "setupMacOSXLocale" we simply drop the call to "JRSSetDefaultLocalization" as it appears to be a NOP. According to Apple, that API sets up native bundle locale, so that any access to native Cocoa UI (l

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-20 Thread Brent Christian
Hi, I have an updated webrev at: http://cr.openjdk.java.net/~bchristi/7131356/webrev.03/ The comments have been updated as Gerard suggested. The code to process the languageString now accounts for 3-character language codes, and 4-char script designations (line 86). More extensive testing of