Re: RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang

2018-10-04 Thread Kim Barrett
> On Oct 4, 2018, at 5:31 PM, David Holmes wrote: > > Looks good! > > Thanks for your patience and perseverance! :) Thanks! And thanks for your patience and perseverance too! > > David

Re: RFR: 8211962: Implicit narrowing in MacOSX java.desktop jsound

2018-10-10 Thread Kim Barrett
> On Oct 10, 2018, at 9:20 PM, Sergey Bylokhov > wrote: > > Looks fine. Thanks! > > On 09/10/2018 18:23, Kim Barrett wrote: >> Please review this trivial fix of a build failure on MacOSX when >> compiling with C++11/14 enabled. An int value is being u

Re: RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang

2018-10-01 Thread Kim Barrett
> On Sep 30, 2018, at 4:51 PM, David Holmes wrote: > > Hi Kim, Thanks for looking at this. >> (2) Remove call to _dyld_bind_fully_image_containing_address, which >> seems to have been deprecated since MacOSX 10.5. Instead use the >> recommended replacement "dlopen(RTLD_NOW)". However, it

Re: RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang

2018-10-01 Thread Kim Barrett
> On Oct 1, 2018, at 2:27 AM, David Holmes wrote: > > On 1/10/2018 1:21 PM, Kim Barrett wrote: >> The current library may have been previously only dlopen’ed with RTLD_LAZY. >> Reopening with RTLD_NOW >> forces resolution of all undefined symbols in that share