On 6/22/16 9:48 PM, Brent Christian wrote:
On 6/22/16 3:58 PM, Naoto Sato wrote:
Hi Brent,
1. It seems that the display language in the new code seems to have some
problems. I see (in es-419.txt):
---
locale[Default|Display|Format].getLanguage () is
user.language: it is
---
And in fact,
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP 47 language
tags are case insensitive, so it would be better to check [a-z] in line
94/95 as well.
- Line 82: Does the API actually returns "zh-Hans_HK"? Underscore
+1
> On 23/6/16 上午10:34, Naoto Sato wrote:
I see that you tested thoroughly :-)
Naoto
On 6/23/16 1:13 PM, Brent Christian wrote:
On 23/6/16 上午10:34, Naoto Sato wrote:
I reviewed webrev.04 thoroughly this time and comments below:
- Although the OSX API returns the cases as in the spec, BCP