Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-23 Thread Naoto Sato
+1 > On 23/6/16 上午10:34, Naoto Sato wrote: I see that you tested thoroughly :-) Naoto On 6/23/16 1:13 PM, Brent Christian wrote: On 23/6/16 上午10:34, Naoto Sato wrote: I reviewed webrev.04 thoroughly this time and comments below: - Although the OSX API returns the cases as in the spec, BCP

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-23 Thread Naoto Sato
I reviewed webrev.04 thoroughly this time and comments below: - Although the OSX API returns the cases as in the spec, BCP 47 language tags are case insensitive, so it would be better to check [a-z] in line 94/95 as well. - Line 82: Does the API actually returns "zh-Hans_HK"? Underscore

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-23 Thread Naoto Sato
On 6/22/16 9:48 PM, Brent Christian wrote: On 6/22/16 3:58 PM, Naoto Sato wrote: Hi Brent, 1. It seems that the display language in the new code seems to have some problems. I see (in es-419.txt): --- locale[Default|Display|Format].getLanguage () is user.language: it is --- And in fact,

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-22 Thread Brent Christian
On 6/22/16 3:58 PM, Naoto Sato wrote: Hi Brent, 1. It seems that the display language in the new code seems to have some problems. I see (in es-419.txt): --- locale[Default|Display|Format].getLanguage () is user.language: it is --- And in fact, display strings are no longer in Spanish in the

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-22 Thread Naoto Sato
Hi Brent, 1. It seems that the display language in the new code seems to have some problems. I see (in es-419.txt): --- locale[Default|Display|Format].getLanguage () is user.language: it is --- And in fact, display strings are no longer in Spanish in the new version (as the language is

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-22 Thread Brent Christian
On 22/06/16 15:10, Alex Strange wrote: On Jun 20, 2016, at 3:44 PM, Brent Christian wrote: I'd prefer something that can build on SDK 10.9 and 10.10, etc. There might be a way to #ifdef it out (not sure), but it's not worth it. I came to the same conclusion. :)