request review #52075

2016-08-24 Thread Björn Ketelaars
Would someone be so kind to review (and commit) https://trac.macports.org/ticket/52075 ? Thank you! -- Björn Ketelaars GPG key: 0x4F0E5F21 ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/mac

Re: how about a 'snowleopardfixes' library port?

2016-08-24 Thread Ryan Schmidt
On Aug 24, 2016, at 3:06 AM, Rainer Müller wrote: > On 2016-08-23 19:13, Ryan Schmidt wrote: >> I would prefer you work with the developers of the affected software >> packages to get the necessary compatibility functions into their sources. >> This will help all Snow Leopard users, not just th

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread Rainer Müller
On 2016-08-24 21:40, Mihai Moldovan wrote: > On 24.08.2016 09:36 PM, Lawrence Velázquez wrote: >> But those Perl ports are always leaves (w.r.t. `cpuid`) because they are >> build dependencies. There's no need to revbump if you're just updating build >> dependencies. > > Aren't build dependencie

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread Lawrence Velázquez
> On Aug 24, 2016, at 3:40 PM, Mihai Moldovan wrote: > >> On 24.08.2016 09:36 PM, Lawrence Velázquez wrote: >> >> But those Perl ports are always leaves (w.r.t. `cpuid`) because they are >> build dependencies. There's no need to revbump if you're just updating build >> dependencies. > > Aren'

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread René J . V . Bertin
On Wednesday August 24 2016 15:40:27 Lawrence Velázquez wrote: > > But those Perl ports are always leaves (w.r.t. `cpuid`) because they are > > build dependencies. There's no need to revbump if you're just updating > > build dependencies. > > To be more specific, there's no need to revbump if t

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread Mihai Moldovan
On 24.08.2016 09:36 PM, Lawrence Velázquez wrote: > But those Perl ports are always leaves (w.r.t. `cpuid`) because they are > build dependencies. There's no need to revbump if you're just updating build > dependencies. Aren't build dependencies included in the DB? I typically run port_cutleaves

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread Lawrence Velázquez
> On Aug 24, 2016, at 3:36 PM, Lawrence Velázquez wrote: > >> On Aug 24, 2016, at 3:05 PM, Mihai Moldovan wrote: >> >>> On 24.08.2016 09:02 PM, René J.V. Bertin wrote: >>> >>> Also, cpuid only has a build dependency on 2 perl packages, so there's no >>> need to reinstall the port when perl ch

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread René J . V . Bertin
On Wednesday August 24 2016 21:05:29 Mihai Moldovan wrote: >Uhm but that won't lead to rebuilds... But there's no need to rebuild here, just as there wouldn't be a reason to rebuild if the perl packages were a runtime dependency. >to make that perl package a leaf. It's not strictly required, bu

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread Lawrence Velázquez
> On Aug 24, 2016, at 3:05 PM, Mihai Moldovan wrote: > >> On 24.08.2016 09:02 PM, René J.V. Bertin wrote: >> >> Also, cpuid only has a build dependency on 2 perl packages, so there's no >> need to reinstall the port when perl changes. > > You can use the revbump to change the dependency to the

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread Mihai Moldovan
On 24.08.2016 09:02 PM, René J.V. Bertin wrote: > On Wednesday August 24 2016 20:43:08 Mihai Moldovan wrote: > >> It will need a revbump once that's done, but otherwise yes. > > That shouldn't actually be necessary; "base" ought to track which PortGroup > files a port depends on, so that portind

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread René J . V . Bertin
On Wednesday August 24 2016 20:43:08 Mihai Moldovan wrote: >It will need a revbump once that's done, but otherwise yes. That shouldn't actually be necessary; "base" ought to track which PortGroup files a port depends on, so that portindex can parse them if any of those dependencies change. Als

Re: [MacPorts] #52081: Ports should require perl5.24 instead of 5.22

2016-08-24 Thread Mihai Moldovan
On 24.08.2016 08:28 PM, MacPorts wrote: > #52081: Ports should require perl5.24 instead of 5.22 > Comment (by rjvbertin@…): > > Not that I can commit it anyway, but I had a look at my `port:cpuid`. > Turns out it depends on `port:p${perl5.major}-foo` ; am I right that this > means it'll transit

Re: how about a 'snowleopardfixes' library port?

2016-08-24 Thread Ken Cunningham
>> >> Just another thought, the declaration could be in its own file, >> referenced with the compile option -include in CFLAGS/CXXFLAGS, with >> conditional #ifdef to add extern "C" for C++. The unused declaration >> should not do any harm in other compile units. That way you could even >> avoid g

Re: how about a 'snowleopardfixes' library port?

2016-08-24 Thread Ken Cunningham
> > Just another thought, the declaration could be in its own file, > referenced with the compile option -include in CFLAGS/CXXFLAGS, with > conditional #ifdef to add extern "C" for C++. The unused declaration > should not do any harm in other compile units. That way you could even > avoid generat

Review request (#51448)

2016-08-24 Thread coquelleni
Hello, Could someone review (and commit) ticket #51448 ? https://trac.macports.org/ticket/51448 Thanks in advance. Nico. ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev

Re: request review #52066

2016-08-24 Thread Rainer Müller
On 2016-08-24 02:14, Björn Ketelaars wrote: > Would someone be so kind to review (and commit) > https://trac.macports.org/ticket/52066 ? Done. https://trac.macports.org/changeset/151932 Rainer ___ macports-dev mailing list macports-dev@lists.macosforge

Re: how about a 'snowleopardfixes' library port?

2016-08-24 Thread Rainer Müller
On 2016-08-23 19:13, Ryan Schmidt wrote: > I would prefer you work with the developers of the affected software packages > to get the necessary compatibility functions into their sources. This will > help all Snow Leopard users, not just those using MacPorts. I agree that fixing bugs in upstre