Revision: 123768
https://trac.macports.org/changeset/123768
Author: larryv at macports.org
Date: 2014-08-13 21:34:03 -0700 (Wed, 13 Aug 2014)
Log Message:
---
macports.tcl: Use quieter git sync command.
pushd and popd print the directory stacks to stdout, which is
On Aug 14, 2014, at 2:40 AM, Joshua Root j...@macports.org wrote:
Do we really need to call 'sh -c' here?
I assumed that directory changes persist after the call to system — hence the
pushd/popd in the previous version. We could probably get by with cd $portdir
… cd \$OLDPWD, though.
We
On 2014-8-14 17:58 , Lawrence Velázquez wrote:
On Aug 14, 2014, at 2:40 AM, Joshua Root j...@macports.org wrote:
Do we really need to call 'sh -c' here?
I assumed that directory changes persist after the call to system — hence
the pushd/popd in the previous version.
Nope, system does a
On Aug 14, 2014, at 4:04 AM, Joshua Root j...@macports.org wrote:
On 2014-8-14 17:58 , Lawrence Velázquez wrote:
On Aug 14, 2014, at 2:40 AM, Joshua Root j...@macports.org wrote:
Do we really need to call 'sh -c' here?
I assumed that directory changes persist after the call to system —
On Aug 14, 2014, at 3:58 AM, Lawrence Velázquez lar...@macports.org
wrote:
I thought that port sync failed immediately if any of the source
syncs exited with a failure status, but I may have been
misinterpreting the output I saw, since my git-svn repository is last
in my sources list.
I
On Thu, Aug 14, 2014 at 12:50 PM, Eric Cronin ecro...@macports.org wrote:
The pushd/popd came from the existing svn support, since it makes no sense
in a system() call I assumed it was intentionally done for the output vs a
single cd at the start (system -W didn't exist yet back then I think).
On Aug 14, 2014, at 12:50 PM, Eric Cronin ecro...@macports.org wrote:
My original patch to add this that's in trac somewhere (#27485 it looks like)
did this, but others thought stash/stash pop was bad so I removed it and just
got in the habit of committing everything locally instead
I don't