Re: [129507] trunk/dports/multimedia/mpv/Portfile

2014-12-14 Thread Ryan Schmidt
/multimedia/mpv/Portfile (129506 = 129507) --- trunk/dports/multimedia/mpv/Portfile 2014-12-15 00:11:38 UTC (rev 129506) +++ trunk/dports/multimedia/mpv/Portfile 2014-12-15 00:26:55 UTC (rev 129507) +set waf_version 1.8.1 +set waf_distfilewaf-${waf_version} +set

Re: [129507] trunk/dports/multimedia/mpv/Portfile

2014-12-14 Thread Brandon Allbery
On Sun, Dec 14, 2014 at 7:50 PM, Ryan Schmidt ryandes...@macports.org wrote: -pre-configure { -system -W ${worksrcpath} ${waf.python} bootstrap.py +post-extract { +xinstall -m 0644 -W ${distpath} ${waf_distfile} ${worksrcpath}/waf } Remember, as Larry said in response to

Re: [129507] trunk/dports/multimedia/mpv/Portfile

2014-12-14 Thread Lawrence Velázquez
On Dec 14, 2014, at 7:55 PM, Brandon Allbery allber...@gmail.com wrote: If we're going to be pedantic, the braces around the variable names don't do anything except in the case of ${waf.python} where they are required. True, but we seem to have settled on ${this} as our style in portfiles. It

Re: [129507] trunk/dports/multimedia/mpv/Portfile

2014-12-14 Thread Mihai Moldovan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 15.12.2014 01:50 AM, Ryan Schmidt wrote: Thanks. How common do you think this is -- port downloads waf before using it? Might we need this in other ports as well? I only had a superficial look, but it seems not be common. Most software

Re: [129507] trunk/dports/multimedia/mpv/Portfile

2014-12-14 Thread Lawrence Velázquez
On Dec 14, 2014, at 8:02 PM, Mihai Moldovan io...@macports.org wrote: Yes, but until I issue a commit changing that in all places at once I don't think this is worth making a huge commit to fix, and in fact I think that would be a bad idea. It's not as if the quotes are *wrong*, and it would