Re: Patch naming policy (was: Re: [153574] trunk/dports/sysutils/skey)

2016-10-06 Thread Mojca Miklavec
Hi, I don't care if we use *.diff or *.patch. Either is fine, but I would prefer if we would stick to one ending and try to be as consistent as we can be. The "patch-" prefix is a bit redundant indeed, but then again I don't care that much. I would be OK with removal, but again I would like to

Re: Patch naming policy (was: Re: [153574] trunk/dports/sysutils/skey)

2016-10-05 Thread Chris Jones
> On 5 Oct 2016, at 2:56 pm, Rainer Müller wrote: > > On 2016-10-05 01:45, Ryan Schmidt wrote: >>> Patches should follow the patch-*.diff naming scheme, so this >>> should be named patch-skeyprune-man8.diff or similar. >>> >>>

Patch naming policy (was: Re: [153574] trunk/dports/sysutils/skey)

2016-10-05 Thread Rainer Müller
On 2016-10-05 01:45, Ryan Schmidt wrote: >> Patches should follow the patch-*.diff naming scheme, so this >> should be named patch-skeyprune-man8.diff or similar. >> >> https://guide.macports.org/#development.patches.source > > Popular opinion seems to be that we should relax that restriction. >

Re: [153574] trunk/dports/sysutils/skey

2016-10-05 Thread mf2k
> On Oct 4, 2016, at 10:33 PM, Lawrence Velázquez wrote: > >> On Oct 4, 2016, at 7:45 PM, Ryan Schmidt wrote: >> >>> On Oct 4, 2016, at 3:58 PM, Rainer Müller wrote: >>> >>> Patches should follow the patch-*.diff naming

Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Lawrence Velázquez
> On Oct 4, 2016, at 7:45 PM, Ryan Schmidt wrote: > >> On Oct 4, 2016, at 3:58 PM, Rainer Müller wrote: >> >> Patches should follow the patch-*.diff naming scheme, so this should be >> named patch-skeyprune-man8.diff or similar. > > Popular

Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Ryan Schmidt
> On Oct 4, 2016, at 3:58 PM, Rainer Müller wrote: > > On 2016-10-04 22:03, lar...@macports.org wrote: >> Revision: 153574 >> https://trac.macports.org/changeset/153574 >> Author: lar...@macports.org >> Date: 2016-10-04 13:03:08 -0700 (Tue, 04 Oct 2016) >>

Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Lawrence Velázquez
> On Oct 4, 2016, at 7:05 PM, Lawrence Velázquez wrote: > > But that day is not today. https://trac.macports.org/changeset/153579 I meant this, obviously. https://trac.macports.org/changeset/153576 vq ___ macports-dev mailing

Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Lawrence Velázquez
> On Oct 4, 2016, at 4:58 PM, Rainer Müller wrote: > > Patches should follow the patch-*.diff naming scheme, so this should be > named patch-skeyprune-man8.diff or similar. > > https://guide.macports.org/#development.patches.source One day I'll get this naming guideline

Re: [153574] trunk/dports/sysutils/skey

2016-10-04 Thread Rainer Müller
On 2016-10-04 22:03, lar...@macports.org wrote: > Revision: 153574 > https://trac.macports.org/changeset/153574 > Author: lar...@macports.org > Date: 2016-10-04 13:03:08 -0700 (Tue, 04 Oct 2016) > Log Message: > --- > skey: Rename patch > > Modified Paths: > --