Re: Pre-commit script to reject commits

2008-03-07 Thread Rainer Müller
Blair Zajac wrote: I was thinking that we should have a pre-commit script reject commits if a portfile does not increment a revision or version if it changes any of its depends_*. I find this pretty annoying to see commits that add a dependency that don't bump a version or revision. I

Re: Pre-commit script to reject commits

2008-03-07 Thread Blair Zajac
Rainer Müller wrote: Blair Zajac wrote: I was thinking that we should have a pre-commit script reject commits if a portfile does not increment a revision or version if it changes any of its depends_*. I find this pretty annoying to see commits that add a dependency that don't bump

Re: Pre-commit script to reject commits

2008-03-07 Thread Ryan Schmidt
On Mar 7, 2008, at 12:24, Rainer Müller wrote: Blair Zajac wrote: If you have the base port installed, say libfoo, but it's not listed as a dependency, then if you remove it, then you'll unintentionally break any ports that picked up a dependency upon it at configure time. Thanks for

Re: Pre-commit script to reject commits

2008-03-07 Thread markd
Thanks for the clarification, I think you are kind of right. But it will always hit someone not affected by the update. For example, changing depends_* inside some variants and incrementing the revsion forces all users to recompile - even if they don't use this variant... And yet,