Re: request review #52025
On 8/18/16 6:30 PM, Björn Ketelaars wrote: > The maintainer of oath-toolkit has not reacted to > https://trac.macports.org/ticket/52025 > > Would someone be so kind to review (and commit) this update? > > Thank you! > Committed in https://trac.macports.org/changeset/151639, maintainer timeout. ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
request review #52025
The maintainer of oath-toolkit has not reacted to https://trac.macports.org/ticket/52025 Would someone be so kind to review (and commit) this update? Thank you! -- Björn Ketelaars GPG key: 0x4F0E5F21 ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: small change in portconfigure.tcl appears to fix missing cxx_stdlib link
Right to the top...
Thanks for the feedback. You know 10x more about this than I do, no
argument at all there.
Noted...always a possible downside to trying things.
As you can tell, I'm trying to poke around to find a reasonably elegant way to
avoid forcing a (basically unnecessary) update to what might be hundreds or
thousands of portfiles (or worse, perhaps, trying to get updates pushed through
to all the ports they represent) for something the ports obviously feel the
system should be doing itself (which is automatically linking in the correct
stdlib, which we have monkeyed with by requiring linking to libc++ in systems
that default to libstdc++).
This seemed the cleanest way.
I'll see if it causes any trouble here, for what that's worth...
K
On 2016-08-18, at 8:55 AM, Joshua Root wrote:
> On 2016-8-19 01:13 , Ken Cunningham wrote:
>> For your consideration
>>
>> this small change in /base/src/port1.0/portconfigure.tcl
>>
>> # Add flags to specify C++ STL implementation
>> if {${configure.cxx_stdlib} ne "" && [string match "*clang*" [option
>> configure.cxx]]} {
>> append_to_environment_value configure CXXFLAGS
>> -stdlib=${configure.cxx_stdlib}
>> append_to_environment_value configure OBJCXXFLAGS
>> -stdlib=${configure.cxx_stdlib}
>> #kenhack
>> append_to_environment_value configure "LDFLAGS"
>> -stdlib=${configure.cxx_stdlib}
>> }
>>
>> appears to fix the missing link reference to the standard c++ lib, and as
>> far as I can see would apply to all ports.
>>
>> It works well here, so far, to fix the missing libc++ link without modifying
>> the portfile.
>>
>> Will test further to see if it causes any unforeseen troubles on my other
>> macports systems running different OS versions, but this would not appear
>> likely to cause trouble to me...
>
> The trouble is that LDFLAGS is not specific to C++, it's used when linking
> everything. At best, the link command will ignore -stdlib, at worst, it may
> fail when given an option it doesn't recognise. (This is much the same reason
> why it checks that configure.cxx is clang++ as well.)
>
> - Josh
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: small change in portconfigure.tcl appears to fix missing cxx_stdlib link
On 2016-8-19 01:13 , Ken Cunningham wrote:
For your consideration
this small change in /base/src/port1.0/portconfigure.tcl
# Add flags to specify C++ STL implementation
if {${configure.cxx_stdlib} ne "" && [string match "*clang*" [option
configure.cxx]]} {
append_to_environment_value configure CXXFLAGS
-stdlib=${configure.cxx_stdlib}
append_to_environment_value configure OBJCXXFLAGS
-stdlib=${configure.cxx_stdlib}
#kenhack
append_to_environment_value configure "LDFLAGS"
-stdlib=${configure.cxx_stdlib}
}
appears to fix the missing link reference to the standard c++ lib, and as far
as I can see would apply to all ports.
It works well here, so far, to fix the missing libc++ link without modifying
the portfile.
Will test further to see if it causes any unforeseen troubles on my other
macports systems running different OS versions, but this would not appear
likely to cause trouble to me...
The trouble is that LDFLAGS is not specific to C++, it's used when
linking everything. At best, the link command will ignore -stdlib, at
worst, it may fail when given an option it doesn't recognise. (This is
much the same reason why it checks that configure.cxx is clang++ as well.)
- Josh
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev
small change in portconfigure.tcl appears to fix missing cxx_stdlib link
For your consideration
this small change in /base/src/port1.0/portconfigure.tcl
# Add flags to specify C++ STL implementation
if {${configure.cxx_stdlib} ne "" && [string match "*clang*" [option
configure.cxx]]} {
append_to_environment_value configure CXXFLAGS
-stdlib=${configure.cxx_stdlib}
append_to_environment_value configure OBJCXXFLAGS
-stdlib=${configure.cxx_stdlib}
#kenhack
append_to_environment_value configure "LDFLAGS"
-stdlib=${configure.cxx_stdlib}
}
appears to fix the missing link reference to the standard c++ lib, and as far
as I can see would apply to all ports.
It works well here, so far, to fix the missing libc++ link without modifying
the portfile.
Will test further to see if it causes any unforeseen troubles on my other
macports systems running different OS versions, but this would not appear
likely to cause trouble to me...
Ken
___
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev
Re: [151593] trunk/dports/textproc/histo/Portfile
> On Aug 18, 2016, at 5:29 AM, g...@macports.org wrote: > > Revision > 151593 > Author > g...@macports.org > Date > 2016-08-18 03:29:02 -0700 (Thu, 18 Aug 2016) > Log Message > > textproc/histo: changed owner > > Checksums changed (probably a forced push). Applying stealth update recipe. This is the correct thing to do, but the reason the checksums changed is because the owner changed. The owner name is part of the directory name inside the tarball. We should enhance the github portgroup to support archive-style URLs, and, on a port by port basis when an update is committed, use those where we have been using tarball-style URLs, because archive-style URLs give you tarballs that don't have the owner name in the directory name. https://trac.macports.org/ticket/40518 > Modified Paths > > • trunk/dports/textproc/histo/Portfile > Diff > > Modified: trunk/dports/textproc/histo/Portfile (151592 => 151593) > > --- trunk/dports/textproc/histo/Portfile 2016-08-18 10:24:58 UTC (rev > 151592) > +++ trunk/dports/textproc/histo/Portfile 2016-08-18 10:29:02 UTC (rev > 151593) > @@ -4,7 +4,7 @@ > PortSystem 1.0 > PortGroup github 1.0 > > -github.setupvisionmedia histo 0.0.2 > +github.setuptj histo 0.0.2 > maintainers g5pw openmaintainer > > categories textproc > @@ -15,9 +15,11 @@ ___ macports-dev mailing list macports-dev@lists.macosforge.org https://lists.macosforge.org/mailman/listinfo/macports-dev
