Re: GitHub post-extract shenanigans

2018-10-17 Thread Aaron Madlon-Kay
Thanks for the additional information, Ryan. I also found another reason `extract.mkdir yes` doesn’t work for my problem: it applies to *all* distfiles, whereas for my purposes I would need it to only be applied to the “main” distfile (as opposed to dependency distfiles). -Aaron > On Oct 17,

Re: GitHub post-extract shenanigans

2018-10-17 Thread Ryan Schmidt
Thanks for finding this answer; I wouldn't have remembered. The github portgroup's post-extract shenanigans are necessary when extracting an automatically-generated GitHub tarball, because the directory name inside those tarballs contains the abbreviated git commit hash, which is not a piece

Re: GitHub post-extract shenanigans

2018-10-17 Thread Aaron Madlon-Kay
After poking around some more I think I can answer my own question: We don't use the `extract.mkdir yes` solution because it extracts to worksrcdir, but per the comment in the github 1.0 portgroup (linked in previous message) the port may want to set worksrcdir to a subdirectory of the extracted

GitHub post-extract shenanigans

2018-10-16 Thread Aaron Madlon-Kay
Hello all. The github 1.0 portgroup does some post-extract shenanigans to normalize the result of extracting the distfile: e.g. a GitHub project `me/myproject` will, as retrieved from GitHub, extract to `me-myproject-0123abc`; this is moved to `myproject` via globbing: