Re: changing 'configure' options for testing

2021-09-28 Thread Ken Cunningham
Ryan asked (when he had this same issue about six months ago) why our cmake PortGroup sets it ON when it breaks all the in-tree tests, and whether we should change the PG to turn it OFF all the time. (The default is OFF I believe.) In fact, we probably should. I'm not sure why we set it like it

Re: changing 'configure' options for testing

2021-09-28 Thread Jason Liu
In addition to the code Ken just provided, he and others have helped me with some test-related "protection" code, so that in addition to a +tests variant, there is the following section of code (I usually place it after any build-related sections, and before any destroot-related sections, in order

Re: changing 'configure' options for testing

2021-09-28 Thread Ken Cunningham
On 2021-09-28 7:44 a.m., Daniel J. Luke wrote: On Sep 20, 2021, at 10:20 AM, Daniel J. Luke wrote: On Sep 20, 2021, at 8:15 AM, Frank Dean wrote: Daniel J. Luke writes: The newest version of clamav uses cmake for builds. In the 'configure' stage, I have it disabling tests because

Re: changing 'configure' options for testing

2021-09-28 Thread Daniel J. Luke
On Sep 20, 2021, at 10:20 AM, Daniel J. Luke wrote: > On Sep 20, 2021, at 8:15 AM, Frank Dean wrote: >> Daniel J. Luke writes: >>> The newest version of clamav uses cmake for builds. In the 'configure' >>> stage, I have it disabling tests because otherwise it won't build without >>> the test

Re: changing 'configure' options for testing

2021-09-20 Thread Daniel J. Luke
On Sep 20, 2021, at 8:15 AM, Frank Dean wrote: > Daniel J. Luke writes: >> The newest version of clamav uses cmake for builds. In the 'configure' >> stage, I have it disabling tests because otherwise it won't build without >> the test dependencies installed (check and pytest). >> >> Do we

Re: changing 'configure' options for testing

2021-09-20 Thread Frank Dean
Daniel J. Luke writes: > The newest version of clamav uses cmake for builds. In the 'configure' stage, > I have it disabling tests because otherwise it won't build without the test > dependencies installed (check and pytest). > > Do we have a template or example of a canonical way to handle

changing 'configure' options for testing

2021-09-19 Thread Daniel J . Luke
The newest version of clamav uses cmake for builds. In the 'configure' stage, I have it disabling tests because otherwise it won't build without the test dependencies installed (check and pytest). Do we have a template or example of a canonical way to handle this? I don't see an obvious hook