Re: Question about `platforms` and `${os.platform}`

2021-12-11 Thread Jason Liu
On Sat, Dec 11, 2021 at 6:41 PM Chris Jones wrote: > No, because that would render the port non functional on non darwin OSes. > You should only specify the darwin platform when it is actually required, > e.g. when then making a os.major conditional that inly makes sense in > darwin platforms. >

Re: Question about `platforms` and `${os.platform}`

2021-12-11 Thread Jason Liu
On Sat, Dec 11, 2021 at 5:46 PM Ryan Schmidt wrote: > On Dec 11, 2021, at 16:41, Jason Liu wrote: > >> >> and be done with it, instead of needing to add one each and every time I >> have a conditional involving `${os.major}`? > > > I wouldn't expect you to need to write more than a couple such >

Re: Question about `platforms` and `${os.platform}`

2021-12-11 Thread Chris Jones
> On 11 Dec 2021, at 10:42 pm, Jason Liu wrote: > >  >> On Sat, Dec 11, 2021 at 5:20 PM Ryan Schmidt wrote: >> >> >>> On Dec 10, 2021, at 15:07, Jason Liu wrote: >>> >>> A conversation in one of my PRs has brought up an interesting question that >>> I've been wondering about for a long

Re: Question about `platforms` and `${os.platform}`

2021-12-11 Thread Ryan Schmidt
On Dec 11, 2021, at 16:41, Jason Liu wrote: > Then would it be easier (or even kosher) to simply wrap the majority of the > Portfile inside of a single > > if {${os.platform} eq "darwin"} { The shorthand way to do that is: platform darwin { > and be done with it, instead of needing to add

Re: Question about `platforms` and `${os.platform}`

2021-12-11 Thread Jason Liu
On Sat, Dec 11, 2021 at 5:20 PM Ryan Schmidt wrote: > > > On Dec 10, 2021, at 15:07, Jason Liu wrote: > >> >> A conversation in one of my PRs has brought up an interesting question >> that I've been wondering about for a long time. In Portfiles, whenever I've >> had a test for `${os.major} <=

Re: Question about `platforms` and `${os.platform}`

2021-12-11 Thread Ryan Schmidt
On Dec 10, 2021, at 15:07, Jason Liu wrote: > A conversation in one of my PRs has brought up an interesting question that > I've been wondering about for a long time. In Portfiles, whenever I've had a > test for `${os.major} <= xx`, I've typically always added an additional check > for

Re: Significant security vulnerability discovered in Log4j

2021-12-11 Thread Jason Liu
On Sat, Dec 11, 2021 at 1:32 PM Eric Gallager wrote: > > so... is there anything to do about this in MacPorts? > There's probably nothing that can be done in terms of the MacPorts packages. It's basically dependent on upstream developers to patch anything that might be affected. It was more of

Re: Significant security vulnerability discovered in Log4j

2021-12-11 Thread Eric Gallager via macports-dev
On Fri, Dec 10, 2021 at 6:00 PM Jason Liu wrote: > > In case everyone hadn't heard the news. If anyone is running Log4j for > logging on any of your web servers, you might want to read this. > > WIRED: 'The Internet Is On Fire' > A vulnerability in the Log4j logging framework has security teams